Skip to content

GitLab

T
tangled
Commit fff51cf2 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot
Browse files
Options

Remove fast/multicol/border-radius-clipped-layer.html test. 

It was failing with LayoutNG block fragmentation due to subpixel
differences. Rounded border painting is very sensitive to what layers
are involved, it seems.

In legacy multicol we establish a layer for the flow thread and perform
clipping and translation to slice the tall single column (internal
representation) into columns (what you see on screen). This is not the
case for NG block fragmentation, where we just paint stuff, without any
additional clipping.

The ref had some absolute positioning and clipping. which appeared to
match the layer situation when legacy multicol was used (but not NG).

We already have plenty of coverage for rounded borders in block
fragmentation in wpt/css/css-break/ , e.g. borders-003.html

Bug: 829028
Change-Id: If5ce0626f004acb0466497e0f1eee06ddeccbd38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429009Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810751}
parent a65f80f8
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 62 deletions
third_party/blink/web_tests/TestExpectations
View file @ fff51cf2
......@@ -1074,7 +1074,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-multicol/mult
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-multicol/multicol-width-small-001.xht [ Failure ]
crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-after-break-after.html [ Failure ]
crbug.com/1079031 virtual/layout_ng_block_frag/fast/multicol/abspos-new-width-rebalance.html [ Crash Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer.html [ Failure ]
crbug.com/1066616 virtual/layout_ng_block_frag/fast/multicol/border-radius-clipped-layer-second-column.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/break-before-first-line-in-first-child.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/caret-range-anonymous-block.html [ Failure ]
......
third_party/blink/web_tests/fast/multicol/border-radius-clipped-layer-expected.html deleted 100644 → 0
View file @ a65f80f8
<!DOCTYPE html>
<p>There should be a box with a rounded border and yellow background below. The start should be in
the first column. The end should be in the third column.</p>
<div style="width:41em; height:10.5em; line-height:2em; position:absolute; clip:rect(0,42em,10.5em,-1em);">
<div style="float:left; width:13em; height:100%;">
<br>
<div style="border-radius:3em; border:1em solid black; padding:0 2em; background:yellow;">
first column<br>
first column<br>
first column<br>
<br>
<br>
</div>
</div>
<div style="float:left; width:1em; height:100%;"></div>
<div style="float:left; width:13em; height:100%;">
<div style="margin-top:-7em; border-radius:3em; border:1em solid black; padding:0 2em; background:yellow;">
first column<br>
first column<br>
first column<br>
second column<br>
second column<br>
second column<br>
second column<br>
second column<br>
<br>
<br>
</div>
</div>
<div style="float:left; width:1em; height:100%;"></div>
<div style="float:left; width:13em; height:100%;">
<div style="margin-top:-17em; border-radius:3em; border:1em solid black; padding:0 2em; background:yellow;">
first column<br>
first column<br>
first column<br>
second column<br>
second column<br>
second column<br>
second column<br>
second column<br>
third column<br>
</div>
</div>
</div>
third_party/blink/web_tests/fast/multicol/border-radius-clipped-layer.html deleted 100644 → 0
View file @ a65f80f8
<!DOCTYPE html>
<p>There should be a box with a rounded border and yellow background below. The start should be in
the first column. The end should be in the third column.</p>
<div style="-webkit-columns:3; -webkit-column-gap:1em; column-fill:auto; width:41em; height:10.5em; line-height:2em; orphans:1; widows:1;">
<br>
<div style="position:relative; border-radius:3em; border:1em solid black; padding:0 2em; background:yellow;">
first column<br>
first column<br>
first column<br>
second column<br>
second column<br>
second column<br>
second column<br>
second column<br>
third column<br>
</div>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment