Skip to content

GitLab

T
tangled
Commit fff5908b authored by Matt Wolenetz's avatar Matt Wolenetz Committed by Commit Bot
Browse files
Options

MSE: Ship SourceBuffer.changeType 

With intent-to-ship approved [1], this change undoes the ephemeral
origin trial integration previously landed in r581041 and ships
SourceBuffer.changeType() (so that its use no longer requires an
experimental flag.) This change retains the UseCounter for this
new MSE API method that was added in r581041.

[1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/K_OFPxA_whE/discussion

BUG=605134

Change-Id: Ie10f8ef71513998dc8672786bc8fea12bb0ad150
Reviewed-on: https://chromium-review.googlesource.com/1182292Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584848}
parent b4bba9de
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 36 deletions
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/mediasource-changetype-origin-trial-interfaces.html deleted 100644 → 0
View file @ b4bba9de
<!DOCTYPE html>
<meta charset="utf-8">
<!-- Generate token with the command:
tools/origin_trials/generate_token.py http://127.0.0.1:8000 MediaSourceChangeType --expire-timestamp=2000000000
To test whether the token is working, run the suite virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials.
-->
<title>MediaSourceChangeType - interfaces exposed by origin trial</title>
<script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script>
<script src="../../../resources/origin-trials-helper.js"></script>
<script>
let token = "AtRt0SH3CPMu71uc+KvPkp74coHka5l2c5KbiC1pzdUW0g7Fbkjfd/pjQIJtOrHnbRJz9331CP1xHwneskoHnw4AAABdeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiTWVkaWFTb3VyY2VDaGFuZ2VUeXBlIiwgImV4cGlyeSI6IDIwMDAwMDAwMDB9";
let properties_to_check = {'SourceBuffer': ['changeType']};
// Skip this test if flags are not set properly.
if(!self.internals.runtimeFlags.mediaSourceChangeTypeEnabled) {
test(t => {
OriginTrialsHelper.check_properties_missing(this, properties_to_check);
}, "MSE changeType method is not available without a token.");
}
OriginTrialsHelper.add_token(token);
test(t => {
OriginTrialsHelper.check_properties(this, properties_to_check);
}, "MSE changeType method is available.");
</script>
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
View file @ fff5908b
...@@ -6293,6 +6293,7 @@ interface SourceBuffer : EventTarget ...@@ -6293,6 +6293,7 @@ interface SourceBuffer : EventTarget
getter updating getter updating
method abort method abort
method appendBuffer method appendBuffer
method changeType
method constructor method constructor
method remove method remove
setter appendWindowEnd setter appendWindowEnd
......
third_party/blink/renderer/modules/mediasource/source_buffer.idl
View file @ fff5908b
...@@ -74,7 +74,7 @@ enum AppendMode { ...@@ -74,7 +74,7 @@ enum AppendMode {
[RaisesException] void remove(double start, unrestricted double end); [RaisesException] void remove(double start, unrestricted double end);
// Explicitly change the container or codecs // Explicitly change the container or codecs
[RaisesException, Measure, OriginTrialEnabled=MediaSourceChangeType] void changeType(DOMString type); [RaisesException, Measure] void changeType(DOMString type);
// Gets or sets the TrackDefaultList this SourceBuffer may consult during // Gets or sets the TrackDefaultList this SourceBuffer may consult during
// the initialization segment algorithm. // the initialization segment algorithm.
......
third_party/blink/renderer/platform/runtime_enabled_features.json5
View file @ fff5908b
...@@ -703,11 +703,6 @@ ...@@ -703,11 +703,6 @@
name: "MediaSession", name: "MediaSession",
status: "test", status: "test",
}, },
{
name: "MediaSourceChangeType",
origin_trial_feature_name: "MediaSourceChangeType",
status: "experimental",
},
{ {
name: "MediaSourceExperimental", name: "MediaSourceExperimental",
status: "experimental", status: "experimental",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment