Skip to content

GitLab

T
tangled
Commit fffc1827 authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot
Browse files
Options

Remove PrerenderBrowserTest.PrerenderSessionStorage 

The test causes problems for mojo-ified SessionStorage. Remove the test
to unblock the effort. The purpose of the test is to exercise a scenario
that includes webcontents swap-in, which does not happen in the field
any more (unless forced by a user with about:flags - this ability is
going away soon).

Bug: 755921
Change-Id: I489be7ece2b7d163448126e6b95a00b5a11126d5
Reviewed-on: https://chromium-review.googlesource.com/1073286
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561907}
parent da96536c
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 54 deletions
chrome/browser/prerender/prerender_browsertest.cc
View file @ fffc1827
......@@ -706,24 +706,6 @@ class PrerenderBrowserTest : public test_utils::PrerenderInProcessBrowserTest {
EXPECT_TRUE(original_prerender_page);
}
// Goes back to the page that was active before the prerender was swapped
// in. This must be called when the prerendered page is the current page
// in the active tab.
void GoBackToPageBeforePrerender() {
WebContents* tab = GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_FALSE(tab->IsLoading());
TestNavigationObserver back_nav_observer(tab);
chrome::GoBack(current_browser(), WindowOpenDisposition::CURRENT_TAB);
back_nav_observer.Wait();
bool js_result;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
tab,
"window.domAutomationController.send(DidBackToOriginalPagePass())",
&js_result));
EXPECT_TRUE(js_result);
}
void DisableJavascriptCalls() {
call_javascript_ = false;
}
......@@ -2575,16 +2557,6 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
agent->DetachClient(&client);
}
// Validate that the sessionStorage namespace remains the same when swapping
// in a prerendered page.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSessionStorage) {
set_loader_path("/prerender/prerender_loader_with_session_storage.html");
PrerenderTestURL(GetCrossDomainTestUrl("prerender/prerender_page.html"),
FINAL_STATUS_USED, 1);
NavigateToDestURL();
GoBackToPageBeforePrerender();
}
// Checks that the referrer policy is used when prerendering.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderReferrerPolicy) {
set_loader_path("/prerender/prerender_loader_with_referrer_policy.html");
......
chrome/test/data/prerender/prerender_loader_with_session_storage.html deleted 100644 → 0
View file @ da96536c
<html>
<head>
<title>Preloader</title>
<script src="prerender_events_common.js"></script>
</head>
<body>
<script>
function loader() {
var storage = window.sessionStorage;
var oldCounter = 0;
if (storage.counter) {
oldCounter = parseInt(storage.counter);
} else {
AddPrerender('REPLACE_WITH_PRERENDER_URL', 0);
}
storage.counter = oldCounter + 1;
}
function DidBackToOriginalPagePass() {
return window.sessionStorage.counter == '2';
}
window.onload = loader;
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment