- 07 Aug, 2018 40 commits
-
-
David 'Digit' Turner authored
NOTE: This is a reland of the following CL which was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1131190 The revert was due to a problem with an internal clank/DEPS runhooks step that calls jinja_template.py (see BUG entry below for details). The new CL was checking inputs by defaults, which would raise an error during gclient sync. To ease review, the first CL on gerrit is the original one, unmodified, and the second fixes the issue. ---- end of NOTE ------ ProTip: start by looking at the action_with_pydefps() definition in internal_rules.gni to review changes in this CL. This CL tries to make "gn analyze" smarter by ensuring that it knows about Python module dependencies, for any python script under //build. At the moment, these dependencies are computed by build_utils.WriteDepFile() automatically (unless the add_pydeps=False argument is passed). This adds all imported module paths to the generated .d file written by the script. Unfortunately, because this .d file is generated by the actions, the corresponding Python sources are not part of the target's inputs, known by GN at parse time, and thus do not appear in "gn analyze" properly. This CL tries to solve the problem by adding a new template named "action_with_pydeps", which acts as "action", but also expects a foo.pydeps file for every foo.py invoked through the 'script' scope variable. This '.pydeps' file is read directly at GN parse time and added to the action's target inputs. These .pydeps contain the path of each imported module, one per line, and are generated with build/print_python_deps.py Benchmarking shows no significant difference in the time taken to perform a "gn gen out/Release" on a full Chrome for Android checkout. This also needs a PRESUBMIT.py step that ensures that all .pydeps files are up-to-date with regards to their corresponding .py source files (this can be done with 'gen_pydeps.py --check .../foo.py') + Remove some --depfile options on a few Python scripts that don't need it anymore (e.g. when their inputs and outputs are now fully known by GN at parse time). + Remove uses of compute_inputs_for_analyze in rules.gni and internal_rules.gni (as well as exec_script() calls to print_python_deps.py). Note that the variable itself is still needed for grit inputs, see tools/grit/grit_rule.gni for details). BUG=870845,843562 R=agrieve@chromium.org, estevenson@chromium.org Change-Id: Id1f606a0c9df9e4e8971fd885ac0394103ca7b03 Reviewed-on: https://chromium-review.googlesource.com/1163512Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#581158}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If74a5b3fa28406bacfe489cff08e9bd636bef897 Reviewed-on: https://chromium-review.googlesource.com/1164842 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581157}
-
Rune Lillesveen authored
This reverts commit c9cbab07. Reason for revert: Caused flakiness https://crbug.com/871601 Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If5d71d67ad54ed590408c7ef1af0c71431c788d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164822Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581156}
-
Anand K. Mistry authored
BUG=None Change-Id: Ib8f43276637b7ad679a7429f3ad88db5878f29c0 Reviewed-on: https://chromium-review.googlesource.com/1163347 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581155}
-
Eric Willigers authored
Ability to Prevent scrolling in HTMLElement.focus() shipped in M64 https://chromium-review.googlesource.com/731225 https://www.chromestatus.com/feature/5745122025144320 BUG=734166 Change-Id: Ia2f8ebe29c553069e4893f7b474bd21b4b1f29a2 Reviewed-on: https://chromium-review.googlesource.com/1163056Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581154}
-
Renee Wright authored
The name should be the only member of the app item that can change as a result of the app being updated (i.e. changes to the .desktop file), so that is the only thing we need to update on the app item. This fixes the problem of app items moving or changing folder when the app is updated. I have tried this on hardware and it works as intended. Bug: 861524 Change-Id: I20e413991609f861b0b371856e8fc96e4905978c Reviewed-on: https://chromium-review.googlesource.com/1160067Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#581153}
-
Koji Ishii authored
Following bot results are included. dummy 0 lines were removed and 3 lines were deflaked by consecutive results since 8628. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib15a811e8240f0570947168b8bf115d874c875da Reviewed-on: https://chromium-review.googlesource.com/1163053 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581152}
-
Kouhei Ueno authored
Clean up. Should not change any behavior. After this CL, the TaskHandle retains the ScriptPromiseResolver by its Persistent. Thus, the KeepAliveWhilePending in ResolveOrReject script forbidden path is removed. Bug: None Change-Id: I72bd9998d621b9d375faa9b1eb90d6ecf3dec2e6 Reviewed-on: https://chromium-review.googlesource.com/1164157Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#581151}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I587e9cb4b321b08e07f86003537116a0b3b55543 Reviewed-on: https://chromium-review.googlesource.com/1164738Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581150}
-
Koji Ishii authored
This patch changes NGInlineItemsBuilder to remove trailing spaces at the end of blocks. It used to do so, but stopped in https://crrev.com/c/1022191 because doing so reduces opportunities to re-use NGInlineItem and increases shaping when contents are added. However, for fonts that has kerning before a space character, this change increased re-shaping every block end. Given line breaking is more often ran than adding contents dynamically, this turned out to be not a good trade off. We could re-shape only end-part in RestoreTrailingCollapsibleSpace to achieve the originally intended optimizations. This speeds up blink_perf tests on Windows by ~10%. This patch also fixes a few cases where space collapsing is incorrect when items are re-used. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id6e0c262db29b4d39ddd4eb1f55b18da2c7e5880 Reviewed-on: https://chromium-review.googlesource.com/1163240 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#581149}
-
Rune Lillesveen authored
This reverts commit d00fd143. Reason for revert: Caused test flakiness https://crbug.com/871652 Original change's description: > window-service: ignore requests to focus null > > Here's my comment as to why this is ignored: > > // The client is asking to remove focus from a window. This is typically a > // side effect of the window becoming, or about to become, an unfocusable > // Window (for example, the Window is hiding). Windows becoming unfocusable is > // handled locally. Assume the request is for such a scenario and return > // false to ignore the change. > // > // To process null requests conflicts with top-level activation changes. For > // example, the typical sequence when a window is hidden is to first remove > // focus, and then hide the window. FocusController keys off window hiding to > // move activation. If this code where to set focus to null, FocusController > // would not see the window hiding (because the active window was set to null) > // and not automatically activate the next window. > // > // Another possibility for this code is to handle null as a signal to move > // focus to the active window (if there is one). I'm going with the simpler > // approach for now. > > BUG=867654 > TEST=covered by tests > > Change-Id: Iee8efd8895284acca4603ff22bde19adf16d8a7f > Reviewed-on: https://chromium-review.googlesource.com/1164409 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581113} TBR=sky@chromium.org,msw@chromium.org Change-Id: I7710ea88b1dcb53d5ad299ff1295ecec31ce3f87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867654 Reviewed-on: https://chromium-review.googlesource.com/1164782Reviewed-by:
-
Jia authored
This cl contains the following changes * Real implementation of smart dim model (SmartDimModelImpl). * Checking in the generated tf native inference code. * Checking in the example preprocessor config. * Additional UMA metrics to log. Bug: 862461 Change-Id: Ib37a9562b23590be7555e34e3227049751f6d07e Reviewed-on: https://chromium-review.googlesource.com/1154618 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#581147}
-
Christopher Cameron authored
Add an empty BridgedNativeWidgetHost interface and a largely-empty BridgedNativeWidgetHostImpl implementation. These will be the browser process part of BridgedNativeWidget. Update NativeWidgetMac to have a BridgedNativeWidgetHost instead of a BridgedNativeWidget, but still allow calls through the old interface. The next steps will be a long process of shuffling members and methods to these interfaces. Bug: 859152 Change-Id: Id8be908302a32e52dc0ae1bf54fe19a285adccef Reviewed-on: https://chromium-review.googlesource.com/1162875Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#581146}
-
Hayato Ito authored
The most of changes are mechanical ones. The interesting part is, for example, that the current EventDispatcher::dispatchEvent, takes a pointer to Event (Event*), while it is doing DCHECK at the beginning, as follows: > DCHECK(event_.Get()); Given that, we can use a reference there safely; the mechanical changes in this CL should be safe. Since there are a lot of callers of event dispatcher (and other functions), I gave up doing every necessary changes in one CL, so that the size of CL wouldn't become huge. For this reason, I couldn't remove EventTarget::DispatchEvent(Event*), for example, yet in this CL, which is now just calling a function which takes a reference, after doing DCHECK(). Once we can replace every usages of callers in follow-up CLs, a function which takes a pointer will be removed. These efforts should be tracked in bug 871637. BUG=871637 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3f20e9a40dd3f950c87282101e968e893b1e8c2c Reviewed-on: https://chromium-review.googlesource.com/1163591 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#581145}
-
tzik authored
STACK_ALLOCATED macro leaves `private:` section on clang build after https://crrev.com/c/1160424, and doesn't change the access specifier on non-clang build, that seems to confuse non-clang build. This CL unifies the difference to fix the non-clang build. Change-Id: I0fdd1236670a5dd64892c19fa642dd4d681e4008 Reviewed-on: https://chromium-review.googlesource.com/1164156Reviewed-by:
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I80b9e122132fd914da335e8d5133c4ffef831ac4 Reviewed-on: https://chromium-review.googlesource.com/1164729Reviewed-by:
-
Kouhei Ueno authored
Bug: 868592 Change-Id: Ida5a487e26634b5f424e82a0323acfab939ffe84 Reviewed-on: https://chromium-review.googlesource.com/1164149Reviewed-by:
-
Steve Anton authored
Bug: 787254 Change-Id: I081690b1e46a73705f86217f38a899706127feea Reviewed-on: https://chromium-review.googlesource.com/1161614Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#581141}
-
Weidong Guo authored
1. Fix test error ArcAppModelBuilderTest.IconLoadNonSupportedScales which is caused by icon file path not found. 64px icon is supported by CL http://go/cgcl/1154136. Test fails because the icon size with 2.0 scale factor, namely 128px, cannot be found, so add those icons. 2. Enable feature flag by default. Bug: 871444 Change-Id: I9f54f71cfb8cf2fbd73dcb2f9b7da514a231ad0f Reviewed-on: https://chromium-review.googlesource.com/1164243 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch simplifies the tests that confirms text selection upon drag selects differently on mac. I will move the test to selection/mouse. Bug: 811502, 866120 Change-Id: Id9bb292236b709b65a98be1eff3fc778da02264b Reviewed-on: https://chromium-review.googlesource.com/1163348 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581139}
-
Peter Collingbourne authored
The intent of crrev.com/579533 was to use the same symbol_level on sanitizer bots as we did before crrev.com/579330 landed by using the default symbol level on all sanitizer bots. That was thought to be 1 on every platform (which would match the previous behaviour), but it turns out that on Mac/Win, the default symbol_level on sanitizer bots is 2, not 1, so the effect of crrev.com/579330 was to increase the symbol level on those bots and crrev.com/579533 had no effect. This change implements the intent of crrev.com/579533 by setting the symbol level back to 1. Bug: 869361 Change-Id: I33e572b215b389fb7d0201f5e6d11415530d86b3 Reviewed-on: https://chromium-review.googlesource.com/1164532 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581138}
-
Mikel Astiz authored
These should allow tests in upcoming patches to mimic the experimentally supported scenario where sync the feature is disabled, but the sync machinery (the engine acting as a transport mechanism) is active as soon as the user is signed in, in a special mode (subset of datatypes, with ephemeral storage). As first user, we introduce a test for USER_CONSENTS. Bug: 856179,866814,814307 Change-Id: Ie3b6c2da470dde691862a379977b4e01c4f2ead2 Reviewed-on: https://chromium-review.googlesource.com/1160852 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#581137}
-
Yuta Kitamura authored
Currently, the main thread WebThread is owned by the embedder. We'd like to shift the ownership to Platform, so that we can stop exposing WebThread to embedders. As a first step, this patch introduces a new initialization method Platform::CreateMainThreadAndInitialize(), which is parallel to Platform::Initialize(). It is targeted to tests or other use cases which only require a simple execution environment of Blink. Currently, each embedder implements its own WebThread, but I'd like to unify those and remove them from non-Blink code eventually. The new CreateMainThreadAndInitialize() lets Platform own the main thread WebThread object, unlike Initialize(). Currently, Platform needs to handle two different cases: main thread owned or not owned, but this is only temporary, and they will eventually converge to the "owned" case. As a test bed, v8_context_snapshot_generator is migrated to the new initialization method. Bug: 826203 Change-Id: I14436509f420a5d73f2ce64722f41da5756fa45b Reviewed-on: https://chromium-review.googlesource.com/1163560 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
We aim to forbid V8 execution from the default task runner of the main thread. As one of the steps, this CL removes EmptyFrameScheduler that offers the default task runner instead of a per-frame task runner. By removing this, some assumptions are changed: Before this CL, a Page might not have a PageScheduler. After this CL, a Page always have a PageScheduler. This CL also moves |CSSAnimationsTest::platform_| and other similar variables to their ancenstor |PageTestBase::platform_| in order to assure that a scheduler owned by a platform is destroyed after a local frame is destroyed. This was necessary to pass the tests. Bug: 870606 Change-Id: I39bf80aea5d4ac01da125b47224620605fea16de Reviewed-on: https://chromium-review.googlesource.com/1162083 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Ned Nguyen authored
Bug:828472, 868162, 828466 Change-Id: Id68fa398fff62455e220946394bf7b53d285cc7a NOTRY=true # site_per_process_webkit_layout_tests flake Change-Id: Id68fa398fff62455e220946394bf7b53d285cc7a Reviewed-on: https://chromium-review.googlesource.com/1164535 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5968caf4e5f6..1ec93d0df7d1 git log 5968caf4e5f6..1ec93d0df7d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 primiano@google.com UI: Fix omnibox animation 2018-08-06 primiano@google.com UI: Add query table, omnibox search and progress bar 2018-08-06 primiano@google.com UI: Switch to SCSS 2018-08-06 primiano@google.com Add interactive trace_processor_shell + fix mac build Created with: gclient setdep -r src/third_party/perfetto@1ec93d0df7d1 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I82a1f6a1abace136e8ff4f4fb53f903a267ff358 Reviewed-on: https://chromium-review.googlesource.com/1164444Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581133}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdf05f4ff4e9..01d9a344b575 git log fdf05f4ff4e9..01d9a344b575 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 egdaniel@google.com Update linux vulkan sdk asset. Created with: gclient setdep -r src/third_party/skia@01d9a344b575 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ia1423a2b7964e8b9fe945ea14d032ed1869432cf Reviewed-on: https://chromium-review.googlesource.com/1164445Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581132}
-
Ramin Halavati authored
Preferences related to CryptAuth are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I390bd032a255db1141430a1ab1a791d01227145d Reviewed-on: https://chromium-review.googlesource.com/1159366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581131}
-
Robbie McElrath authored
This migrates DiscoveryNetworkMonitory from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 868001 Change-Id: Ib8e7e1b766058579dfbc22d885df560a545b6804 Reviewed-on: https://chromium-review.googlesource.com/1147432 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581130}
-
Matt Falkenhagen authored
ServicifiedServiceWorker has a lower count of main resource requests that result in a fetch event dispatch. Add UMA to try to debug the issue. Bug: 866335 Change-Id: Iad5906f550722d073f0bfc6c788668aef18abd25 Reviewed-on: https://chromium-review.googlesource.com/1163353 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581129}
-
Mathieu Perreault authored
A previous change split the Autofill settings into addresses and payments pages. This goes through the feature code and updates the relevant call sites to lead either to the addresses page or the payments page. Bug: 870366 Test: manual Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2cad30bc762a20d499ec203c8628e63c057e84d2 Reviewed-on: https://chromium-review.googlesource.com/1162502 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#581128}
-
James Cook authored
The mojo app version is the default in stable channel in M68. Delete the legacy non-app version and remove the feature flag. Clean up touch HUD unit tests. Bug: 840380 Test: ash_unittests Change-Id: I940a3344eed05404fe4656827bad98749244f0b1 Reviewed-on: https://chromium-review.googlesource.com/1164480 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f74c888461d6..06a50f7eab7c git log f74c888461d6..06a50f7eab7c --date=short --no-merges --format='%ad %ae %s' 2018-08-07 dgarrett@google.com prototype-firmwarebranch: Create branched metadata.json. Created with: gclient setdep -r src/third_party/chromite@06a50f7eab7c The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib275b4d411b4c64a43f7801a850bf20c669337e1 Reviewed-on: https://chromium-review.googlesource.com/1164602Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581126}
-
Scott Violet authored
BUG=837684 TEST=covered by tests Change-Id: I209d2722d8cf5acc09ff51112f69253b9ca0a79c Reviewed-on: https://chromium-review.googlesource.com/1164417 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
Bug: 868592 Change-Id: Ia1d17f0b1d07d27a1665d6871545f051ee2eed87 Reviewed-on: https://chromium-review.googlesource.com/1164148Reviewed-by:
-
Hayato Ito authored
See crbug.com/869308 for details. Bug: 869308 Change-Id: Ie83796a1e281dcdc25267637ddfe2d7b1d658da3 Reviewed-on: https://chromium-review.googlesource.com/1164152Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581123}
-
Kevin Bailey authored
Currently one can activate the tab switch button with shift-space etc. This CL restricts it to only space, no modifiers. Bug: 780835 Change-Id: I49b50d9d693e6201d7c3e74c91929bf71280865f Reviewed-on: https://chromium-review.googlesource.com/1163991Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581122}
-
Ryan Hamilton authored
No flag flips this week Delete QuartcBbrOptions in favor of setting BBR options within QuartcFactory. Adding options to QuartcBbrOptions is extra boilerplate that doesn't really serve any good purpose. For now, we can put all the options in quartc_factory.cc where they'll be reviewed by the QUIC team. If this proves burdensome, we can later move some of the configuration out of //third_party/quic/quartc by passing a QuicTagVector into QuartcFactory. Merge internal change: 207318618 https://chromium-review.googlesource.com/c/chromium/src/+/1164000 Use GetCertChain instead of the more expensive GetProof in QuicCryptoServerConfig::EvaluateClientHello. Protected by FLAGS_quic_reloadable_flag_quic_use_get_cert_chain Merge internal change: 207314454 https://chromium-review.googlesource.com/c/chromium/src/+/1163999 Eliminate a dead code path in QuicCryptoServerConfig::EvaluateClientHello. There is only one caller of this method, and that caller always clears the proof before calling EvaluateClientHello. So there is no need to handle the case where a valid proof is pass into QuicCryptoServerConfig::EvaluateClientHello. Merge internal change: 207294767 https://chromium-review.googlesource.com/c/chromium/src/+/1163984 Enable BBR5, BBR8, and BBQ1, 2, and 4. - BBR5 sets a longer window length for ack aggregation. - BBR8 skips PROBE_RTT if the connection has been app-limited recently. - BBQ1 uses a slightly slower STARTUP gain. - BBQ2 uses a lower CWND gain during STARTUP. - BBQ4 uses gain of 0.75 during DRAIN. Quality test results look comparable to the config at head: http://sponge/8034f562-6964-470c-bade-fb1cff737b66 These options should provide a better baseline for Quartc. They should improve performance for Quartc's use case through fewer PROBE_RTTs and smoother STARTUP. Merge internal change: 207280788 https://chromium-review.googlesource.com/c/chromium/src/+/1163921 Add two new tests in QuicConnectionTest to verify that - when crypot packet is sent, retransmission alarm is set with correct retransmission timeout; - when crypto packet is sent, path degrading alarm is set with correct path degrading timeout. Merge internal change: 207193472 https://chromium-review.googlesource.com/c/chromium/src/+/1163920 Remove unused 'found_error' argument to QuicCryptoServerConfig::EvaluateClientHelloAfterGetProof (and change callers to not pass it in). Merge internal change: 207164287 https://chromium-review.googlesource.com/c/chromium/src/+/1163918 Rename IsProbingForMoreBandwidth to ShouldSendProbingPacket in QUIC's SendAlgorithmInterface. Merge internal change: 207139582 https://chromium-review.googlesource.com/c/chromium/src/+/1163917 Implement a bit to disable retransmission on QuartcStream. For now, a simple bit to disable retransmission is enough for Quartc. We only want to use this for the first iteration of integrating Quartc into the WebRTC audio path, where retransmissions are not currently used. We believe this will be good enough to match WebRTC's current state. In the future, we may want to upgrade this to something more sophisticated: a TTL/deadline or even a callback to evaluate whether a stream should be retransmitted at the moment it happens. We will revisit this bit when more sophisticated controls become necessary. Merge internal change: 207009357 https://chromium-review.googlesource.com/c/chromium/src/+/1163916 Only skip updating min_rtt_ in BBR if the existing sample has expired Only skip updating min_rtt_ in BBR if the existing sample has expired, not if the new sample is smaller or 0. Protected by existing flag FLAGS_quic_reloadable_flag_quic_bbr_less_probe_rtt AND activation by connection options(ie: BBR7) which are only used by Quartc. Merge internal change: 206990230 https://chromium-review.googlesource.com/c/chromium/src/+/1163915 Split KeyExchange into separate crypto and factory pieces Currently, KeyExchange encapsulates two separate operations: first, the ability to compute a shared key, and second, the ability to create new KeyExchange objects. The fact that a KeyExchange object may be passed around solely for the purpose of creating new objects of the sa me subtype is confusing, and makes it harder to audit the code for uses of the encapsulated private key. This CL improves things by separating object-creation duties into a separate Factory object, which a given KeyExchange type implements as a singleton. Code-motion refactoring in QUIC KeyExchange types. No functional change intended, not flag-protected. Merge internal change: 206816903 https://chromium-review.googlesource.com/c/chromium/src/+/1163914 StrCat() can now be used with a single argument, so there is no longer any reason to pass a useless empty string. Merge internal change: 206783905 https://chromium-review.googlesource.com/c/chromium/src/+/1163905 Use unique_ptr to manage lifetimes of KeyExchange objects Use unique_ptr for memory management rather than bare pointer. No functional change intended, not flag-protected. Merge internal change: 206649898 https://chromium-review.googlesource.com/c/chromium/src/+/1163904 Change-Id: If661a73b9f673682a31abb93d9982bacf92f27a4 Reviewed-on: https://chromium-review.googlesource.com/1164001 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581121}
-
Anand K. Mistry authored
DiskMountManager::Disk is big enough and used in enough places that it should be standalone. BUG=None TBR=tommycli@chromium.org,yusukes@chromium.org Change-Id: I11edf072fb3f32b55ed7c39887189b40d85e755c Reviewed-on: https://chromium-review.googlesource.com/1157950 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581120}
-
Jorge Gil authored
Bug: b/32781610 Change-Id: I1a244e1ed247913a3829e6efaf15b65a3c03f2cd Reviewed-on: https://chromium-review.googlesource.com/1161571 Commit-Queue: Jorge Gil <jorgegil@google.com> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#581119}
-
