- 16 Mar, 2016 40 commits
-
-
mikecase authored
Removing DEPRECATED_java_in_dir from the AndroidWebview apk test targets. Note that this will mean if you want to add a new test file or a new file to add to the AndroidWebView shell apk you will need to add the file explicitly to the java_files list. BUG= Review URL: https://codereview.chromium.org/1801033004 Cr-Commit-Position: refs/heads/master@{#381526}
-
ortuno authored
This is the first step to moving Web Bluetooth over to mojo. This patch does the following: - Creates a new WebBluetoothError mojo enum in a new web_bluetooth.mojom. This enum should be accessible from both content and blink. - Modifies WebKit/public/BUILD.gn and WebKit/public/blink.gyp to generate the headers for the new mojom interface. - Modifies WebKit/public/BUILD.gn, WebKit/Source/BUILD.gn, WebKit/public/blink_headers.gyp, and WebKit/Source/config.gyp to include files in gen/third_party/WebKit - Modifies content/browser/DEPS so that the new headers can be accessed from content/browser. Follow up patch with Web Bluetooth Service: http://crrev.com/1775953004 BUG=508771 Review URL: https://codereview.chromium.org/1784613002 Cr-Commit-Position: refs/heads/master@{#381525}
-
vmpstr authored
This patch makes the API a bit clearer by taking a copy of scoped_refptr in some situations (where ownership is shared) and using a raw pointer in situations where ownership is not needed. The only references that remain are the ones captured in lambdas or Callbacks. R=danakj BUG=589044 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1803863003 Cr-Commit-Position: refs/heads/master@{#381524}
-
trchen authored
The CL https://codereview.chromium.org/1782713003/ I submitted a few days ago was still wrong. This time a test is also added. Review URL: https://codereview.chromium.org/1805823002 Cr-Commit-Position: refs/heads/master@{#381523}
-
mikecase authored
Adding an isolate file similiar to what exists for the AndroidWebViewTest.apk to run the instrumentation test through the isolate file. BUG= Review URL: https://codereview.chromium.org/1790633004 Cr-Commit-Position: refs/heads/master@{#381522}
-
mikecase authored
BUG= Review URL: https://codereview.chromium.org/1810633002 Cr-Commit-Position: refs/heads/master@{#381521}
-
sergeyu authored
BUG=577954 Review URL: https://codereview.chromium.org/1800893002 Cr-Commit-Position: refs/heads/master@{#381520}
-
mnaganov authored
If Chrome starts without child services pre-warming, ChildProcessLauncher is not getting the special binding flag, and this causes child service creation failure. BUG=592722,593250 Review URL: https://codereview.chromium.org/1797383003 Cr-Commit-Position: refs/heads/master@{#381519}
-
maxbogue authored
BUG=569636,569678 Review URL: https://codereview.chromium.org/1800313002 Cr-Commit-Position: refs/heads/master@{#381518}
-
lazyboy authored
through ServiceWorkerWriteToCacheJob. This CL does not fix the underlying issue, it is just suppressing a not so useful error log. BUG=568788 Test=Load an extension page with ServiceWorker, observe no "Allowing load of ..." error messages anymore. Review URL: https://codereview.chromium.org/1790993002 Cr-Commit-Position: refs/heads/master@{#381517}
-
ben authored
. set this bit on mus so we don't try to create per-user instances of it now that running it as root has no superpower. R=sky@chromium.org Review URL: https://codereview.chromium.org/1811483003 Cr-Commit-Position: refs/heads/master@{#381516}
-
yusufo authored
We used to only keep a boolean for a first load, but that seems to be very fragile since onNavigatedToDifferentPage also gets called in refrestSelectedTab. This caches the initial url and only flips state when there is a change from the url BUG=90326 Review URL: https://codereview.chromium.org/1809683002 Cr-Commit-Position: refs/heads/master@{#381515}
-
yzshen authored
This CL allows MultiplexRouter to dispatch multiple queued messages to clients without returning to the message loop. This way we may starve other tasks on the same thread, but we have been doing the same thing in the non-associated-interface case (see Connector::ReadAllAvailableMessages). So it is probably okay. BUG=590495 Review URL: https://codereview.chromium.org/1808583003 Cr-Commit-Position: refs/heads/master@{#381514}
-
aiolos authored
Telemetry is using the DependencyManager to get the reference builds, and no one else is currently using it. Removing it reduces a synced chromium checkout by ~2G on mac. BUG= Review URL: https://codereview.chromium.org/1797303003 Cr-Commit-Position: refs/heads/master@{#381513}
-
vmpstr authored
This patch changes RefCountedBytes::TakeVector to return a ref ptr instead of a raw pointer. This minimizes the changes of a leak if a caller forgets to delete it, or forgets to wrap it in a ref ptr. R=danakj@chromium.org, thakis@chromium.org TBR=thakis@chromium.org BUG=595163 Review URL: https://codereview.chromium.org/1803263002 Cr-Commit-Position: refs/heads/master@{#381512}
-
pfeldman authored
BUG=593241 Review URL: https://codereview.chromium.org/1808533002 Cr-Commit-Position: refs/heads/master@{#381511}
-
cylee authored
Track lowmemorykiller events from kernel and reports to UMA. It reports: - Memory released by each kill. - Time to last kill for knowing how frequently the event occurs. The strike-up code would be in another CL. BUG=none Review URL: https://codereview.chromium.org/1780183003 Cr-Commit-Position: refs/heads/master@{#381510}
-
tommycli authored
This patch 1) Adds the Easy Unlock title and description to People UI. 2) Adds the Easy Unlock setup and turnoff buttons. (Not hooked up) 3) Updates the EasyUnlockHandler to support the enabled state. 4) Fixes some issues with Easy Unlock strings. BUG=563721 Review URL: https://codereview.chromium.org/1799913003 Cr-Commit-Position: refs/heads/master@{#381509}
-
dcheng authored
This CL eliminates some of the branches and simplifies the bookkeeping, since it needs to be done whether the FrameOwner is local or remote. Doing this bookkeeping is important, since it prevents a remote frame owner from retaining a WebLocalFrameImpl and keeping it live after it's already swapped out. BUG=none Review URL: https://codereview.chromium.org/1802953003 Cr-Commit-Position: refs/heads/master@{#381508}
-
ochang authored
https://pdfium.googlesource.com/pdfium.git/+log/3cc1802..30410ce TBR=tsepez@chromium.org BUG=594111 Review URL: https://codereview.chromium.org/1807933002 Cr-Commit-Position: refs/heads/master@{#381507}
-
vabr authored
This is just a silly typo, but makes searching for the mentioned method hard. BUG=576287 Review URL: https://codereview.chromium.org/1800113002 Cr-Commit-Position: refs/heads/master@{#381506}
-
fmeawad authored
The crash was due to an excessive amount of trace events logged due to direct calls from webgl into v8 primitives. The trace events on the v8 primitives have been removed. BUG=590761 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1805403003 Cr-Commit-Position: refs/heads/master@{#381505}
-
tedchoc authored
pollForCriteria -> pollInstrumentationThread pollForUIThreadCriteria -> pollUiThread More often than not in Android, you should be using pollUiThread, so this is making the naming more explicit while we migrate the tests to correctly use that. BUG= Review URL: https://codereview.chromium.org/1786243003 Cr-Commit-Position: refs/heads/master@{#381504}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5a6e92f18095..07ebb39b800b $ git log 5a6e92f18..07ebb39b8 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1810643002 Cr-Commit-Position: refs/heads/master@{#381503}
-
msw authored
Broken by https://codereview.chromium.org/1762813002 IDS_AURA_SET_DESKTOP_WALLPAPER is ChromeOS-only. ( it's defined in ash/ash_chromeos_strings.grdp ) Perhaps we should move some of these to ash/ash_string.grd? BUG=NONE TEST=Chrome builds with use_ash=1 on Windows. R=sky@chromium.org Review URL: https://codereview.chromium.org/1813443002 Cr-Commit-Position: refs/heads/master@{#381502}
-
georgesak authored
Note that we should see a higher average score for reloaded tabs, which would give us correlation between the tab discarding heuristic and the SE score. BUG=551995 Review URL: https://codereview.chromium.org/1801723003 Cr-Commit-Position: refs/heads/master@{#381501}
-
japhet authored
BUG=594072 Review URL: https://codereview.chromium.org/1805653002 Cr-Commit-Position: refs/heads/master@{#381500}
-
jkarlin authored
It's possible for the sync event to be dispatched in the test before the postMessage is received by the ServiceWorker. This CL fixes that by waiting for a response from the postMessage before starting the sync event. BUG=595191 Review URL: https://codereview.chromium.org/1812503002 Cr-Commit-Position: refs/heads/master@{#381499}
-
dalecurtis authored
BUG=533190 TEST=none Review URL: https://codereview.chromium.org/1808803002 Cr-Commit-Position: refs/heads/master@{#381498}
-
fgorski authored
Revert of RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending (patchset #2 id:20001 of https://codereview.chromium.org/1808643003/ ) Reason for revert: Closed tree. Original issue's description: > RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending > > Ensure that ScriptedIdleTaskController does not get unnecessarily retained by a cancelled timeout task if the > idle task has been triggered, but the document has gone away. > > BUG=595155 > > Committed: https://crrev.com/82f18cd2a7b718c4d5356222017d9855a53eb6f3 > Cr-Commit-Position: refs/heads/master@{#381489} TBR=esprehn@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595155 Review URL: https://codereview.chromium.org/1814443002 Cr-Commit-Position: refs/heads/master@{#381497}
-
reveman authored
This was supposed to be included in the change that added the auto-generated scaler files. This also updates scaler.xml to the latest upstream version. TBR=piman@chromium.org BUG=549782 Review URL: https://codereview.chromium.org/1807463004 Cr-Commit-Position: refs/heads/master@{#381496}
-
ianwen authored
Popup windows are managed in a window that is separate to the activity. Historically this fact caused many snackbar related crashes. Also it is a heavy burden to support popup window based snackbars in multi window mode. This CL converts the view layer of snackbars from popup window to Android View. After this change, the snackbar design will be a pure MVC structure, with SnackbarCollection(M), SnackbarView(V), and SnackbarManager(C). BUG=570778 Review URL: https://codereview.chromium.org/1759483002 Cr-Commit-Position: refs/heads/master@{#381495}
-
ben authored
BUG= Review URL: https://codereview.chromium.org/1801133002 Cr-Commit-Position: refs/heads/master@{#381494}
-
sebsg authored
"security.?number", "card.?pin" and "c-v-v" to fix net-a-porter.com, efollet.com and m.jcp.com respectively. BUG=595096 TEST=FormStructureBrowserTest Review URL: https://codereview.chromium.org/1807463003 Cr-Commit-Position: refs/heads/master@{#381493}
-
rnephew authored
Permissions problems should be fixed with https://codereview.chromium.org/1800283002/ BUG=592953,575277,571513,591224 Review URL: https://codereview.chromium.org/1811593002 Cr-Commit-Position: refs/heads/master@{#381492}
-
gyzhou authored
This CL mimics the code for desktop platforms other than mac in https://codereview.chromium.org/1805583002/ BUG=594722 Review URL: https://codereview.chromium.org/1812543002 Cr-Commit-Position: refs/heads/master@{#381491}
-
rockot authored
This adds support for the upcoming MojoChannel field trial. It also simplifies the logic around enabling Mojo channel in general, getting rid of compile-time overrides and instead controlling the feature only at runtime via a single flag or (in the absence of said flag) the field trial. BUG=595082 R=jam@chromium.org Review URL: https://codereview.chromium.org/1805653003 Cr-Commit-Position: refs/heads/master@{#381490}
-
rmcilroy authored
RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending Ensure that ScriptedIdleTaskController does not get unnecessarily retained by a cancelled timeout task if the idle task has been triggered, but the document has gone away. BUG=595155 Review URL: https://codereview.chromium.org/1808643003 Cr-Commit-Position: refs/heads/master@{#381489}
-
erikchen authored
copyTexImage2D fails when all of these conditions are met: 1. The internal format of the new texture is GL_ALPHA, GL_RED, or GL_RG. There are probably a couple more. GL_RGB and GL_RGBA always work fine. 2. The GPU is from Nvidia. 3. The source texture is backed by an IOSurface. BUG=581777 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1736093002 Cr-Commit-Position: refs/heads/master@{#381488}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8f09765..9d229a3a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1811583002 Cr-Commit-Position: refs/heads/master@{#381487}
-