- 03 Mar, 2018 40 commits
-
-
Scott Violet authored
These make construction slightly clearer in that only arguments that are needed can be supplied. BUG=none TEST=covered by tests Change-Id: Ie4029896ff24957b1f7264ef6fb64fba018625ab Reviewed-on: https://chromium-review.googlesource.com/946882 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#540762}
-
Jeremy Roman authored
A fairly direct copy of CoerceJavaScriptListToArray, including adding the "do not coerce to string" behavior for elements. CoerceJavaScriptDictionaryToArray has the same behavior, so hopefully this distinction can be left out of the Java-side code. Bug: 794320 Change-Id: Ib9decbe9cbc332ac59b1590b10ff310057ee8544 Reviewed-on: https://chromium-review.googlesource.com/946872Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540761}
-
David Grogan authored
When a table has a specified fixed height that is more than needed by its rows chrome only distributes the extra height to the first table body, ignoring thead, tfoot, and other tbody elements. Note this only contains tests, not a fix. Bug: 708345 Change-Id: Ib477306459a2f49feffe354e2cf3fed9b27e74e1 Reviewed-on: https://chromium-review.googlesource.com/942040 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#540760}
-
Jeremy Roman authored
std::make_unique is the more usual way to do this, and Blink doesn't even have WrapArrayUnique anymore for this reason. Bug: 755727 Change-Id: I9dc78827b8ef84da7c297ebc147a3ef157d0acc1 Reviewed-on: https://chromium-review.googlesource.com/946125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540759}
-
Greg Thompson authored
BUG=817450 TBR=jshin@chromium.org Change-Id: Iddd24e24699f8c94e7a51e56b4beed8867a4dc20 Reviewed-on: https://chromium-review.googlesource.com/947964Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540758}
-
Jeremy Roman authored
Hopefully this makes it easier to what the rule being tested is. Change-Id: I381d15956be4ba6d15a9b54c18bf01657228eda4 Reviewed-on: https://chromium-review.googlesource.com/946116Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540757}
-
Scott Violet authored
This reverts commit 824bbddf. Reason for revert: reverting in hopes of making tree green. The linux x64 bot has been flakely failing. For example, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59821%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout and FAILED: obj/components/download/internal/common/internal/download_response_handler.o /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/download/internal/common/internal/download_response_handler.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"325667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPONENTS_DOWNLOAD_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fdebug-prefix-map=/b/c/b/linux_clobber/src/out/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-header-guard -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nspr -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../components/download/internal/common/download_response_handler.cc -o obj/components/download/internal/common/internal/download_response_handler.o In file included from ../../components/download/internal/common/download_response_handler.cc:5: ../../components/download/public/common/download_response_handler.h:16:10: fatal error: 'services/network/public/mojom/url_loader.mojom.h' file not found #include "services/network/public/mojom/url_loader.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Move downloadResponseHandler to components/download > > No major change in functionality, just moving the files > > Bug: 803135 > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 > Reviewed-on: https://chromium-review.googlesource.com/944545 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540736} TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org Change-Id: I1863660ebd431022abe2bf919ab38925fead91af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803135 Reviewed-on: https://chromium-review.googlesource.com/947983Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540756}
-
Xianzhu Wang authored
The drag image is painted from the containing frame, so the property tree state should be the containing LayoutView's tree state. Bug: 816836 Change-Id: I28c6c9913cb89645f8f1dde4a34b47fab5ca77b4 Reviewed-on: https://chromium-review.googlesource.com/947257 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540755}
-
Vikas Soni authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a182a9a..3c1cb02 Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.angle:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: I1303a026e8c781b9acff25e9c7b73ca4ba4c9299 Reviewed-on: https://chromium-review.googlesource.com/946893 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#540754}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/222d8fe8..77e9b284 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4e8895405ec719a4711e25998ca9ecdfd32d3c95 Reviewed-on: https://chromium-review.googlesource.com/947765Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540753}
-
James Wallace-Lee authored
PlatformServiceBridge, instead of using reflection, should load an instance of PlatformServiceBridgeImpl that is determined by GN. A downstream cl, which should land first, provides an alternate implementation of PlatformServiceBridgeImpl. Bug: 682070 Change-Id: I642603ccb4e4dd4a602803772acd343bfe6cf0dd Reviewed-on: https://chromium-review.googlesource.com/897994 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540752}
-
Daniel Bratell authored
chrome_proximity_auth_client.cc uses easy_unlock_service which was just moved to be ChromeOS only so chrome_proximity_auth_client.cc needs to be as well. If it's compiled and not completely ignored by the linker (most of the time but not in jumbo builds), it will break the build. TBR=jhawkins@chromium.org Bug: 817115 Change-Id: I606cf0958beb6a736bf0717471a6542adde4dc73 Reviewed-on: https://chromium-review.googlesource.com/947962 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#540751}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7a4c2e60da4bc7a7e6ab8efe49789c6a2e43808b Reviewed-on: https://chromium-review.googlesource.com/947888Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540750}
-
Kouhei Ueno authored
Bug: 813452 Change-Id: I31e68cd13b258516db7eac83fc5e8758d3912f51 Reviewed-on: https://chromium-review.googlesource.com/946908Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#540749}
-
rbpotter authored
- Reduce spacing between unsupported message and "Learn More" link in preview area. - Add new "No longer supported" fragment string and use in place of the "No longer supported." string for the destination settings (but not the destination change dialog). Bug: 792093 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida7d0a02df3fed50a3d050f919a556711a9bacec Reviewed-on: https://chromium-review.googlesource.com/945308Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#540748}
-
Istiaque Ahmed authored
This CL adds two tests to exercise scenarios where verified_contents.json fetch can fail. The tests make sure that the fetch fails and ContentHashFetcher responds correctly. FetchInvalidVerifiedContents: Fetched hash contains invalid signature content. Fetch404VerifiedContents: Hash fetch results in 404. Bug: 818315, 796395 Change-Id: I3606bf504bf1e710705d2020bdf0ac3afa84d77a Reviewed-on: https://chromium-review.googlesource.com/942182 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540747}
-
Chris Harrelson authored
This is mostly a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/923089, now that a squashing bug was fixed in https://chromium.googlesource.com/chromium/src/+/8e4234fdc272ddda5ec9c156a2397c64d7a69f60. It differs from a straight-reland in that it also does not mark the PaintLayer with SetNeedsGraphicsLayerUpdate. Bug: 770343 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If4a29f30b42ff45eb6a456bced4ab2e837f81d3e Reviewed-on: https://chromium-review.googlesource.com/947579Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540746}
-
Siddhartha authored
This cl adds ukm for background memory dump providers. This only adds the providers approved in the privacy review: https://docs.google.com/document/d/1mzRM7TzDHo-blauk5nfG34zX_4_amCoshPE1iptoOdQ UMA for these metrics will be added in next cl. BUG=730783 Change-Id: Ife23dd28cd443725a7b8a6d74ba532220f4bb46f Reviewed-on: https://chromium-review.googlesource.com/939904 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#540745}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23d80a8f4bd2..644d1e63d9ad $ git log 23d80a8f4..644d1e63d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29796a786d06a2adc196b72706f7e3107c4c5d00 Reviewed-on: https://chromium-review.googlesource.com/947472Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540744}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3bff32bad8e5a5b92b5770337065ec3cacd9350a Reviewed-on: https://chromium-review.googlesource.com/947885 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540743}
-
Mike Wasserman authored
Bug: 771980 Change-Id: I600e523b71c8c4261c47b12a477cc2d394a222bf Reviewed-on: https://chromium-review.googlesource.com/944715 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540742}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f1f2246..222d8fe8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6d9ed03082ddb6d3175742adabc58061aae01044 Reviewed-on: https://chromium-review.googlesource.com/947823Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540741}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61cb4782. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13088 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If108b515e590fafc9da4748cb8d4f0839e2d0225 Reviewed-on: https://chromium-review.googlesource.com/947763 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540740}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I0739bb5f016b2617ac05a8679b54899f692438b6 Reviewed-on: https://chromium-review.googlesource.com/947747Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540739}
-
Andrew Grieve authored
This reverts commit f3af7e37. Reason for revert: Broke ContextualSearchManagerTest#testTapALotDLD Original change's description: > [TTS] mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > Change-Id: I18111f2537cfb16a4523d7f0cc766037fbf6050a > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540629} TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,rockot@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org Change-Id: Ib65533422cef13b6231dba93990b4e5cac77adba Bug: 754862, 818374 Reviewed-on: https://chromium-review.googlesource.com/947642 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540738}
-
Khushal authored
R=piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3cd322f9fad475377e748a322fbc39c90dc2bca9 Reviewed-on: https://chromium-review.googlesource.com/942476Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540737}
-
Min Qin authored
No major change in functionality, just moving the files Bug: 803135 Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 Reviewed-on: https://chromium-review.googlesource.com/944545Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540736}
-
Mitsuru Oshima authored
This reverts commit 63c07973. Reason for revert: This is causing crbug.com/818010 and crbug.com/817957. Original change's description: > Handle WebContents occlusion on aura. > > With this CL, when a WebContents is occluded on aura: > - WebContents::GetVisibility returns OCCLUDED > - RenderWidgetHostImpl::WasHidden is called on all > RenderWidgetHostImpls that belong to the WebContents. > That allows: > - Changing the priority of renderer processes to background. > - Not rendering frames unnecessarily. > > Bug: 668690 > Change-Id: Ie1c86d271276576a6b5c7adfb11bd0e42d5d491e > Reviewed-on: https://chromium-review.googlesource.com/937820 > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540149} TBR=avi@chromium.org,sky@chromium.org,peter@chromium.org,fdoray@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 668690 Change-Id: Id58705c66157cb18be220cc59b29a50fd3b14d95 Reviewed-on: https://chromium-review.googlesource.com/947802Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#540735}
-
Alexander Alekseev authored
This Cl doesn't include the bindings, only the UI. Bug: 818366 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d07d68700e60e31a1b1260b48ea40c511c27be3 Reviewed-on: https://chromium-review.googlesource.com/947567Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#540734}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d0de9616e5bb..462839ea9942 $ git log d0de9616e..462839ea9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iadd42c2297e920de51d2312527c5cbcffde4a7a7 Reviewed-on: https://chromium-review.googlesource.com/947662Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540733}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1de5c82..0f1f2246 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3c6b1dbe92c38eb33dfdc757fbf1b40d593bf12c Reviewed-on: https://chromium-review.googlesource.com/947131Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540732}
-
Shenghua Zhang authored
Due to 10.9 macs are not supported and os is upgraded to 10.13, the builders names with '10.9' in chromium.mac should be renamed to '10.13'. This cl includes buildbot config and luci infra config. Bug: 805475, 790169 Change-Id: I4bb24757dc3d728a319de279c793172c010097e0 Reviewed-on: https://chromium-review.googlesource.com/946746 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540731}
-
Marijn Kruisselbrink authored
Bug: 813046 Change-Id: Ie8775a418059b5c69dd47ea06668101e69f6ee72 Reviewed-on: https://chromium-review.googlesource.com/939714Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540730}
-
Robert Iannucci authored
Bug: 818054,818230 Change-Id: Ia3c395bf89845c683bba74b4944e5c673ae3a0b0 Reviewed-on: https://chromium-review.googlesource.com/946747 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540729}
-
Devlin Cronin authored
Update chrome/test/data/extensions/api_test/system to manifest v2. This involved complying to manifest v2's CSP requirements. Bug: 816679 Change-Id: I14b3f139770722a7312786c582ca0e74fef892db Reviewed-on: https://chromium-review.googlesource.com/946906Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540728}
-
Emily Stark authored
We currently log a warning message for subresources that use Symantec certificates that have been distrusted. This message didn't fire, however, for iframe main resources because Blink isn't notified about them in the same way as it is other failed resource loads. To log for iframe main resources, the logging logic is moved in RenderFrameImpl (from LocalFrameClientImpl) and called when a frame fails to load. This doesn't work 100% reliably for OOPIFs because of https://crbug.com/817881. Bug: 815219 Change-Id: I961a3e664c0383a7ff81be7def6de17185501243 Reviewed-on: https://chromium-review.googlesource.com/943984Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540727}
-
Ella Ge authored
This cl remove setting cursor style to default cursor in HandleDrag. The SetCursor here is before reach drag threshold, we shouldn't do it here because drag may not going to start. We always update cursor style on mousemove events, setting cursor here may cause cursor blink when mousedown on a draggable item and slowly move. Drag-and-drop will control the cursor after start dragging, so no need to setting cursor. Bug: 799799 Change-Id: I9168d05f3b861a5e50dbb0b7e9e1bb5e5ebe19b1 Reviewed-on: https://chromium-review.googlesource.com/941504Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#540726}
-
Robert Sesek authored
Switch to using -exported_symbols_list with the specified saves file to preserve specific global symbols. Then use the strip command to remove all remaining local symbols. The strip command is now applied via //build/config/mac:strip_all rather than explicitly on specific executables. Bug: 805453 Change-Id: I8d21b12116842eda1f9eb5c0758f52d6198a116f Reviewed-on: https://chromium-review.googlesource.com/922987 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540725}
-
Jeremy Roman authored
Bug: 755727 Change-Id: Ief44c8e53de86bb86fa01f423da5bb59ec8b7105 Reviewed-on: https://chromium-review.googlesource.com/946124Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540724}
-
James Cook authored
The container holds the ChromeVoxPanel window, which is created by chrome. Future CLs will make the ash::ChromeVoxLayoutManager manage the bounds of ChromeVoxPanel and updates to the display work area. This is needed to support mustash, as the information needed to compute the window bounds is owned by ash, but ChromeVox is implemented with an extension owned by chrome. Bug: 628655 Test: ash_unittests, open and close ChromeVox via Ctrl-Alt-Z Change-Id: I02ac4384b949043eafc0578b06676b7e757888c5 Reviewed-on: https://chromium-review.googlesource.com/946517 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540723}
-