- 11 Mar, 2020 40 commits
-
-
Minyue Li authored
Bug: 1054403 Change-Id: I6349687ce55535a0cdc405db67687d967a04fea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066777 Commit-Queue: Minyue Li <minyue@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749126}
-
Friedrich Horschig authored
This CL changes the banner of the chrome:settings/passwords/check site according to the number of found passwords: - it's hidden if there are compromised credentials - it's positive if the analysis is completed without results - it's neutral if the analysis is still running Screenshots at the linked https://crbug.com/1047726#c31 Additionally, all images support dark mode. The new SVGs were compressed using svgo (~60% smaller than the originals). Bug: 1047726 Change-Id: I1105735ebbb90064a5daa0af1e0fc64ba708ec31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087623 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749125}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7ce540e. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I17ec33e25bb22b7a1910751077100d106af96162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096938Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749124}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/984dc32776be..59f3b71c04de git log 984dc32776be..59f3b71c04de --date=short --first-parent --format='%ad %ae %s' 2020-03-11 danilchap@webrtc.org Automate conversion from c++ VideoCodeType to java VideoCodecType Created with: gclient setdep -r src/third_party/webrtc@59f3b71c04de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I58083a39af56df135f0aae51ea1b0ed6b95d49b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749123}
-
Jan Wilken Dörrie authored
This change modifies the SavedPasswordPresenter to ignore blacklisted and federated credentials. Bug: 1047726 Change-Id: Ib20ac5ef7a4b33d2d9f0251ca36ade4dbf5d0e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097976 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749122}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56a7e020561a..9b620aa0c12d git log 56a7e020561a..9b620aa0c12d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 laddoc@outlook.com Add flag to check whether offset is implicit or explicit (#2031) Created with: gclient setdep -r src/third_party/glslang/src@9b620aa0c12d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Idde8f4314eb2c0503b74395c9bf5e0b9b2757d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097929Reviewed-by:
-
Morten Stenshorne authored
This will be used by the pre paint code (in an upcoming patch) when traversing the NG fragment tree rather than the layout object tree. We'll also need the fragment child iterator to understand block fragmentation, but I decided to follow up on that in a separate CL. Bug: 1043787 Change-Id: Ib85cbc5cc011142b3060bbf6f1d59cefe6130704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089894Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#749120}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b12f6e513ac..45c5398037c4 git log 1b12f6e513ac..45c5398037c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 8be72df60462..16ae92a4ee52 (1 commits) 2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 343d4f6f1870..e2176c91b23c (2 commits) Created with: gclient setdep -r src/third_party/angle@45c5398037c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ia86c64f6cf1beef90d1a8194863bc2a09a9a48ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097927Reviewed-by:
-
Vasilii Sukhanov authored
It's applicable to "Clear browsing data" dialog. Bug: 1049193 Change-Id: Ide2495f9f5deec249de8cb71a843239891d20e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089866Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749118}
-
Pavol Marko authored
This converts the remaining "pref_mapping" entries in policy_test_cases.json (which are currently just ignored) to "policy_pref_mapping_tests". As one of the pref mappings is only available if USE_CUPS is defined, this also adds a way to specify that some tests should only run if a preprocessor macro is defined. Bug: 1017632 Test: browser_tests --gtest_filter=PolicyPrefsTest.PolicyToPrefsMapping Change-Id: Ia8aac403eaf561af0d657e557b36b231bd1c2576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055104 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#749117}
-
Kei Nakashima authored
This CL adds tests for VectorBackedLinkedList, where |ValueType| is String or unique_ptr. Change-Id: I05969c37324aa424e0ff26e8e87ebb8dfe6f1193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096172 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66ee2d6004a..1422f8e60e7b Created with: gclient setdep -r src-internal@1422f8e60e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I49783f4be2f90739e40edd8a6f40090d51512c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749115}
-
Philipp Hancke authored
adding a positive test for "it bundles on the first transport and closed the second" BUG=1058826 Change-Id: I1dad046855739d033f028385fb6caca288fa0cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096763 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#749114}
-
Marian Fechete authored
Bug: b/150927780 Change-Id: Ic2f49a13bc36c2ce6e693779c9991cfffd1d4e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096576 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749113}
-
Vidhan authored
Bug: 1045401 Change-Id: I2635b294c4349d4178f898a43eaf48f411bccab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091531 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
-
Monica Basta authored
Bug: 1043128 Change-Id: I9171e8e8238347d427db01cbb7553140ddc92d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093226 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749111}
-
Jan Wilken Dörrie authored
This change adds detailedOrigin and isAndroidCredential to the CompromisedCredential object. These properties will be required when showing an edit dialog, allowing the user to change a compromised credential. Bug: 1047726 Change-Id: Ie6c7ecf41629e486f1fa06288c5bf4b2d348b843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093603 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749110}
-
Jan Wilken Dörrie authored
This change cleans up the passwordsPrivate.CompromisedCredentialsInfo dictionary by moving the elapsedTimeSinceLastCheck into the more appropriate PasswordCheckStatus dictionary. Since after this change CompromisedCredentialsInfo would only have a single compromisedCredentials member, the dictionary is removed in favor of using the list directly. Bug: 1047726 Change-Id: Ibfc499c50065f82b560eea03dc1244d094e30eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096956 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is inspired on [1], by kinuko@. [1] https://crrev.com/c/2016524 BUG=704136 R=dcheng@chromium.org, guidou@chromium.org Change-Id: Ib51d558858d831aa1d3ba96345d3986b5afc0c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096387Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This is a reland of f440b571 Original change's description: > [Autofill Assistant] Added ShowCalendarPopup to UI framework. > > This adds a new interaction to the framework, which shows a calendar > popup and lets the user set or clear a date from the specified range. > > Bug: b/145043394 > Change-Id: I739e6b5ccb5821352b1ce63e63d8573bdde74f8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093224 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/master@{#748718} Bug: b/145043394 Change-Id: I04f14fd1f982ce9f358b705b350c35a31784bea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096586 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#749107}
-
Rob Buis authored
Implement the <mfrac> element [1] by adding support for it on the DOM and adding a layout algorithm. Add more layout utilities to obtain metrics for laying out the fraction. Add a MathML painter class for painting the fraction bar, this class will be used later on for painting other MathML parts. Bug: 6606 [1] https://mathml-refresh.github.io/mathml-core/#fractions-mfrac Change-Id: I0ab580844e1431d38d14252695bc140786349189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041665 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed678386b4ac..984dc32776be git log ed678386b4ac..984dc32776be --date=short --first-parent --format='%ad %ae %s' 2020-03-11 mbonadei@webrtc.org Revert "Whitespace change to kick bots." Created with: gclient setdep -r src/third_party/webrtc@984dc32776be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9cf8b290d478388261c7f8a5da373edaa8a48333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097926Reviewed-by:
-
Patrik Höglund authored
Turns out we don't need this. Bug: chromium:1029452 Change-Id: I06d3e22209facecbdfe94dfe7e9c1974f92aea74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096585 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749104}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8e510a1a6cb..e4aabc8bab65 git log a8e510a1a6cb..e4aabc8bab65 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 eseckler@chromium.org telemetry: Only raise buffer data loss exception after data collection Created with: gclient setdep -r src/third_party/catapult@e4aabc8bab65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059767 Tbr: eseckler@google.com Change-Id: I50e4fbfc42c13f105d57775f1310e24e3c1ef8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097925Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f83e96da. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7c52bb34d1465538f317f9caa6d466eb4a368225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095265Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LinkHighlightImpl::Paint()| to use squesr rect instead of rounded rect when <a> has nested inline box, e.g. <a>ABC<b>DEF</b></a> as same as |NGPaintFragment|. This patch makes gesture-tapHighlight-simple-nested.html test to pass. Bug: 982194 Change-Id: I824b6833223093892eb1aaa9936fa14c27c76028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097777 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This reverts commit 4030a757. Reason for revert: There are more warnings, see bug and e.g. https://ci.chromium.org/p/chrome/builders/ci/ToTWin/5913 Original change's description: > Remove pointer-to-int-cast suppression > > Chrome now successfully builds with ToT Clang after > crrev/9243da16. > > Bug: 1059231 > Change-Id: I5208e0c6d5990146e28ef57617038430a4b3a310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095705 > Auto-Submit: Arthur Eubanks <aeubanks@google.com> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748662} TBR=hans@chromium.org,aeubanks@google.com Change-Id: I121805c670bf60c8b6c7982d9740b223c413a4cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096678Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#749100}
-
Michael van Ouwerkerk authored
Also move ownership from yasmo to knollr. Bug: 1059811, 1059812, 1059810, 1059809, 1059808 Change-Id: Id86abb2d6ec949f31ae627a28d20d16238076f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095539Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#749099}
-
Gauthier Ambard authored
The test was very flaky, but only on EG1 it seems. Trying to re-enable it for EG2 only. Fixed: 1059256 Change-Id: Iac578b95450ea6516a88b596d0340b5c034647e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095734 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749098}
-
Colin Blundell authored
Currently ExternalNavigationHandlerTest overrides the value of a feature in ChromeFeatureList.java via the functionality that the latter supports for enabling features in test contexts. However, we will be porting the feature in question to be defined via a //components-level ExternalIntentsFeatureList.java that will be as minimal as possible (see crbug.com/1060097 for context); in particular, we do not want to have to port over the functionality that supports enabling the feature in a test. Thus, this CL changes the test to enable the production functionality in question via an explicit testing API on ExternalNavigationHandler.java. Note that all of this will go away if/once the functionality is enabled by default and the feature is removed altogether, which is work under development (see crbug.com/839751). Bug: 1031465 Change-Id: Ibcdf9e0e72b7c7564ee067625af7e0f4bb663d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093607 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749097}
-
Maksim Sisov authored
Previously, we thought we should run weston inside xvfb with x11 backend. But it turned out the headless-backend serves our needs quite well as well. Thus, update the xvfb script to be able to spawn weston proc and make sure xvfb is not used if --use-weston is passed. Bug: 1029241 Change-Id: I81658700259d10b3f82cbf492c5eddd39f5bf63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056543 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#749096}
-
David Grogan authored
These don't have a match so weren't being run: third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap-001.htm third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap_nowrap.html third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap_wrap-reverse.html third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap_wrap.html These are failing in all browsers on wpt.fyi because they're not written correctly: third_party/blink/web_tests/external/wpt/css/css-flexbox/ttwf-reftest-flex-wrap-reverse.html third_party/blink/web_tests/external/wpt/css/css-flexbox/ttwf-reftest-flex-wrap.html And we already have these flex-wrap tests that encompass all the behavior those above were trying to test: flexbox-flex-wrap-default.htm flexbox-flex-wrap-flexing.html flexbox-flex-wrap-nowrap.htm flexbox-flex-wrap-wrap.htm flexbox-flex-wrap-wrap-reverse.htm Fixed: 953534 Change-Id: I13d1c373da08db897548e9309058e25f75048f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094545Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749095}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e2176c91b23c..56a7e020561a git log e2176c91b23c..56a7e020561a --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rharrison@google.com Use strcmp for all of the extended instruction set checks in the disassembler (#2107) Created with: gclient setdep -r src/third_party/glslang/src@56a7e020561a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ifbf68418fa11942d223874787135db514249b824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097920Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af79e7a37126..f66ee2d6004a Created with: gclient setdep -r src-internal@f66ee2d6004a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1e73d3f6d0b273662b13971b87b2afc69ac41834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097919Reviewed-by:
-
Monica Basta authored
We have two tests for sync controls one with sync setup friendly settings on and another off. This CL enforces the value of the flag for each of the tests, it was assumed that the flag is 'disabled' by default. This will no longer be true after enabling field trial testing for sync setup friendly settings. Bug: 1043128 Change-Id: I9f40497ee7eab256bf53e4518c115d6356f3d53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096739Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#749092}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6bc4a7405acc..0340292972b9 git log 6bc4a7405acc..0340292972b9 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 abcc536b6207..c5b3cbdb4502 (7 commits) 2020-03-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7f81408a..43a5bd0c (526 commits) Created with: gclient setdep -r src/third_party/skia@0340292972b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I2583292b320b1461f3dab43e6f96aad2bbcf7ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097918Reviewed-by:
-
Mohammed Abdon authored
Bug: 1041022 Change-Id: Ib319d03d0bc6a275da77b4c7ed6c95fe6078aeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091526Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#749090}
-
Kamila Hasanbega authored
This reverts commit 9321f32f. Reason for revert: (Sheriff): This cl seems to be the reason https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2370 Fails. Original change's description: > a11y: Use more g_return_val_if_fail in AXPlatformNodeAuraLinux > > These macros are used when implementing GObject interfaces to help > mitigate accidental misuse of the API. We were using them, but not > consistently in the AuraLinux accessibility implementation. This change > makes their use more consistent. > > The original author of this CL is Martin Robinson<mrobinson@igalia.com> > > Bug: 1032019 > Change-Id: I75ee57eea79ab11202924f9b04bd1def78dd5fc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096167 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#749059} TBR=mrobinson@igalia.com,jkim@igalia.com Change-Id: I6422c761f42ce170b050433d573f1732df7c6231 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096713Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749089}
-
Donna Wu authored
The fix (crrev.com/c/1750517) missed to bind nfc_remote_ to the MiscPlatformAPI runner. Bug: 520391 Change-Id: I7500cb55bac1a48cade78e82c55b864dec99f456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093552 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#749088}
-
Noel Gordon authored
Bug: 992824 Change-Id: I5144978e10df5f5c8eaba6e4b63f898402320b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096424 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#749087}
-
