GitLab

Avoid unneccessary copy of structures gfx::Rect & gfx::RectF 
by passing them by const ref rather than value. 

Any struct of size > 4 bytes should be passed by const ref. 
Passing by ref for these structs is faster than passing 
by value, especially when invoking function has multiple parameters. 

Pass by value creates unneccessary overhead which should be avoided.

BUG=159273

Review URL: https://codereview.chromium.org/93663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98

- Remove PlatformServerChannel/PlatformClientChannel.
- Add PlatformChannelPair (move stuff formerly in PlatformServerChannel
  into this).

It became apparent that my previous plan to make this work on Windows
wasn't work nicely. On the one hand, on Vista+, we can basically make
things work like POSIX (created the channels in the parent and connect
them, and send a channel to a child). On the other, on XP, to be secure
you need to do more work (the channels aren't connected or authenticated
initially), so you'd need much more machinery (to wait for connection,
to authenticate, etc.).

So I'll go for a different mechanism to make things work on XP. The
assumption from the Mojo embedder API will be that it's given a channel
handle that's already been connected, authenticated, etc. (which will be
taken care of by other means). This will add flexibility in other ways
as well (e.g., make Mojo IPC more happily coexist with Chrome IPC -- you
should be able to pass a handle over Chrome IPC to set up Mojo IPC).

Still to do: Move PlatformChannelPair into its own files.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/134373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244223 0039d316-1c4b-4281-b951-d872f2087c98

Hardware video decode depends on GLX but we may be using OSMesa. In
this case fallback to non-hardware video decode gracefully instead
of static casting to an incorrect type.

This allows us to remove flags forcing non-OSMesa for some tests,
and they will test hardware decode on the ChromeOS VMs still.

These flags must go in order to support browser tests running
with a compositor instead of using legacy software mode, since
GLX inside the bot Xvfb environment can not run the compositor.
(This is a small piece of enabling us to test real code paths
in browser tests https://codereview.chromium.org/120313002/ .)

R=fischman@chromium.org, piman@chromium.org, piman
BUG=270918

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244111

Review URL: https://codereview.chromium.org/132503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244222 0039d316-1c4b-4281-b951-d872f2087c98

I did it/fixed it.

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/134663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244221 0039d316-1c4b-4281-b951-d872f2087c98

ui::TouchEvents now know the id of their source device.
The target of a touch can't be effected by a touch on another display.

Relanding https://codereview.chromium.org/103173004/, after it was
reverted https://codereview.chromium.org/103173004. When ensuring that
the GR wasn't reused between tests, I had neglected to delete the old
GR.

BUG=315651
TEST=GestureRecognizerTest.GestureEventTouchLockIgnoresOtherScreens

Review URL: https://codereview.chromium.org/132123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244220 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/134553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244219 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/133413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313716

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243957

Review URL: https://codereview.chromium.org/123383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=325435
NOTRY=true
TEST=none

Review URL: https://codereview.chromium.org/134013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/133903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330843

Review URL: https://codereview.chromium.org/133013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244214 0039d316-1c4b-4281-b951-d872f2087c98

When supplying a zero size to getcwd() typical behavior is to allocate
internally and return a pointer.  This behavior was already implemented, but
disabled by checking if size <= 0 and erroring with EINVAL.  As size_t is
positive definite, this entire check can be removed.

R=noelallen@chromium.org, sbc@chromium.org, binji@chromium.org
BUG=

Review URL: https://codereview.chromium.org/122943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244213 0039d316-1c4b-4281-b951-d872f2087c98

This is to get us ready to dynamically enable or disable a renderer feature whenever, for example, the gpu is switched in a multiple gpu system.

BUG=332188
TEST=
R=bbudge@chromium.org, jamesr@chromium.org, joi@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/126993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/132033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244211 0039d316-1c4b-4281-b951-d872f2087c98

Previously we looked at including the touchscreen name in the UMA
hardware profile: https://codereview.chromium.org/23619085/.

As that posed a privacy concern, this patch includes the vid/pid
instead.

BUG=248910

Review URL: https://codereview.chromium.org/103893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244210 0039d316-1c4b-4281-b951-d872f2087c98

This change is a first step toward moving UbertokenFetcher and
GoogleAutoLoginHelper into //google_apis. Rather than UbertokenFetcher having a
variant of StartFetchingToken() wherein it uses the primary account ID,
callers must always supply the account ID. As GoogleAutoLoginHelper should
also not know about PO2TS, this CL similarly eliminates
GoogleAutoLoginHelper::Login().

BUG=330292
TBR=nyquist,mkwst,courage

Review URL: https://codereview.chromium.org/131973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244208 0039d316-1c4b-4281-b951-d872f2087c98

Make it possible to configure synthetic delays using trace categories.
For example, the category filter "DELAY(gpu.SwapBuffers;16)" would make
swap buffers take at least 16 ms to complete.
    
BUG=307841

Review URL: https://codereview.chromium.org/98953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244207 0039d316-1c4b-4281-b951-d872f2087c98

We've been happy to prerender https URLs for quite some time now.

BUG=none
TEST=no behavior change

Review URL: https://codereview.chromium.org/133993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244206 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a reland of r243816, fixing the tiny typo.

Previously, sort was not started until all the metadata is fetched. When fetching took a time, the user saw unsorted list for a while. With this patch, sort is happened just after every updates. User can see sorted list every time.

BUG=327479
TEST=manually tested

Review URL: https://codereview.chromium.org/132683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/132283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244204 0039d316-1c4b-4281-b951-d872f2087c98

This resulted in a double -D definition.

TBR=scottmg

Review URL: https://codereview.chromium.org/132903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244203 0039d316-1c4b-4281-b951-d872f2087c98

Turns out we accidently removed the DTMF payload type from the SDP. We
now preserve it even if we force iSAC.

BUG=332016
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/133353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244200 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the TranslateDelegate to inject the required
dependencies in the translate component.
TranslateDelegate is a singleton for now, but this will need to be
revisited once the ownership model of TranslateManager is improved.

BUG=331509

Review URL: https://codereview.chromium.org/131463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244199 0039d316-1c4b-4281-b951-d872f2087c98

The Android SDK has been updated to 19, make it possible to use new
APIs.

BUG=None
TEST=None, build.
NOTRY=true

Review URL: https://codereview.chromium.org/130743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244198 0039d316-1c4b-4281-b951-d872f2087c98

This was added for the sake of Chrome Frame and is now no longer needed.

BUG=316496
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/129003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244197 0039d316-1c4b-4281-b951-d872f2087c98

Remove PrerenderTracker::TryCancel* methods and associated ones, since destruction of prerender only happens on the UI thread through PrerenderContents now.

BUG=304341
R=mmenke@chromium.org, tburkard@chromium.org

Review URL: https://codereview.chromium.org/132613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244196 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244195 0039d316-1c4b-4281-b951-d872f2087c98

In RawChannelPosix::OnFileCanReadWithoutBlocking()'s call to memmove(),
read_buffer_start may point one past the end of the buffer. This isn't a
"real" problem, since in that case read_buffer_num_valid_bytes_ will be
zero, but it's illegal to subscript a vector with an invalid index and
an assertion fails in Debug builds (an alternate fix would be to replace
&read_buffer_[read_buffer_start] with &read_buffer_[0] +
read_buffer_start).

The bug was exhibited by the flakily-failing
MultiprocessMessagePipeTest.QueueMessages (in Debug builds), so to test
run:

out/Debug/mojo_system_unittests \
    --gtest_filter=MultiprocessMessagePipeTest.QueueMessages \
    --gtest_repeat=-1 --single-process-tests

R=darin@chromium.org
BUG=329622

Review URL: https://codereview.chromium.org/132173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244194 0039d316-1c4b-4281-b951-d872f2087c98

Fix idle handlers not being called. The problem was that RenderThread::AddRoute was assuming that each listener was a RenderWidget. That used to be the case originally, but hasn't been like that for a while (i.e. also see ChromeV8ExtensionHandler and ChromePluginPlaceholder).

BUG=333051
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/133483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244193 0039d316-1c4b-4281-b951-d872f2087c98

This information is now coming in via the debug info. Lots of stuff may
disappear now.

BUG=None
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/128263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244190 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Broke compilation on a number of bots on the main waterfall

TBR=hashimoto@chromium.org,kinaba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=324166

Review URL: https://codereview.chromium.org/134213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244189 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244187 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/133123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244186 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/131543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244185 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244184 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164851:164871&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/133833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324166

Review URL: https://codereview.chromium.org/133123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244182 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267514

Review URL: https://codereview.chromium.org/119963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244178 0039d316-1c4b-4281-b951-d872f2087c98

As transient logic has been moved outside of aura it doesn't make
sense for these methods to be in WindowObserver anymore. Instead they
have been added to TransientWindowManager.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/132013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244176 0039d316-1c4b-4281-b951-d872f2087c98