- 09 Sep, 2019 40 commits
-
-
Yuchen Liu authored
1. Turn on flag 'enable_widevine' and 'ENABLE_PROTECTED_MEDIA_IDENTIFIER_PERMISSION'. 2. Add widevine key system config. Bug: 991723 Test: Shaka player demo "Dig the Uke". Change-Id: I49a7661fb4b8b5732b597622f9d496ea611dc9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783802 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f431ad17465..eb4f2d5031bc git log 4f431ad17465..eb4f2d5031bc --date=short --no-merges --format='%ad %ae %s' 2019-09-09 jdarpinian@chromium.org Fix WebKit iOS build Created with: gclient setdep -r src/third_party/angle@eb4f2d5031bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I43ec7d3621fe6e1b2b22da9c24b06593fdc37d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694944}
-
Daniel Cheng authored
319125 is a straightforward browser memory corruption bug where an IPC handler blindly trusts data from the renderer, forgetting that one of the types of data that can be set is a raw pointer ^_^ Change-Id: I14a37f1882c06edc56e5d4d2f7c1d0444869bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790480 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694943}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/305a5283c5b4..5a0242ba5c8f $ git log 305a5283c..5a0242ba5 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 marpan vp9-svc: Add new frame drop mode for SVC 2019-08-30 angiebird Report failure of vp9_alloc_motion_field_info 2019-08-30 zxdan Upload Motion Field Estimation Unit Test Files 2019-08-29 angiebird Free set_mv properly 2019-06-28 alexconv Don't generate mv refs that won't be used 2019-08-22 angiebird Move motion field from TplDepFrame to MotionField 2019-08-28 jianj Add resize test for smaller width bigger size. 2019-08-28 hienho vpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings 2019-08-21 angiebird Add MACRO MAX_INTER_REF_FRAMES 2019-08-21 angiebird Add motion_filed_info in VP9_COMP 2019-08-20 angiebird Add free_tpl_buffer 2019-08-13 hienho vp8/encoder/vp8_quantize: fix int sanitizer warnings 2019-08-09 hienho test/acm_random.h: int sanitizer warning Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ib7502b9e520ed37d16e6eaab29b07bd2a5d46495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792980Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#694942}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I42c276f72ec4d1532e6a63db4dd52cc15afcd31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792787 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694941}
-
Peter Kotwicz authored
In order to use the theme-color specified by the web page for TWAs, CustomTabStatusBarColorProvider#setUseTabThemeColor() needs to be invoked because CustomTabStatusBarColorProvider#mUseTabThemeColor defaults to false. setUseTabThemeColor() is currently not invoked because TrustedWebActivityCoordinator#mInTwaMode defaults to true This CL fixes the bug by adding a speculative call to setUseTabThemeColor() in onPostInflationStartup() similar to what is done for the toolbar hide state This CL also enables CustomTabActivityTest.testToolbarColor() on Lollipop. This matches similar tests like WebappSplashScreenThemeColorTest#testThemeColorNotUsedIfPagesHasOne() BUG=997578 TEST=TrustedWebActivityTest.testStatusBarColorPrecedence Change-Id: I6015acbae310650051b49f75cacbddc16a5e66e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771316 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#694940}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e380fd484db..a0e6ded9fcac git log 9e380fd484db..a0e6ded9fcac --date=short --no-merges --format='%ad %ae %s' 2019-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 75cf3925..e25e7642 (694706:694813) Created with: gclient setdep -r src/third_party/webrtc@a0e6ded9fcac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4a4b4d4c58050e2f4ccd55b29c8930d1e29d6013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694939}
-
Robbie McElrath authored
This also replaces android_webview_java with a java_group that depends on browser_java to prevent clank from breaking. Test: ninja -C out/aw system_webview_apk Bug: 934152 Change-Id: I1b78bcff70bc73fd307c28ebe4e453ab069c9668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788589 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694938}
-
Erik Språng authored
Bug: 1000023 Change-Id: I55d2f5134abb180f96cb9216d0ea5dee9456216d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793084 Commit-Queue: Erik Språng <sprang@chromium.org> Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#694937}
-
Erik Chen authored
Some visual properties are for the page, and some are for the widget. Right now, all are propagated by WidgetMsg_SynchronizeVisualProperties. This is incorrect since it's possible for a renderer to have a page but not a widget. This CL begins the process of fixing this incorrect routing. It adds a new IPC message ViewMsg_UpdateLocalMainFrameVisualProperties, which allows us to begin routing visual property messages through the Page object. This CL should not have any behavior changes. Bug: 998273 Change-Id: I4f4b46f8bd51e2d64b652db6aa1df6e6c3b076a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788201Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694936}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/022776627054..6ef368773be1 Created with: gclient setdep -r src-internal@6ef368773be1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7e8845e52b274aff31509c0638225c42f95795ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793355Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694935}
-
Tim Song authored
This CL makes the app list window the parent of the uninstall dialog so it remains open when the dialog opens. TEST=manual + browser test BUG=995890 Change-Id: Ib675d11ef893d802810a86d37e7c341583822cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762932 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694934}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/c6a260a763ca..8e8b719e061c git log c6a260a763ca..8e8b719e061c --date=short --no-merges --format='%ad %ae %s' 2019-09-09 featherless@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@8e8b719e061c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-components-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: Icf16a84c721bee1eda238e08c0c19a0c724c93bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694933}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I9dc3abc965aa895c6b3e26e1000b139908b70171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792235 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694932}
-
Owen Min authored
This feature affects the implementation of CloudReportingEnabled policy. Right now, this policy installs an extension to upload the report. Once the flag is enabled, the browser will no longer force-install the reporting extension but use built-in enterprise_reporting::ReportScheduler to schedule and upload reports. This flag will be removed once the migration is fully rolled out. Bug: 956237 Change-Id: Ibb429cb4b1c80f56aa4e1ae8a4ad64c2d51e94d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789929 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#694931}
-
Michael Crouse authored
This change is a follow-up of cl/1762791 to improve the description and naming of HintsFetcher coverage. Bug: 994931 Change-Id: I690ff6ddbda70cdbcdfbb56b5244270f33af25c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783233 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#694930}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ic89e2341058252857652e26cc36ed7fab1a73a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791281 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694929}
-
Xida Chen authored
Bug: None Change-Id: Ia4e2d9382b8cc96227975cdced4ea806fcf565e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792957Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694928}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ice6d514deeabf18a0d956b41e3562e2e8b75cc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791280 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694927}
-
Michael Spang authored
This fixes a warning in the chromecast build: WARNING at build arg file (use "gn args <out_dir>" to edit):10:12: Build argument has no effect. use_v4l2 = true ^--- Did you mean "use_afl"? The variable "use_v4l2" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <out_dir>" The build continued as if that argument was unspecified. Done. Made 10706 targets from 1920 files in 4874ms Bug: 1001721 Test: CQ Change-Id: I7654192da98864366c6c22755ec23e7a7eb80b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790270 Auto-Submit: Michael Spang <spang@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#694926}
-
Sean Gilhuly authored
Work on crbug.com/963446 is complete, move this TODO to the appropriate issue. Bug: 971257 Change-Id: I30d4b0f0de81a294bc29a023272c298c5bda89f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793503Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#694925}
-
Varun Khaneja authored
This should have been added when the code to sync the code was landed but I forgot to do it then. R=holte Bug: 963165,966646 Change-Id: Ie82e1348f580f8676e115c375e7b33d85d49210f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788499 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#694924}
-
Matthew Mourgos authored
- Remove the shelf_constants.h file and replace it with a new ShelfConfig class used to access the current shelf values. - Replace the usage of constants from shelf_constants.h with the use of ShelfConfig::Get(), encapsulating the constants. - No visible UI changes can be seen with this change. - ShelfConfig is owned and instantiated by the shell, so that in the future ShelfConfig can add and remove itself as an observer to things such as tabler_mode_controller. - This change is in preparation for dense shelf. In the future, ShelfConfig will be used for transitioning between dense shelf and the standard (current) shelf during runtime. Classes that use changed ShelfConfig values will observe ShelfConfig and be notified by ShelfConfig to update their layout and use the new values. Bug: 973483 Change-Id: I7c14ed3248b32e3a337b91e0822003894e7ba37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775390 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694923}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a860326887f..1e4d70d1dd08 git log 6a860326887f..1e4d70d1dd08 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e4d70d1dd08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I49ad11846fc975997a1700e9bab2fb66bd709e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793287Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694922}
-
Robbie McElrath authored
This CL removes dependencies on JNI headers when they're not used and the Java implementation isn't included. This makes chrome_public_apk work with crrev.com/c/1743088. Bug: 836335 Change-Id: Iec02f4fec9cf93183949547960e191e675e62ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746641 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694921}
-
Saman Sami authored
If a client embeds two different SurfaceIds with the same embed token, we will end up in a bad state. Ignore duplicate embed tokens in activation dependencies. I will investigate why the clients are behaving this way but regardless of the reason viz should be resilient and not crash. Bug: 1001143,962367 Change-Id: I19dddbe60c2d87ce6b94a4fee4b584efafa70876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791797 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#694920}
-
Yulun Wu authored
This will bring behavior in line with app list: disabled items will no longer appear in shelf context menu. Also fixed function order in arc_app_context_menu.h to match .cc. Bug: 997128 Change-Id: I794ffed521267a725c176fa46e39cd39fea260ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772517 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#694919}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3fdfe2823866..c2d84bfa7421 git log 3fdfe2823866..c2d84bfa7421 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ethannicholas@google.com fixed byte/ubyte types in SPIR-V output 2019-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c2d84bfa7421 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ib5f09d55505e0964ebe4d0e28727d1cb8d5078b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694918}
-
Dominic Mazzoni authored
Android uses somewhat different date/time pickers. They look like spinners. The first bug was that they didn't expose their accessible name and value. Fixed by whitelisting those roles as roles that need to expose a value on Android, and added test coverage. The second bug was that the value wasn't being updated. This change adds a call to fire a ValueChanged event to the right Blink code. Bug: 998119, 998121 Change-Id: Ibee5778c3afc532bdd145eeb7d5f4646287fc383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790466 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#694917}
-
Elly Fong-Jones authored
Leading "- " sets off a list in markdown, oops :) TBR=agable@chromium.org Bug: None Change-Id: I12bf7bcd460a9751c92c2c1e0aa3c5328e5d0382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790377Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#694916}
-
Stefan Zager authored
Need to change the invocation after this: https://chromium-review.googlesource.com/c/android_ndk/+/1783234 BUG=891999 R=jbudorick@chromium.org,cbiesinger@chromium.org Change-Id: I3d21c01e5bce740c839e9d9f2375f32da33072d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786876Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#694915}
-
Luum Habtemariam authored
Since adding this flag we've found out that the kPluginVm flag exists. Now we'll start the CupsProxyService based on that and rip out the old flag. Bug: chromium:945409, chromium:999873 Test: manually confirmed service startup with new flag Change-Id: I4b3815d05bcca104725104250ab3b043b58f2411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790272 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694914}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I771f441d9dd9d90c9b19d4025e397404e6c03d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793383 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#694913}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I2ad15b7167db4e90ca80761c42de1d00ef08b41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792789 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#694912}
-
Mike Wittman authored
Implements the ThreadDelegate abstraction for Android, providing the stack base address and registers that may require rewriting to update them from pointing to the original stack to the copied stack. Removes code from the TracingSamplerProfiler that was attempting to use the StackSamplingProfiler with the built-in Android StackSampler. This had no effect previously and crashes with the current skeleton implementation. Tracing will be able to use the built-in sampler when it's in a more mature state. Bug: 988579 Change-Id: I4c44bbec33f2e1457c03de37d8c852a85eb9d65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764288Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694911}
-
Avi Drissman authored
BUG=958419, 844455 Change-Id: I0549227aba40f6fd85b9e7b39e719798cd33e0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730774Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694910}
-
Fredrik Söderquist authored
To be able to separate the resolution of intervals from the update of the "position" information (percent, repeat) we need to keep the "full" previous interval. Extend the existing |previous_interval_begin_| to a full interval, add a new GetActiveInterval(...) helper and use that in CalculateAnimation{Repeat,Percent}. Then move the calls to the latter two functions in Progress() after the interval check/resolution. Bug: 998526 Change-Id: Ia7154e6612252d21b04ab6302c8ef75bc7664b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790449Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#694909}
-
Tom Anderson authored
This is a reland of 0173c183 Original change's description: > Reland "Use shared memory to send images to X server" > > This is a reland of a752710d > > Original change's description: > > Use shared memory to send images to X server > > > > When playing back a 1440p 60fps video without hardware acceleration, ~15% of > > frames would be dropped. With this change, I'm not getting any dropped frames. > > > > Background: > > The bottleneck is in SoftwareOutputDeviceX11::EndPaint, which (for 4K video) was > > taking ~0.06s per frame, which was limiting the output to ~15fps. It was taking > > so long because we were sending each frame to the X server over the wire. With > > the shared memory approach from the above CL, SoftwareOutputDeviceX11::EndPaint > > takes only ~0.00002s. > > > > Summary of changes: > > * Switch usage of XPutImage() to XShmPutImage() when possible. > > * Shm segment is recycled across frames. > > * Segment has a 1.5x growth policy to give windows room to resize without > > having to reallocate for each frame. > > * Segment has space for 2 frames. It was experimentally found that bumping > > this up to 3 didn't give significant gains. > > * X server sends a completion event when XShmPutImage() is finished, so we > > cannot recycle the memory until getting this event. > > * Event processing happens on the GPU main thread, but processing needs to > > happen on the compositor thread, so forwarding the event is necessary. This > > is implemented in XShmImagePool. > > > > BUG=991633 > > > > Change-Id: Ia7782cb9e21d0a93d3250c118e4ba76025354e40 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693737 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691321} > > R=jorgelo > TBR=rjkroege,kbr,kylechar > > Bug: 991633 > Change-Id: Id0533ea8ba4de45ca2242ee979197798a818826d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775500 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693202} R=rjkroege TBR=jorgelo,kbr,kylechar CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel Bug: 991633 Change-Id: I9b678d7bbb928e3fc0214f2336cd780846a4bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789444Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694908}
-
Zhongyi Shi authored
Bug: 999285 Change-Id: Iafd038d43229d927105b3013e42c2ae333839ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776703 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#694907}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d4e6d75c. With Chromium commits locally applied on WPT: d8d7248d "Move forced colors tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I0cba28e543c03b67c543e364774c57e18039a94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792855Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694906}
-