- 28 Jun, 2019 40 commits
-
-
Etienne Bergeron authored
Adding unitests to ensures the zero width characters are processeed correctly with render_text and font fallbacks. R=msw@chromium.org Bug: 972090 Change-Id: Ie68f706278669f1347475699cf0516e9ad1356ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681451Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673430}
-
Ken Buchanan authored
A type map for authenticator.mojom was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1653489 This follows up by adding one for the test class, virtual_authenticator.mojom, allowing removal of the typeconverter files. Bug: 831209 Change-Id: I166b5076da22e0ac98055e5efbdba88d2590c51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674223Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673429}
-
Kristi Park authored
Bug: 953822 Change-Id: Iec62b45fc25ec411fde50ca6b765139c07a6e6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677236Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#673428}
-
danakj authored
This is a reland of 0287293f It removes the change to use content::NavigateToURL as it introduced flake: https://bugs.chromium.org/p/chromium/issues/detail?id=979664 TBR=rouslan@chromium.org Original change's description: > Make PaymentRequestBrowserTestBase more compatible with Android > > Replace the mojo injection to change how PaymentRequests are made > by instead injecting a factory in C++. Future work will do a similar > injection into the Android Java code to change PaymentRequest behaviour > in similar ways. > > Use content test helpers to navigate instead of chrome ui desktop-only > helpers. > > R=rouslan@chromium.org > > Bug: 961849 > Change-Id: Id4859416e7457686cc35c9c578ee3a4954fe80e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680861 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673091} Bug: 961849 Change-Id: I3083e2c9d7557a7ecf8c48a2bbe2a0d19f56fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681878Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#673427}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/923582ce437a..c4781ad47d89 Created with: gclient setdep -r src-internal@c4781ad47d89 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ifdd17a63d7c2026e6b6a72a9b4ecacbd3f84a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673426}
-
Asanka Herath authored
This test was not enabled on macOS due to flakiness. The codepaths involved have changed substantially. This CL re-enables the bug to verify whether the flakiness still exists and if so to determine the underlying cause. Either way, the underlying logic is once again going through some changes which makes it important to have test coverage on macOS. Bug: 927074 Change-Id: Ie39bd7bc974e49b7dcb3ed27febb89a8ec890107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681558Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#673425}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/48e07b5f07a4..7781794b96fb git log 48e07b5f07a4..7781794b96fb --date=short --no-merges --format='%ad %ae %s' 2019-06-28 zoddicus@users.noreply.github.com Rolling 2 dependencies (#748) Created with: gclient setdep -r src/third_party/shaderc/src@7781794b96fb The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Id2daa553da5b98f21871352151f8aebe8178c94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673424}
-
Khushal authored
Canvas2DLayerBridge keeps track of the current resource on the cc::TextureLayer to avoid unnecessary updates to the layer's resource if it was not updated. But it missed a case where the TextureLayer's resource was being cleared if the canvas is made invisible after hibernation. Avoid the above by simply asking the layer for its current resource instead of mirroring that state in Canvas2DLayerBridge and running into issues if we can't keep them consistent. R=enne@chromium.org,fserb@chromium.org Bug: 977474 Change-Id: I6850115ffc019d7148a4dad40f97bb66029aa4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680296Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#673423}
-
John Lee authored
This CL merges some CSS to just 1 selector, removes some unnecessary CSS, and introduces a CSS variable for controlling the min-height of cr-input. https://imgur.com/a/XpUvUNZ Bug: 973674 Change-Id: I5fa6969548d6cc307e3f91a475e399ee977b5b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680656Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#673422}
-
Natalie Chouinard authored
Migrate the Payment methods preference fragment from the deprecated framework preferences to support library preferences. Bug: 968592 Change-Id: Id59253744c2cf278ad6bcbcad2a897887139c004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680673Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673421}
-
Jun Cai authored
This is a follow-up CL for the discussion at the following CL about using JniMocker in the instrumentation tests: https://chromium-review.googlesource.com/c/chromium/src/+/1665909/7 This CL updates the jni_generator/README.md saying that currently JniMocker only works for junit/robolectric tests, and is not yet ready for instrumentation tests. Bug: None Change-Id: I9b82f38f47068a18813ed2601b3fe3d779f7fb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681004 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673420}
-
wutao authored
Assistant web view has different host widget, so the event target may not be the |contents_view|. It should be enough to only check position in Tablet mode because the Assistant window is always on the top if it is visible. Bug: b/134169629 Test: manual Change-Id: I3e7cdac7ac122226ed2cc0b7ced83633a048ac7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679437 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#673419}
-
Yuly Novikov authored
Also update the documentation. Bug: 978103, 898684 Change-Id: I412fa68addac0327c7632d83a90606f99e6ebc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680974Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673418}
-
Jun Mukai authored
Currently individual ArcAppResult / CrostiniAppResult instance keeps icon loader and the results will be recreated every time the search is conducted (including suggestion chip). This means the ARC++ / Crostini searchers always attempt to load the same icon every time the app-list is shown and some query is searched. This is apparently inefficient; this CL allows to cache the icon images for such search results so that no further image loading and decoding won't be conducted. This CL doesn't change the performance numbers on the LauncherAnimations test cases since they use dummy data. By measuring on a real session with my test account, I see improvements AnimationSmoothness.Peeking by ~10%. Mean 51.0 to 60.2 for 10 attempts, mode value improved from 41 to 58. Bug: 978461 Test: manually Change-Id: Ie34ad979d6fdf94addc2959ea74a4e4d9652add0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677260Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673417}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d47875c4c50..85e0cba51e88 git log 6d47875c4c50..85e0cba51e88 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 crouleau@chromium.org [Telemetry] Raise exception when trace buffer is overrun. Created with: gclient setdep -r src/third_party/catapult@85e0cba51e88 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948412 TBR=crouleau@google.com Change-Id: I51da4e1da745425a3a5fd328132c6ba139716dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673416}
-
Tarun Bansal authored
Enable PredictivePrefetchingAllowedOnAllConnectionTypes by default since we decided to enable the experiment for 100% population now. Change-Id: I053429312301d5665ef599523b8b919ac0e6a0ed Bug: 914503 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679655Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#673415}
-
dpapad authored
<link rel="import" src="foo.html"> needs to be converted to import './foo.m.js'; Where the "./" prefix is added, otherwise the following error is thrown at runtime. Uncaught TypeError: Failed to resolve module specifier "foo.m.js". Relative references must start with either "/", "./", or "../". This was discovered while porting md_select_css.html to Polymer3, which happens to trigger this case. Bug: 965770 Change-Id: Id22bcb70a2d1bb4035b33b54dbde87bf0321982c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681343 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#673414}
-
Gabriel Charette authored
This is a prerequisite for MOCK_TIME on ThreadPool because base::internal::WorkerThread doesn't support TimeTicks::Now() being zero. And it's also a definite source of pain given the number of codesites found which had to work around this. Bug: 946657 Change-Id: I115b4af77e5095454b2d505915884215e82d7f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677107Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#673413}
-
Evan Stade authored
This re-lands commit a5646d5a. Difference to original: Override TearDownOnMainThread() instead of TearDown(). Original change's description: > Remove NOTIFICATION_FULLSCREEN_CHANGED > > Replace with an observer interface on FullscreenController. > > Bug: 268984 > Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671901} Bug: 268984 Change-Id: I735754efa634d8ef21b4bb57f366dbad22b3c682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676731 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673412}
-
Salvador Guerrero authored
leveldb_database.cc used to log all initialization errors, including a case we considered normal. When a database file is missing, and the client set create_if_missing = false then this means the client expected the file to be missing. Our DB code attempts to open the shared database. As no client has migrated to it then it's fine if it doesn't exist. However, as this code get executed when BrowserContext starts then it spams the logs on BrowserTests. This CL removes logging for this specific case, as it is an expected state which doesn't have to be logged. Change-Id: I51a986b43b13c441384a7cf67df6565a64881941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670361 Commit-Queue: Salvador Guerrero <salg@google.com> Auto-Submit: Salvador Guerrero <salg@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#673411}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a47ba4119f27..8f01c4e1b654 git log a47ba4119f27..8f01c4e1b654 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 eladalon@webrtc.org Define FecControllerOverride and plumb it down to VideoEncoder 2019-06-28 danilchap@webrtc.org Add trait to Build/Parse DependencyDescriptor rtp header extension 2019-06-28 kwiberg@webrtc.org Initialize signal processing function pointers statically Created with: gclient setdep -r src/third_party/webrtc@8f01c4e1b654 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3273b3dfceb7f9e01950a9245ce9788c2e5fd840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673410}
-
Jun Cai authored
This CL implements the permission prompt for Bluetooth Scanning API on Android: 1. Implements a permission prompt on Android. The message at the top of the prompt calls out that the user is being asked the permission for a site to receive nearby Bluetooth advertisement packets. The prompt lists device name for found nearby Bluetooth devices. 2. Implements the ShowBluetoothScanningPrompt method in TabWebContentsDelegateAndroid which launches a permission prompt displaying the nearby Bluetooth devices. I uploaded some screenshots of the permission prompt in the issue link. Bug: 960960 Change-Id: I15a3b4115644fe0d8674c7c00921b5560287e51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665909Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673409}
-
Jun Mukai authored
This has been enabled on all devices for a while, now we can say it's always true. Removing the flag and the legacy code now makes sense. Bug: 979365 Test: compilation succeeds / trybot Change-Id: Icf8bbf06fbd385ad9ff50380d242e0b4b43960e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680986 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#673408}
-
Ilia Samsonov authored
ProcessGTestOutput might return TestResults in |results|, even if the method returns false. Instead of re-using the vector set by ProcessGTestOutput, return new vector from ProcessMissingTestResults. Bug: 978566 Change-Id: I036b79e0a578c87d4dc692b042302e4c2db4ede8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677689Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#673407}
-
Katie D authored
This component extension will use the automation API to provide accessibility tree information to the Automatic Clicks controller in Ash, initially enabling drawing of focus rings to highlight the scrollable region where scroll events will take place. The extension is only loaded if the autoclick features flag is enabled. See go/chromeos-dwell-scroll-design for more. Bug: 978163 Change-Id: Id3700f113a913738d4a15cd87dee18c194ef55d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673570Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#673406}
-
Miguel Casas authored
This CL adds UMA histograms of VideoFrameSubmitter decode-to-raster and decode-to-compositor delays (the latter strictly included in the former). This is needed for field data collection and CrOs tests (Tast uses Go and there are no Go bindings for about:tracing AFAIK). Bug: 953253 Change-Id: I384f5b8cd9d4bd28d9857d07957be5a52af3e85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680764Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#673405}
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7d9288f5f86e..30e7f9d856eb $ git log 7d9288f5f..30e7f9d85 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 angiebird Remove mv_dist/mv_cost from new mv search funcs 2019-06-25 angiebird Speed up diamond_search_sad_new 2019-06-25 angiebird Let full_pixel_exhaustive_new return int64_t 2019-06-20 zxdan script to compact frames to y4m video 2019-06-19 zxdan add output of frame info 2019-06-19 zxdan Add Ray Tracing 2019-06-14 zxdan Add Scene module to manage other objects 2019-06-20 angiebird Integerize exhaustive_mesh_search_new() 2019-06-20 angiebird Make vp9_nb_mvs_inconsistency return int64_t 2019-06-19 angiebird Make type of lambda int in TplDepFrame 2019-06-19 angiebird Integerize log2_approximation() Created with: roll-dep src/third_party/libvpx/source/libvpx BUG=webm:1624 Change-Id: Iaf1a692312f7dba13865c14299b4e0969a386b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680301Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#673404}
-
Victor Hugo Vianna Silva authored
Bug: 979546 Change-Id: Ia6ff275769c75029f434ba2f4712d2613af5d827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682034 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#673403}
-
danakj authored
This adds it as a 100% experimental target so that it does not block CLs and only adds it to the android-kitkat-arm-rel as a first step. Other bots will be removed from exclusions as it proves okay. R=sky@chromium.org Bug: 961849 Change-Id: I652b7ae3a76ec511ca6fc8881f7708c7d0802105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680513 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673402}
-
Fabrice de Gans-Riberi authored
This will soon be required for every user of the DNS service. Bug: 979080 Change-Id: Ifc10b74d2917f825bbd299b4f9e8d4ebc7dc8cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680896 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#673401}
-
Bettina authored
Previously, Chrome Safe Browsing code converted PasswordType from the password manager code to ReusedPasswordType which we define in the protos. However, the only difference is that SYNC_PASSWORD=>SIGN_IN_PASSWORD. SIGN_IN_PASSWORD is confusing. Thus, this CL is changing to use the original PasswordType from the PasswordManager as it will be a clearer source of truth. In addition, the SYNC_PASSWORD originally meant a password for an account that is considered "blessed" for sync. This is equivalent to the primary account, which is the a currently Chrome signed in profile that the user has that is closest to being set to syncing if the user chooses to set it up. This is only part 1 of the refactoring. The next part is to update SyncAccountType with the new field from the new proto. Bug: 914410 Change-Id: I35948bc745e568cb93e5f852cf4ff9a2b4bc1393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639717Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#673400}
-
Junbo Ke authored
global volume multiplier for extra audio streams. Bug: b/134381697 Test: On device Change-Id: Idbabbfef0381f00d330263d721c6da0fc4c752ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681384 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#673399}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/625f5b2fbd89..d4d43ac07382 git log 625f5b2fbd89..d4d43ac07382 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 syoussefi@chromium.org Add suppression for test failing on old MESA 2019-06-28 syoussefi@chromium.org Vulkan: Enable numerous deqp texture tests 2019-06-28 jmadill@chromium.org Revert "Cleanup angle_libs_suffix in BUILD.gn." 2019-06-28 geofflang@chromium.org GL: Clamp uniform array access on Android and AMD devices. 2019-06-28 fei.yang@arm.com Vulkan: pipeline cache not populated as blob cache is not set Created with: gclient setdep -r src/third_party/angle@d4d43ac07382 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:979349 TBR=syoussefi@google.com Change-Id: Iee3e81a53e2763e495679f3a55dc6793cee911c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673398}
-
Mohammad Refaat authored
Change InsertTab method on TabModel to be InsertWebState. (This is intermediate step as i'll be moving the logic to WebStateList and will call it directly). Bug: 914967 Change-Id: Ie131559abfd9c8a073992ee8ad67c046e6a4cc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680134 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#673397}
-
Tiansong Cui authored
When disconnect starts, device can be disconnected any time so we shouldn't treat it as still connected. Bug: internal b/136211218 Test: cast_bluetooth_unittests Change-Id: I84d2bf996d8cef956ae612f0fbfe1fc1d2fe56d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681306Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Auto-Submit: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#673396}
-
Francois Doray authored
The failure reported in https://crbug.com/857418 has nothing to do with what the test is verifying. It is very possible that the problem was caused and later fixed by unrelated changes. Bug: 857418 Change-Id: Ia0f213c5bb86743c1e97aa8d4d66fabe42dbee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679060 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#673395}
-
Natalie Chouinard authored
Migrate the Password settings page from the deprecated Framework Preferences to the Preferences Support Library. This also fixes the issue with missing preference widget animations on the Password settings screen. Bug: 968592, 967858 Change-Id: Id9aa3a1fda30729f52e2456e730345acaa01c1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678848Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673394}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: sky@chromium.org, miu@chromium.org, boliu@chromium.org, seantopping@chromium.org Change-Id: Ic005b1cc50020f130fe216efcc1c01187bcaa9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680425 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673393}
-
Siye Liu authored
There are differences in the behaviors in Textfield::InsertText and RenderWidgetHostViewAura::InsertText when the provided text is empty. TSF uses TextInputClient::InsertText to commit current composition and expects all implementation classes to have same behavior. The text will be committed only if the provided text is not empty in TextField::InsertText. However, in RenderWidgetHostViewAura::InsertText, composition will be committed with current composition text if provided text is empty. As a short term fix for Windows platform, only call |InsertText| if text is not empty. Use crbug.com/978678 to keep track of long term solution. Bug: 977820 Change-Id: I3eb1bbc9ed6f98f8356fda01cd9cc2ee91a79a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675465 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#673392}
-
chrome://flagsMaksim Moskvitin authored
Bug: 922900 Change-Id: I5c6f07b29e21f278d2051e5fc06cf0e36d611ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678373 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673391}
-