- 26 Jun, 2020 40 commits
-
-
Rakib M. Hasan authored
Several fixes have landed in the most recent version which may resolve test failures. Bug: 1096572 Change-Id: I1ec878a40a49137b38690a7a4ea234362ca42a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268307Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#782957}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593151085-57fe35f0746eacbd2632836a414f4d24425341a7.profdata to chrome-mac-master-1593172332-f17aa6b42592bba9619dfbc84b45f66eb92ffb6a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If7b5a732635d1ae8eac801fc7d3462b45dfbff3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782956}
-
Rainhard Findling authored
This CL changes any issues the ICU syntax presubmit check may find from an error to a warning. The reason for this are false positives: the current ICU syntax check flags some more rare ICU plural syntax variants as invalid while they are actually correct (e.g. explicit numeral statements beyond 1). The long-term solution for this is to improve the ICU syntax check to correctly recognize such syntax variants. For now, this CL prevents CQ errors for CLs containing such syntax. Bug: 1081730 Change-Id: I882a4e6f5ae11a0a5361782589b1705d652531b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270221Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#782955}
-
Johannes Kron authored
Add the histograms Media.RTCVideoDecoderInitializationLatencyMs and Media.RTCVideoDecoderReinitializationLatencyMs that tracks the initialization and reinitialization latencies of the hardware video decoder that is used in the RTC pipeline. Bug: 1061040 Change-Id: I25626b6b0473bde0a21a5b6c826a1eabdc1c0cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270437Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#782954}
-
Morten Stenshorne authored
If there's something unbreakable inside a container at a fragmentainer boundary, and there are no possible breakpoints, it will overflow the fragmentainer. This was already working, but in such cases, the container should then also overflow the fragmentainer (and consume the amount of space that it overflows). This will also effectively make us refuse breaking inside the block-start border or padding area (since that's included in the intrinsic block-size, which is unbreakable). The fieldset layout algorithm is still able to handle breaks inside borders and padding (and had tests for it), but since this will no longer happen, some tests had to be updated. The algorithm should also be fixed (only a TODO for now), to no longer support such breaks (mostly about removing a little code). There's also a fieldset-specific regression introduced by this CL: crbug.com/1097012 . This is about fieldset block-end padding and how the fragmentation machinery gets confused by it. This affects two unit tests. Rather than disbling them, I thought it was better to update with incorrect expectations (with a TODO), since the tests are probably still useful, even with this bug. Bug: 829028, 875235 Change-Id: I833faf7bc84328d36c9ccd640478badfd6278492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263353Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#782953}
-
Sylvain Defresne authored
There is now only a single project generated from gn, so update the documentation to remove reference to the workspace (and remove old warnings against opening the project directly). Bug: none Change-Id: I8d19c078159154c740e9c7fae5b72b62b1997ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267097 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782952}
-
Miguel Casas authored
DrmDisplay::SetColorSpace() ends up setting the de/gamma ramps instantly via HardwareDisplayPlaneManager(Atomic)::CommitGammaCorrection(). When transitioning SDR-HDR or viceversa, this causes a glitch because the de/gamma ramp is committed separately from the page flip containing the new content. This CL fixes that by adding a parameter |on_next_commit| to DrmDisplay::CommitGammaCorrection() and wiring it down to the appropriate HardwareDisplayPlaneManagerAtomic where, if set, the code stores the new gamma/degamma ramps and pushes them on the next Commit(). Bug: b:158781255 Change-Id: I89ad16f15d40f1c9674ce78f68400b74d506b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264771Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#782951}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1c518aa4d4fde49899293f7681099573678c976d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270109Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. By this CL, ClearBrowsingDataFragmentBasic class uses |IdentityServicesProvider#getIdentityManager| function by passing profile via |Profile#getLastUsedRegularProfile| function. Note: This is only code clean up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ib961204a5133e49da4f9af3a92b0331baacea1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266473 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#782949}
-
Sreeja Kamishetty authored
In IsInactiveAndDisallowReactivation, we currently log a DumpWithoutCrashing to monitor crashes from wild. But, we could receive this from a compromised renderer sending an IPC from a speculative state. This CL kills the renderer process in that case when we try to ignore such events Bug: 1085430 Change-Id: I9b5f482207207ed34e5dc1a3b95c7c762d167d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213818 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782948}
-
Kent Tamura authored
Note: LayoutNGForControls flag is in "experimental" state. This CL does rebaseline for some tests, and add LayoutNGFlexibleBox:: IsChildAllowed(), which LayoutFlexibleBox has. Bug: 1040826 Change-Id: Ie7554b701698fb7b9780a560c65821989e7c4fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245162 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782947}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5bc57ff35f996749e118a58ccfaf937339e1de51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270340Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782946}
-
Scott Violet authored
There are a couple still failing, which I will need to investigate. BUG=1025626 TEST=this just updates expectations, no actual code change. Change-Id: I38f4ed163c5638fab6d00ca045b1b174f101c8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268877 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#782945}
-
ckitagawa authored
This CL moves the call to RFHI::SetEmbeddingToken() from NavigatorImpl::DidNavigate() to RFHI::DidNavigate() and makes it private. This mitigates the risk of it being called elsewhere causing a bug and generally cleans up the API. Bug: 1098283 Change-Id: I9e41c37d16e059e747c44236031c83d4236c01a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261262 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=none TBR=grt@chromium.org Change-Id: Iff6eb54c3cff2bd162d799c9b1e977345da641f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270300Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#782943}
-
Mike Dougherty authored
NSErrors need to be converted to strings before logged in order to display details about the error. Bug: 1098758 Change-Id: I3f55c27b747bceefb4f9115aa57c91120b873905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267440Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782942}
-
Colin Blundell authored
Now that infobars have landed in WebLayer, we can step back and share what makes sense to be shared. InfoBarCompactLayout.java (like InfoBarLayout.java) is reusable by WebLayer. This CL componentizes //chrome's InfoBarCompactLayout.java; a followup CL will change //weblayer to use it rather than its own custom fork. All the resources that InfoBarCompactLayout.java were either already componentized into //components/infobars/android for InfoBarLayout.java or are from lower levels of the codebase that are depended on by //components/infobars/android:java_resources. Change-Id: Ic1efeca868b94f536056e5872cf5508f7913df2b Bug: 1099169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264126Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#782941}
-
Mirko Bonadei authored
Since the absl component build has landed, this CL restricts access to the absl source_sets in favor of a direct dependency on the component target. For now there is an allowlist but based on the outcome of https://groups.google.com/a/chromium.org/forum/#!topic/cxx/cNZPHgfhNP4 it might be lifted. Bug: 1046390 Change-Id: I171ff8352e10241ca5dd3703d15e189a5ff534b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260532 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782940}
-
Roman Aleksandrov authored
Fixed: 975711 Change-Id: I07a8c958011bb39709abde4180d5c9099fde80f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257916 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782939}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6580fb3e51cc..839fddf46af2 2020-06-26 patrick.brosset@microsoft.com Grid: Round offset data to handle high-dpi monitors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098929 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieaf66b49e16b7b83885ef77a4a35188ded1e2281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270428Reviewed-by:
-
Benjamin Smith authored
R=tmrts@chromium.org, ulan@chromium.org Search is a critical user journey for Gmail. Search inbox for deals. Bug: 1044682 Change-Id: I0f66c879ab02cfa3332a75576595335a344f9d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247319 Commit-Queue: Benjamin Smith <codesmith@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782937}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I79ad69afd033c282e63cc25e3c44db664d7d13ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257747 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Harald Alvestrand authored
This is the first step in removing the feature: 1) Count 2) Deprecate 3) Remove Bug: webrtc:6625 Change-Id: Icd9ad6afa7cb427340d075680134fc5d85050353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270062 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b19cfeeb5c66..54544ec92add 2020-06-26 danilchap@webrtc.org In av1 encoder set bitrate per layer when scalability is used. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I50b86962a5da308e3f6c5ab283b2887538ae9a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270425Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c84119493b9c..55be03a1e001 2020-06-26 fmayer@google.com Merge "Add --heaps to heap_profile script." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6888537b59b12be8e302f05e60007dfbcc6795d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270424Reviewed-by:
-
Tanmoy Mollik authored
This feature was launched to 100 percent stable. This cl removes the java side of the feature flag. Bug: 1096011 Change-Id: Ib836eee0e256d541b30ed3ac6bb17324335c1640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266879 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#782932}
-
Side Yilmaz authored
Fix for crrev.com/c/2242078 that is reverted here(crrev.com/c/2259150), because of crbug.com/1098208. This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since HistoryManager runs only in regular mode, this CL always pass regular profile to IdentityServicesProvider. The code behaviour stays same as today. Bug: 1041781, 1075562 Change-Id: Ib1f32ca458c7d2243991d7b4f17af1c8f5c2f78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262952Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#782931}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/837b9c5748eb..b60d96652beb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090082,chromium:1091851 Tbr: droger@google.com Change-Id: Ib74ee441e24f0265abfe5ae6de3affc20358665e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270421Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782930}
-
Nick Diego Yamane authored
R=msisov@igalia.com Bug: 896640 Change-Id: I8a6fcdd87e9bcb622e21bf3e86af185cd0b761f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267418Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#782929}
-
Nohemi Fernandez authored
AddAccountSigninManagerTests were failing due to a missing run completion. Remove intermediary method that causes this failure. Bug: 1078815 Change-Id: I1766e593927cd40be318cf66bb67d11f5ed47006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264057 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782928}
-
Jérôme Lebel authored
Migrating from MDCInkView to MDCRippleView in IdentityPickerView. For more details: https://material.io/develop/ios/components/ink/#migration-guide-ink-to-ripple Fixed: 1099381 Change-Id: I074db9baabaff9461a456df48498d63089a13cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267323 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#782927}
-
Mikel Astiz authored
It's not actually used to sync any data because all datatypes have been migrated, so there is no need to continue persisting the Directory to disk (sqlite), sparing unnecessary I/O load. The patch also removes the plumbing for unrecoverable Directory errors, which are no longer relevant. Change-Id: I956df6d69d3dbdd466074c9df468a2b7ab629a72 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265999Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782926}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46f8ecc40de9..6580fb3e51cc 2020-06-26 paulirish@chromium.org stylelint: exit gracefully if all affected files are ignored 2020-06-26 changhaohan@chromium.org Add search cancel button to SearchableView 2020-06-26 mathias@chromium.org Add e2e test for fake eval in Console If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1067184,chromium:1083142,chromium:1099603 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I794bf3758a4b7c3784049748e24e75d2a7f919b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270422Reviewed-by:
-
Olivier Robin authored
Bug: 1089532,1088885,1088884,1088883,1088881,1088800 Change-Id: If98d79e873b32b4037b9535540da7056c9848c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266898Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782924}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I6e0adab94e65727828893d34444fc2feb8e8304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256767Reviewed-by:
-
David Roger authored
This reverts commit b7b42218. Reason for revert: the tests are flaky. See https://crbug.com/1099636 Original change's description: > Add location delegation instrumentation tests > > Add some integration tests that runs javascript get geolocations and > verify results. > > Bug: 1069506 > Change-Id: I368489922b13711b3e9d0f3d800a7cc3172a979c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249372 > Reviewed-by: Peter Conn <peconn@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782422} TBR=mthiesse@chromium.org,peconn@chromium.org,eirage@chromium.org Change-Id: I3b143731db0bcbae01f880cd1bb70474f0b32e22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069506, 1099636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270321Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782922}
-
Mirko Bonadei authored
This reverts commit 3a2a481f. Reason for revert: This doesn't work because gtest_enable_absl_printers is declare_arg'd in googletest so in WebRTC we get an error even if we use declare_default in the .gn file. Original change's description: > Add gtest absl deps to the absl component. > > This CL conditionally adds absl/debugging deps to the absl component > if build_with_chromium=false. This will allow downstream projects to > use gtest with absl (for pretty printers and matchers) but it will > remove these dependencies in Chromium to avoid to add static > initializers. > > When static initializers will be removed, the dependency will not be > conditional so Chromium will also be able to set > 'gtest_enable_absl_printers=true'. > > Bug: 1046390 > Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782889} TBR=thakis@chromium.org,mbonadei@chromium.org,danilchap@chromium.org Change-Id: I808c4b928c98733965276fd49093bfe35b4d9f74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270082Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782921}
-
Benjamin Smith authored
R=tmrts@chromium.org, ulan@chromium.org Open Conversation is a critical user journey for Gmail. Open first conversation in inbox. Bug: 1044682 Change-Id: Ia03c9b5799823a203e63ee1357f025b874945e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246867 Commit-Queue: Benjamin Smith <codesmith@google.com> Reviewed-by:
-
Jia authored
Following a hard-to-reproduce bug report (crbug.com/1098059), this cl adds logging to monitor if some curve data is invalid. Bug: 881215 Change-Id: I9b2b099c052ff601a747b4e6241d6cb31b5b3c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269598 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#782919}
-
Tim van der Lippe authored
shell=True is a security hazard per the Python documentation: https://docs.python.org/2/library/subprocess.html#frequently-used-arguments This has 2 effects that required changes in scripts: 1. The shell removes extraneous quotes from arguments, which we now should no longer include in any argument passed in 2. The shell now requires an array of arguments, rather than a string Next to that, removal of shell=True is required if we later want to call the script as part of a GN action. R=tapted@chromium.org,dpapad@chromium.org Bug: 1096473 Change-Id: I77e85048e5a6db33035ca774434857170aeaf91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264365Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#782918}
-
