GitLab

BUG=413748

Review URL: https://codereview.chromium.org/568393002

Cr-Commit-Position: refs/heads/master@{#295000}

Fix a ServiceWorker crasher. We have to test the provider_host_ weakptr in async callbacks because the document can be closed, and the host deleted, in the interim.

BUG=414118

Review URL: https://codereview.chromium.org/569423002

Cr-Commit-Position: refs/heads/master@{#294999}

This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes.

This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future.

BUG=375039
TEST=browser_test passes

Review URL: https://codereview.chromium.org/562103002

Cr-Commit-Position: refs/heads/master@{#294998}

ChannelMojo::OnConnect() ignores errors in Send() but the error
results deleting |message_readrer_| which causes null access.
This CL add an error check for that.

This also adds some hooks to make this testable by
faking lower level API.

TEST=ipc_channel_mojo_unittest.cc
BUG=410813
R=yzshen@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/554363004

Cr-Commit-Position: refs/heads/master@{#294997}

https://skia.googlesource.com/skia/+log/f0ddf33f1954489d45e4f2d9c8712eac60539c65..44162675ca4b790c2af0fbd9c41f262c8be26b05

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/567423003

Cr-Commit-Position: refs/heads/master@{#294996}

Review URL: https://codereview.chromium.org/571843002

Cr-Commit-Position: refs/heads/master@{#294995}

BUG=359249

Review URL: https://codereview.chromium.org/568363002

Cr-Commit-Position: refs/heads/master@{#294994}

We're still seeing crashes that appear to come from multiple simultaneous
writes. Given that writing_ is false when we crash, but the operation
matches the current thread, file handle and IPC Channel, it could
be that for some reason a failed Write is still genarating a notification.

So this CL stores two error codes (one for the current operation and another
for a previous failure), and the write size.

BUG=387876
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/564863003

Cr-Commit-Position: refs/heads/master@{#294993}

Originally, we delayed the rendering and waited for the late coming frames. However, when play with audio, the late coming frame should be just dropped to keep the AV sync. So we change to drop a frame if it comes too late.

BUG=411123
TEST=Run vda_unittest on peach_pit.

Review URL: https://codereview.chromium.org/562173003

Cr-Commit-Position: refs/heads/master@{#294992}

Regression is tiny (0.04%).

http://build.chromium.org/p/chromium/builders/Linux/builds/53433
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/575603003

Cr-Commit-Position: refs/heads/master@{#294991}

Regression is tiny (0.06%).

http://build.chromium.org/p/chromium/builders/Win/builds/24362
https://chromeperf.appspot.com/report?masters=Chromiqum&bots=chromium-rel-xp&tests=sizes%2Fchrome.dll&checked=all&start_rev=294698&end_rev=294959

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/575713002

Cr-Commit-Position: refs/heads/master@{#294990}

Discovered while running cast_simulator when seeing that no frames were
late at the receiver, even under impossible scenarios.

Review URL: https://codereview.chromium.org/575683002

Cr-Commit-Position: refs/heads/master@{#294989}

https://chromium.googlesource.com/chromium/blink/+log/fbd4f37d728e462a9cbc3482156ad7e8c2c1d0b5..be75ff2f0cfa2d2ad48039af212f6b609c550784
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/576563003

Cr-Commit-Position: refs/heads/master@{#294988}

BUG=https://code.google.com/p/chromium/issues/detail?id=388101
TEST=local + with trybots
R=mseaborn@chromium.org,jam@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/452543002

Cr-Commit-Position: refs/heads/master@{#294987}

These are only used for futexes that are shared between processes, which should not be happening in Chromium.
BUG=413855

Review URL: https://codereview.chromium.org/569713004

Cr-Commit-Position: refs/heads/master@{#294986}

Always start a renderer if one does not already exist.
The check is cheap so no need for a parameter to control it.

BUG=

Review URL: https://codereview.chromium.org/570783002

Cr-Commit-Position: refs/heads/master@{#294985}

BUG=384041

Review URL: https://codereview.chromium.org/561453002

Cr-Commit-Position: refs/heads/master@{#294984}

BUG=407184,386735

Review URL: https://codereview.chromium.org/564373006

Cr-Commit-Position: refs/heads/master@{#294983}

BUG=309681,414153
TEST=AutomationApiTest.*.

Review URL: https://codereview.chromium.org/561933002

Cr-Commit-Position: refs/heads/master@{#294982}

This allows Skia to do YUV conversion on the GPU in the case of a
hardware-accelerated canvas.

Note that this only works for JPEG color space video frames, as that's
the only format Skia currently supports.

BUG=91208

Review URL: https://codereview.chromium.org/531353002

Cr-Commit-Position: refs/heads/master@{#294981}

The extension gets disabled when Chrome goes to sleep. If it doesn't
wake up for some reason, the app will stay disabled. To make sure this
doesn't happen, enable the app after loading it (this should be no-op if
the app is already enabled).

TEST=Let a Chromebook battery drain while it's suspended. On next boot the
easy unlock app should be enabled (provided that it was enabled when Chromebook
was suspended).

BUG=410082

Review URL: https://codereview.chromium.org/564663003

Cr-Commit-Position: refs/heads/master@{#294980}

When updating the ReadyState, HTMLMediaElement will immediately check the duration.
If at that time has_valid_metadata_ is false, we will return NaN.
So the has_valid_metadata_ has to be set before ReadyState is updated.

BUG=414499

Review URL: https://codereview.chromium.org/572803002

Cr-Commit-Position: refs/heads/master@{#294979}

The exact wakeup times are don't-cares as long as the interval is regular.

BUG=411488

Review URL: https://codereview.chromium.org/567133002

Cr-Commit-Position: refs/heads/master@{#294978}

BUG=414362

Review URL: https://codereview.chromium.org/576543003

Cr-Commit-Position: refs/heads/master@{#294977}

Hangout Remote Desktop integration is no longer targetting M39.
Since it hasn't gone through security review yet, we should disable the
feature until we got a sign off from security.

BUG=414463

Review URL: https://codereview.chromium.org/572083002

Cr-Commit-Position: refs/heads/master@{#294976}

There are some parameters in the Gesture Configuration which are
no longer used for unified gesture detector:
max_radius_;
min_flick_speed_squared_
min_rail_break_velocity_
min_scroll_delta_squared_
min_touch_down_duration_in_seconds_for_click_
rail_break_proportion_
rail_start_proportion_
scroll_prediction_seconds_
points_buffered_for_velocity_

BUG=380131

Review URL: https://codereview.chromium.org/570633002

Cr-Commit-Position: refs/heads/master@{#294975}

BUG=402728

Review URL: https://codereview.chromium.org/578483002

Cr-Commit-Position: refs/heads/master@{#294974}

BUG=

Review URL: https://codereview.chromium.org/569283005

Cr-Commit-Position: refs/heads/master@{#294973}

Add a flag for lucid sleep so that apps that wish to start working with it can
do so while it's still under development.  Also to help with testing when the
lid is closed, add a class that will flash the light bar when the system is in dark
resume.

BUG=397328
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/566993002

Cr-Commit-Position: refs/heads/master@{#294972}

This makes touch events work in <webview>.
Otherwise GestureRecognizer starts sending event to bogus Window*, which
crashes the browser.

BUG=413017
Test=
In a touch enabled device, open a chrome app that has a <webview>.
e.g. https://chrome.google.com/webstore/detail/edggnmnajhcbhlnpjnogkjpghaikidaa
Try doing the following actions, none of them should crash the browser.
1. Tap on an input box, e.g. by going to http://www.google.com.
2. Scrolling a page should work.
3. Go to a page that has no touch handlers, you should be able to scroll the
page w/o problem.
3. Go to a page that has touch handlers (e.g. touchstart), you should be able
to scroll the page w/o problem.
4. Go to a page that has preventDefault() on touchstart event, you shouldn't
be able to scroll the page.

Review URL: https://codereview.chromium.org/572763002

Cr-Commit-Position: refs/heads/master@{#294971}

BUG=414453
TEST=None
R=dalecurtis

Review URL: https://codereview.chromium.org/578433002

Cr-Commit-Position: refs/heads/master@{#294970}

Before this change, MojoApplicatioHost was activated only if some
browser-side modules requested it. There was no way for renderer
to activate it.

This CL let MojoApplicationHost always get activated. Now
renderer can request services it needs without its own activation flow.

R=darin@chromium.org,tsepez@chromium.org
TEST=none
BUG=none

Review URL: https://codereview.chromium.org/563373002

Cr-Commit-Position: refs/heads/master@{#294969}

Revert of Minor cleanup in EasyUnlockClient (patchset #2 id:20001 of https://codereview.chromium.org/569813002/)

Reason for revert:
Looks like some ChromeOS code was missed here; it's unclear why bots didn't catch this.

Original issue's description:
> Minor cleanup in EasyUnlockClient
>
> * arg names in GenerateEcP256KeyPairCallback typedef were reversed
> * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead
> of having long list of arguments)
>
> BUG=None
> TEST=existing unittests
>
> Committed: https://crrev.com/35e3a9c7061205db58f57182f5ba5eb87be0f355
> Cr-Commit-Position: refs/heads/master@{#294954}

TBR=stevenjb@chromium.org,isherman@chromium.org,tbarzic@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/577443004

Cr-Commit-Position: refs/heads/master@{#294968}

BUG=

Review URL: https://codereview.chromium.org/566343002

Cr-Commit-Position: refs/heads/master@{#294967}

This CL adds JUnit4 to chromium android checkouts. It will be used for
host-side java unit testing. This should allow us to both write new
tests for existing java code and convert some existing device-side
instrumentation tests.

BUG=316383

Review URL: https://codereview.chromium.org/556893004

Cr-Commit-Position: refs/heads/master@{#294966}

This is the 3rd part accelerated direction control.

The legacy code was handling alternatesdirection instead of the full set
of direction controls.

Now that blink side has landed, we can remove this legacy code.

It builds on top of https://codereview.chromium.org/227733004 and
https://codereview.chromium.org/225183014

BUG=348071

Review URL: https://codereview.chromium.org/576553002

Cr-Commit-Position: refs/heads/master@{#294965}

Since the CQ runs this bot, git cl try should too.

BUG=413904

Review URL: https://codereview.chromium.org/565393002

Cr-Commit-Position: refs/heads/master@{#294964}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/553573003

Cr-Commit-Position: refs/heads/master@{#294963}

This occurs in the NativeViewHostAura::NativeViewDetaching code path where we first remove the
clipping window which is the intermediate parent of the web contents view. The clipping window
is hidden which causes the RWHVA::Hide function to get called which initiates the hiding sequence.
Then the web contents view is reparented to the main view which is still visible. Now the RWHVA::Show
function is called which initiates the show sequence. Eventually the main view is hidden, which then
initiates the hide sequence.

Addressed this with the following changes.
1. WebView::AttachWebContents and WebView::DetachWebContents
   now show and hide the webcontents native view. The
   WebContents is shown and hidden as before in
   WebContentsNativeViewAura::OnWindowVisibilityChanged.

2. Removed the WebContentsNativeViewAura::OnWindowParentChanged function.
   This function was present to show and hide the webcontents if the window was visible.
   This should not be needed with the change in #1 above.

3. Added a new file webview_unittest.cc. This contains the unittest WebViewUnitTest.TestWebViewAttachDetachWebContents
   This is run as part of unit_tests.exe.

BUG=412989
R=sky

Review URL: https://codereview.chromium.org/564553002

Cr-Commit-Position: refs/heads/master@{#294962}

Similar to https://codereview.chromium.org/385743002 , but in a file
that's also built in host targets. Depends on r#294584.

If your bot can't deal with this, please let me know!

BUG=none

Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593
Cr-Commit-Position: refs/heads/master@{#294687}

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/443483002

Cr-Commit-Position: refs/heads/master@{#294961}