- 16 Sep, 2020 40 commits
-
-
Saurabh Nijhara authored
The policy value creation login is currently duplicated in the tests that need to set DeviceMinimumVersion policy. This CL extract that logic along with other common elements into a test helper class that could be used by multiple test classes. This test helper class would also be useful when the update required notification unit tests are extracted into a separate unit test class which should be placed closer to c/b/chromeos/ui/update_required_notification.cc. Bug: 1128413 Change-Id: I0952c9c4f99af348e6de40154b57cf2a777ef07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410255 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807435}
-
Henrik Boström authored
This function is only used by video_capture_device_avfoundation_mac.h and unittest. By moving this to the modern capture implementation, it makes sense to not longer take "Class implementation" as argument. This function now only works with the intended implementation. Bug: chromium:1124647 Change-Id: Ia3a3802ddd523fd6501f00333e0fbaf7e9a5956b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410035 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#807434}
-
Stephen Chenney authored
Found while adding ink overflow for text decorations, we currently do not invalidate ink overflow on any text decoration style changes (presumably because we never previously computed overflow for them). Here we add the necessary predicate function and update the json template to invoke the predicate on the appropriate style changes. Tested with a unit test to confirm the style difference computation sets the necessary flag. Bug: 896295 Change-Id: I3e3e697c70a21ae66da7288c0b0a5d9826593a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411300Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#807433}
-
Alice Wang authored
This CL removes the unused method SyncTestRule#signinAndEnableSyncInternal() as all its usages are migrated. Bug: 1126814 Change-Id: I98d876133dc1f2b5068a2f9f451ff963fad4683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410123Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807432}
-
Mariia Shvedchenko authored
This is a reland of f1b689af Reland, since the CL was not the culprit for the builder failures. Original change's description: > [Autofill] Returns all patterns that match given language and fieldtype. > > This CL provides new structure MatchingPattern that replace using > single regular expressions, but store more information about concret > pattern. Also it contains splitted MatchType into MatchFieldTypes > and MatchAttributes and sceleton of PatternProvider class. > > > Change-Id: I5acebf12aafaca67ae87260b2c897bdf35a38bea > Bug: 1121990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385282 > Reviewed-by: Christoph Schwering <schwering@google.com> > Reviewed-by: Matthias Körber <koerber@google.com> > Commit-Queue: Mariia Shvedchenko <mariiash@google.com> > Cr-Commit-Position: refs/heads/master@{#806125} Bug: 1121990 Change-Id: I18e615e2019894d1cda1b8b1dac95218ead4949a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414068Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#807431}
-
Sigurd Schneider authored
In https://crrev.com/c/1962191 we switched off various HeapSnapshot tests in order to complete the ES Modules migration. However, switching these tests back on is not as trivial since they are inspector/CDP tests that rely on the DevTools frontend JS as a dependency, and it is not possible to load the frontend code over the file:// protocol used to boot these tests. This CL switches the tests back on, and duplicates the functionality from the frontend necessary to run these tests, on the assumption that the supporting JS for these tests will need to be managed independently of the frontend going forward. Bug: 1110817 Change-Id: I2d0d6714e1a2b42a324dbdddda5f94ec49ee72a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396078Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#807430}
-
Henrik Boström authored
This is a reland of ca1323fe The original CL was supposed to modify FourCCToChromiumPixelFormat, but this part of the change got lost in a rebase. This reland has been rebased on top of other changes, including support for both a modern and a legacy implementation of the VideoCaptureDeviceAVFoundation. As a consequence, this CL has to have both a modern and a legacy implementation of FourCCToChromiumPixelFormat. This CL moves FourCCToChromiumPixelFormat from the utils file to the static part of the capture classes. This allows the VideoCaptureDeviceFactory to perform GetDeviceSupportedFormats() using the current implementation. Original change's description: > [macOS Capture] Recognize NV12 and prefer it by default. > > The current default is YUVY, which despite not being supported by any > cameras we've tested, is preferred[1] over the currently recognized > YUY2, which IS supported by most cameras we've tested. See [2] and > https://crbug.com/1124647. > > This CL changes the default to NV12 and makes it a recognized format. > This pixel format is more preferred (according to [1]) than both YUVY > and YUY2. An alternative would be to default to YUY2 instead, and YUVY > wouldn't be picked because it isn't in the list of supported formats, > but we have reason to believe that NV12 is a better choice for future > WebRTC patches and that this format is supported by the Chrome > rendering pipeline. > > NV12 is a planar pixel format, it has 2 planes and is contiguous in > memory. To support this, this CL adds support for planar (along with > the old nonplanar) contiguous buffers. We don't care how many planes > there are, as long as the buffer remains contiguous. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:media/capture/video_capture_types.cc;l=18;drc=9e9c1706881c9a04f124ade622c10460d14fd9f5?q=media::VideoCaptureFormat::ComparePixelFormatPreference&originalUrl=https:%2F%2Fcs.chromium.org%2F > > [2] https://docs.google.com/document/d/1kcJ0Km5kAvrNFB6o7RG89bpvjOhgEo-0qorg5qm7KyA/edit?usp=sharing > > Bug: chromium:1124647 > Change-Id: I5c92e1de73922fd9ee87d8a5892438f61f2f56bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391064 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806084} Bug: chromium:1124647 Change-Id: If7497373e7cd31966e9da4e3b1f4869d59904e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410380Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
[PartitionAlloc] Disable PartitionAddressSpace::UninitForTesting when USE_PARTITION_ALLOC_AS_MALLOC is enabled. This causes the memory allocated before running tests. So the tests will crash because of access violation. Bug: 998048 Change-Id: I3e91471f1d55284ea6fbd2d3045171ede017902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410145Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#807428}
-
Gyuyoung Kim authored
Now we can use mojom::V8CacheOptiosn directly in Blink. So, this CL replaces all uses of blink::V8CacheOptions, then remove it. Change-Id: I636e0259d0b7da692bf693c3ec13f99dba9cd410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409665Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
These tests are now e2e tests in the DevTools repository. Consult DevTools front-end documentation on how to run these locally in case you make changes to the GC. https://chromium.googlesource.com/devtools/devtools-frontend/ Bug: chromium:1110817 Change-Id: Ibbb83b5793700cb993e840b2c46c67e216b6b978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412288 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This directory doesn't have any code. Remove it. Bug: 919392 Change-Id: I69443b2d892b459dad3cc9a47b7a8445f28ac7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412061Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#807425}
-
Colin Blundell authored
These browsertests began failing on Android M when I introduced the translate infobar, and I was unable to resolve the issue at the time (while I had verified manually that the translate infobar worked as expected on M). The failures turned out to be an instance of the bug fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2410488; interestingly, in this case the bug manifested deterministically rather than racily. Bug: 1094903, 1128384 Change-Id: I6d01d12d57363d0717524e87d3e3cae6b26cf21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413254Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807424}
-
Takashi Sakamoto authored
third_party/vulkan_memory_allocator uses posix_memalign inside vma_aligned_alloc only when defined(__linux__) && defined(__GLIBCXX__) && !defined(_GLIBCXX_HAVE_ALIGNED_ALLOC). When building chrome on linux-rel (using libc), aligned_alloc will be used instead. Since libc allocator shim overrides free, freeing memory allocated by aligned_alloc causes crash. Bug: 1121427 Change-Id: I4d6c34e493a685520bb0c561b1b1c6b16ceb38e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392230Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff50ca34..b09e7729 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78265e6b1a6a8e18408ffc940243634a7546c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410767Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807422}
-
Raphael Kubo da Costa authored
Tests using generic-sensor-iframe-tests.sub.js have been flaky on the Mac bots for a long time. The flakiness is usually seen in the same-origin iframe focus traversal test, where the "is_sensor_suspended" command returns true rather than false. The cause is the same one as r805674 ("sensors: Rewrite the frequency hint test"): the mock platform sensor uses window.setInterval() to simulate the periodic reading of sensor data, but setInterval()'s actual frequency can vary a lot (especially on the Mac bots), to the point that we cannot rely on the other timer we created in iframe_sensor_handler.html will consistently have a period longer than setInterval()'s. The only way to reliably check if a sensor is suspended or not is to query the mock platform sensor directly at the expense of no longer using only the public API: we now have a isReadingData() method in MockSensor that we use to query if the sensor is fetching new readings or not. Bug: 1073865 Change-Id: I99941b88722fc68163cca54e44ac6fc61a6425cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411933 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807421}
-
Reda Tawfik authored
This CL adds favicons to each credential row int the bottom sheet or a default icon if no icon is available for a site. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c14 Bug: 1104132 Change-Id: I44c6486a4534498107404c3ee3906ae7e6306ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396238Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#807420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97fd79e5180b..588efd970283 2020-09-16 changhaohan@chromium.org TypeScriptify elements/DOMLinkifier.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0829d5cc93d71ead5dfc2bdbcceda175e4e7253f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807419}
-
Benoit Lize authored
From the dev/beta/stable experiments, this reduces memory by multiple MiB per renderer @95th percentile, with larger savings on popular websites (7MiB on Facebook at the median on desktop, for instance). Enable it by default. Bug: 1029320 Change-Id: Iaa355d50f80617b2a8eb763984761a5cc3d5aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410041Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d48ef5f7ddc8..5e931ebb24fb 2020-09-16 fmayer@google.com Merge "Clarify experimental_flamegraph example." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia2a4817d247c53d545a25864c2620c4afaff8b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413787Reviewed-by:
-
Danil Chapovalov authored
This is a temporary solution. pending on help from abseil team to resolve this SI properly As side effect it disables absl's stack traces for mac. Bug: 1127002 Change-Id: I7be2c1d15af50ba50c7a9df2d56ae00939c4aa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409693Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#807416}
-
Adlai Holler authored
We already have the GrDirectContext available, so just use that. Change-Id: I49436e7a8fefc0cc3bdd9e6425bd730c4a897e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410539 Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#807415}
-
Changhao Han authored
Frontend CL: https://crrev.com/c/2410229 Bug: chromium:1047356 Change-Id: Id1c4e2bbb00ab1edda81f8f95d9c9cb7705c206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410069Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807414}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d3a0f602852..5453e7b7795f 2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1960f3b2 to e4cbd27e (817 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I64d469b86a8b365c36a475b71b88180c58696544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413403Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5416f18adfa6e7f14452094ec3b6c2ef9791a48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413553Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807412}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deacaf80c273..0f21b6caecea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rhalavati@google.com Change-Id: I8384f8a883daeaf328d4ba74621ed79b6fab8244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807411}
-
Yutaka Hirano authored
Expose WebTransport interface so that we can use the interface for various protocols such as QUIC and HTTP/3. We keep QuicTransport for some time to make the transition easier. https://github.com/WICG/web-transport/issues/129 Bug: 1123413 Change-Id: I8a6cc835fa0ae44804b5cb21bf6e5553c371334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386692 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807410}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I56926c9c55c099b654b66a5d3e47274d8cccee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413405Reviewed-by:
-
Satoshi Niwa authored
The search query will be used to perform a search in the selected folder at Files app start up. This is required for DocumentsUI CTS (See go/arc-r-documents-ui) TEST=unit_tests --gtest_filter="FileManagerUrlUtilTest.* Bug: 1126742 Change-Id: I298100e70cea260c8c89acead13d63a152e4ca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402926Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#807408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e500174f4bb..2595f13f7e0c 2020-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia727531ae1eda80117153015ce7e280cc5af89d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413404Reviewed-by:
-
Milica Selakovic authored
Automated password change fails if it is started with empty username. Without username flow cannot pass login stage. Bug: 1128880 Change-Id: I5a934f3fbf1ca0f992bae23afcd0717deca6decc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413262Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#807406}
-
Rune Lillesveen authored
AttachContext.force_legacy_layout was not initialized for slot elements when attaching for assigned flat tree children. We did not fall back to legacy layout for children of a slot styled as a multicol container. Bug: 1127874 Change-Id: I092ce2bb6f1af6a0af67c47d692f8f41284eedb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410487 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807405}
-
Swapnil authored
ForceInstalledMetrics::ReportMetrics is a large method and it would be good to break it down into smaller sub-methods. This CL adds new methods to report error codes for force installed extensions when the failure reason is either MANIFEST_FETCH_FAILED or CRX_FETCH_FAILED. Bug: 1127851 Change-Id: I4e3d0ac6c393a4f1af14a5979c80f08641159ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409960Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#807404}
-
Alex Rudenko authored
Re-enables the test and fixes it to account for async rendering of the styles panel. Bug: chromium:1075869 Change-Id: Ia148e6dc7e99a29fd14df22ea3f80253bdd10827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412731 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I94f292cadd364a941585809da4fa7855557141da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412981Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807402}
-
Denis Kuznetsov authored
Bug: 1024092 Change-Id: I76cf85b16b2d3bc65445dd8559357529f0798011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404453Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#807401}
-
Hiroki Sato authored
This change exposes the docked magnifier preferences via chrome.accessibilityFeatures API. Bug: 1125420 Test: browser_test AccessibilityFeaturesApiTest Change-Id: I327c987d52c02ba08455716b213a31a1ba45eb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402924 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807400}
-
Andrei-Laurențiu Olteanu authored
Reorder GetService() and OnDisconnect from diagnostics_service.h. Fix wrong service name from comment. Added DiagnosticRoutineEnum Convert to diagnostics_service_converters.h because vector Convert method uses it and needs to be the first method of the file. Reorder methods from diagnostics_service_converters.h. Bug: b:166723291 Change-Id: Iaf2d2484701393e7a9abc4ad387e2a8e4c0bece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410241 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#807399}
-
Hiroki Nakagawa authored
This CL moves the tests for prerender from core/exported/ to core/loader/ to support core/exported/ deprecation. See the following doc for details of the deprecation: https://docs.google.com/document/d/1lzGeXN4nwnANdFSpVxmJ1TUgb3QBPFCjVxLsFVBlKdE/edit?usp=sharing This CL also renames prerendering_test.cc to prerender_test.cc, and PrerenderingTest to PrerenderTest for consistency with other prerender components. Bug: n/a Change-Id: Ia1af6176b3cb2e01e5fa9f7f514801f1c352a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409431 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807398}
-
Jan Wilken Dörrie authored
This change moves the utilities base::invoke, base::identity and several type traits used in the implementation for base::ranges from base/ranges to base/stl_util.h and base/template_util.h, so that they can be more easily consumed by other code. Bug: 1071094 Change-Id: I8e2bacd5e8b83f1b374b4e6db118c37af5db7c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404854 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807397}
-
Hiroki Nakagawa authored
For code simplification, this CL replaces WebPrerenderRelType with mojom::PrerenderRelType. Before this change, WebPrerenderRelType was represented as bit-field. This is because it was allowed to specify both "prerender"[1] and "next"[2] types at the same time in the link rel attribute like <link rel="prefetch next">. However, in that case, "prerender" is just prioritized[3], so it was unnecessary to keep both the types in the bit-field. Therefore this CL introduces the mojom::PrerenderRelType as enum instead of bit-field. This would make code simpler and more readable. [1] https://html.spec.whatwg.org/C/#link-type-prerender [2] https://html.spec.whatwg.org/C/#link-type-next [3] https://source.chromium.org/chromium/chromium/src/+/master:components/prerender/browser/prerender_manager.cc;l=177;drc=ee49bcdf8e3a7764fa22b8e9d1ec1d0c9332870f Bug: n/a Change-Id: Ida2957a659c7578930bdeac136c72ebc8cacb8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409890Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
