- 26 Sep, 2017 40 commits
-
-
Yuwei Huang authored
When a connection is closed by the host, ChromotingClient will first get the notification on network thread, then free the connection object and notify UI components on the UI thread. In some rare situations, a mouse event may be posted to the network thread after the connection is reset and before ChromotingSession starts cleaning up resources, and causes segfault because the input_stub is already freed by the connection. This CL fixes this problem by immediately resetting the input_stub when the connection is being reset. Bug: 766698 Change-Id: I95d230565154dfe3762b9de516f5fa02dabb2bba Reviewed-on: https://chromium-review.googlesource.com/683801Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#504443}
-
Corentin Wallez authored
BUG=angleproject:2137 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e50aab356858f84c6d198dc8dc387eed5998480 Reviewed-on: https://chromium-review.googlesource.com/685035Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504442}
-
Nate Fischer authored
Previously, WebView would explicitly post onPageStarted for loadDataWithBaseUrl, since this navigation was handled by blink and it did not generate the event. With browser-side navigation (PlzNavigate), this is no longer the case and the navigation code will post this event under the normal pipeline. For this reason, we need to disable the extra postOnPageStarted when browser-side is turned on. As part of the implementation, this adds a Java wrapper around IsBrowserSideNavigationEnabled. This also modifies an integration test to check that we only get onPageStarted called once. Bug: 702785 Test: run_webview_instrumentation_test_apk -f LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted Change-Id: I3abc7b3503feee26e5b2438f9b039be30750e4ef Reviewed-on: https://chromium-review.googlesource.com/683634Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504441}
-
Michael Giuffrida authored
This reverts commit be622beb. Reason for revert: Breaks PDFToPWGRasterBrowserTest.TestSuccess Bug: 768938 Original change's description: > Roll src/third_party/freetype/src/ 6f2b6f8f7..02e80da60 (1 commit) > > https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6f2b6f8f72ff..02e80da6090c > > $ git log 6f2b6f8f7..02e80da60 --date=short --no-merges --format='%ad %ae %s' > 2017-09-24 apodtele Tweak per-face LCD filtering controls. > > Created with: > roll-dep src/third_party/freetype/src > R=bungeman@chromium.org,drott@chromium.org > > Change-Id: Ief384669998d1994f574fdf86229a05ec16f6426 > Reviewed-on: https://chromium-review.googlesource.com/682176 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Ben Wagner <bungeman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504362} TBR=bungeman@chromium.org,drott@chromium.org Change-Id: I5d8d33e6800dd282538a066bc0109620f8e36521 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/685397Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504440}
-
Francois Doray authored
WorkerPool is being deprecated in favor of TaskScheduler. NSS functions may reenter //net via extension hooks. If the reentered code needs to synchronously wait for a task to run but the thread pool in which that task must run doesn't have enough threads to schedule it, a deadlock occurs. To prevent that, calls to NSS functions are made within the scope of a MAY_BLOCK base::ScopedBlockingCall which increments the thread pool capacity after a short timeout. Bug: 659191 Change-Id: I2a2719f7c104f1ecf8cac7e4019836920c777261 Reviewed-on: https://chromium-review.googlesource.com/648328 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504439}
-
wutao authored
We want a mechanism to defer ui::Layer painting during animation. There are two benefits. First, we will not do layer compositing and rasterization at the same time. Second, we can cache the render surface of the animating layer. In deferred paint mode, the |damaged_region_| in SchedulePaint() will be accumulated and drawn after the deferred paint request is removed. Changes: 1. Added APIs of [Add|Remove]DeferredPaintRequest(). 2. Modified SchedulePaint() and SendDamagedRects() to defer painting. Bug: 761109 Test: linux build and device. Change-Id: I7d9710b7a6e758b6a70550d62e9cbce64333ee6b Reviewed-on: https://chromium-review.googlesource.com/646906 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504438}
-
Andrew Grieve authored
Downstream rename is now complete. Bug: 731186 Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9 Reviewed-on: https://chromium-review.googlesource.com/684956Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#504437}
-
Vladimir Levin authored
This patch does the following: - Moves the decode implementation to ImageLoader - Adds the decode functionality to SVGImageElement - Reworks the decode functionality to use microtasks to align with the proposed spec changes: https://github.com/whatwg/html/pull/2965 This patch also cleans up some tests and adds <picture> tests. R=fs@opera.com, domenic@chromium.org Bug: 705669 Change-Id: I736f44c59cc173bda9f89000eaea309ddfbbeb85 Reviewed-on: https://chromium-review.googlesource.com/665381 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#504436}
-
kylechar authored
Add WrapRefCounted() which is a better named version of make_scoped_refptr(). The new name matches the MakeUnique/WrapUnique convention already established. Update a subset of callsites to use the WrapRefCounted() or MakeRefCounted<T>() if possible. Other callsites will be updated in a followup CL and make_scoped_refptr will be deleted. Bug: 765333 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea443d3d60f7b158b4bbbc0f43f5c3b4fad1c079 Reviewed-on: https://chromium-review.googlesource.com/684557 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504435}
-
rbpotter authored
onPrivetCapabilitiesSet_ expects to always get an array back from parsePrivetDestination, even if it only contains 1 element. Change this to work with the new changes from https://chromium-review.googlesource.com/c/chromium/src/+/666183, which allow parsePrivetDestination to return a destination if there is only 1 destination obtained. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e3dc4a1d0606d08cbce29b1839b13a6445cc6e7 Reviewed-on: https://chromium-review.googlesource.com/683301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#504434}
-
Biao She authored
Bug: None Change-Id: I17162ce72e6047e0d26613fad6a041703e8f2698 Reviewed-on: https://chromium-review.googlesource.com/684699Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#504433}
-
Niranjan Kumar authored
File containing previous chrome logs is /var/log/chrome/chrome.PREVIOUS If log upload happens soon after log rotation, then we are left with a very small amount of Chrome logs available in the CPanel Admin Console. Similar to this CL: codereview.chromium.org/1394243004 BUG=b:65739107 CPanel to verify that chrome.PREVIOUS was uploaded. TEST: Deployed Chrome to device, waited for a log upload, and checked Change-Id: I06d7ee8e4d01f006f0d29ceaea0138e9758d06cc Reviewed-on: https://chromium-review.googlesource.com/680536Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Niranjan Kumar <kumarniranjan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504432}
-
Yash Malik authored
This CL adds a new type of transient element that is visible for at least a minimum and at most a maximum duration. It also refactors constants from UiSceneManager so they could be used in tests. Bug: 768598 Change-Id: I6da7c6c25c106c404914aa26abadb3bc14567171 Reviewed-on: https://chromium-review.googlesource.com/683300 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504431}
-
Nick Carter authored
ReplaceChars and RemoveChars can actually be implemented in terms of the algorithm used for ReplaceSubstringsAfterOffset(), which is already finely tuned to do this operation in linear time. The only difference is to swap out which find function is used, which is accomplished here by a boolean parameter. Bug: 756585 Bug: 760330 Change-Id: I780dc996e360b75dc8845af90cfc7e2afed2cd6d Reviewed-on: https://chromium-review.googlesource.com/642357 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#504430}
-
Jenny Zhang authored
Bug: 767245 Change-Id: I059d4e783510b9dd3b5db5e8cfd7312e9cd43146 Reviewed-on: https://chromium-review.googlesource.com/679934Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504429}
-
Chris Mumford authored
backup_table_extension stopped being used in c006a0ae. Also fixed a signed/unsigned warning. Bug: None Change-Id: I7407cfd7546da9f40389075c1eea1bcfdd94d8bc Reviewed-on: https://chromium-review.googlesource.com/683076Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#504428}
-
Peter E Conn authored
When the user triggers a fetch through the more button, if the fetch fails, display a Snackbar. Ideally in the future we can offer the user information specific to how it failed and actions to remedy it. Bug: 663376, 765603 Change-Id: I12fb27631454fb015803ae4a24a3d69c0a13357c Reviewed-on: https://chromium-review.googlesource.com/671269Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504427}
-
Marijn Kruisselbrink authored
We might want to stop supporting this, so see how common the behavior is. Bug: https://github.com/w3c/FileAPI/issues/79 Change-Id: Ia01150c0288cad4efc155a780693077f4413c019 Reviewed-on: https://chromium-review.googlesource.com/683334Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#504426}
-
Lutz Justen authored
Example needs to be double escaped. & should be &. BUG=chromium:768305 TEST=Loaded in Chrome, Mac & is escaped properly Change-Id: I7fc2709b2ef230488a09b4289d06735e7d8fbddb Reviewed-on: https://chromium-review.googlesource.com/685074Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#504425}
-
Klaus Weidner authored
During presentation, the normal compositor VSync loop which usually provides VSync markers for event logs is disabled. Since these are useful for debugging timing, synthesize them in our OnVSync. Bug: Change-Id: Id87d337859a1fdf028d8ba01a76a10d3cfabcf8a Reviewed-on: https://chromium-review.googlesource.com/679776Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504424}
-
Karl Schimpf authored
Modify ArrayBufferContents::ReserveRegion() to only reserve memory on both posix and windows. Previous code would only reserve on posix, and would do both reserve and commit on windows. Bug: v8:6743 Change-Id: If61e3ecc5edb7082ca13845121bba4c602e537c7 Reviewed-on: https://chromium-review.googlesource.com/682759Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#504423}
-
Lucas Furukawa Gadani authored
Bug: 655753 Change-Id: If5466905c2dcb876ae6374f683c2f8ad29fe5859 Reviewed-on: https://chromium-review.googlesource.com/680158Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504422}
-
MinChen authored
Bug: 766904 Change-Id: I06be2da65f7072e782cd1ba30824f6a9497572eb Reviewed-on: https://chromium-review.googlesource.com/678258Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#504421}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a7caeb529121..15dffdf6bd8d $ git log a7caeb529..15dffdf6b --date=short --no-merges --format='%ad %ae %s' 2017-09-26 dsinclair Remove fx_text_int.h 2017-09-26 dsinclair Remove font default params Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I8b2ec63ed7274f6f03235ab6abcb46360afff32a Reviewed-on: https://chromium-review.googlesource.com/684957 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504420}
-
Vladislav Kaznacheev authored
This should prevent metalayer triggering when a user is writing/sketching while accidentally holding down the stylus button. Bug: 767440 Test: ash_unittests --gtest_filter=PaletteTrayTest* Change-Id: I98a1dc4be2bb888c6cc06e3e93a60b73b56c6a8d Reviewed-on: https://chromium-review.googlesource.com/683254 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#504419}
-
Thanh Pham authored
the bottom left of and non-overlapping with a hovered UIElement. In Chrome UI Devtools, users enter the inspection mode and pin an element by left-clicking on a window/widget or view on the Chrome UI. When user moves the cursor outside of the current UIElement, if the pinned UIElement is at the bottom left of and doesn't overlap with the hovered UIElement rectangle, the layout will display horizontal and vertical distances between the pinned UIElement and the UIElement under cursor as shown in picture below. This case refers to R1_BOTTOM_FULL_LEFT_R2. Bug: 750096 Change-Id: Ibdfed83e240f85e5557bb32c52b5f7168f493205 Reviewed-on: https://chromium-review.googlesource.com/591770Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thanh Pham <thanhph@chromium.org> Cr-Commit-Position: refs/heads/master@{#504418}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f6f7cf60985d..90f28ec3da53 $ git log f6f7cf609..90f28ec3d --date=short --no-merges --format='%ad %ae %s' 2017-09-25 egdaniel Add some asserts and explict setting of fIsMipMapped 2017-09-25 benjaminwagner Specify more specific CPU dimensions. 2017-09-26 reed Revert "Revert "migrate to sk_sp for SkFontMgr API"" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6b3cb56ecbfa52b476a14ee5e4d42c556c8e0d0a Reviewed-on: https://chromium-review.googlesource.com/684955Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504417}
-
Mark Mentovai authored
This broke in 223326c1. Bug: 763398, 768630 Change-Id: Ie5e7eb7a7d3ea01a30b8a262db22931c2ed7d4d9 Reviewed-on: https://chromium-review.googlesource.com/684616Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#504416}
-
Chris Mumford authored
Bug: None Change-Id: I2c9ec29d8559ad1afb61fddafbf27af320b4f8e5 Reviewed-on: https://chromium-review.googlesource.com/683003Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#504415}
-
Reza.Zakerinasab authored
In chromium-review.googlesource.com/670519 SkImage objects without color space info are tagged as sRGB by drawin the image onto a sRGB canvas. This is not needed anymore as makeColorSpace() assumes the no-color-space images as sRGB. Bug: 754713, 740197, 767275 Change-Id: Ic6a9461919bf49d3bf316d93ca6a5e10bc6f3d7c Reviewed-on: https://chromium-review.googlesource.com/672023Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#504414}
-
Brett Wilson authored
Plumbs the oilpan hooks to the out-of-process memory allocation log. Change two loops in ChromeContentRendererClient to use C++11. Bug: 763173 Change-Id: I7fc2b27fcc84c6f1298130096e584936042b9763 Reviewed-on: https://chromium-review.googlesource.com/671418Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504413}
-
dpapad authored
This is in preparation of completely removing paper-toolbar from third_party/polymer. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idf8a0733f751f1e3cd2269682ed9bbf5856cc149 Reviewed-on: https://chromium-review.googlesource.com/683297Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#504412}
-
Michael Thiessen authored
Bug: 767589 Change-Id: If3127d75eb4b7645979e478c0e5ce82916a27feb Reviewed-on: https://chromium-review.googlesource.com/677958 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#504411}
-
Ben Wagner authored
Before this change setting use_system_freetype = true use_system_harfbuzz = false will cause Chromium to crash due to the built-in HarfBuzz pulling in the small bootstrap FreeType. This small bootstrap FreeType will then be used for calls it exports, but other calls would go to the system FreeType, creating a very confused state. This change causes the built-in HarfBuzz to build against the system FreeType instead of the bootstrap FreeType when use_system_freetype is true. BUG=http://lists.gnu.org/archive/html/freetype-devel/2017-09/msg00125.html Change-Id: Iba11baf834df43b290b7b81fcdff36c502d0ee76 Reviewed-on: https://chromium-review.googlesource.com/684975Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504410}
-
danakj authored
ReleaseCallbacks aren't part of CompositorFrames, they are for resource management in-process, so move them to resources/. CopyOutputRequests can be in a CompositorFrame atm, but also go to frame sinks in other ways too, so move them up a level to frame_sinks, along with the CopyOutputResults which are not part of a CompositorFrame at all. TBR=jam NOTRY=true Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iab8d8268b13d8eb81568dbf4a0222135c4a12d57 Reviewed-on: https://chromium-review.googlesource.com/682760 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#504409}
-
Sergey Ulanov authored
The script stopped working with more recent versions of Fuchsia. packages/gn/gen.py now expects full path for --modules argument. Updated the script to pass full path for packages/gn/sdk. Change-Id: I32c511cae73075a7b37c26035e8bea764605a332 Reviewed-on: https://chromium-review.googlesource.com/683342Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504408}
-
Nicolas Dossou-gbete authored
Preview: https://photos.app.goo.gl/2NJzRQ31Js9ltKeC3 Bug: 762932 Change-Id: I47d47928cf4f1708bfc1ea96689e81362e166ca8 Reviewed-on: https://chromium-review.googlesource.com/664578Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504407}
-
Rouslan Solomakhin authored
Before this patch, calling PaymentRequest.show() would bring the background window to the foreground, which allows a page to open a pop-under. This patch adds a check for the browser window being active (in foreground) in PaymentRequest.show(). If the window is not active (in background), then PaymentRequest.show() promise is rejected with "AbortError: User cancelled request." No UI is shown in that case. After this patch, calling PaymentRequest.show() does not bring the background window to the foreground, thus preventing opening a pop-under. Bug: 768230 Change-Id: I2b90f9086ceca5ed7b7bdf8045e44d7e99d566d0 Reviewed-on: https://chromium-review.googlesource.com/681843Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504406}
-
John Abd-El-Malek authored
http/tests/devtools/service-workers/service-workers-navigation-preload.html was failing and now it's crashing. TBR=yzshen@chromium.org NOTRY=true Change-Id: I46478782f0be345957d06f89d19365876fae9fbb Reviewed-on: https://chromium-review.googlesource.com/685294Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#504405}
-
Jiaquan He authored
- This reverts commit 2f873e14, "cros:Enable PlaystoreSearch and AnswerCards by Default on Eve Only". - Full-screen is already ON, blur is ON on selected devices. Enabling for Answer Cards and Play Store app searching. This will be landed when prod server is 100%. Bug: 766784 Change-Id: Ie4c685a82c6e6f2e89ec082480f33e4ecc57039f Reviewed-on: https://chromium-review.googlesource.com/678735Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Vadim Tryshev <vadimt@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#504404}
-