GitLab

A couple of places in our code-based were hand-written to check for
whether the code was running on Android O, before we added support
for this through BuildInfo#isAtLeastO().

This CL makes them both call the generic method, so if that
generic method is changed, they will both benefit from that.

BUG=704209

Change-Id: I44b583af0744a67c889ef786eef7e6a96ddf8eed
Reviewed-on: https://chromium-review.googlesource.com/488129Reviewed-by: Dan Alcantara <dfalcantara@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467585}

Note that this only changes the one overload that matches the semantics
of std::basic_string<T>::replace(): STL doesn't provide an overload to
find a pattern and replace that pattern.

Bug: 709815
Change-Id: If1ef5a6233fd39d02f76cadb1e5d18d9d6905831
Reviewed-on: https://chromium-review.googlesource.com/487902Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467584}

TBR=yzshen@chromium.org

Bug: 709815
Change-Id: Ic2967caa96c4a42782766541472494aa27bc6179
Reviewed-on: https://chromium-review.googlesource.com/488170
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467583}

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}

There were two issues preventing focus from working correctly:
. In ash there is a single FocusClient used. FocusSynchronizer didn't
  work well with this, and as a result never told mus about focus
  changes.
. Mushrome mode was never configuring activation parents in mus. This
  meant even once the previous item was fixed mus would ignore the
  focus request. The fix is to move configuration of activation
  parents to the right place.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2843193002
Cr-Commit-Position: refs/heads/master@{#467581}

There's a race where we could receive a new click event before receving
notification of a remote frame becoming focused as a result of advancing
(using the tab key for example) to that frame.

If we already think we're focused we would never reply back to the
browser to refocus this frame.

BUG=713977
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2844563002
Cr-Commit-Position: refs/heads/master@{#467580}

Revert of [tools/perf] Disable browse:chrome:newtab (patchset #1 id:1 of https://codereview.chromium.org/2827623002/ )

Reason for revert:
The issue with InputText was fixed in crrev.com/2822573002

Original issue's description:
> [tools/perf] Disable browse:chrome:newtab
>
> Story is failing on android bots.
>
> TBR=nednguyen@google.com,ssid@chromium.org
> BUG=712590
>
> Review-Url: https://codereview.chromium.org/2827623002
> Cr-Commit-Position: refs/heads/master@{#465199}
> Committed: https://chromium.googlesource.com/chromium/src/+/6a10d876438a19c51bf3d73d7f4484255718a5a2

TBR=nednguyen@google.com,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=712590

Review-Url: https://codereview.chromium.org/2844883004
Cr-Commit-Position: refs/heads/master@{#467579}

Element rolls:
  paper-icon-button: 1.1.2 -> 1.1.6
  paper-menu: 1.2.2 -> 1.3.0
  paper-radio-button: 1.3.3 -> 1.4.0

Targeted PRs:
  https://github.com/PolymerElements/paper-icon-button/pull/111
  https://github.com/PolymerElements/paper-menu/pull/107
  https://github.com/PolymerElements/paper-radio-button/pull/119

R=sammiequon@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839293002
Cr-Commit-Position: refs/heads/master@{#467578}

BUG=684680
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2840333004
Cr-Commit-Position: refs/heads/master@{#467577}

This CL adds a temporary solution to make the active user's pref
service available in *ash.

BUG=713934

Review-Url: https://codereview.chromium.org/2827193004
Cr-Commit-Position: refs/heads/master@{#467576}

Review-Url: https://codereview.chromium.org/2818103002
Cr-Commit-Position: refs/heads/master@{#467575}

This CL tweaks the MB configs so that any builder that is using goma
also sets strip_absolute_paths_from_debug_symbols_by_default=true.
This helps ensure that we get the best goma cache hit rate possible.
We don't just make the default equal to use_goma=true because doing
so may make it harder for devs to debug binaries, and we want devs
to be able to both debug binaries and use goma by default; the
tradeoff is that their builds are slightly slower.

R=thakis@chromium.org, jochen@chromium.org
BUG=603286, 712790

Review-Url: https://codereview.chromium.org/2837863005
Cr-Commit-Position: refs/heads/master@{#467574}

For example, chrome/common/renderer_configuration.mojom defines:

interface RendererConfiguration {
  SetInitialConfiguration(etc);
  SetContentSettingRules(etc);
  SetFieldTrialGroup(etc);
};

The generated IDs in
gen/chrome/common/renderer_configuration.mojom-shared-internal.h, prior
to this CL, and also after this CL with an empty seed, are:

constexpr uint32_t kRendererConfiguration_SetInitialConfiguration_Name = 0;
constexpr uint32_t kRendererConfiguration_SetContentSettingRules_Name = 1;
constexpr uint32_t kRendererConfiguration_SetFieldTrialGroup_Name = 2;

After this CL, with a "foo" seed, the IDs are:

constexpr uint32_t kRendererConfiguration_SetInitialConfiguration_Name = 1257880741;
constexpr uint32_t kRendererConfiguration_SetContentSettingRules_Name = 631133653;
constexpr uint32_t kRendererConfiguration_SetFieldTrialGroup_Name = 549336076;

BUG=673417

Review-Url: https://codereview.chromium.org/2794743002
Cr-Commit-Position: refs/heads/master@{#467573}

Set kShowStateKey property from init params show_state so that
mus window is created properly.

BUG=714804
TEST=DesktopWindowTreeHostMusTest.CreateFullscreenWidget

Review-Url: https://codereview.chromium.org/2840903002
Cr-Commit-Position: refs/heads/master@{#467572}

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381

Review-Url: https://codereview.chromium.org/2842303002
Cr-Commit-Position: refs/heads/master@{#467571}

BUG=703403
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2846623002
Cr-Commit-Position: refs/heads/master@{#467570}

The test case fractional-scroll-offset-fixed-position-non-composited.html
is passing, so removing it from TestExpectations

BUG=417782

Review-Url: https://codereview.chromium.org/2839193002
Cr-Commit-Position: refs/heads/master@{#467569}

Revert of printing::Metafile:  Simplify OS_MACOSX-specific code path (patchset #3 id:40001 of https://codereview.chromium.org/2802093006/ )

Reason for revert:
Likely causing https://crbug.com/712309

Original issue's description:
> printing::Metafile:  Simplify OS_MACOSX-specific code path
>
>   - printing::Metafile
>       * move MacRenderPageParams to PdfMetafileCg
>       * remove virtual RenderPage()
>   - printing::PdfMetafileCg
>       * Add MacRenderPageParams
>       * RenderPage no longer an override
>   - printing::PdfMetafileSkia
>       * no longer implment RenderPage()
>       * code moved to printing::PrintedDocument::RenderPrintedPage()
>
> This will help isolate BUG=chromium:374359
>
> R=thestig@chromium.org
>
> Review-Url: https://codereview.chromium.org/2802093006
> Cr-Commit-Position: refs/heads/master@{#463828}
> Committed: https://chromium.googlesource.com/chromium/src/+/c843c89f3051e4b01cf032e52c478000f7ded0ee

TBR=halcanary@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2839323002
Cr-Commit-Position: refs/heads/master@{#467568}

This CL removes the bookmarks-sidebar element in and replaces it with
a root bookmarks-folder-node. This serves to specify the recursive nature
of the sidebar, and will allow for neater recursive behaviors such as
keyboard navigation.

BUG=692844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823053003
Cr-Commit-Position: refs/heads/master@{#467567}

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2840393002
Cr-Commit-Position: refs/heads/master@{#467566}

Remove media-remoting-encrypted flag since encrypted contents are not
supported by media remoting for now.

BUG=715853

Review-Url: https://codereview.chromium.org/2843263002
Cr-Commit-Position: refs/heads/master@{#467565}

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2838343003
Cr-Commit-Position: refs/heads/master@{#467564}

This CL:
* Removes the dependency on gdbus from NPBL and uses //src/dbus instead
* Handle notifications asynchronously on a dedicated task runner
* Modify NativeNotificationDisplayService to allow async initialization
  of the NotificationPlatformBridge (only on Linux)

BUG=676220
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2821533003
Cr-Commit-Position: refs/heads/master@{#467563}

The cast executables set RPATH. If shared_libraries set RUNPATH, this
can causes issues since the RUNPATH in the shard_lib suppresses the RPATH from
the parent executable, but libraries are placed such that the parent
binary RPATH will find them.

If RUNPATH/RPATH are not set on the shared_libraries, then the parent
RPATH gets used correctly.

BUG=internal b/37514052
TEST=build libcast_media_1.0.so
readelf -a libcast_media_1.0.so | grep PATH
RUNPATh and RPATH are not set

Change-Id: I3866ddd84ced393a3926b023160298054d9a4adb
Reviewed-on: https://chromium-review.googlesource.com/487827Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467562}

This patch generates the following fields as part of a group:
- background ('storage_only' of type FillLayer)
- background_color ('storage_only' of type Color)

Since both fields correspond to shorthands, we specify them in
ComputedStyleExtraFields.json5.

Diff of generated files:
https://gist.github.com/darrnshn/48a62d4ef7efe9f7a8c2b707eb57644f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2841433002
Cr-Commit-Position: refs/heads/master@{#467561}

CWVScrollView.

BUG=714543

Review-Url: https://codereview.chromium.org/2840013004
Cr-Commit-Position: refs/heads/master@{#467560}

Cr-Commit-Position: refs/heads/master@{#467559}

This is a preparation of collapsed border optimization
(https://codereview.chromium.org/2805103003/)
and bug fixing (later).

BUG=626748

Review-Url: https://codereview.chromium.org/2840903003
Cr-Commit-Position: refs/heads/master@{#467558}

Combine the base class and only remaining subclass. Simplify:
-Remove some unnecessary accessors for the subclass.
-Merge constructors, destructors, Init/OnInit, OnAppImageUpdated.
-Make some CLC base classes and functions private.
-Remove unused includes.

Rename test files and classes.

BUG=557406
TEST=No functional changes; refactoring only.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2839933005
Cr-Commit-Position: refs/heads/master@{#467557}

Revert of HttpCache::Transaction layer allowing parallel validation (patchset #33 id:800001 of https://codereview.chromium.org/2721933002/ )

Reason for revert:
Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/4271

Original issue's description:
> This CL is a precursor to allowing shared writing to fix cache lock.
>
> This CL allows transactions to continue to their validation phase even when another
> transaction is the active reader/writer. After the validation phase, if its a match
> the transaction might wait till the response is written to the cache by the active
> writer. If its not a match the transaction will doom the entry and go to the
> network. In a subsequent CL, the not matching case will create a new entry as well.
>
> BUG=472740
>
> Review-Url: https://codereview.chromium.org/2721933002
> Cr-Commit-Position: refs/heads/master@{#467426}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757849f76e8a808

TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472740

Review-Url: https://codereview.chromium.org/2847653002
Cr-Commit-Position: refs/heads/master@{#467556}

This CL processes the Expect-CT header when received on HTTP
responses. TransportSecurityState parses the header and, if valid and received
on a compliant connection, stores the Expect-CT state for the current host. (If
valid but received on a non-compliant connection, the header information is not
stored but a report is sent to alert the site owner of the misconfiguration.) A
follow-up CL will check the dynamic Expect-CT state on connection setup.

BUG=679012

Review-Url: https://codereview.chromium.org/2774763005
Cr-Commit-Position: refs/heads/master@{#467555}

DirtyStackingContextZOrderLists may try to call LayoutView::Compositor(),
which may be invalid during such times. In any case, DirtyStackingContextZOrderLists
is irrelevant during document shutdown.

BUG=715736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2840403002
Cr-Commit-Position: refs/heads/master@{#467554}

This is the equivalent of http://crrev.com/2835403002 for the Mac-specific
scrollbar opacity plumbing.

BUG=606395

Review-Url: https://codereview.chromium.org/2838513003
Cr-Commit-Position: refs/heads/master@{#467553}

Update the filter for mus_browser_tests used on Mojo FYI bots with more tests
that pass locally.

TBR=sky@chromium.org
TEST=mus_browser_tests
BUG=705716

Review-Url: https://codereview.chromium.org/2844853002
Cr-Commit-Position: refs/heads/master@{#467552}

This test was previously disabled without comment or explanation on all platforms.
It was fixed for non mac platforms but needs to remain disabled on Mac.

TBR=sky@chromium.org
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2843313002
Cr-Commit-Position: refs/heads/master@{#467551}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d4e9c7fe..822954dd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2841303002
Cr-Commit-Position: refs/heads/master@{#467550}

Based on step 3 of yosin's plan:
https://codereview.chromium.org/2812423002#msg7

This CL does the following:

- Introduces a DocumentMarkerList interface

- Introduces GenericDocumentMarkerListImpl, an implementation
  of DocumentMarkerList that works for all marker types and is implemented on top
  of DocumentMarkerListEditor

- Refactors DocumentMarkerController to use GenericDocumentMarkerListImpl instead
  of using DocumentMarkerListEditor directly

BUG=707867

Review-Url: https://codereview.chromium.org/2820633002
Cr-Commit-Position: refs/heads/master@{#467549}

Rename NodeLayoutData -> NodeRenderingData as it captures the idea
behind the object better.

See here for discussion: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/style-dev/iLGP_mMZdjE/w5K1t2NCBQAJ

BUG=595137

Review-Url: https://codereview.chromium.org/2830583002
Cr-Commit-Position: refs/heads/master@{#467548}

This ensures proper capability check. This is also the last domain
without proper model.

BUG=none

Review-Url: https://codereview.chromium.org/2843763004
Cr-Commit-Position: refs/heads/master@{#467547}

TBR=yzshen@chromium.org

Bug: 709815
Change-Id: Ia33e5034d373e773f4c0db6aa65aa5ef1d161110
Reviewed-on: https://chromium-review.googlesource.com/487604
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467546}