GitLab

This reverts commit 9f8158c1.

Reason for revert: Culprit of failed VR tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6884

Original change's description:
> VR: Ensure we remove black overlay if VR is exited while entering.
> 
> This fixes a failure mode where we shutdownVR after handling the VR NFC
> broadcast, and fail to properly cancel VR entry.
> 
> Also does some other random cleanup of comments/visibility.
> 
> Bug: 862829
> Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b
> Reviewed-on: https://chromium-review.googlesource.com/1138726
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575388}

TBR=mthiesse@chromium.org,tiborg@chromium.org

Change-Id: Ibe67ee8c09dc44ac34d40c3eaf890884b400fc24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862829
Reviewed-on: https://chromium-review.googlesource.com/1140813Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575725}

We could run NGFlexLayoutAlgorithm for nodes that weren't
LayoutNGFlexibleBox when they had display:flex. We'd been assuming that
all display:flex elements would get a LayoutNGFlexibleBox node, but not
so -- the <details> element always gets a BlockFlow no matter what its
display value is.

That should also probably be changed, but needs an intent to ship and
risks compat issues, so just fix the LayoutNG crash for now.

Bug: 862797
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibc42e76f9ea312b6458ca7f7798b8ca6ba69cfdd
Reviewed-on: https://chromium-review.googlesource.com/1139401
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575724}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I432045209798b3008f4a55c962873daa37fc5e06
Reviewed-on: https://chromium-review.googlesource.com/1138798Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575723}

ThreadSafeAssociatedPtr is only supposed to be used by the IPC
conversion system.  In addition, it has a tendancy to post all
calls to MediaLog::AddEvent, which can have the side-effect of
ordering them after the (Mojo)VideoDecoder is destroyed since that
happens synchronously when VideoDecoder::Initialize fails.  So, we
don't get messages that describe why the failure happened, since
MojoVideoDecoderService has torn down the binding by then.

Instead, we make MojoMediaLog thread safe, and avoid the extra post
in the process.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I50fdb27c169c4b68222aa92f46c41a9ff23b4413
Reviewed-on: https://chromium-review.googlesource.com/1139080
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575722}

In jumbo build experiments, two (identical but small)
GetActiveTextureUnit() functions ended up in the same translation
unit which caused the compiler to fail.

This patch moves the useful function into a shared utility file.

Bug: 801580
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id6f8f1002db18593150bec30f1e8b7092f464e13
Reviewed-on: https://chromium-review.googlesource.com/1136308Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#575721}

This re-lands commit a6dc11ea
which was reverted for leaking (caught by lsan bot).
Fix: unref custom cursors created in CursorData::ToNativeCursor

Go through CursorFactoryOzone to load the PlatformCursor (which
confusingly could be CursorData, but for now is X11CursorOzone). Also
set fields on the cross-platform Cursor type so that code which relies
on it such as CursorWindowController::UpdateCursorImage will work.
That code path can be exercised with --ash-enable-cursor-motion-blur
although there is currently no use of custom cursors with ws2.

TBR=sky@chromium.org, tsepez@chromium.org

Change-Id: I1d6324a6049d83850185171a42c164f7679f5a5e
Reviewed-on: https://chromium-review.googlesource.com/1120860
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575720}

Bug: 844016
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I20115592c139201348980f835bc16154f656eadf
Reviewed-on: https://chromium-review.googlesource.com/1136658Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575719}

Bug: 864458
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia2f18a1fc92a35d0a09cde3ad4f42e4c2e7936a4
Reviewed-on: https://chromium-review.googlesource.com/1140362Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575718}

Add a Layout.DisplayCutout.StateChanged UKM event that
is recorded when display cutout state changes.

BUG=825890

Change-Id: I7b134117ea847505e62f3690d0ac45ab02db8e1f
Reviewed-on: https://chromium-review.googlesource.com/1117638Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575717}

Using wpt-import in Chromium de0b602f.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21500

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor
bajones@chromium.org:
  external/wpt/gamepad
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
bokan@chromium.org:
  external/wpt/visual-viewport
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-cascade
  external/wpt/css/css-conditional
  external/wpt/css/css-namespaces
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
chongz@chromium.org:
  external/wpt/pointerlock
  external/wpt/touch-events
chongz@chromium.org, yosin@chromium.org:
  external/wpt/input-events
cvazac@akamai.com, igrigorik@chromium.org:
  external/wpt/server-timing
dcheng@chromium.org, scottmg@chromium.org:
  external/wpt/domparsing
dgrogan@chromium.org:
  external/wpt/css/css-tables
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
dtapuska@chromium.org:
  external/wpt/uievents
eae@chromium.org, szager@chromium.org:
  external/wpt/intersection-observer
ecobos@igalia.com:
  external/wpt/css/css-display
ericwilligers@chromium.org:
  external/wpt/css/motion
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
fmeawad@chromium.org, panicker@chromium.org:
  external/wpt/device-memory
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
garykac@chromium.org:
  external/wpt/clipboard-apis
  external/wpt/keyboard-map
garykac@chromium.org, joedow@chromium.org:
  external/wpt/keyboard-lock
guidou@chromium.org:
  external/wpt/mediacapture-streams
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline
igrigorik@chromium.org, yoav@yoav.ws:
  external/wpt/preload
jfernandez@igalia.com:
  external/wpt/css/css-align
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/encoding
  external/wpt/storage
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
  external/wpt/webstorage
kojii@chromium.org:
  external/wpt/css/css-rhythm
  external/wpt/css/css-scoping
  external/wpt/css/css-writing-modes
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2
kozyatinskiy@chromium.org:
  external/wpt/console
kpaulhamus@chromium.org:
  external/wpt/webauthn
ksakamoto@chromium.org:
  external/wpt/resource-timing
mcasas@chromium.org:
  external/wpt/geolocation-API
  external/wpt/mediacapture-record
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/mixed-content
  external/wpt/secure-contexts
  external/wpt/upgrade-insecure-requests
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mkwst@chromium.org, jochen@chromium.org:
  external/wpt/subresource-integrity
mlamouri@chromium.org:
  external/wpt/mediasession
  external/wpt/remote-playback
  external/wpt/screen-orientation
msisov@igalia.com:
  external/wpt/webvtt
msramek@chromium.org, mkwst@chromium.org:
  external/wpt/clear-site-data
mstensho@chromium.org:
  external/wpt/css/css-break
  external/wpt/css/css-multicol
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
ortuno@chromium.org:
  external/wpt/bluetooth
panicker@chromium.org:
  external/wpt/longtask-timing
  external/wpt/page-visibility
  external/wpt/user-timing
panicker@chromium.org, tdresser@chromium.org:
  external/wpt/paint-timing
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
rego@igalia.com:
  external/wpt/css/css-grid
  external/wpt/css/css-ui
  external/wpt/css/selectors
rijubrata.bhaumik@intel.com, mcasas@chromium.org:
  external/wpt/html-media-capture
rmcilroy@chromium.org:
  external/wpt/requestidlecallback
rob.buis@samsung.com:
  external/wpt/quirks
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-method-basic-card
  external/wpt/payment-method-id
  external/wpt/payment-request
skobes@chromium.org:
  external/wpt/css/css-scroll-anchoring
smcgruer@chromium.org:
  external/wpt/css/css-position
tdresser@chromium.org:
  external/wpt/hr-time
  external/wpt/navigation-timing
timvolodine@chromium.org:
  external/wpt/battery-status
timvolodine@chromium.org, reillyg@chromium.org:
  external/wpt/orientation-event
worker-dev@chromium.org:
  external/wpt/workers
  external/wpt/worklets
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=foolip

No-Export: true
Change-Id: I1635c3d7fa89e779585adc775200ef6bd8b55e65
Reviewed-on: https://chromium-review.googlesource.com/1140494
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575716}

The local_card_migration_manager is the manager to control the local card migration flow, which is similar to the credit_card_save_manager class. The FormDataImporter will trigger the migration when user submit a form using a local card or a server card.

If the user is signed-in and sync, and have [more than one local card when use a local card] or [at least one valid local card when use server card], migration will start to fetch legal docs. When successfully fetch the legal docs, it will pop-up first round window to ask user whether to migrate local card. If user agree, it will pop-up second window with all valid local card for upload. If user agree on the second window, we will sequentially upload valid local cards.

In this CL, we mainly solve the triggering logic for the migration. The logic is mainly in the FormDataImporter and the ShouldOfferLocalCreditCardMigration() in LocalCardMigrationManager. If the migration requirements are met, we will fetch legal docs from the server. If we successfully fetch the legal docs, we will trigger the first round pop-up window to the user. We also add experimental flag in this CL to enable/disable the migration.

For the unittest, we use a variable in the test class as an observer and it is True when successfully fetch the legal docs. We check this variable to test whether the migration is triggered or not. And we also create new constructor in the test_autofill_manager and test_form_data_importer for the new local_card_migration_manager for testing.

The triggered two-round pop-ups windows together with their callback functions will be included in the following CLs.

Bug: 852904
Change-Id: Iadd17b4e36e12bc9ef17075d0703b796d37ed334
Reviewed-on: https://chromium-review.googlesource.com/1111569
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#575715}

Before this change, there was a flash of white above every non-browser
window when entering overview mode, because the overview code was using
the kTopViewColor property to get the frame's color. That property was
only set correctly for certain browser windows (not, e.g., v1 apps)
and for some others it was set to always use the inactive frame color.

Instead, use kFrame{Active,Inactive}ColorKey which should be set for all
windows and also has a reasonable default.

Related to linked bug because it reduces the number of differences
between ash and classic browser windows.

Bug: 854704
Change-Id: Ie86223cb97509f860069895fefa1054b48080ed9
Reviewed-on: https://chromium-review.googlesource.com/1119356
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575714}

Add viz_views to an exisiting build target.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5d7b959487bf86d7b7fa940f8f0948f8e0480cdb
Reviewed-on: https://chromium-review.googlesource.com/1136870Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575713}

Changes methods in this test to use TimeTicks instead of double to
represent timestamps.

Change-Id: Ib888cd0d107e2190d7216ee0e69fea02c34ea78d
Bug: 763980
Reviewed-on: https://chromium-review.googlesource.com/1117829Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575712}

This restores the previous (non-crashing) behavior while we contemplate what
the right fix for this is.

Bug: 862282
Change-Id: Ie4fe333f7ff01224db252d2cc6f3e83922122a8d
Reviewed-on: https://chromium-review.googlesource.com/1138821Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575711}

Nvidia Shield gamepads report some buttons using usage numbers
from the Consumer usage page instead of the Button usage page
which is typical for gamepads. This CL adds logic to check for
several common usages outside the Button page and append them to
the end of the gamepad button array.

It also fixes the Xbox One S gamepad mappings to add these buttons.
The names of the mapping functions for the original firmware and
updated firmware were previously reversed; this is also fixed.

Fixed in this CL:
* [Mac/Linux] Xbox One S Guide button, original FW, Bluetooth
* [Mac/Linux] Xbox One S Guide/Back buttons, 2016 FW, Bluetooth
    (These devices are already well-supported on Windows.)
* [Mac/Win/Linux] Nvidia Shield 2015 Guide/Back/Extra buttons, USB
* [Win/Linux] Nvidia Shield 2017 mapper added, USB/Bluetooth

A mapper for Nvidia Shield 2017 was not added on Mac. The gamepad
is not recognized as a HID gamepad over USB and does not stay
connected over Bluetooth.

Note that some Consumer key codes have other meanings on some
platforms that may cause Chrome to navigate away from the current
page.

BUG=847692

Change-Id: I4edafc0507c553ebdc4daac0b5a6f1ecfeb7c1ed
Reviewed-on: https://chromium-review.googlesource.com/1091633Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575710}

It's very easy to forget checking for !db, which explains crbug.com/860228.
Now Execute does the check for us. The caller must designate a value
to be passed to the result callback in the case of db failure.

BUG: 864592

Change-Id: Ie4e1ac0bcd60e9e0c8c30413af10d44ff0175b47
Reviewed-on: https://chromium-review.googlesource.com/1140277
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575709}

Bug: 787924
Change-Id: I4da50acf43aa180cd62ea5e2210c5d54adda1dcf
Reviewed-on: https://chromium-review.googlesource.com/1140673Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575708}

Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList
Disable WindowSelectorTest.RoundedEdgeMaskVisibility

Tbr: xiyuan, xdai
Bug: 864467, 864465
Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167
Reviewed-on: https://chromium-review.googlesource.com/1140683Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575707}

This is a reland of 5cab33d1

In Patchset 2, it also makes the widget insensitive to mouse events
while animating closed.

This fixes the crash triggered when the user clicks on the results list
while the popup is animating closed. It also makes the popup no longer
change its highlighted match in response to mouseover events.

We also are insensitive to gesture events while closing, but we do not capture
them.

Original change's description:
> Omnibox UI Refresh: Implement popup open and close opacity animations.
>
> This eases in and out the Omnibox popup opacity over 82ms as it opens
> and closes. This matches the animation spec provided by UX.
>
> Bug: 823535
> Change-Id: Ic2add1f57f63ae6d043812f2bd5a766f84d302c9
> Reviewed-on: https://chromium-review.googlesource.com/1081198
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564295}

TBR=ajuma@chromium.org

Bug: 823535, 857486
Change-Id: Ie497eefd007ae30a9098be30f55f63dc51adecc3
Reviewed-on: https://chromium-review.googlesource.com/1138514
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575706}

This function initializes the login screen multiple times, which views login did
not support.

Bug: 859559
Change-Id: I57f3282b12c604074f9d34760f9804c18eee2d09
Reviewed-on: https://chromium-review.googlesource.com/1125129Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575705}

Render: https://screenshot.googleplex.com/gTB6H033JFQ

Bug: 854369
Change-Id: I0dea118fe75090aa7bd4b54b31168768777c7d93
Reviewed-on: https://chromium-review.googlesource.com/1112664
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575704}

Removing mock-vr-service.js and using xr-device-mocking instead to
reduce the amount of code duplication.

Change-Id: If44a1365da855d1b789404fd21e31c92c0bbf8f5
Reviewed-on: https://chromium-review.googlesource.com/1140283
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575703}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dcf3638e..b1e14adb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I69cb1df8fa91cfc67aca8ee70e87602be33fb5af
Reviewed-on: https://chromium-review.googlesource.com/1140137Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575702}

Change-Id: Icbc23ea507b5fe09a5bfb1d38d1f40e84c0d4e99
Reviewed-on: https://chromium-review.googlesource.com/1136980
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575701}

In virtual/layout_ng this test has been passing for a while.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng/fast/inline/styledEmptyInlinesWithBRs.html

a local bisect reveals this is the fix:
https://chromium-review.googlesource.com/1132532

Bug: 714962
Change-Id: Idbe3cf1a463596d2cc99f38360cad255af0bcdb8
Reviewed-on: https://chromium-review.googlesource.com/1140367Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575700}

external/wpt/css/css-shapes/shape-outside/values/shape-margin-001.html
external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html
have both been passing on Linux for the whole of the flakiness
dashboard history.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external/wpt/css/css-shapes/shape-outside/values/shape-margin-001.html%20external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html

Bug: 441840
Change-Id: I4a9d6c92c0d8708a010f390e949eba81d713afc3
Reviewed-on: https://chromium-review.googlesource.com/1140371Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575699}

The CL moves as much as possible from AutofillPopupViewNativeViews to
AutofillPopupBaseView (parent for the generation drop-down). At the same time
AutofillPopupViewViews implements the stuff specific for it and irrelevant for
the new views prompts. AutofillPopupViewViews is gonna be deleted soon anyway.

Bug: 851021
Change-Id: I4711c29220c841356e5a7d8adca0cd5c222c8cde
Reviewed-on: https://chromium-review.googlesource.com/1136633Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575698}

The purpose of the added test is to ensure the reliability of the feature as
well as detecting flakiness that could be caused by race conditions.

The test is marked as MANUAL_ to avoid it running on the regular commit queue
trybots.

To run the test manually on Android, increasing various timeouts is needed:
out/android_release/bin/run_content_browsertests --gtest_filter=*WebRtcImageCaptureStressBrowserTest* --test-launcher-retry-limit=0 --ui-test-action-max-timeout=60000 --shard-timeout=60
The above sets the timeout to 1 minute, which should be more than enough for 10 photos.

Bug: 857530
Change-Id: Ibf4f78d43dc3cbe24687710f48bf311f7bb0bfd4
Reviewed-on: https://chromium-review.googlesource.com/1135703
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575697}

Also added unit tests and updated TestPersonalDataManager.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic65ad3a3a6688cf0cbd8ccc75038e0a6557cde00
Reviewed-on: https://chromium-review.googlesource.com/1139090Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575696}

BUG=836871

Change-Id: If259500c8f226ff198586f56a3d711565791b488
Reviewed-on: https://chromium-review.googlesource.com/1140433
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575695}

The worker's onmessage handled needs to be wrapped in a step_func()

Change-Id: Icfbad1936d9c9bd7fbd5522ce64f667f2699ef0d
Reviewed-on: https://chromium-review.googlesource.com/1139179
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575694}

Bug: 680407,621126
Change-Id: I4be6aeb3cdce35c89abaea8ce756aba456aa36b9
Reviewed-on: https://chromium-review.googlesource.com/1138794Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575693}

Some Chrome OS services actually rely on this being OK since they don't
have the PID of the target process available. Presumably they would fail
if DCHECKs were enabled.

This removes an unnecessary DCHECK so that such code can be exercised in
chromium tests.

Bug: None
Change-Id: Id546644aae7222eaf76b9a279f0c99af0764573c
Reviewed-on: https://chromium-review.googlesource.com/1140280Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575692}

Bug: 857533
Change-Id: I9a62b52edad78b30cc25dc15f7f098ce3a82bc46
Reviewed-on: https://chromium-review.googlesource.com/1140374
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575691}

In fullscreen, when the mouse moves to the upper border of the screen, a
slide-down menu will show. When the user enables showing toolbar in
fullscreen, a native title bar will also appear. In such case, our tab
strip and toolbar should show underneath the title bar.

This CL reuses the Cocoa browser's menu and mouse tracking classes, and
implements a Views based FullscreenToolbarController to track the mouse
activities and menu progress so the top UI would show in appropriate
position.

BUG=831219

Change-Id: Ia30c9cb74819a866ae39cc3e696affb94350efbf
Reviewed-on: https://chromium-review.googlesource.com/1130001Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575690}

We decided to skip the finch trial for adding these new UMA metrics,
so remove the flag kPresentationFeedbackEveryFrame added earlier.

Bug:851088

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I63eacff9d616594d340b983a0fe373c24e790032
Reviewed-on: https://chromium-review.googlesource.com/1136069Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575689}

When the flag is on, Polymer 2 is used everywhere. When off, Polymer 1 is used.

Bug: 862472
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iefdbf6448c0c69b6f22df1a3db57db29e29607da
Reviewed-on: https://chromium-review.googlesource.com/1137706
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575688}

This is a partial reland of b035cfda

Original change's description:
> Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s.
>
> Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky,
> potentially causing unexpected early-exits if run under a different
> RunLoop to the one intended.
>
> If a caller has taken a Quit*Closure() from the RunLoop then we now
> assume that they intend to use it to quit the loop, and therefore use
> of QuitCurrent*Deprecated() with it must be unintentional.
>
> Bug: 844016
> Change-Id: Ib181d0cb34cdba2af29f557646cbe631101bc6b0
> Reviewed-on: https://chromium-review.googlesource.com/1082980
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571499}

Bug: 844016
Change-Id: I0666631fa736244c18f8848b317b41762881c748
Reviewed-on: https://chromium-review.googlesource.com/1121296Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575687}

Don't allow Explore on Content to re-show itself in response to a tap on
the toolbar button until any previously set content is fully removed
from the sheet.

Also, go directly to the hidden state when tapping on the scrim when the
peek state is disabled.

BUG=863568

Change-Id: I5f6fea7fe637b4f346542321de6716899b6bf8fc
Reviewed-on: https://chromium-review.googlesource.com/1139112Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575686}