- 16 Oct, 2019 40 commits
-
-
Ana Salazar authored
Bug: 1009413 Change-Id: I96251acc1010789d41e43b3dd1bac5b16b8698cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863856Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#706648}
-
Ken Rockot authored
Removes the mojom enum equivalent of leveldb::Status. Status is used everywhere DatabaseError was used before. Bug: 1000959 Change-Id: Ib1e957f7d7b6c6e66162ea768d591f7394d558dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863775 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706647}
-
Dan Harrington authored
The GCM handler doesn't need to create the GCM token. Splitting this interface simplifies the code. Additionally, we can now always create the gcm handler, even in reduced mode. GetGCMToken() is now a global function, and still called only after browser start. This is safer, because the handler is accessed by another keyed service. Before this CL, there was no guarantee that the gcm handler would be created before it's accessed by gcm_profile_service_factory.cc Change-Id: I27ab837f4294f450ee11dfaa9a833ba90cf3c83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690712 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#706646}
-
David Trainor authored
RoundedCornerImageView ran into a few problems exposed by omnibox usage: - ImageView#setImageResource() doesn't end up calling setImageDrawable() on some Android versions. - BitmapDrawable can apply a scale so getIntrinsicWidth/Height won't be the same as get Bitmap#getWidth/Height. This wasn't handled in this code. - Also some general code clean-up to make it easier to parse and update in the future. Bug: 1001209 Change-Id: Ib861686ce51eb019cc068e24e042aca1ae42cd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788299 Commit-Queue: Ender <ender@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#706645}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3903.0-1569840015-benchmark-79.0.3923.0-r1 to 79-3904.41-1571046112-benchmark-79.0.3940.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I302bfe26522e9cbe85acd3e2077d73998b4eb05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706644}
-
tby authored
For debugging, it will be useful to track the model weights over time to rule out any bad behaviour in the model itself. This CL VLOGs the weights each time they are changed. Note the code for this looks a little misplaced at the bottom of SearchResultRanker::Train, but that's where other metric-related code lives in a parallel CL. Bug: 1011221 Change-Id: I8a737b0f8221f7016d08c6f2f3f4e96d253ffd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864492Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706643}
-
Max Li authored
Bug: 923594 Change-Id: Id7fee971d9d52eac80a79523c9a354fd53809c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862732 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706642}
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3904.19-1569838411-benchmark-79.0.3923.0-r1 to 79-3931.2-1571054549-benchmark-79.0.3940.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I73bcebfebd035be911e59d8888636c81580e7e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865699Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 to 79-3928.0-1571049528-benchmark-79.0.3940.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Iac049fe0b473b4b6bab48aafc56dec10191f187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865698Reviewed-by:
-
Mike Dougherty authored
This test is flaky on the bots when run as part of the suite. Although unable to reproduce locally, the calls to ExecuteJavaScript were failing which points to a general test problem. Without being attached to a windowed view, WKWebView can internally suspend processes. Add the |web_view| to a windowed container to try to prevent flake. Additionally, extend the timeout for JavaScript execution because the old timeout was too short for JavaScript execution to always complete. Bug: 1013206 Change-Id: I1bd685563bc0e522647ab0402e64428fa746e430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856659Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706639}
-
John Abd-El-Malek authored
This reverts commit 6cd69069. Reason for revert: broke weblayer instrumentation tests, see https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/20184?blamelist=1#blamelist-tab Original change's description: > Persist cookies for profiles with non-null path > > Currently the cookies are not persisted because the default > implementation of ContentBrowserClient::CreateNetworkContext doesn't > specify cookie_path parameter. In this CL CreateNetworkContext is > overridden in WebLayer implementation. > > Bug: 1014048 > Change-Id: I1b7a307a64cd836eb5c4a45817412b997b89f1f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862677 > Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706390} TBR=jam@chromium.org,boliu@chromium.org,pshmakov@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014048 Change-Id: I7b302c7ea8618acd1c578b14ac9c8ed894744cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865130Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706638}
-
Hiroshige Hayashizaki authored
This CL imports post-#176 upstream reference implementation's tests into wpt/import-maps/imported/, and executes them under virtual/import-maps-without-builtin-modules/. The pre-#176 existing tests are still left under wpt/import-maps/builtin-support.tentative/imported/, which are excluded by this CL from virtual/import-maps-without-builtin-modules. To match with the expectation of post-#176 tests, this CL modifies ImportMap::ToString() to output strings (not single-element arrays) as right hand side. https://github.com/WICG/import-maps/pull/176 Bug: 990561, 1010751 Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706637}
-
Ahmed Mehfooz authored
Bug: 1002714 Change-Id: Iad2c658e651d5301353ca0db289570d1ea94530a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865650Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706636}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Id93a18c55d148eb9cf4f7fea9a53f2c4add63d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861514 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706635}
-
Chandani Shrestha authored
Keyboard accessiblity: In this change user can navigate through swatches using LEFT AND RIGHT arrow keys. Pressing ENTER or SPACEBAR selects focused color. This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down 1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344 2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875 3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873 4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Bug: 963183 Change-Id: I4877d89c49c1c1072deb2da7f6a811af7cd5c21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817344Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706634}
-
Ken Rockot authored
Eliminates use of the BatchedOperation mojom struct from LocalStorageContextMojo. Bug: 1000959 Change-Id: I09b849a3a53379735535dc7d00db19d2c745bfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863253 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#706633}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: I01c20af558317070d99313252823aef38f85338c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864460 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#706632}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f73d91573493..71a18f6f4b01 git log f73d91573493..71a18f6f4b01 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 bhamrick@google.com Merge "trace_processor: Bounds checks for reading Fuchsia record data" 2019-10-16 treehugger-gerrit@google.com Merge "Reland "processor: Move TimestampedTracePiece into its own header"" Created with: gclient setdep -r src/third_party/perfetto@71a18f6f4b01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4a561bf2f3b74d9a451b178acc112876bf0b7337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864817Reviewed-by:
-
Andrey Kosyakov authored
This is a test for regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1856929 Change-Id: I833a24ceb7b316f432033f3bf721084a708dfd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863850 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#706630}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64444bc865d2..562a37f926dd git log 64444bc865d2..562a37f926dd --date=short --no-merges --format='%ad %ae %s' 2019-10-16 danilchap@webrtc.org Increase timeout in test-only helper SendTask back to infinity 2019-10-16 phoglund@webrtc.org Remove the fileutils hack for good. Created with: gclient setdep -r src/third_party/webrtc@562a37f926dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia0ee3c28f4bcfca84c687501e96c93eb0f7ac2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864818Reviewed-by:
-
Kevin Ellis authored
Previously, the paused_ flag was used to signal that the animation was in a paused state. This flag is not part of the spec and is being phased out. Instead, we look for pending pause or play tasks and whether there is a start time to determine if the animation is paused in alignment with the spec. Note that fixing play state calculation entailed fixing the handling of setting a zero playback rate. Previously, setting the playback rate to zero would clear the start time; however, this has the unwanted side effect of forced the animation into the paused state, which is not to spec. A running or finished animation should have a start time (if not a pending change) even if the playback rate is zero. https://drafts.csswg.org/web-animations/#play-states Bug: 960944 Change-Id: I1fd43315d3b1c42b22302bf730c450a03836861a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862258 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706628}
-
Jacques Newman authored
We want to to allow relations such as labelled-by and described-by to reference elements that are inert. There seems to be precedent for a node having a child with a parent other than itself (see ax_node_object.cc:2447). With this in mind, when a node node is being cleared, it should only clear its child's parent pointer if it points to itself(the parent currently clearing its children). Example: node a: children = { b, c }, parent = null node b: children = { c }, parent = a node c: children = { g, h, i }, parent = a In this case, node c is both a child of the a (the root) and b. If we clear node b, we should not disconnect node c, from a. The tree would look like this: a |____ | | b c |________ | | | g h i Where node b would have indirect_children = {c} Patchset 1 reverts the mitigation that was checked in here: commit 5ef90f37 https://chromium-review.googlesource.com/c/chromium/src/+/1814460 Bug: 996992 Change-Id: I9b9cbc10aea473270178f15f283a1bacfa71b971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838473 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#706627}
-
Kayce Basques authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=986998#c8 Bug: 986998 Change-Id: Ie9755d7820f8743a03ee6664e7bb70667e3bced9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865012 Commit-Queue: Kayce Basques <kayce@google.com> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Kayce Basques <kayce@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706626}
-
John Budorick authored
This reverts commit 4ba7eb3a. Reason for revert: spec revert for crbug.com/1014952 crbug.com/1015014 crbug.com/1015013 crbug.com/1014951 Original change's description: > Resubmit: Lower priority of processes hosting exclusively ads. > > This change adds a variable to ChildProcessPriorityLauncher to > indicate whether the associated process is only used to run tasks for > ad frames (low priority frames). That variable is then used by the > RenderProcessHost to background the frame in those cases. Notification > happens in the RenderProcessHost via new UpdateFrameWithPriority. > > Note: Identification of ad frames is done as per the AdTagging project. > Frames that have been marked as ads remain ads, and thus the > RenderProcessHost will remain low priority if the frame is navigated > to any other non-ad URL within the same process (same domain). > > Currently this is behind a feature which is off by default. > We will be experimenting with this to determine its impact on > both ads and in the browser as a whole. > > TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org > > Bug: 979234 > Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680 > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706049} TBR=alexmos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979234,1014951,1014952,1015013,1015014 Change-Id: Ib719e3f70371b7941d0b27f9bc171594149dd24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864618 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706625}
-
Yuchen Liu authored
Cast may run two media services, one in browser process with CMA media pipeline, the other in gpu process with GPU VDA: 1. Introduce a new media service "media_renderer", which is used and implemented on Cast. It's the same media service as before, we only use it to create media::Renderer and media::ContentDecryptionModule. 2. Change Cast's default media service host to "gpu", so that DefaultRenderer could use MojoVideoDecoder for v4l2 decoder. 3. Cast runs "media_renderer" service in browser process, to replace the old "media" service. Merge-With: eureka-internal/316201 Bug: internal b/138261332 Test: YT, GPM Change-Id: I08ea092b8b94115b3a7e642f8d188d67ef3884e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815719 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706624}
-
nancy authored
BUG=1009248 Change-Id: I0aca18b0a9cf6fc3dc72b4ec0cf1f33451279acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863062Reviewed-by:
-
Jonathan Metzman authored
Builds started failing because //base was only depended on implicitly. TBR=googleo Change-Id: I1b020d169cf092cbd1e6050a9512a3c818c24bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865474Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706622}
-
Kehuang Li authored
So it won't lost connection due to timeout, but will still be closed if the sender side crashes or send invalid message. Meanwhile, fix a bug in the unittests that causes socket not destroyed on the sequence by specifically calling Stop. Bug: internal: 142752569 Bug: internal: 142443304 Test: On device and unittests. Change-Id: I9a75d9727cf7abb3f0acc146b1028edfb3afb45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865532Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706621}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5cc32d92cbf..15bcceb9eaa2 Created with: gclient setdep -r src-internal@15bcceb9eaa2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I1da4f885425a0e9c6dc0c16ec7b09afa3486f0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864813Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706620}
-
Kevin Bailey authored
Adds a small fuzzer for AutocompleteInput, an input classifier and state structure. Change-Id: Ib73721b44a9ef6ca15e978fcea210e56fd40be30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862346 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706619}
-
Evan Stade authored
Replace NOTIFICATION_PROFILE_CREATED/DESTROYED with ProfileObserver. Bug: 268984 Change-Id: I77921a45a79d8bdee9e3a6fc786b5ac6e8c9ee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852412 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706618}
-
Tomasz Wiszkowski authored
This allows BaseSuggestionViewProcessor to create refine icon on behalf of the actual view processor. Bug: 982818 Change-Id: I4424ec9d2e5d1f2fd25f1bc3ce0795076d998852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856901 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#706617}
-
John Budorick authored
This reverts commit 315b3895. Reason for revert: new tests fail on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30281 Original change's description: > In tablet mode, tap on overview background should go to home screen. > > Clamshell mode behavior will remain the same, i.e., tapping on the > overview background will return to its previous state, it can either be > in-app or home screen. > > Bug: 997885 > Change-Id: I82624e44024e273a343c20e3707cb1d97e31d594 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864026 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706548} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I6a9b5666e168dab72d4192036c44d093388c4225 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865556Reviewed-by:
-
Steven Bennetts authored
Shill is not providing a type for VPN IP Configs so we need to set it to IPv4 so that OncMojo.getIPConfigForType() finds it correctly. Bug: 1011557 Change-Id: I13431e0c1a352cf2456832fa97ad0d088c61667b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865470Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706615}
-
Andrew Grieve authored
The whole point of srcjar_deps is that the path to the .srcjar doesn't need to be known by the caller :P. No behavior change. Change-Id: If5f0e7649605d979081152478ca6c76c42e9ed8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856821 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#706614}
-
Hector Carmona authored
This will allow NVDA and JAWS to enter app mode automatically. Bug: 867081 Change-Id: Ib7bc6a417d452a7e63f8a9b644713a5570d37a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855179Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#706613}
-
Peter Kasting authored
Without this, removing an animated view from a widget would stall the animation; this could leave its state incorrect, e.g. if it was later re-added. This can affect the omnibox with an upcoming patch I'm writing. This was introduced by http://crrev.com/657587 ; before that, AnimationRunner did not exist, and removing a view from a widget would have no effect on animations. Bug: none Change-Id: Iae457306a3a3f68e42772009a24d34dd65d4a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857191 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706612}
-
Yulun Wu authored
Bug: 1010919 Change-Id: I08894264b7e219178602d3ea1d2ee00fb851381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854528 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Dale Curtis authored
We've seen unusual statistics when we try to implicitly rely on the lack of an AudioCodec and VideoCodec to imply HLS support. So instead explicitly signal when we're using the MediaPlayerRenderer. This merely helps us differentiate watch time from MediaPlayer, it does not track HLS watch time directly. TEST=play hls, observe MediaPlayer in UKM fields. R=sandersd Change-Id: I7167504436af62a54eb4ebb20a02732e1f65a5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863858 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706610}
-
Francois Doray authored
The policy was previously named TabLifecyclesEnabled and its name/description said that it controlled throttling, freezing and proactive discarding. It actually never controlled throttling and we decided to abandon the proactive discarding feature. Therefore, the name and description are changed to indicate that it controls tab freezing only. Also, the "future" tag is removed since we plan to ship tab freezing in M79. Bug: 844426 Change-Id: I6fdab954aa9d1c9fb5a63217ccda7b869726fc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863382 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#706609}
-
