GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/261673003

git-svn-id: svn://svn.chromium.org/blink/trunk@173015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The regression happened in r172651. This patch returns missed class.

BUG=368362

Review URL: https://codereview.chromium.org/253193004

git-svn-id: svn://svn.chromium.org/blink/trunk@173013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Non-blocking stylesheets like alternate stylesheets cause a synchronous style
recalc when finished loading. This is quite the opposite of what one would
expect as these stylesheets should not contribute to the style at all. We use
deferred style recalc to batch up the style recalcs instead.

It might be possible to further improve this by not doing a style recalc at
all, but that requires that we detect when a non-blocking stylesheet becomes
relevant by another link element setting the preferred stylesheet set to the
same name as that of an alternate stylesheet already added as non-blocking.

R=dglazkov@chromium.org
BUG=368659

Review URL: https://codereview.chromium.org/260713005

git-svn-id: svn://svn.chromium.org/blink/trunk@173012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366788

Review URL: https://codereview.chromium.org/265543003

git-svn-id: svn://svn.chromium.org/blink/trunk@173011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make Range.detach() a no-op as per DOM4:
http://dom.spec.whatwg.org/#dom-range-detach

This makes the code a lot simpler, as it avoids a lot of null checks and
exception throwing. Also add a UseCounter and a deprecation message to see
if this can be removed entirely from the specification.

Firefox already does this since version 15:
https://bugzilla.mozilla.org/show_bug.cgi?id=702948

However, detach() is not a no-op in IE11.

R=arv@chromium.org, tkent@chromium.org
BUG=367322
TEST=fast/dom/Range/detach-no-op.html

Review URL: https://codereview.chromium.org/252783002

git-svn-id: svn://svn.chromium.org/blink/trunk@173010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/261653004

git-svn-id: svn://svn.chromium.org/blink/trunk@173009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Valgrind complained of use before initialization so initializing
InlineFlowBox's m_lineBreakBidiStatusEor, m_lineBreakBidiStatusLastStrong,
and m_lineBreakBidiStatusLast to LeftToRight.

BUG=368303

Review URL: https://codereview.chromium.org/252263002

git-svn-id: svn://svn.chromium.org/blink/trunk@173008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/255363003

git-svn-id: svn://svn.chromium.org/blink/trunk@173006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/254333004

git-svn-id: svn://svn.chromium.org/blink/trunk@173005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While this is a relatively new property, it does require a synchronous IPC
to the browser process in order to get the permission status, and thus would
be better as a Notification.hasPermission() method returning a Promise (or
similar).

Since we will need a similar construct for Push Messaging, and potentially
other APIs, let's get some data on whether developers use this to see if
we can get a more common, asynchronous approach.

BUG=

Review URL: https://codereview.chromium.org/254023002

git-svn-id: svn://svn.chromium.org/blink/trunk@173004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This updates the viewport trigger for GPU rasterization to
<meta name="viewport" content="width=device-width, minimum-scale=1.0,
  initial-scale=1.0, user-scalable=yes">

BUG=367202

Review URL: https://codereview.chromium.org/268453003

git-svn-id: svn://svn.chromium.org/blink/trunk@173003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's no longer set to be anything but true.

Depends on: https://codereview.chromium.org/239973005/

R=abarth@chromium.org, vollick@chromium.org
BUG=365853

Review URL: https://codereview.chromium.org/247673005

git-svn-id: svn://svn.chromium.org/blink/trunk@173002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172823

BUG=366438
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/267503002

git-svn-id: svn://svn.chromium.org/blink/trunk@173001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enabled calc parsing in the sizes attribute, and adds tests for that.

BUG=357586
Depends on http://crrev.com/252743004

Review URL: https://codereview.chromium.org/259193004

git-svn-id: svn://svn.chromium.org/blink/trunk@173000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Functioins in there files have been rewritten in
components/autofill/content/renderer/password_form_conversion_utils.
This is to refact old Blink code on WebPasswordFormData and utils files.

R=gcasto@chromium.org, tkent
BUG=None

Review URL: https://codereview.chromium.org/246233005

git-svn-id: svn://svn.chromium.org/blink/trunk@172999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a target for blink_common, and starts a rough skeleton of blink_platform. There are a lot of dependencies for the platform pat (like V8) so I thought it best to checkpoint that before I start worrying about those.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/257733002

git-svn-id: svn://svn.chromium.org/blink/trunk@172998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is always on, so we don't need to branch on it.

Depends on: https://codereview.chromium.org/239973005/

R=abarth@chromium.org, vollick@chromium.org
BUG=366114

Review URL: https://codereview.chromium.org/249423002

git-svn-id: svn://svn.chromium.org/blink/trunk@172997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=368164

Review URL: https://codereview.chromium.org/268443004

git-svn-id: svn://svn.chromium.org/blink/trunk@172996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/254303002

git-svn-id: svn://svn.chromium.org/blink/trunk@172995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=344497,356644,365698
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/264483005

git-svn-id: svn://svn.chromium.org/blink/trunk@172994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, haraken@chromium.org, mikhail.pozdnyakov@intel.com, wibling@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/260713004

git-svn-id: svn://svn.chromium.org/blink/trunk@172993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The sizes attribute parsing requires calc() parsing and evaluation.
This CL adds a thread safe calc parser (for unsigned length values).

BUG=357586

Review URL: https://codereview.chromium.org/252743004

git-svn-id: svn://svn.chromium.org/blink/trunk@172992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Clearly there's opposition to this naming, best to revert while we discuss.

Original issue's description:
> isActiveFocus() is a more meaningful name
> 
> Previously the function was named isActive() which
> didn't lay emphasis on the behavior and purpose of
> the function. There was a FIXME to rename the
> function to isActiveFocus().
> 
> Patch for doing the same.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172911

TBR=jochen@chromium.org,jamesr@chromium.org,pdr@chromium.org,abarth@chromium.org,eseidel@chromium.org,suyash.s@samsung.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/269433002

git-svn-id: svn://svn.chromium.org/blink/trunk@172991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/255983003

git-svn-id: svn://svn.chromium.org/blink/trunk@172990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I've been regularily contributing to WTF for about 1 year already - basically
from the Blink birth - and I'm one of the most active contributors there (around 80 commits in wtf/ folder, mostly to smart pointers and containers classes).

Recent WTF contributions
https://codereview.chromium.org/253753004/ MessageQueue uses Deque<OwnPtr<> >
https://codereview.chromium.org/252633005/ Enable WTF::HashSet<OwnPtr<> >
https://codereview.chromium.org/249363002/ Use macros instead of specializing VectorTraits explicitly
https://codereview.chromium.org/240213009/ Introduce a macro enabling 'SimpleClassVectorTraits'

The list of all my WTF contributions
http://svnsearch.org/svnsearch/repos/BLINK/search?from=20130402&path=%2Ftrunk%2FSource%2Fwtf&author=mikhail.pozdnyakov%40intel.com

Reviewing of WTF patches
https://codereview.chromium.org/256743005/ Add removeAll method.
https://codereview.chromium.org/228403002/ Prevent buggy use of swap and operator= on vectors
https://codereview.chromium.org/223373002/ Add LinkedHashSet collection
https://codereview.chromium.org/219413002/ Check for concurrent modification

NOTRY=true

Review URL: https://codereview.chromium.org/255123003

git-svn-id: svn://svn.chromium.org/blink/trunk@172989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This aligns with the spec and Gecko.

BUG=367648

Review URL: https://codereview.chromium.org/268443003

git-svn-id: svn://svn.chromium.org/blink/trunk@172988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=368592
TEST=none

Review URL: https://codereview.chromium.org/262663002

git-svn-id: svn://svn.chromium.org/blink/trunk@172987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove [PerWorldBindings] IDL attribute from non wrapper type attributes.
The 2 generated code paths are identical for non wrapper types (e.g.
DOMString) so there should be no performance benefit to having a separate
code path for the main world.

This reduces the release binary size by ~18Kb. I did not see any
regression on the Bindings performance tests locally.

This CL does not change attributes of non-wrapper type that use
[LogActivity=xxx] extended attribute because this would cause a behavior
change. This is sad though because those account for a much greater
binary size (~100 Kb in release).

This CL also adds an assertion to the bindings generator so that folks
stop doing this unintentionally.

Review URL: https://codereview.chromium.org/256263002

git-svn-id: svn://svn.chromium.org/blink/trunk@172986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366585

Review URL: https://codereview.chromium.org/251183005

git-svn-id: svn://svn.chromium.org/blink/trunk@172984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=133733

Review URL: https://codereview.chromium.org/261623002

git-svn-id: svn://svn.chromium.org/blink/trunk@172983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/266433004

git-svn-id: svn://svn.chromium.org/blink/trunk@172982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This does not change the generated code, it is only to match the spec:
http://whatwg.org/html#htmlmediaelement
http://whatwg.org/html#mediacontroller

BUG=354298

Review URL: https://codereview.chromium.org/266473003

git-svn-id: svn://svn.chromium.org/blink/trunk@172981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

lazyAppendAuthorStyleSheets seems to handle cumulative addition of
stylesheets now.

Review URL: https://codereview.chromium.org/262643002

git-svn-id: svn://svn.chromium.org/blink/trunk@172980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/253843007

git-svn-id: svn://svn.chromium.org/blink/trunk@172979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also update the GC unit test with explicit {fill|stroke}Ellipse calls to
preserve current test semantics.

R=senorblanco@chromium.org,schenney@chromium.org

Review URL: https://codereview.chromium.org/258293002

git-svn-id: svn://svn.chromium.org/blink/trunk@172978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Plus/minus 0.5 to the truncated value is more reasonable than
directly adding 1, because 0.5 is the average of the fraction
value.

This patch fixes Acid3 test 99/100 when zoom is 125%, and also
improves overall image zooming.

This patch requires a content shell change to set zoom factor
in script (CL 253493006).

BUG=360713

Review URL: https://codereview.chromium.org/251063002

git-svn-id: svn://svn.chromium.org/blink/trunk@172977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov@chromium.org

Review URL: https://codereview.chromium.org/265493006

git-svn-id: svn://svn.chromium.org/blink/trunk@172975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=367082

Review URL: https://codereview.chromium.org/258953005

git-svn-id: svn://svn.chromium.org/blink/trunk@172974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_syncHelper will be 0 if initialize() fails. connect() must just return
with false in such case.

BUG=368329

Review URL: https://codereview.chromium.org/266483003

git-svn-id: svn://svn.chromium.org/blink/trunk@172973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A fixed clang/asan has been rolled.
See https://code.google.com/p/address-sanitizer/issues/detail?id=279

R=ager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/257403002

git-svn-id: svn://svn.chromium.org/blink/trunk@172972 bbb929c8-8fbe-4397-9dbb-9b2b20218538