- 04 Dec, 2020 40 commits
-
-
Liquan (Max) Gu authored
In PaymentUiService, the way to get the selected payment app is through mPaymentMethodsSection, in spite of the fact that getSelectedPaymentApp() is available. This CL is to replace these mPaymentMethodsSection usages with getSelectedPaymentApp(). This will help moving the payment app management logic out of PaymentUiService. Bug: 1155614 Change-Id: I870d9b24f3cc78e007817c7b67bf9ca0639ccf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574598 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833850}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibd5feccf0a802824695a4165252d501b43d2feaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575338Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#833849}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/extensions. Bug: 1113033 Change-Id: I7bbea659093e20086f9ac7eca7419cd50129b061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572786 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#833848}
-
Liquan (Max) Gu authored
This CL adds PaymentUiService#showShippingAddressError() to encapsulate the UI logic so as to simplify the boundary between the UI and the business logic. Bug: 1155582 Change-Id: I144785eb833da259a6752f2f20d193f5f61c2e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572909 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Bottom controls UI was enabled only on tabbed chrome UI but a bug in https://crrev.com/c/2567077 caused it to run for other UI modes as well. This CL partially reverts the changes in the CL and let the root ui coordinator for tabbed mode handle the initialization again. Bug: 1154485, 1142286, 1154582 Change-Id: I834958fd6d3e620d928064a800c2499bb0deba6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569435Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#833846}
-
Alison Maher authored
This change updates the field_group of all the internal forced colors properties to "*" to ensure that they are all stored in a rare data structure. Bug: 970285 Change-Id: Ibfdac0b40980824e79eab51f9f42e807d94eda97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566691Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/079a95bc7240..b28382109909 2020-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I8e233de31470988fa8d18e1b4efb6f43350757e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833844}
-
Jeroen Dhollander authored
Previously the Quick Answers view was added first to the context menu, causing it to jump as items were added/removed to the menu. Bug: b/173569669 Test: Manually deployed and verified we no longer get multiple |OnBoundariesChanged| events. Change-Id: I6b8e52b7e24f653dcf033eb218c26b61f4de86e4 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567183Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833843}
-
Trent Begin authored
This change groups the network diagnostic routines into similar categories to simplify the UI. This brings the app in closer alignment to the original Chrome App. https://screenshot.googleplex.com/9TA8y5z4gDKC3hB Bug: chromium:1142857 Change-Id: I6336106a0d6b945012d6e6c93b98f1f0a46fca8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561294 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833842}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607082643-9d7584569e97498303bfc8f363e6d14838d94e40.profdata to chrome-linux-master-1607104719-553836ec892e604b847a609e48d12198e967747c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ice7fe7207ba4acb9b2ed520c51409bddd3f9553f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574902Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607082643-ec3aa91ed6cc9a4e56961da34010bfe7d1bfcfad.profdata to chrome-mac-master-1607104719-e1d1a8dd7fb3b6aba7965596c29afef7497a651e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie443972e14285fb4ded29a1c784d90d768b7722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575107Reviewed-by:
-
Yann Dago authored
Create a new ClearBrowsingDataOnExitList that takes a list of browsing data to delete when chrome shuts down. In case the data was not properly deleted at shutdown, an attempt to delete them will be made at the next startup. This policy will keep the browser alive until the browsing data is properly deleted. This policy has no effect unless the SyncDisabled policy is active. BYPASS_POLICY_COMPATIBILITY_CHECK=<BrowsingDataLifetime had a bug in 88> Bug: 1026442 Change-Id: Iea425b9f9a61086fda118a28746bbf77853b65eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440238 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833839}
-
Becca Hughes authored
Change-Id: I33bbb1cca27e8973414a6520b7c76cf1135949b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575038Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#833838}
-
Sophie Chang authored
Bug: 1112500 Change-Id: I1fdb815bf0614055e4195529f52d3e33498193c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569849 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833837}
-
Eugene But authored
Move kRemoveProtectionFromPrefFile check to a later stage when Finch is actually initialized. Before this change kRemoveProtectionFromPrefFile chekh would always return false. Bug: None Change-Id: I4cb5eeb5b96760572ffa34146b15b9361fb7cd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568217 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833836}
-
Avi Drissman authored
Chromium requires 10.11, so now SDK constants can be used. Bug: 1153883 Change-Id: Ie4c206873adc1f5aca6682cf1623de316086f17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572697 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#833835}
-
Gordon Seto authored
Extract fetching pending eSIM profiles logic into esim-manager-utils. This is to avoid duplicate logic when querying for eSIM profiles in the settings page in follow-up CL crrev.com/c/2572748. Bug: 1093185 Change-Id: I0181c48f704fab518124ef2422ef38814206b86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570545 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Matthew Jones authored
This reverts commit 79b4e301. Reason for revert: Suspected cause of test failures on android-lollipop-arm-rel: https://ci.chromium.org/ui/p/chromium/builders/ci/android-lollipop-arm-rel/5950/overview ThreadCacheTest.PeriodicPurgeStopsAndRestarts ../../base/allocator/partition_allocator/thread_cache_unittest.cc:525: Failure Value of: ThreadCacheRegistry::Instance().has_pending_purge_task() Actual: false Expected: true Original change's description: > [PartitionAlloc] Don't perform expensive allocations to fill the thread cache. > > Bug: 998048 > Change-Id: Ie18db70f78188e4541aa4d5a0f44da2ce166524e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569664 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833771} TBR=lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,bartekn@chromium.org Change-Id: I2a9cbb1bbd2b4ca3eae9580c510f88f05edeadb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575003Reviewed-by:
-
Tom Sepez authored
Broken at https://chromium-review.googlesource.com/c/chromium/src/+/2417091 The build configuration that provides the PDF_ENABLE_XFA symbol does not appear to be present for files at the pdf/ directory level, only for those at the pdf/pdfium/ directory level. To avoid requiring these definitions at a higher level (since this minimizes recompilation when the value changes), add a helper function in pdf/pdfium/ to return this information. Change-Id: I2499816aa9e5ac08c7064a961d2ed4f70c7772f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575042 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#833832}
-
Matthew Mourgos authored
This change is in preparation of multipaste related VK API changes, where the ChromeVirtualKeyboardDelegate will need to be a ClipboardHistoryControllerObserver. This will allow the VK to observe clipboard history changes. Bug: 1099318 Change-Id: I5535d45255b137219cf76b76f6d94c9bfb5ca9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573636Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#833831}
-
Chris Mumford authored
IndexedDBContextImpl had the following two member variables: IndexedDBDispatcherHost indexed_db_factory_; std::unique_ptr<IndexedDBFactoryImpl> indexeddb_factory_; The first name was confusing. Renamed to: IndexedDBDispatcherHost dispatcher_host_; to avoid confusion. Bug: none Change-Id: Iaefb0e077f94ea2e1639a4c7aeb28a29f9a3ffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575037Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#833830}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b917ab64e84b..2d21a8fb4dbe 2020-12-04 cjamcl@chromium.org Add WATCHLISTS entry for lighthouse 2020-12-04 bmeurer@chromium.org [LMI] Add support for inspecting WebAssembly.Memory objects. 2020-12-04 tvanderlippe@chromium.org Port pretty-printing layout tests to Karma 2020-12-04 kimanh@chromium.org [LMI] Show signed/unsigned values next to each other, if different 2020-12-04 tvanderlippe@chromium.org Improve formatting of do-while loop 2020-12-04 tvanderlippe@chromium.org Fix permissions for test scripts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:1155566,chromium:983851 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3f64c8136baa665dfdbaafad82c370ae754d2d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575216Reviewed-by:
-
Stephen McGruer authored
Using wpt-import in Chromium 1aa111f7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mstensho@chromium.org: external/wpt/css/css-break external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/css-contain external/wpt/css/css-grid yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ic7dc1808879a15bc57c0b4d65d22a323780a9a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572988Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833828}
-
Francois Beaufort authored
This CL makes sure all ImageCapture related capabilities, constraints, and settings are copied to the cloned MediaStreamTrack. This wasn't the case before. Bug: 934063 Change-Id: I783d0804e56f46152e1ba02255ff454dd1ba76aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567917Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#833827}
-
Etienne Bergeron authored
Remove an unsupported eliding multiline mode: ELIDE_LONG_WORDS The eliding mode is still supported by ElideRectangleText(...) and still used in Canvas. This CL only prevent an incorrect use in RenderText and remove it from the fuzzer. R=msw@chromium.org Bug: 1150235 Change-Id: I53aee3ddc2ba9fd8e7b69995e25aa697644b6894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561438Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1df52ed5909b..ff8800deaa33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138953 Tbr: sergeyu@google.com,mmentovai@google.com Change-Id: I87b70dc70cae70364cef5f9525795f959c2acde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574997Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833825}
-
Andrew Grieve authored
Tested that all targets now build via: autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled) Bug: 1155547 Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833824}
-
Ken Buchanan authored
Some callback aliases were missed when I was taking out the BLE authenticator code earlier this year. This removes them. Change-Id: Ic69352e4fde6892821e9076f111d030299e9451f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575156Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833823}
-
Sorin Jianu authored
Change-Id: Ie468abd468d88cca3f6eb01855f1033718545b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575319Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833822}
-
Juan Mojica authored
This change adds the intent parameters data class as well as API methods into LensController for starting the AGSA connection early and launching the intent via the Lens SDK. Bug: 1098431 Change-Id: I5e9d1777e352c246bf93372d6e7fe2d2b22c78f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551424Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/master@{#833821}
-
Ben Pastene authored
This reverts commit 00437792. Reason for revert: suspect to be causing apps.LaunchGallery failures on CrOS https://bugs.chromium.org/p/chromium/issues/detail?id=1155028#c21 Original change's description: > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > This isn't directly using net::IsSafePortablePathComponent since what > is safe for the File System Access API is not the same as what is safe > for Downloads. As such currently this duplicates a lot of the > implementation of this method, but in a followup we should attempt to > unify these two implementations as much as possible. > > Bug: 1150810, 1154757 > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833042} TBR=mek@chromium.org,pwnall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150810 Bug: 1154757 Bug: 1155028 Change-Id: I6c0fb2af7096d4f7f47d3e17a40c5a69105808cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574931Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833820}
-
Toby Huang authored
This CL fixes the CachedMetricsProfile and DemographicMetricsProvider for ChromeOS Ash. It introduces a profile selection strategy for CachedMetricsProfile and skips the number of profiles on disk check in DemographicMetricsProvider for ChromeOS Ash. Bug: 1145655 Change-Id: I3cf69673e428cc7ff81e4d1e5f1650a6d96bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527521Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833819}
-
Egor Pasko authored
In http://crrev.com/833775 a command line flag was renamed in list_java_targets.py. Update generate_gradle.py accordingly. Bug: None Change-Id: I91c85063f5eb1ae442731536103492c2fe15ff7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575018 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833818}
-
Andrew Grieve authored
We couldn't do this when increment_install was not a GN arg, but it's easy to do now that it is :). Bug: None Change-Id: I42c243fa530e448158405bf4157016f578f319ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573011 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833817}
-
Rouslan Solomakhin authored
This patch checks the result of WebContents::FromRenderFrameHost() for null to avoid crashing. Bug: 1064628 Change-Id: Ib755a014e72e2428e8343aa2aac2b3b707c484ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572908Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833816}
-
David Tseng authored
Previously, chrome.accessibilityPrivate.enableChromeVoxMouseEvents only sent mouse events through the accessibility -> chrome.automation layer only when ChromeVox was enabled. Make it so that we also send (when requested) to the accessibility common extension when magnifier is enabled. R=josiahk@chromium.org Test: browser_tests --gtest_filter=*Spoken*.SpeakingTextUnderMouseForShelfItem* for ChromeVox. Magnifier tests tbd when it gets used for upcoming features. Change-Id: If620e69d3d7a0d0480afac412ae9c4d52b8cfba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572797 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
rajendrant authored
Change-Id: I59d9725499dfabe490411391350f5050ebe326c8 Bug: 1152527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574258 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#833814}
-
Joon Ahn authored
Screen: http://screen/BhQEsVaDzMLxAEj Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#000933fc-29e1-4d4b-aa49-9d1b8fb16a24 Bug: 1125150 Test: browser_test --gtest_filter=Diagnostics* Change-Id: Ic52a8249e29e17ce703a1acc91d1e8280db93073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572790Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833813}
-
Chris Thompson authored
Support for the enterprise bypass of the TLS 1.0/1.1 removal will be removed in May 2021. This adds a notice to the policy page to clarify this. The sunsetting of this bypass has been previously announced in https://www.chromestatus.com/feature/5759116003770368, https://security.googleblog.com/2018/10/modernizing-transport-security.html (in 2018), and https://blog.chromium.org/2019/10/chrome-ui-for-deprecating-legacy-tls.html (in 2019). Bug: 896013 Change-Id: Ib0cb2ba9bc8a925a1a8bfd3ee17995ae0a23bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569811 Commit-Queue: Chris Thompson <cthomp@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Add NavigationCallback.onFirstContentfulPaint variant that matches up to CCT's version for easier comparison. Bug: 1152600 Change-Id: I3025464676ecb2cc649e445701cdc5797e4d068d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559285Reviewed-by:
-
