GitLab

BUG=405038
TEST=
1. Sign in to Chrome and make sure there are no Auth Errors
2. Navigate to chrome://signin-internals
3. In the Basic Information section, observe that there is no ErrorController Username or ErrorController Status section
4. Trigger an Auth Error (for example by revoking Chrome's access token at accounts.google.com)
5. In chrome://signin-internals, observe that the Basic Information section was updated with the ErrorController Username and ErrorController Status fields.

Review URL: https://codereview.chromium.org/1025323004

Cr-Commit-Position: refs/heads/master@{#322426}

Currently media code uses a separate logging system (MediaLog) and some important messages are reported there, but are not reported in the main browser log. Currently media log messages can only be seen in the chrome://media-internals, but since they are very useful, we should add them to the main browser log as well.

BUG=453180

Review URL: https://codereview.chromium.org/877273002

Cr-Commit-Position: refs/heads/master@{#322425}

BUG=469582

Review URL: https://codereview.chromium.org/1036663002

Cr-Commit-Position: refs/heads/master@{#322424}

Currently, ChromeVox Next uses the programmatic string when whenever $role gets used. This cl makes it so $role resolves to a msg id, if one exists. Additionally, the role info object also lists the arcon associated with that role.

This allows us to remove a few of the output rules (button, textField).

Review URL: https://codereview.chromium.org/1011913002

Cr-Commit-Position: refs/heads/master@{#322423}

Set Fixedsource image unscaled to make it really fixed.

BUG=None

Review URL: https://codereview.chromium.org/1038523006

Cr-Commit-Position: refs/heads/master@{#322422}

Review URL: https://codereview.chromium.org/1036513008

Cr-Commit-Position: refs/heads/master@{#322421}

BUG=470232

Review URL: https://codereview.chromium.org/1034873003

Cr-Commit-Position: refs/heads/master@{#322420}

Revert of Send autocapitalize flags to the Android virtual keyboard based on Blink hints. (patchset #6 id:100001 of https://codereview.chromium.org/1003143002/)

Reason for revert:
compile fail on
http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/13039

../content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:128:error: cannot find symbol
        if ((inputFlags & WebTextInputFlags.AutocapitalizeCharacters) != 0) {

Original issue's description:
> Send autocapitalize flags to the Android virtual keyboard based on Blink hints.
>
> This changes the behaviour of AdapterInputConnection to pass a
> InputType.TYPE_TEXT_FLAG_CAP_* based on the
> WebTextInputFlags.Autocapitalize* instead of doing it purely based on the
> element's type.
>
> This CL requires the following Blink CL:
> https://codereview.chromium.org/995363002
>
> BUG=466930
>
> Committed: https://crrev.com/d1421a5faf9dc2d3b3cad10640576b24a092d9ba
> Cr-Commit-Position: refs/heads/master@{#322414}

TBR=aurimas@chromium.org,shuchen@chromium.org,mlamouri@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466930

Review URL: https://codereview.chromium.org/1008153003

Cr-Commit-Position: refs/heads/master@{#322419}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/12736d7..9737cee

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1035993002

Cr-Commit-Position: refs/heads/master@{#322418}

This pulls in the following Native Client changes:

c7ebcbc: (hidehiko@chromium.org) Non-SFI mode: Update headers for nacl_helper_nonsfi.
2312a39: (stichnot@chromium.org) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
e0ca648: (stichnot@chromium.org) Add Subzero to test scripts.
316f3e5: (dschuff@chromium.org) Build the IRT with nacl-clang for x86
70e1707: (dschuff@chromium.org) Revert of Build the IRT with nacl-clang for x86 (patchset #16 id:290001 of https://codereview.chromium.org/940993003/)
55bd3af: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
715ffb5: (mtrofin@chromium.org) Using LLVM FileCheck exclusively.
5995d5f: (sbc@chromium.org) Implement pthread_rwlock functions for NaCl newlib
f7533e5: (jfb@chromium.org) Update revision for PNaCl
b7793fe: (jfb@chromium.org) Test bswap with large offset

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/2d8b0bb6ffaf871fdc1f902d38778b2df8c6ff0d..b7793fedbadcf1c2c10c7f1a2ffb0f41342750ad

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R= dschuff@chromium.org

Review URL: https://codereview.chromium.org/1037953003

Cr-Commit-Position: refs/heads/master@{#322417}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b8c26baf..e4dfe3b9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1026153003

Cr-Commit-Position: refs/heads/master@{#322416}

Revert of Port Chromium OS touch noise filtering to Chromium (patchset #8 id:410001 of https://codereview.chromium.org/991533002/)

Reason for revert:
This patch breaks the PFQ for 32/64 bit due to some string conversion problems:

0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.cc:100:63: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64 {aka long long int}' [-Werror=format=] chromeos-chrome-43.0.2346.0_rc-r1: touch.tracking_id, max_duration.InMilliseconds());
should I revert this - or do you want to land a patch for it?
Oh - there is also another one:
0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc: In member function 'virtual void ui::HorizontallyAlignedTouchNoiseFilter::Filter(const std::vector<ui::InProgressTouchEvdev>&, base::TimeDelta, std::bitset<20u>*)': chromeos-chrome-43.0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc:39:66: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64 {aka long long int}' [-Werror=format=] chromeos-chrome-43.0.2346.0_rc-r1: other_touch.tracking_id, other_touch.x, other_touch.y);

Original issue's description:
> Port Chromium OS touch noise filtering to Chromium. The Chromium OS
> touch noise filtering is at
> https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master
>
> When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and
> all of the subsequent events for that touch are dropped. A "touch press"
> initiates a new touch.
>
> BUG=407840
> TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.*
>
> Committed: https://crrev.com/1df4aa125090c601b1a18c4354b8ca9323cb4c79
> Cr-Commit-Position: refs/heads/master@{#322293}

TBR=flackr@chromium.org,spang@chromium.org,pkotwicz@google.com,sadrul@chromium.org,pkotwicz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=407840

Review URL: https://codereview.chromium.org/1033933004

Cr-Commit-Position: refs/heads/master@{#322415}

This changes the behaviour of AdapterInputConnection to pass a
InputType.TYPE_TEXT_FLAG_CAP_* based on the
WebTextInputFlags.Autocapitalize* instead of doing it purely based on the
element's type.

This CL requires the following Blink CL:
https://codereview.chromium.org/995363002

BUG=466930

Review URL: https://codereview.chromium.org/1003143002

Cr-Commit-Position: refs/heads/master@{#322414}

This adds tests to validate the effects of command line arguments on
ChromeComponentUpdaterConfigurator:
--component-updater disable-pings
--component-updater fast-update
--component-updater url-source = <url>
--component-updater test-request

BUG=469875

Review URL: https://codereview.chromium.org/1013003003

Cr-Commit-Position: refs/heads/master@{#322413}

WebRTC 8862:8867
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/70e3d3d..547c64a

Libjingle 8863:8869
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/f4031d6..4d55b53

TBR=
BUG=

Review URL: https://codereview.chromium.org/1037963002

Cr-Commit-Position: refs/heads/master@{#322412}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ce86687..b880d7f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1038873002

Cr-Commit-Position: refs/heads/master@{#322411}

This invocation causes a side effect of setting wrong max to
the baselines_ during ElideEmail(), which causes an infinite loop
later in ItemizeTextToRuns().

BUG=470179
R=msw@chromium.org
TEST=the new test case covers (it doesn't end without this patch)

Review URL: https://codereview.chromium.org/1037573006

Cr-Commit-Position: refs/heads/master@{#322410}

This also adds the network technology 1x badge to cr_network_icon

BUG=470282

Review URL: https://codereview.chromium.org/1033843003

Cr-Commit-Position: refs/heads/master@{#322409}

BUG=459600

Review URL: https://codereview.chromium.org/1034043002

Cr-Commit-Position: refs/heads/master@{#322408}

R=fmalita@chromium.org
BUG=skia:3588

Review URL: https://codereview.chromium.org/1017853005

Cr-Commit-Position: refs/heads/master@{#322407}

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1031983005

Cr-Commit-Position: refs/heads/master@{#322406}

This API was never officially supported, but I left in ABI compatibility for a while for the Google Earth prototype. They're now on the stable 1.2 version, so this version of the API can go away.

sky TBRed for trivial change to chrome/common/ppapi_utils
binji TBRed for native_client_sdk

BUG=414398
TBR=sky@chromium.org,binji@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1014723007

Cr-Commit-Position: refs/heads/master@{#322405}

This CL is adding a content switch that is used by WebView to not create
a ScreenOrientationDelegate which will prevent locking to work on WebView
and will correctly return that locking isn't supported to Javascript.

BUG=466080

Review URL: https://codereview.chromium.org/1037693003

Cr-Commit-Position: refs/heads/master@{#322404}

We have run into a driver issue where after we invalidate a Frame
Buffer Object it gets into a state where it will randomly drop
draw calls and/or texture copies. I have added a workaround for this
issue by skipping frame buffer invalidations on Adreno 420s. This is
valid because invalidations set the frame buffer to be in an undefined
state so skipping them is technically okay, however we may lose
optimizations that could happen at the driver level for operations
being performed on an undefined FBO.

R=sievers@chromium.org, vmiura@chromium.org
BUG=443060

Review URL: https://codereview.chromium.org/1034663003

Cr-Commit-Position: refs/heads/master@{#322403}

The session_manager has been mitigating some potential Owner settings
edge cases for quite some time, mostly around the user whitelist being
enabled without the owner on it! While these should all be gone, very
old devices being used for the first time could still run into
this. That said, Chrome's in a better position to handle this issue,
so let's move the functionality here.

BUG=chromium:422046
TEST=unit

Review URL: https://codereview.chromium.org/985093002

Cr-Commit-Position: refs/heads/master@{#322402}

- Copy Android relocation packer source from AOSP:
    bionic/tools/relocation_packer/
- Remove golden test data generation scripts (not needed here)
- Add a local ScopedFd.h, to avoid any dependency on base
- Add gyp and gn build files for chromium
- Update third_party/android_platform/README.chromium

BUG=385553
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/1027823002

Cr-Commit-Position: refs/heads/master@{#322401}

Review URL: https://codereview.chromium.org/1008563003

Cr-Commit-Position: refs/heads/master@{#322400}

BUG=

TBR=tsepez@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1031393002

Cr-Commit-Position: refs/heads/master@{#322399}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/da5a017..12736d7

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1031403002

Cr-Commit-Position: refs/heads/master@{#322398}

BUG=470835

Review URL: https://codereview.chromium.org/1034923002

Cr-Commit-Position: refs/heads/master@{#322397}

BUG=466867

Review URL: https://codereview.chromium.org/1010323002

Cr-Commit-Position: refs/heads/master@{#322396}

BUG=

Review URL: https://codereview.chromium.org/1036623002

Cr-Commit-Position: refs/heads/master@{#322395}

This unifies the painting code path between Views that are and are not
backed by layers, they all go through View::Paint now.

View::Paint will only translate the canvas relative to the parent when
layer() is false, keeping the origin at the origin of the view when it
is backed by a layer().

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1035833002

Cr-Commit-Position: refs/heads/master@{#322394}

We are using .svg file in ServiceWorkersView but the mime-type for .svg file is not correctly set.

BUG=466871

Review URL: https://codereview.chromium.org/1035873002

Cr-Commit-Position: refs/heads/master@{#322393}

BUG=467712

Review URL: https://codereview.chromium.org/1026053003

Cr-Commit-Position: refs/heads/master@{#322392}

This re-lands https://codereview.chromium.org/750183008 (originally
by loislo@) with the output chunk size reduced down from 10M to 100K
(close to what it used to be originally). The reason for telemetry
failures of original change on Windows was the bug in websocket-client
(https://github.com/liris/websocket-client/issues/163) that caused
it to fragment Python heap when receiving a large frame.

Original issue description:
Move serialization into a worker thread. As a result
IO thread will be able to send messages to the browser.

The original implementation did serialization on IO thread
and was not able to send the messages because ipc had
is_blocked_on_write_ = true and had no chance to check
the actual state of the channel. So the messages were
collected in output_queue. Also the messages could be quite
big and could block the IO thread for a long time.

BUG=463572
TBR=dsinclair
(as he already l-g-t-m-d the original patch)

Review URL: https://codereview.chromium.org/1035783002

Cr-Commit-Position: refs/heads/master@{#322391}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3a82b4f..da5a017

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1030363002

Cr-Commit-Position: refs/heads/master@{#322390}

BUG=none
R=glider@chromium.org

Review URL: https://codereview.chromium.org/1038883002

Cr-Commit-Position: refs/heads/master@{#322389}

At present, the initialization of the guest's zoom level in
GuestViewBase::StartTrackingEmbedderZoomLevel() is ineffective since the
guest web contents may not have navigated yet ... this occurs for
example when embedding extension options pages in the settings-
extensions page.

Also, the extension options guest should place its guest into isolated
zoom mode since changes to the zoom of settings-extensions page should
not affect the zoom level of the associated extension.

BUG=468397, 468404

Review URL: https://codereview.chromium.org/1009193003

Cr-Commit-Position: refs/heads/master@{#322388}

Leaving the QuicDispatcher unchanged for now. Will unify that in
a followup.

Also removes the remaining balsa dependency in QuicInMemoryCache.

Review URL: https://codereview.chromium.org/1032903002

Cr-Commit-Position: refs/heads/master@{#322387}