- 26 Jan, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7373af4b529..8cb3911f7e9b Created with: gclient setdep -r src-internal@8cb3911f7e9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id44bc5af508733db43e3ff6aa812b32057671c30 Reviewed-on: https://chromium-review.googlesource.com/c/1438026Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626337}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I664858de798ac16136a2334050ae0d4fbd572a86 Reviewed-on: https://chromium-review.googlesource.com/c/1437327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626336}
-
Armando Miraglia authored
This CL gets rid of the googHotword constraint in the renderer process. This property was available only with the legacy constraints syntax. A follow-up CL will remove the property in the browser process. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WlIzSK6-xq0 BUG=577627,564574,924485 Change-Id: I7c0e9ab0608db841c5428187d50174770949067e Reviewed-on: https://chromium-review.googlesource.com/c/1426688Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#626335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6ccdc6c3e62..d7373af4b529 Created with: gclient setdep -r src-internal@d7373af4b529 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a868ff295645f2fc94970d063e6fc7f17e91071 Reviewed-on: https://chromium-review.googlesource.com/c/1438118Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I134a944022e1c2290b50b4d2f38fddcb27f7ee70 Reviewed-on: https://chromium-review.googlesource.com/c/1438116Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0d21d1f7b8bb5c7c62d274b31eeadf5d71121c98 Reviewed-on: https://chromium-review.googlesource.com/c/1438117Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16a2fe7e1553..f6ccdc6c3e62 Created with: gclient setdep -r src-internal@f6ccdc6c3e62 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2392305c62101ef6544754b4323460f0ff022bf5 Reviewed-on: https://chromium-review.googlesource.com/c/1438114Reviewed-by:
-
Andrew Grieve authored
Bug: 912690 Change-Id: I6148fd6f980b334638ee8ab5b4abbef97cbd99ce Reviewed-on: https://chromium-review.googlesource.com/c/1437979 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#626330}
-
Dale Curtis authored
Adds a trace in VideoRendererImpl::Render() and VideoFrameSubmitter::SubmitFrame() with information on the frame selected and the frame submitted. BUG=none TEST=chrome://tracing shows frame info. R=liberato Change-Id: I7ec27258db43bf420f35f0cde23b907bee26a23e Reviewed-on: https://chromium-review.googlesource.com/c/1436488 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#626329}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c4d51cc6482..16a2fe7e1553 Created with: gclient setdep -r src-internal@16a2fe7e1553 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69271985b4b31de5383a51fe374f52234549672a Reviewed-on: https://chromium-review.googlesource.com/c/1438024Reviewed-by:
-
Kevin Strohbehn authored
Bug: NA Change-Id: I92b5b7e81c7712c8476c9690975a6e8283f24a14 Reviewed-on: https://chromium-review.googlesource.com/c/1438000 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626327}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fce0b4f7. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7323dec27ef3c8c5a0a7566abfa219b1590ef5ec Reviewed-on: https://chromium-review.googlesource.com/c/1437977Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9504cfbd59..7c4d51cc6482 Created with: gclient setdep -r src-internal@7c4d51cc6482 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:920652,chromium:828647,chromium:828648,chromium:828649,chromium:828650,chromium:828651,chromium:828672 TBR=mmoss@chromium.org Change-Id: I2a5a270975ed4b339b9f0f6b3520f7f45926198f Reviewed-on: https://chromium-review.googlesource.com/c/1437726Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ie59d8115c6e317d091391b1551b3c9ce351d3b3d Reviewed-on: https://chromium-review.googlesource.com/c/1437584Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#626324}
-
Findit authored
This reverts commit 726375b6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 626289 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzI2Mzc1YjZhMGM1NTgzZjRkNmMzN2EwZDVlZGFmMjQyMWNiNzJiOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/9272 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac Sample Flaky Test: external/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads_without_user_activation.sub.tentative.html Original change's description: > Add tentative WPT to verify download in sandbox > > General testing idea: > For a network request, we store a token in stash. And after a fixed > period of time sufficient for the download to finish, if there are > any, we validate the token in the stash to see if the network request > was issued and finished successfully. > > In the case of <a download> where the decision of download can be made > before resource fetching, the server sets the token immediately. > > In the case of navigation to a download, the server will stream a > response over 1 seconds and set the token at the end only when the > socket has been connected. So it is able to detect any download > cancellation while fetching the resource. > > Bug: 539938 > Change-Id: I734c8cc18d1f761f16646c6b859a6b731ab40ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/1422667 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626289} Change-Id: Id343b8de2a751856b27907ba4c8dfb52715e4598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 539938 Reviewed-on: https://chromium-review.googlesource.com/c/1437999 Cr-Commit-Position: refs/heads/master@{#626323}
-
Dan Beam authored
crisper.js:formatted:6217 Uncaught TypeError: Cannot read property 'getDetailsButton' of null at HTMLElement.getDetailsButton (crisper.js:formatted:6217) at HTMLElement.onViewExitFinish_ (crisper.js:formatted:8074) at HTMLElement.handler (polymer-extracted.js:11) at crisper.js:formatted:2132 at async Promise.all (chrome://extensions/index 0) I'm fairly sure this was caused in https://crrev.com/c/1125507 Unfortunately, CrExtensionsManagerUnitTest.UninstallFromDetails is flaky and currently DISABLED_ (I re-enabled it locally and it didn't fail). Bummer. R=rbpotter@chromium.org BUG=none Change-Id: Ic390a4ee61d61832f9aee96ca5d9a2f2d9310c40 Reviewed-on: https://chromium-review.googlesource.com/c/1437949 Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#626322}
-
Hector Carmona authored
This is because we don't have a good list of email providers to recommend that will be relevant based on locale. Bug: 924274 Change-Id: I432c1a81e0c0272673edace4ac82781dbb216c45 Reviewed-on: https://chromium-review.googlesource.com/c/1437554 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#626321}
-
Fabrice de Gans-Riberi authored
This implements setting and using the |headers| data in LoadUrlParams. A new test fixture is added to ensure the extra headers are properly received by the test server. Reason for reland: Now with extra nullptr dereference check. Bug: 923598 Change-Id: Ie677bc7a13da381f018e1de94daa4742462803cf Reviewed-on: https://chromium-review.googlesource.com/c/1437937 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#626320}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11455bfdc0c5..71b05185eb63 git log 11455bfdc0c5..71b05185eb63 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 primiano@google.com Merge "perfetto-ui: cd ui; ./npm audit fix" 2019-01-25 primiano@google.com Merge "perfetto-ui: Fix presubmits" 2019-01-25 primiano@google.com Add DISCARD policy to TraceBuffer Created with: gclient setdep -r src/third_party/perfetto@71b05185eb63 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:115601774 TBR=perfetto-bugs@google.com Change-Id: Id75211486ff6a18c7531b439d5a83c88f399ae58 Reviewed-on: https://chromium-review.googlesource.com/c/1437857Reviewed-by:
-
David Tseng authored
Change-Id: I7ac749bfa0115479b133e9e9f53390b9ebf4022a Reviewed-on: https://chromium-review.googlesource.com/c/1435114Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626318}
-
Azeem Arshad authored
This CL adds a new ConnectionEstablisher implementation that supports FCM web push based background notifications in ChromeOS - Android Message for Web integration. This implementation uses a regular message dispatch to the service worker to allow it to register for push notifications. See go/awm-cros-fcm. Bug: 920831 Change-Id: I2bc555313468fc210f183f8c7ce5f786b68e383f Reviewed-on: https://chromium-review.googlesource.com/c/1432796 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#626317}
-
Andrey Kosyakov authored
Mark external/wpt/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html as timing out on win TBR=ossu Bug: 626703 913932 Change-Id: I12a8ee4d3d9948a074b0060a84c40b63c9f2e350 Reviewed-on: https://chromium-review.googlesource.com/c/1437582Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626316}
-
CJ DiMeglio authored
This should have been removed with https://chromium-review.googlesource.com/c/chromium/src/+/1379178 but I guess was missed. Bug: 836549 Change-Id: I452b29f252cb6664281388ab5866ddad8005a48b Reviewed-on: https://chromium-review.googlesource.com/c/1437702Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#626315}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I01c0f7e9e6b9d25752b9fe83b6cd116c485613b4 Reviewed-on: https://chromium-review.googlesource.com/c/1437730Reviewed-by:
-
Lei Zhang authored
On Linux, given sufficient RAM, GetMaxRendererProcessCount() can now return a value as high as (RLIMIT_NPROC / 2), instead of being capped to a hard-coded maximum. This lets the browser start more processes and have more process isolation between renderers if the environment can support it. This also makes the browser behave better when running in an environment that is constrained by the process limit. BUG=104689 Change-Id: I2b249bc4b1e1c2e52579cf6fd603798f3e028249 Reviewed-on: https://chromium-review.googlesource.com/c/1088242 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626313}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2f7dfae. With Chromium commits locally applied on WPT: f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I12709d90e33a1d2bee62a8f62a5a6afe5a402603 Reviewed-on: https://chromium-review.googlesource.com/c/1437718Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b0dd7244802..48c3b49693ae git log 1b0dd7244802..48c3b49693ae --date=short --no-merges --format='%ad %ae %s' 2019-01-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-01-25 tbegin@google.com sludge: change full builder to release builder 2019-01-25 bhthompson@google.com Add R73 release branch builders Created with: gclient setdep -r src/third_party/chromite@48c3b49693ae The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idb988a786bc080e0f588c040fdcde2882f152399 Reviewed-on: https://chromium-review.googlesource.com/c/1435727Reviewed-by:
-
Tommy Steimel authored
This fixes an issue where Chrome will only download a video/3gpp file instead of playing it when opened with Chrome. Bug: 910658, 923081 Change-Id: I0fcdfe5952f0020c35fe09a0db85a4e83fe4d37a Reviewed-on: https://chromium-review.googlesource.com/c/1437720Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#626310}
-
Fabrice de Gans-Riberi authored
The underlying blobfs issues affecting cast_runner_integration_tests, cast_runner_browsertests, web_runner_integration_tests and webrunner_browsertests have been fixed. Bug: 910799, 918586, 925574 Change-Id: Id40b0f01916b8a111ac1544550ba33f2e2d74371 Reviewed-on: https://chromium-review.googlesource.com/c/1437917Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
khachatryan authored
Chrome m73 branch is released. Adding support for Chrome v73 and dopping v70 from the supported list. Change-Id: Ic4a4a06042bd9589e48b1553caee7fbda82444b8 Reviewed-on: https://chromium-review.googlesource.com/c/1437936Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#626308}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5904ee3f58e3..d51fbe347e70 git log 5904ee3f58e3..d51fbe347e70 --date=short --no-merges --format='%ad %ae %s' 2019-01-26 jmadill@chromium.org Fold buffer access validation into extensions. Created with: gclient setdep -r src/third_party/angle@d51fbe347e70 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I769d1aa6f518121a890d6d2b00c155acdafef828 Reviewed-on: https://chromium-review.googlesource.com/c/1437723Reviewed-by:
-
Tetsui Ohkubo authored
In NotificationViewMD, users can disable a notification from inline settings. When "Done" button is clicked, ToggleInlineSettings() might call DisableNotification() to apply the setting. After DisableNotification is called, there's no guarantee that the notification view still exists. Therefore, it's better to call the method at the end of ToggleInlineSettings. In this case, 1. DisableNotification() triggers animation in UnifiedMessageListView 2. PreferredSizeChanged() cancels the animation and deletes all removed notifications. 3. As |this| is already null, it crashes by use-after-free. So calling DisableNotification() at the end is also important to make the animation work properly. This is M72 ReleaseBlock-Stable. TEST=NotificationViewMDTest.TestDeleteOnDisableNotification BUG=924922 Change-Id: I25d2d345b146b28d935f597d4e851f7caebac5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436282Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#626306}
-
Dan Beam (slow until 1/29) authored
This reverts commit 340e6008. Reason for revert: this was just on the off chance WebUI Dark Mode made it in M73. It's probably not going to, but either way: no longer need this temporary change in. Original change's description: > WebUI Dark Mode: force user manager and print preview into light mode > > This is in the unlikely event that dark mode actually makes it in 73. > These UIs are not ready yet. > > R=dpapad@chromium.org > BUG=883049 > > Change-Id: Iaa79feadd8d341c4b730a9a6598f42c756070613 > Reviewed-on: https://chromium-review.googlesource.com/c/1435517 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625843} TBR=dbeam@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883049 Change-Id: I31278716430d53b1181de4da5044d158aaf33473 Reviewed-on: https://chromium-review.googlesource.com/c/1437746Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626305}
-
Chris Palmer authored
Give an example of a trivial grammar. Tweak some wording. Add some internal links. Bug: None Change-Id: I28e5fd06906f347dde558fe08b02221ba075189a Reviewed-on: https://chromium-review.googlesource.com/c/1437896 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626304}
-
Dan Beam authored
R=aee@chromium.org BUG=883049 Change-Id: I59f447ca7e21e7b2e8db4f8686e0739e8e68eaf7 Reviewed-on: https://chromium-review.googlesource.com/c/1437579Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626303}
-
Takuto Ikuta authored
This change extracts param data related struct only used in mojom cc files to another header file, params-data.h. And only mojom cc files include params-data.h. By extracting structs, this CL reduces total size of included files from compiles including mojom headers. This CL reduces total size of generated header files when building chrome. mojom-shared.h: 9576659 -> 6343886 mojom-shared-internal.h: 7552016 -> 3053172 And this helped to reduce compile time. e.g. obj/content/browser/browser/navigation_url_loader_impl.o: 25.6s -> 22.7s in Z840 Linux chrome build time on 24C/48T Z840 Linux reduced from 3478.5s to 3385.5s. Bug: 922875 Change-Id: I0e233e6046f9b47d6386ea24ea911da638b6aa69 Reviewed-on: https://chromium-review.googlesource.com/c/1436286 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#626302}
-
Stefan Zager authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g-pdQdSR0HI/LY6lcGKOCgAJ Bug: 827639 Change-Id: I4f99a90794badc546bfda7e9af1aeb5d4f0a09bd Reviewed-on: https://chromium-review.googlesource.com/c/1437497 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626301}
-
Miguel Casas authored
This CL reenables the pixel tests disabled in crrev.com/c/1436081 since the reference images should have been regenerated by now. Bug: 922218 Change-Id: Ic0f0d054e92be935041a41812507d062a166ae8d Reviewed-on: https://chromium-review.googlesource.com/c/1437777 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626300}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a8c86c2b674e..b600f15d3895 git log a8c86c2b674e..b600f15d3895 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 thestig@chromium.org Remove optional parameter from CFWL_Edit::SetText(). 2019-01-25 thestig@chromium.org Add destructors for CFWL_Edit subclasses. 2019-01-25 thestig@chromium.org Make CFWL_Barcode's status an enum. 2019-01-25 thestig@chromium.org Add BC_LAST to enum BC_TYPE. Created with: gclient setdep -r src/third_party/pdfium@b600f15d3895 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0ef35efd072cb2c447034d8d8b0c6866c4b8e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/1437724Reviewed-by:
-
Xiaohui Chen authored
* Remove old feature flag and commandline params * Update first_run to use the new assistant flag Bug: b:120553209 Test: locally build and run Change-Id: Id1ad774fbf4adbdff12b37ad93c3b4851f3c2d27 Reviewed-on: https://chromium-review.googlesource.com/c/1436149 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#626298}
-
