- 06 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f509345ab9f..57ea1fcb74d6 2021-01-05 csmartdalton@google.com Convert GrTriangulator to a class 2021-01-05 fmalita@chromium.org [svg] Deferred text position adjustments 2021-01-05 csmartdalton@google.com Don't use the tessellator if caps.avoidStencilBuffers is set 2021-01-05 brianosman@google.com Guard against Inf/NaN when constructing circular blur textures 2021-01-05 johnstiles@google.com Add support for `number(boolean)` and `boolean(number)` casts in SkSL. 2021-01-05 borenet@google.com [infra] Remove jobs for no-longer-existing ChromeOS devices 2021-01-05 mtklein@google.com Stop calling schedule() 2021-01-05 brianosman@google.com Reland "SkRuntimeEffect: Test matrix inverse() intrinsic" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I33728cd6baebaa1a16797c9d4a0e98eb9546e975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840430}
-
David Black authored
Before: http://shortn/_L6D4o1zrki After: http://shortn/_MuXhA5lF6T Bug: 1163326 Change-Id: Ifed54414f0adfabc289d9f90f665226a7300d099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612050 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840429}
-
Ben Reich authored
When sharding browser tests they need access to the isolated task directory to ensure no clashing of output when writing out the coverage files. Pass it through as a command line switch when the gn arg use_javascript_coverage=true is passed in. CL:2584416 enables the redirection of coverage files to the supplied path in the Files browser test harness. The browser test harness independently writes out the coverage files to a supplied directory so in the merge_results.py script we ensure the output directory exists before writing the merged files. --devtools-code-coverage=/some/directory Bug: 1113941 Test: browser_test --gtest_filter=*FilesApp* Test: https://chromium-swarm.appspot.com/task?id=5077deb238ad7610 Change-Id: I8bb6d6640e2ce74d9d01805b3746b6303e11a21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584375 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#840428}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609869437-3a75c705c558e60abdee705e3f24c9125b018e03.profdata to chrome-win64-master-1609880376-433e631db9acaf4e4400335821e1ac4c51c26057.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iac0a72f926c62400f924a4953de2c3dadbe0bf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611989Reviewed-by:
-
Xiaoqian Dai authored
The two flags are "drag-to-snap-in-clamshell-mode" and "multi-display-overview-and-split-view". TODO: - clean up the feature flags in the following CL. Bug: 1143342, 1143331 Change-Id: I13739a3856a37af6f33ad0e41632331c2d2c6884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600219Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#840426}
-
Victor Costan authored
Change-Id: I7ab1de6fcc9b6778ce29e1fdd85d3e926dcfe0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610632Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840425}
-
Tarun Bansal authored
This code is no longer in use. Change-Id: I2ec05b8b3106b630260e82880cf31d2b8ec7eb1b Bug: 1090417,1159182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599005Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840424}
-
Pavel Yatsuk authored
This CL addresses a crash in the scenario when the tab is closed while the message is still displayed. In this scenario WebContents gets destroyed before the message is dismissed by auto-dismiss timer. Along with WebContents, SavePasswordMessageDelegate get destroyed. Its dtor fails on the check that the message was dismissed. This CL dismisses all messages on willCloseTab event from TabModel. BUG=1161664 R=lazzzis@chromium.org,twellington@chromium.org Change-Id: Id2b94dfe5d37f17f50ea60356a7edccc524d0778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610365Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#840423}
-
Willie Koomson authored
This change adds the DemoModeDelegate interface to ArcClientAdapter. This is used to load the Demo Session apps path for ARCVM. BUG=b:144542975 TEST=ArcDemoModeDelegateImplTest unittests; run Chrome with change and verify that it does not crash Change-Id: I703ac8e4344dc1e78531d94b0c52be576668c2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600076 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#840422}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5675ec0..c8d1d1cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7618a30190ed7f33756ac7d4ea9ad8c3fb2f8c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840421}
-
Jeremy Roman authored
flat_map can be more efficiently constructed when it only has to sort once, which can be done by constructing the initial data in a vector (and ideally, as here, by reserving its capacity). Change-Id: Iea865434fe17c7b06a21d62565b447332c521cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605881 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#840420}
-
Jeremy Roman authored
HintsChecker::sequence_checker_ is made effective, which may cause the checker to discover previously unknown sequence bugs if any exist. class contains no non-const data or any other apparent reason to require a sequence checker. DecisionTreePredictionModel: :sequence_checker_ is removed, since that Change-Id: I4c62720d62e2cbb32ea45acfcd9f482406361f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606130 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Xinghui Lu authored
We plan to add referrer to real time URL check and would like to know the latency of obtaining referrer from Safe Browsing navigation observer. We don't plan to preserve these metrics for a long time, so they are set to be expired in three months. Metrics added: SafeBrowsing.NavigationObserver.IdentifyReferrerChainByEventURLTime SafeBrowsing.NavigationObserver.IdentifyReferrerChainByWebContentsTime SafeBrowsing.NavigationObserver.AppendRecentNavigationsTime Bug: 1161342 Change-Id: I1fc9431aa37cfd472bffebdbdda26bcbd352c632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601544 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840418}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/973bd4ba0f57..e91097bf3a24 2021-01-05 jmadill@chromium.org Vulkan: Clean up "actual"/"intended" naming. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I50fbb8ad39199b82d426e03c28ecaec3dae0782c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611987Reviewed-by:
-
Ana Salazar authored
Log every time the holding space tray changes visibity in the shelf. This change uses the histogram: HoldingSpace.Pod.Action.All to log the pod visibility changes. We add two enum values: kShowPod and kHidePod. Additionally, we changed the name for the existing enums kShow and kClose to kShowBubble and kCloseBubble to make a clear distintion between the visibility of the pod and the visibility of the bubble. Bug: 1162125 Change-Id: I5d15e2c0e8e51b4f29e031e86c0e1531d27e5a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607644 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#840416}
-
Erik Chen authored
The API is unused. The only extension that was allowed to use the API has been in delete-on-install mode since March 2019. Bug: 914525 Change-Id: I0073c1ad9b2527f6236114bc23e6bcf36a44d4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597934Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Toni Barzic authored
Do not reinitialize holding space keyed service delegates on suspend done if they're already initialized. HoldingSpaceKeyedService may get initialized after associated SuspendImminent was dispatched, in which case delegates may still be around (and calling Init more than once may crash, as persistence delegate may try to invoke persistence restored callback twice). BUG=1163203 Change-Id: I066e0b84703098326f9380c54f010b9202272dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611408 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ed37cbced6f..f257fc7a7055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158906 Tbr: kmoon@google.com Change-Id: Idddb94b8bb4d57103b7900d8de7d2527afb3dc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Kahmy Moon <kmoon@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840413}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7afe3e8177253c6c4eca910cf7620c77521c7fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612145Reviewed-by:
-
Alexander Surkov authored
inspect's scripting Support inspect property filters such as a textbox.AXRole, where |textbox| is DOM id attribute of an HTML element which allows to create easy-to-read scripting scenarios. Bug: 1136957 Change-Id: Ia69466c9692bd2fe385cfa23a3224df22f215a90 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586117 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840411}
-
Philip Rogers authored
This patch removes unused ComputedStyle "style_" variables from LayoutNG tests. When possible, the SetUp override has also been removed. Change-Id: I12e590fded2afa9885f41c36bd5ae5d6c1c881f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612111 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840410}
-
Daniel Rubery authored
This usage was safe, since if the PasswordProtectionRequestion was destroyed, |url_loader_| would be destroyed as well and not call the callback. But the usage should be either documented with that reasoning or removed, and we already have WeakPtrs set up for the PasswordProtectionRequest. Change-Id: I30f2f5fc5d3383f942d0ad3dc01584c69c25ed25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612027 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840409}
-
Ryan Heise authored
Change chromeos-kevin-builder-perf-fyi mb_config to be the same as every other chromeos-kevin builder Bug: chromium:1159607 Change-Id: I2f279d59d7d96927d34bba059daa4d74df10e4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611498Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#840408}
-
Findit authored
This reverts commit b6b27b58. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840380 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I2YjI3YjU4N2JiOWY2NGJkNjIzMTc5YTFkZmQxNmYzNzQwMDZkNjcM Sample Failed Build: https://ci.chromium.org/b/8858901594834267904 Sample Failed Step: compile Original change's description: > Roll Perfetto from f9a1b53d2809 to 325d666beb8f (6 revisions) > > https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..325d666beb8f > > 2021-01-05 primiano@google.com Speculative fix of NaCL build > 2021-01-05 primiano@google.com Merge "Win port: Disable android_{stats,internal} at build time" > 2021-01-05 primiano@google.com Merge "Windows port: LITTLE_ENDIAN, ENTRYPOINT and minor test fixes" > 2021-01-05 treehugger-gerrit@google.com Merge "Rename client factory files." > 2021-01-05 primiano@google.com Merge "Checkout test data directly in /test, remove symlink" > 2021-01-05 primiano@google.com Merge "base: Port subprocess to Windows" > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel > Bug: chromium:174454879 > Tbr: perfetto-bugs@google.com > Change-Id: I3b4f07f671b66c670b80cd7347ed975dc9cdcc5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611887 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#840380} Change-Id: I644e048267c98f9f423abcbdab9a107ab4559ef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:174454879 Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612091 Cr-Commit-Position: refs/heads/master@{#840407}
-
Wan-Teh Chang authored
Update to the dav1d 0.8.1 release. https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/ea65e1abc519..441e643915be $ git log ea65e1abc..441e64391 --date=short --no-merges --format='%ad %ae %s' 2021-01-01 janne-vlc Update NEWS for 0.8.1 2020-12-16 gramner CI: Run multithreaded tests using thread sanitizer (tsan) 2020-11-23 martin arm32: mc: Add NEON implementation of emu_edge for 16 bpc 2020-11-25 martin arm32: mc: Add NEON implementations of the w_mask functions for 16 bpc 2020-09-03 martin arm32: mc: Add NEON implementation of the blend functions for 16 bpc 2020-11-25 martin arm64: mc16: Get rid of one instruction in blend_v w16 2020-12-01 martin arm32: mc16: Fix column alignment in the warp function 2020-11-24 martin arm32: mc: Improve scheduling in blend_h 2020-11-24 martin arm32: mc: Use a replicating vld1 to all lanes in one place 2020-11-23 martin arm32: mc: Use two-word replicating loads in emu_edge 2020-11-24 martin arm32: mc: Back up and restore fewer registers in blend_h/blend_v 2020-11-24 martin arm32: Use ldrd for loading two parameters from the stack Created with: roll-dep src/third_party/dav1d/libdav1d R=dalecurtis@chromium.org Change-Id: Ia48e160a881dde4f95a81c8d047b2e9167251a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612105 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840406}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609858728-3e92b62c0c1af42b6c3d7f7431a7286c240b0146.profdata to chrome-win32-master-1609869437-72e3039165a5f03888cbec3c10f727c8e1a8e480.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I86ad8cf2ccc9d78c4ddbff539575b874deeab70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611889Reviewed-by:
-
Joel Hockey authored
Crosh (chrome-untrusted://crosh) will be hosted in lacros, and process_proxy must be included in lacros. Bug: 1161413 Change-Id: If4a082484291f06ec5c042c33eddb6976707824e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608103Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81098e59adfc..7e7351226820 2021-01-05 sokcevic@google.com Revert "Use HEAD instead of hardcoded branch" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155492 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iaffdce1b1dd0c48d040b0852eade636d716aaff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611986Reviewed-by:
-
Lukasz Anforowicz authored
RFC7159 requires the control characters (U+0000 through U+001F) to be escaped, but in practice these characters might still appear in JSON resources on the web. To ensure that CORB protects such resources, this CL modifies CrossOriginReadBlocking::SniffForJSON so that it ignores control characters. This CL should be safe wrt backcompatibility, because `kYes` answer from sniffing would still indicate that the input is not valid Javascript. For example, the following is not valid Javascript, even if the string contains a control character: { "... <unescaped control character here> ..." : ... } Fixed: 1148397 Change-Id: I368a6971a911618344b4886f7c7ccc2f95d6187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596879 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840402}
-
Adrienne Walker authored
These started flaking after the patch from this review landed: https://chromium-review.googlesource.com/c/chromium/src/+/2589117 That patch added an early IsFeatureEnabled check which caused a data race with the ScopedFeatureList usages in the appcache unit tests. Avoid this data race by deferring calling GetDefaultStoragePartition and constructing the WeakPtrFactory for the storage partition until after the appcache tests have a chance to set the feature list. Bug: 1162415 Change-Id: If5a708155a7cb35a41433ca4176cd42a05c28844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612029 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840401}
-
Ian Struiksma authored
2 Autofill tests are failing for various reasons (see individual bugs for details), so disabling until we do some re-recording. Also disabling 1 password manager test. Bug: 1140567 Change-Id: I5de917594c5c37ff9ec4158c45defe64c8f41cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600794 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840400}
-
Tomasz Wiszkowski authored
Bug: 1158456 Change-Id: I83141e1deffceef81e0e9d1928834dfe3f0783cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596252 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Patti authored
Python2 used to support 0-prefixed integers for octals. Python3 removed that in favor of the 0o prefix syntax. Fix the syntax error in calculate_package_deps.py by switching out the 0 for a 0o. Bug: 1163342 Change-Id: I84f181eb75c4ad75077ed898768eb37a12c51d65 TBR: thomasanderson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612244 Commit-Queue: Patti <patricialor@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#840398}
-
Joey Arhar authored
srcElement and returnValue were specified in [1] and have WPTs in [2]. cancelBubble is documented in [3] and has a WPT which passes in all browsers in [4]. [1] https://github.com/whatwg/dom/pull/407 [2] https://github.com/web-platform-tests/wpt/pull/10258 [3] https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble [4] https://wpt.fyi/results/dom/events/Event-cancelBubble.html Fixed: 692695 Change-Id: Ia7113a9996a0e272829a3e81bf751412444e9ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610947Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840397}
-
spdonghao authored
Related doc: https://docs.google.com/document/d/13MZrZWXnkUhR3pdtyBbxytoAe3Jpngy5RZ-Vg4iL8yQ/edit?resourcekey=0-eSxwXfEn4bpV3w_y-b2vpQ# Bug: 1155757 Change-Id: I70c38585c2bc41ff7f094d6becbd8335a49e7004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595351Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#840396}
-
Sky Malice authored
Change-Id: If36b7a0da82d041742c4f454381a20817a3d0a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607572Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#840395}
-
David Tseng authored
Change-Id: I0f04c23422d0e1a897a8402b42f8d61a86690970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603934 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840394}
-
Yuwei Huang authored
This CL provides an experimental AudioCapturer implementation for Mac. It's only enabled in debug builds. Since Mac doesn't provide an API to capture system-wide audio, the way it works is to have the user install some kind of loopback CoreAudio plugin like BlackHole, then make it both the input and output device. The user will also need to go to the clunky "Security & Privacy" panel and give Microphone permission to our app. This setup streams audio quite well and I didn't notice any glitches, though you'll need to have everything set up correctly in order to use this experimental capturer. Bug: 1161363 Change-Id: Id79a9bc2d9a7cdc788b3f0405432b99a31d08930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601551 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#840393}
-
Jeroen Dhollander authored
This crash was introduced in my recent refactoring. Note it only happens when VLOG is enabled. Bug: N/A Test: deployed. Change-Id: Ie7029a2cf250a93778a831af95596ce02cbf8809 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612087 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840392}
-
adoneria authored
Bug: 1160010 Change-Id: Ic42d2d1c99aba531c4b1a13863670b11dd475f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597714 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840391}
-
