- 18 Jul, 2016 40 commits
-
-
mmenke authored
So that it can be removed in a followup CL. This CL also fixes saving/restoring incognito cookie stores on Android, which was not being done correctly. BUG=620770,627256 Review-Url: https://codereview.chromium.org/2103863003 Cr-Commit-Position: refs/heads/master@{#406063}
-
dfalcantara authored
* Add the ability to bold parts of a label. * Add the ability to show a tertiary label in the PaymentOption, which will later be used for phone number display. * The phone number is passed in to the PaymentOption using the new constructor via the AutofillAddress class. See crbug.com/626833 for screenshots. BUG=603635,626833 Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f Review-Url: https://codereview.chromium.org/2135573004 Cr-Original-Commit-Position: refs/heads/master@{#405900} Cr-Commit-Position: refs/heads/master@{#406062}
-
dgozman authored
Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived. (patchset #1 id:1 of https://codereview.chromium.org/2101073002/ ) Reason for revert: Decided to try another approach, see discussion in issue 622018 Original issue's description: > [DevTools] Always report encodedDataLength in Network.ResponseReceived. > > Currently, we only send encodedDataLength for redirects. However, we already know how much we read when sending ResponseReceived. This will improve reporting for failed requests, as they don't get loadingFinished with full encodedDataLength. > > BUG=622018 > > Committed: https://crrev.com/00f8f6c17d27799700974e599d6003b7f376071c > Cr-Commit-Position: refs/heads/master@{#402543} TBR=allada@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622018 Review-Url: https://codereview.chromium.org/2158073002 Cr-Commit-Position: refs/heads/master@{#406061}
-
isheriff authored
TBR=thestig@chromium.org BUG=484351,484852 Review-Url: https://codereview.chromium.org/2156123003 Cr-Commit-Position: refs/heads/master@{#406060}
-
thakis authored
git grep'd for "more then", "less then", "greater then". (Interestingly, no hits for "fewer then".) BUG=none NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2157963002 Cr-Commit-Position: refs/heads/master@{#406059}
-
jaepark authored
BUG=628054 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2149153003 Cr-Commit-Position: refs/heads/master@{#406058}
-
agrieve authored
It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none Review-Url: https://codereview.chromium.org/2149173002 Cr-Commit-Position: refs/heads/master@{#406057}
-
cfroussios authored
Password manager uses a switch to allow the user to override the auto-detection of the appropriate password store. OSCrypt should respect this switch as well. The switch value is read and passed to OSCrypt at a very early point in Chrome's start, before any of OSCrypt's dependents use it. I also reworked OSCrypt's build to make it simpler for chrome to deduce whether the linux implementation of OSCrypt will be used. - Previously, os_crypt_linux was used only if we also decided to link at least one linux backend. Otherwise we used os_crypt_posix. + Now, we always use the linux implementation for linux. If no KeyStorage is linked, the linux implementation defaults to the same behavior as for posix. This CL is a fixed version of https://codereview.chromium.org/2118443002/ BUG=602624 Review-Url: https://codereview.chromium.org/2159743002 Cr-Commit-Position: refs/heads/master@{#406056}
-
msramek authored
This is a followup to https://codereview.chromium.org/1838333004/ where it was added to the history WebUI. Folio: https://folio.googleplex.com/chromenarnia/Clear%20Browsing%20Data%20&%20History/MD%20Update What's not seen on Folio, but was discussed offline: Although it's positioned in the side bar, the footer should not behave like a paper-item. Only the link itself should be clickable. Update: https://screenshot.googleplex.com/s2yAqZ05yXT - this is a new screenshot after the side-bar layout changed (used to be static, after https://codereview.chromium.org/2020963002/ it's hidden under the hamburger menu. BUG=595332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2088093004 Cr-Commit-Position: refs/heads/master@{#406055}
-
lushnikov authored
This patch rolls protocol descriptor copies in the front_end folder, which are used by the hosted mode. BUG=none TBR=dgozman Review-Url: https://codereview.chromium.org/2159883002 Cr-Commit-Position: refs/heads/master@{#406054}
-
pmonette authored
CONTINUE_ON_SHUTDOWN means the thread running the task will not be joined on shutdown and may not have a valid singleton/lazy_instance at that moment. Also made DhcpcsvcInitSingleton explicitly leaky to avoid the AssertSingletonAllowed() dcheck. BUG=478209 Committed: https://crrev.com/de7e9038663d69356e558764d5a7b215e8b49b5b Review-Url: https://codereview.chromium.org/1904273002 Cr-Original-Commit-Position: refs/heads/master@{#390125} Cr-Commit-Position: refs/heads/master@{#406053}
-
lushnikov authored
Since protocol split, the generate_protocol_externs.js CLI has to accept both protocol files as input. BUG=none R=dgozman Review-Url: https://codereview.chromium.org/2158063002 Cr-Commit-Position: refs/heads/master@{#406052}
-
dgrogan authored
De-duplicate; narrow a condition; fix a method that did the opposite of its name; add comments, etc. No new tests because there _should_ be no behavior changes. BUG=613728 Review-Url: https://codereview.chromium.org/2153283002 Cr-Commit-Position: refs/heads/master@{#406051}
-
jbudorick authored
BUG= Review-Url: https://codereview.chromium.org/2147223005 Cr-Commit-Position: refs/heads/master@{#406050}
-
jmadill authored
https://chromium.googlesource.com/angle/angle.git/+log/4c32feb..5bc93c4 BUG=621031,628052,612066 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2158003002 Cr-Commit-Position: refs/heads/master@{#406049}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b4db493..9b382ab2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2158943002 Cr-Commit-Position: refs/heads/master@{#406048}
-
dpapad authored
BUG=628987 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2158043002 Cr-Commit-Position: refs/heads/master@{#406047}
-
fdoray authored
With this CL, the following histograms are recorded with a suffix indicating the number of startups with the same version: - Startup.BrowserMainToRendererMain - Startup.BrowserMessageLoopStartTime - Startup.BrowserMessageLoopStartTimeFromMainEntry - Startup.BrowserOpenTabs - Startup.BrowserWindowDisplay - Startup.FirstWebContents.MainFrameLoad2 - Startup.FirstWebContents.MainNavigationFinished - Startup.FirstWebContents.MainNavigationStart - Startup.FirstWebContents.NonEmptyPaint2 - Startup.LoadTime.ExeMainToDllMain - Startup.LoadTime.ProcessCreateToDllMain - Startup.LoadTime.ProcessCreateToExeMain - Startup.SystemUptime - Startup.TimeSinceLastStartup BUG=580211 Review-Url: https://codereview.chromium.org/2117373003 Cr-Commit-Position: refs/heads/master@{#406046}
-
kmarshall authored
* Change BlobChannel PutBlob() Mojo IDL to use shared memory handles instead of a byte array. * Create "SharedMemoryBlob" class for encapsulating Mojo shared memory initialization and lifetime management semantics. * Add BlobChannelSenderProxy class, which manages interactions with the renderer side of the BlobChannel IPC interface. * Add Blimp-specific run_all_unittests.cc, which bootstraps the Mojo environment before executing unittests. R=wez@chromium.org CC=maniscalco@chromium.org BUG=600719,614564 Review-Url: https://codereview.chromium.org/2033013003 Cr-Commit-Position: refs/heads/master@{#406045}
-
reveman authored
Allows widget close animations to use the scale assigned to shell surface at the time it is destroyed. BUG=628932, b/29082277 Review-Url: https://codereview.chromium.org/2157863002 Cr-Commit-Position: refs/heads/master@{#406044}
-
thomasanderson authored
This fixes a race condition where: 1. We get a ConfigureNotify event that tells us the window was resized and as a result post a delayed resize task 2. The window is resized 3. The delayed resize task runs and resizes the window to the old size The symptom experienced by this bug could be seen with tooltips which reuse the same window for each tooltip. If a window was resized to be larger, we would only render in the smaller area and garbage data would fill the rest. BUG=442111 Review-Url: https://codereview.chromium.org/2154483002 Cr-Commit-Position: refs/heads/master@{#406043}
-
gogerald authored
BUG=628046 Review-Url: https://codereview.chromium.org/2149163002 Cr-Commit-Position: refs/heads/master@{#406042}
-
rajendrant authored
ExternalDataUseReporter class is created with the data use reporting logic. ExternalDataUseReporter is created in IO thread and moved to UI thread. It is owned by ExternalDataUseObserver. BUG=570884 Review-Url: https://codereview.chromium.org/2145863002 Cr-Commit-Position: refs/heads/master@{#406041}
-
varkha authored
Changes the parent of search widget labels and close buttons in overview mode to be kShellWindowId_StatusContainer which is still above all windows but below menus and screen overlays. BUG=629039 Review-Url: https://codereview.chromium.org/2154323002 Cr-Commit-Position: refs/heads/master@{#406040}
-
clamy authored
We've seen a sharp augmentation of renderer hangs on Android. This histogram is meant to help identify the root cause of this renderer hangs, since it's currently hard to distinguish whether this is happening during normal browsing or during beforeunload/unload/when the page is closing. BUG=621303 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2136173003 Cr-Commit-Position: refs/heads/master@{#406039}
-
pkotwicz authored
BUG=None Review-Url: https://codereview.chromium.org/2149873002 Cr-Commit-Position: refs/heads/master@{#406038}
-
sdefresne authored
BUG=None Review-Url: https://codereview.chromium.org/2159763002 Cr-Commit-Position: refs/heads/master@{#406037}
-
rouslan authored
When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG=624924 Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea Review-Url: https://codereview.chromium.org/2116583002 Cr-Original-Commit-Position: refs/heads/master@{#405876} Cr-Commit-Position: refs/heads/master@{#406036}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d2b666834a28..3c2ec02098fa $ git log d2b666834..3c2ec0209 --date=short --no-merges --format='%ad %ae %s' BUG=628239 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2162583002 Cr-Commit-Position: refs/heads/master@{#406035}
-
jshin authored
This should go in after https://chromium-review.googlesource.com/#/c/349730/ is landed. Update install-chromeos-fonts.py to install the latest notofonts and roboto font packages for CrOS. R=dzhioev BUG=617281 TEST=OOBE screen still use Roboto CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2043883004 Cr-Commit-Position: refs/heads/master@{#406034}
-
rockot authored
Fixes a missing lock acquisition from the listener thread when accessing |channel_|. Also removes the TSAN suppression for this bug. BUG=628481 TBR=glider@chromium.org for suppression removal Review-Url: https://codereview.chromium.org/2158893002 Cr-Commit-Position: refs/heads/master@{#406033}
-
cco3 authored
Double.compare and Long.compare were introduced in api 19, but the minimum is api 16. This change uses compareTo instead. BUG=628711 Review-Url: https://codereview.chromium.org/2157663002 Cr-Commit-Position: refs/heads/master@{#406032}
-
jasonroberts authored
BUG= internal b/30144624 Review-Url: https://codereview.chromium.org/2154513002 Cr-Commit-Position: refs/heads/master@{#406031}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/490c07d77670..6451a0cea600 $ git log 490c07d77..6451a0cea --date=short --no-merges --format='%ad %ae %s' 2016-07-18 robertphillips Add makeSpecial calls to SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161533003 2016-07-18 fmenozzi Add filename to gradient scrape 2016-07-18 jcgregorio Revert of remove unused TableMaskFilter (patchset #1 id:1 of https://codereview.chromium.org/2156463002/ ) 2016-07-18 bsalomon In GrShape detect that stroked axis-aligned lines are rrects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=jcgregorio@google.com Review-Url: https://codereview.chromium.org/2154313002 Cr-Commit-Position: refs/heads/master@{#406030}
-
stip authored
BUG= Review-Url: https://codereview.chromium.org/2152413003 Cr-Commit-Position: refs/heads/master@{#406029}
-
pke authored
Implement a ContentSuggestionsProvider that reads from the OfflinePageModel, converts to ContentSuggestions and provides those to the ContentSuggestionsService. Add a chrome-flag to enable the provider and implement a factory that registers the provider with the service. The implementation is not usable by users, yet, because extraction of title, snippet text and image is not implemented. Those fields are filled with dummy data or left empty. Deduplication, sorting and discarding are also not implemented. But the OfflinePageSuggestionsProvider serves as an example for other ContentSuggestionsProvider implementations and it can be used to test multiple-section UI implementations. BUG=628198 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2149453004 Cr-Commit-Position: refs/heads/master@{#406028}
-
vmpstr authored
This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2155893002 Cr-Commit-Position: refs/heads/master@{#406027}
-
rogerm authored
This CL updates the PersonalDataManager to run autofill profile de-duplication (if enabled) at the appropriate time, depending on whether autofill profile sync is enabled. If sync is not enabled, profile de-duplication is run after the data is initially loaded. If sync is enabled, profild de-duplication is run after the sync first becomes active. In all cases, de-duplication is only run once for a given version of chromium. BUG=627519 R=sebsg@chromium.org, mathp@chromium.org Review-Url: https://codereview.chromium.org/2142123002 Cr-Commit-Position: refs/heads/master@{#406026}
-
msramek authored
BUG=589586 Review-Url: https://codereview.chromium.org/2132563003 Cr-Commit-Position: refs/heads/master@{#406025}
-
robert.bradford authored
When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2160603002 Cr-Commit-Position: refs/heads/master@{#406024}
-