- 25 Feb, 2019 40 commits
-
-
Xiaocheng Hu authored
Bug: 935629 Change-Id: I8a3c83a027dff593756897b0332dd047da0c6e2d Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487173Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635175}
-
Mike Reed authored
Bug: skia:8773 Change-Id: Icb42a9604f44c342eb18a974068ba0584dc3a740 Reviewed-on: https://chromium-review.googlesource.com/c/1476972Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#635174}
-
Steven Bingler authored
Change-Id: I2bb4ee0d3676dc29dda4de7424ab418637f59803 Reviewed-on: https://chromium-review.googlesource.com/c/1483450Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#635173}
-
Min Chen authored
Bug: 934953 Change-Id: I031a8aa7fd12057515c92d966d4255fd0e7c0a8f Reviewed-on: https://chromium-review.googlesource.com/c/1483815 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#635172}
-
Katie D authored
Missed changing function name in one place, in https://chromium-review.googlesource.com/c/1480542. Bug: 905419 Change-Id: I38c174a4899b163c58ebc99ff0fd995fb7c6c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1484580Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#635171}
-
Richard Townsend authored
A future CL will introduce a HTML parser which doesn't use the HTMLParserScheduler. This CL moves PumpScheduler outside so it can be re-used by this new parser. No behaviour changes are expected. Bug: 901056 Change-Id: I096e379f1c4adcd9ce221c241c322415995298a0 Reviewed-on: https://chromium-review.googlesource.com/c/1456013Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#635170}
-
John Delaney authored
This is a reland of 4eb465c4 Original change's description: > Measure main frame bytes and main frame ad bytes per-page > > Measure the amount of bytes directly loaded in the main frame by the > page. Record separately the total number of ad bytes loaded in the main > frame. Main frame ad bytes per page are currently recorded in > PageLoad.Clients.Ads.Resource.Bytes.TopLevelAds, but this only accounts > for network bytes. > > Rather than adding more counters to AdsPLMO, main frame data will > be stored in a separate FrameData object to reduce repetition. It > makes sense at this point to also refactor all page bytes counts to > a frame data object. This will help compartmentalize the two classes. > This change should be a no-op to existing metrics. > > Bug: 919122 > Change-Id: I83839cea1d01e375bb8d2a088be69d0911119966 > Reviewed-on: https://chromium-review.googlesource.com/c/1478091 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634320} Bug: 919122 Change-Id: I10bc30f171e4afcb7c5ed146a336848a0c5ec338 Reviewed-on: https://chromium-review.googlesource.com/c/1486372 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635169}
-
Raymond Toy authored
When a source node has been scheduled to stop but is subsequently disconnected so that it's not reachable from the destination, final processing of the node wasn't getting done, so that we think the node is still active. Implement HandleStoppableSourceNode which checks for active nodes to see if the current time is past the stop time. If so, cleanup of the node is scheduled, freeing this finished node and allowing it to be collected. Two tests added (one for OscillatorNode and one for ConstantSourceNode). Also verified the repro case from the bug shows that the nodes are collected. Bug: 717528 Test: internals/constant-source-stopped-gc.html, internals/oscillator-stopped-gc.html Change-Id: I7e8797abc9ba553b4f459db95f6ad6c8939dabf3 Reviewed-on: https://chromium-review.googlesource.com/c/1474989Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#635168}
-
Reid Kleckner authored
crrev.com/631831 removed remote_application_details.h and now check_gn_headers.py is complaining. TBR=joedow@chromium.org Change-Id: Id752208b1a524a98cd0947743ebbffccabe03563 Reviewed-on: https://chromium-review.googlesource.com/c/1487231Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635167}
-
Guido Urdaneta authored
LocalVideoCapturerSource is complex and independent enough that it should have its own file. Moreover, MediaStreamVideoCapturerSource is generic and works with other types of capturer sources. This change will facilitate maintenance of LocalVideoCapturerSource and will simplify Onion Soup since it makes MediaStreamVideoCapturerSource have fewer dependencies on content. Bug: 921006 Change-Id: Ib4afeb776fc13f41fe44240e921ff429ab7084fb Reviewed-on: https://chromium-review.googlesource.com/c/1483082Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#635166}
-
Robert Ma authored
Bug: 935208 Change-Id: Ie5e73c7fd01c46d7f033c9f2ed5522c35926bd3f Reviewed-on: https://chromium-review.googlesource.com/c/1485492 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#635165}
-
Lukasz Anforowicz authored
All renderer-initiated navigations should specify an |initiator_origin| (CommonNavigationParams::initiator_origin is a base::Optional to accomodate browser-initiated navigations and some extension APIs which need to distinguish between no origin VS a unique origin). Bug: 919144 Change-Id: I91ad5a2ecc1ac81c7f13f16f6eb281f814866411 Reviewed-on: https://chromium-review.googlesource.com/c/1474091 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635164}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2cba890d. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic6ad6e1bbb8387c4fabffe7908395702b906b63b Reviewed-on: https://chromium-review.googlesource.com/c/1486673Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635163}
-
Alex Clarke authored
Instead of a linked list of EmptyQueuesToReload we use a single atomic bit per TaskQueueImpl. Sampling the atomic flag is inherently racy wrt SequenceManagerImpl::ReloadEmptyWorkQueues. This is OK however thanks to the WorkDeduplicator which spots if a PostTask (and possibly a SetReloadFlag) occurred while DelayTillNextTask was running. Improves SequenceManagerPerfTest.PostImmediateTasks_OneQueue/3 by about 6% on Linux. Change-Id: I61943c6a3bd4fc96f063b94217767fc899962c4e BUG: 901345, 897751 Reviewed-on: https://chromium-review.googlesource.com/c/1474656 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635162}
-
Xiaocheng Hu authored
Bug: 935607 Change-Id: Idca5f854c7cc85741d4fcbe2db5e9c12bcab08dd NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1486719Reviewed-by:
-
liberato@chromium.org authored
VideoResourceUpdater can't currently convert hw VideoFrame resources into sw planes in sw comspositing mode, since it isn't given a context provider to use for the conversion. This CL causes it to fall back to software video decoding in that case. Note that adding support to VideoResourceUpdater isn't terribly difficult, but might be crashy. The rough sketch is here: https://chromium-review.googlesource.com/c/chromium/src/+/1483680 Bug: 932879 Change-Id: I3b05e17fce40b9095de7eb6bc5ef64645a69a11b Reviewed-on: https://chromium-review.googlesource.com/c/1484073Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635160}
-
Chris Hall authored
Comment had a 'not' which was likely a mistake, the Add*Attribute methods all remove the attribute if it already exists before adding. R=aboxhall,dmazzoni Change-Id: Iaf0bc259ba8c6e9f64f4b443935ff01979ca893d Reviewed-on: https://chromium-review.googlesource.com/c/1485613 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635159}
-
John Abd-El-Malek authored
Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114 Change-Id: If1534e7eb5a16871cd3610f5d17c015e40b6ed6b Reviewed-on: https://chromium-review.googlesource.com/c/1479637Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#635158}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=avi@chromium.org Bug: 714018 Change-Id: I8214a621e6110e956dfc09b89f47b5858a9723d5 Reviewed-on: https://chromium-review.googlesource.com/c/1486117 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#635157}
-
Andrew Grieve authored
Other related changes: * Tiger viewer uses full_name for dex nodes (parameters & return types) * Add return value & field type to Dex symbols as: org.Class#someFunction(...): ReturnType * template_name and full_name for dex fields now follow same format as methods (using #): "org.Class#mField: type" Bug: 912814 Change-Id: I3f6dc056ec4abb0a8c4c90fa5f556eaccb7f6e38 Reviewed-on: https://chromium-review.googlesource.com/c/1485013Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635156}
-
Xiaocheng Hu authored
Bug: 935595 Change-Id: Idd3a7a67120fd25bb05869d7be034275e5785c6b NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1487091Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8747978ce6f5..afb82004c0be git log 8747978ce6f5..afb82004c0be --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com traceconv: update shas for trace_to_text Created with: gclient setdep -r src/third_party/perfetto@afb82004c0be The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idec07fe74f48c11c6ae957c9653677cce8dc5579 Reviewed-on: https://chromium-review.googlesource.com/c/1486832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635154}
-
Dmitry Gozman authored
Since we produce code cache asynchronously, content might already be invalid, e.g. due to frame detach. Added a test which catches the issue in 2 of 10 runs. Bug: none Change-Id: Ie4368b2a9dce68d236a7310900488056a9e20765 Reviewed-on: https://chromium-review.googlesource.com/c/1483365Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635153}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b1953a0012f..9eb111e85e7e Created with: gclient setdep -r src-internal@9eb111e85e7e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4ecfa96c743dcd96d212d0c6fbe51f5eb90b3592 Reviewed-on: https://chromium-review.googlesource.com/c/1486833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635152}
-
Nico Weber authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/37a60998cade..30153b4eb581 $ git log 37a60998c..30153b4eb --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thakis breakpad: Remove semicolons, mac edition. Created with: roll-dep src/third_party/breakpad/breakpad Bug: 926235 Change-Id: I675d9e89a94499be37e76719b687fb3709f52094 Reviewed-on: https://chromium-review.googlesource.com/c/1486715 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635151}
-
Morten Stenshorne authored
Remove NGInlineChildLayoutContext from NGBlockLayoutAlgorithm. This structure is quite big, and since we stack-allocate the alogorithms, this matters. Only stack-allocate NGInlineChildLayoutContext on demand (when children are inline). This saves 816 bytes [*] of stack space per in-flow layout recursion. [*] Linux 64bit release. Bug: 930637 Change-Id: I40c12cb6e7996e54c9bf3ebe7285350591c90fef Reviewed-on: https://chromium-review.googlesource.com/c/1485238Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635150}
-
Aaron Krajeski authored
ImageBitmapRenderingContext.toDataURL() does not throw CORS errors when reading from a tainted canvas. It is not super urgent right now as the entire functionality is broken, it simply returns black pixels, so there is no security vulnerability RIGHT now. Regardless once https://bugs.chromium.org/p/chromium/issues/detail?id=838108 is fixed, it will expose a problem. Currently toDataURL() in dev builds fails https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc?q=unaccelerated_static_bitmap_image&sq=package:chromium&dr=C&l=28 and on https://cs.chromium.org/chromium/src/cc/paint/paint_image_builder.cc?dr=C&q=paint_image_builder&sq=package:chromium&g=0&l=47 not sure when this was introduced, but as of now we have no tests for toDataURL(). toDataURL() with LOCAL images also appears to be broken for ImageBitmapRenderingContext, as it just returns empty images. Will add tests and try to fix those problems in other CLs Bug: 930057 Change-Id: Id22d22310ae2130472f1a3cbc104cfe632a7129c Reviewed-on: https://chromium-review.googlesource.com/c/1474546Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635149}
-
Nico Weber authored
Bug: 926235 Change-Id: I9f9018856c94a6863ab04f7cb058abc0d9645840 Reviewed-on: https://chromium-review.googlesource.com/c/1486713 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635148}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/507158f88d4d..e3b205b1202f git log 507158f88d4d..e3b205b1202f --date=short --no-merges --format='%ad %ae %s' 2019-02-25 nigeltao@google.com Update Wuffs version Created with: gclient setdep -r src/third_party/skia@e3b205b1202f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If10424bd21f79e15445f3e9210ecc6a9ae5b2f4a Reviewed-on: https://chromium-review.googlesource.com/c/1486511Reviewed-by:
-
Eugene But authored
Return non-zero rect from WKWebView.frame to avoid DCHECK. Additional changes: - rename mock_wk_list_ to fake_wk_list_ - create fake_wk_list_ in SetUp - consistently use OCMock3 API Bug: 935056 Change-Id: I1ce700ad1fd0db03230535fa72799699a26c0ccd Reviewed-on: https://chromium-review.googlesource.com/c/1484973 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635146}
-
Emily Hanley authored
This reverts commit 234e5b3a. Reason for revert: <INSERT REASONING HERE> Original change's description: > Batch Histogram uploads. > > Some benchmarks such as rendering.mobile produce more data than the chromeperf > dashboard can handle at once. > This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch > histograms into multiple files, then uploads them one at a time. > > Bug: chromium:909961 > Change-Id: Ia3e16657c6bf0bfbf0e1da9671ebe0852f9e70d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1478085 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Commit-Queue: Ben Hayden <benjhayden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634220} TBR=benjhayden@chromium.org,simonhatch@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:909961 Change-Id: Ie3bd895037266bd88e31f1275b784a86f8ed23c3 Reviewed-on: https://chromium-review.googlesource.com/c/1486679Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635145}
-
Jérôme Lebel authored
Opens the sync encryption dialog when the user taps on the "Encryption" item. Bug: 914059 Change-Id: I5a750107f2594e64c4d81e468a47c8a7607e5286 Reviewed-on: https://chromium-review.googlesource.com/c/1477237 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635144}
-
Yi Su authored
ios_web_shell_egtests.PDFTestCase can be removed now since it's covered by WebStateObserverTest.PdfFileUrlNavigation. Bug: 930859 Change-Id: I5bfc34f825908b1380e52a7eb1e0a20450033661 Reviewed-on: https://chromium-review.googlesource.com/c/1486533 Commit-Queue: Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635143}
-
Scott Haseley authored
There were some cases where if BeginMainFrameNotExpectedSoon was not sent when the scheduler initally stopped observing frames, it would not be sent when the client (blink scheduler) needed it. This led to requestIdleCallback getting stuck in a state where idle tasks would queue but not run since the blink scheduler was unaware the the CC was in a long idle state. This CL splits the NOTIFY_BEGIN_MAIN_FRAME_NOT_SENT -- which could have resulted in either BeginMainFrameNotExpected[Until|Soon] messages being sent -- into two separate actions. If the scheduler is in a long idle period and has not already send a BeginMainFrameNotExpectedSoon message in that frame, it will now send one when requested. This also adds several unit tests: - Test for not sending more than one BeginMainFrameNotExpected* message in the same frame. - Test that BeginMainFrameNotExpectedSoon is sent if it wasn't initially needed when entering a long idle period. - Test that BeginMainFrameNotExpectedSoon is sent when requested if it wasn't initally, even if BeginMainFrameNotExpectedUntil was sent in the frame (this previously failed). - Test that BeginMainFrameNotExpectedSoon is sent when requested if it wasn't initally, even if visibility changed to false while inside of BeginImplFrame (this previously failed). Bug: 893653 Change-Id: I242aa5aa247200993f837fc577e18d4e27c4a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1474806 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#635142}
-
Roman Sorokin authored
s/QuitWhenIdle/Quit Bug: none Change-Id: Ideb2560ec8ba637e4b29644a73e9a32e68cba724 Reviewed-on: https://chromium-review.googlesource.com/c/1482980Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f408608..d7d9726d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I931698add5214f076f952028527fd589f0be13cf Reviewed-on: https://chromium-review.googlesource.com/c/1486116Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635140}
-
Michael Lippautz authored
Canonical fix: - Model liveness through PannerNode (AudioNode), i.e., keep alive listener from there. - Change off-thread handler to use a weak root This works as AudioNode disposes the handler in the pre-finalizer. Bug: 928781, 843903 Change-Id: I3b7454adcfbd2ab2c993974c3cda0415c1a20427 Reviewed-on: https://chromium-review.googlesource.com/c/1486092Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Bug: 935587 NoTry: True Tbr: xiaochengh@chromium.org Change-Id: Ic438a578728b6cfe4a5897dd22c37af5606fe3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1486835Reviewed-by:
-
Fredrik Söderquist authored
This enumeration value is only used during style resolution, and thus there should be no need to handle it elsewhere. This allows cleaning up the ShouldFullyInvalidateFillLayersOn*Change helpers as well, removing the only users of StyleImage: :UsesImageContainerSize() and in turn also Image: :UsesContainerSize(), so removing those as well. Change-Id: I6400ca9acf98359712891fc74e1a232a2cfbc208 Reviewed-on: https://chromium-review.googlesource.com/c/1486354Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635137}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8deadd8d022c..b92fa105572a git log 8deadd8d022c..b92fa105572a --date=short --no-merges --format='%ad %ae %s' 2019-02-25 cwallez@chromium.org KnownObject: Make it an error to request ID 0 Created with: gclient setdep -r src/third_party/dawn@b92fa105572a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934360 TBR=cwallez@chromium.org Change-Id: I07642d4fcad4e3339bf6becf4ce8a8ffad92fed5 Reviewed-on: https://chromium-review.googlesource.com/c/1486065Reviewed-by:
-
