- 05 Sep, 2013 19 commits
-
-
xhwang@chromium.org authored
- Now we can notify demuxer ready as soon as the demuxer is ready. We don't need to wait for a key to be added if the stream is encrypted. - QueueSeureInputBuffer() et al return MediaCodecStatus to pass detailed status. - If no key is available the media pipeline pauses. - After a key is added we try to resume the media pipeline playback. BUG=277211,255781,281663 TEST=Start decoding without key is added and see no crash. After key is added playback resumes. R=acolwell@chromium.org, jschuh@chromium.org, qinmin@chromium.org Review URL: https://codereview.chromium.org/23545029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221331 0039d316-1c4b-4281-b951-d872f2087c98
-
etienneb@chromium.org authored
This issue was found by a linter. R=enne@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23658023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221330 0039d316-1c4b-4281-b951-d872f2087c98
-
dvh@chromium.org authored
- InstallTracker::Oberve() could trigger OnExtensionUninstalled() twice because NOTIFICATION_EXTENSION_UNLOADED notification with reason UNLOAD_REASON_UNINSTALL could be sent along with an additional NOTIFICATION_EXTENSION_UNINSTALLED. - In ComponentLoader::UnloadComponent(), change reason back to UNLOAD_REASON_DISABLE. Change how Apps Developer Tools is disabled: - Use ExtensionService::UninstallExtension() instead of ComponentLoad::Remove() to remove Apps Developer Tools. It makes the codepath consistent with regular extension uninstall. BUG=278393, 277897 Review URL: https://chromiumcodereview.appspot.com/23636002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221329 0039d316-1c4b-4281-b951-d872f2087c98
-
ikarienator@chromium.org authored
Currently chrome.usb.findDevices always yields new ids and there is no way to know the consistency among different calls. chrome.usb.getDevices API will be introduced which yields stable ids for each device and remains unchanged until the device is unplugged. API Proposal: https://docs.google.com/a/chromium.org/document/d/16OJQRjW6ZRkIQqA3qIEVFBRY3tFLFnlNXlTGJ5pgPfg/edit BUG=277139 Review URL: https://chromiumcodereview.appspot.com/22914023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221328 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221327 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG=249018 TEST=gpu_unittests, webgl conformance tests Review URL: https://chromiumcodereview.appspot.com/23534007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221326 0039d316-1c4b-4281-b951-d872f2087c98
-
harrym@chromium.org authored
Updated and/or duplicated (updated with copy renamed *ForLegacyShelfLayout) unit tests as required. BUG=246279 TBR=jamescook@chromium.org, skuhne@chromium.org Review URL: https://codereview.chromium.org/22793011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221325 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
PPB_NetworkList_Private was implemented before PP_ArrayOutput and PPB_NetAddress was added. Refactor GetIPAddress() to use these new types. Also removed in-process support because PPB_NetAddress doesn't support in-process mode. BUG=281781 TBR=piman@chromium.org (trivial changes in content_renderer.gypi) Review URL: https://chromiumcodereview.appspot.com/23806003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221324 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
BUG=243013 Review URL: https://chromiumcodereview.appspot.com/23537017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221323 0039d316-1c4b-4281-b951-d872f2087c98
-
markus@chromium.org authored
See original discussion at https://codereview.chromium.org/18656004/ Reverted as: https://codereview.chromium.org/23463010/ Added a new base::strings::SafeSPrintf() function that can safely be called from all restricted (e.g. async-signal-safe) environments. It is roughly equivalent to snprintf(). But it is easier to use, as it uses C++ to be type-safe. In release builds, this function is guaranteed to never call any other library function nor any system calls. In debug builds, we call RAW_CHECK() in some circumstances. This code is needed for (at least) the seccomp sandbox and to clean up code in the stack tracer. Those changes are pending and will be submitted as separate CLs. BUG=285499 TEST=base_unittests TBR=willchan@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221322 0039d316-1c4b-4281-b951-d872f2087c98
-
aelias@chromium.org authored
This patch fixes the tile management viewport to be the on-screen-visible rect for the last hardware draw. There are two problems I needed to solve: 1) Suppress UpdateTilePriorities from happening when the last draw was a software draw, which is specified by the new "viewport_valid_for_tile_management" bool. 2) In some cases, the clip rect is smaller than the WebView's visible viewport -- for example when the Android Browser progress bar is forcing redraws, the clip is only a small area at the top of the screen. I switched to using the visible viewport for UpdateDrawProperties + glViewport, and introduce a separate "DeviceClip" to override glScissor. (It's necessary to make the change at this level, rather than directly plumbing the visible viewport to UpdateTilePriorities, because UpdateTilePriorities also makes use of outputs from the draw properties calculation.) I also cleaned up all uses of device_viewport_size() to call DrawViewportSize() instead, with the sole exception of UnscaledScrollableViewportSize() which should continue to use the main-thread device_viewport_size_ in all cases (because that's the viewport for scrolling, not drawing). New tests: PictureLayerImplTest.SuppressUpdateTilePriorities, ExternalStencilPixelTest.DeviceClip NOTRY=true BUG=232844 Review URL: https://chromiumcodereview.appspot.com/23171014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221321 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
- Put FontConfigIPC creation in PreSandboxInit(). - Add a sanity check for being single threaded. BUG=269816 R=markus@chromium.org Review URL: https://codereview.chromium.org/23830004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221320 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
Previously, the Activity Log was disabled by default unless a flag was set or a specific app was installed. With this CL, events will be logged for everyone. However, we will only write to the database or stream to the API if the flag is set or the app is installed. BUG=276501 Review URL: https://chromiumcodereview.appspot.com/23729005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221319 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=webgl conformance tests R=bajones@chromium.org, kbr@chromium.org Review URL: https://codereview.chromium.org/23464034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221316 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=236893 R=sky@chromium.org Review URL: https://codereview.chromium.org/23760003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221315 0039d316-1c4b-4281-b951-d872f2087c98
-
etienneb@chromium.org authored
This issue was found by a linter. R=vollick@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23523027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221314 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
BUG=285350 Review URL: https://chromiumcodereview.appspot.com/23620028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221313 0039d316-1c4b-4281-b951-d872f2087c98
-
edmundyan@chromium.org authored
BUG=284547 Review URL: https://chromiumcodereview.appspot.com/23545023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221312 0039d316-1c4b-4281-b951-d872f2087c98
-
jyasskin@chromium.org authored
BUG=276610 Review URL: https://chromiumcodereview.appspot.com/23537019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221311 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Sep, 2013 21 commits
-
-
avallee@chromium.org authored
This allows creation of a transform and its inverse that would be used to counter-animate some child layer. BUG=270857 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220124 R=vollick@chromium.org, wittman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220479 Review URL: https://chromiumcodereview.appspot.com/22861008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221309 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=285398 R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/23450018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221308 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221307 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157245:157250&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/23499009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221306 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
BUG=284513 Review URL: https://chromiumcodereview.appspot.com/23927006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221305 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=170921 TEST=no change Review URL: https://chromiumcodereview.appspot.com/23684030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221304 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=268937 TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients TBR=tim (for chrome/browser/sync) Review URL: https://chromiumcodereview.appspot.com/22581003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221303 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
This CL makes sure that an input method never reference to a destroyed object. We're not 100% sure why Issue 280219 is happening, but it seems a destroyed object is referenced from an input method. For render_widget_host_view_win.cc, there is no need to check the focus. Even if it's not focused, the object going to be destroyed should be removed from the TSFBridge. BUG=280219 TEST=none Review URL: https://chromiumcodereview.appspot.com/23478020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221302 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221301 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Some plugins needs to have document loaded to decide if printing is supported. This patch makes scripted print preview for plugins to wait DidStopLoading(). BUG=268778 R=cevans@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/23855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221300 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157225:157244&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/23681008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221299 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
BUG=284772 TEST=unittest Review URL: https://chromiumcodereview.appspot.com/23506029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221298 0039d316-1c4b-4281-b951-d872f2087c98
-
flackr@chromium.org authored
BUG=284891 TEST=Alt-tab and F5 button will enter overview mode without a flag. Review URL: https://chromiumcodereview.appspot.com/23534041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221297 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This is because colorama is missing license header on its files, even if LICENSE.txt is included. Note that these files are not needed for the build process to complete. R=phajdan.jr@chromium.org NOTRY=true BUG=colorama:44 Review URL: https://chromiumcodereview.appspot.com/23654007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221296 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
This is a refactoring-only change! Eliminates enums for accessibility roles, states, and notifications and uses equivalent enums from Blink instead. Saves several giant switch statements, saves a few characters per line, and makes future changes to roles and states simpler. Another benefit is that you can search for a role, state, or event and find all of the places where it's used throughout the code at once. Also renames WebAccessibilityObject -> WebAXObject and notification -> event in the context of accessibility. BUG=269034 Review URL: https://chromiumcodereview.appspot.com/23651003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221295 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
The active window is minimized only if the active web page or app does not handle the key first. BUG=284522 TEST=manual, ash_unittests AcceleratorCommandsTest.* Review URL: https://chromiumcodereview.appspot.com/23611005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221294 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Remove --[en|dis]able-new-dialog-style command-line flags. Remove the corresponding strings and about:flags entry. The new dialog style has been on-by-default since M-29. Retain DialogDelegate::UseNewStyle() for Views/Win Textfield. (new dialogs can't host the off-by-default Win Textfields) (this will go away once I remove the Views Textfield flags) Retain split DialogDelegate::UseNewStyleForThisDialog() codepaths. (we explicitly want the old style for some dialogs see Issue 246777) (task manager, about:ipc dialog, extension (cros save/open) dialog) (this could go away if we made those windows not use dialog code) BUG=166075,282698 TEST=New dialog style is used on Windows/CrOS everywhere except for the Task Manager, about:ipc dialog (Win only), and Extension (CrOS save/open) dialogs. The old dialog style is used with --disable-views-textfields for technical reasons. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/23530019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221292 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/23532042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221291 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Somehow this slipped through the cracks. BUG=none TBR=jar@chromium.org, sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/23950005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221290 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221289 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
1712: ninja: Stop lower-casing outputs on case-insensitive file systems. 1713: Convert setup.py to use setuptools 1714: ninja/mac: Support rules running on mac_bundle_resources. BUG=280718 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/23630005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221288 0039d316-1c4b-4281-b951-d872f2087c98
-