- 10 Apr, 2019 40 commits
-
-
David 'Digit' Turner authored
This CL introduces a new script that can be used to check and try to fix various locale-related files in the Chromium source directory. This is essentially a replacement for build/android/check_android_grit_strings.py that will be extended to support more features over-time, most of them not Android specific. This will be used to ease the addition of translations for new locales. Example usage: # Print list of locales supported by Chrome. build/locale_tool.py list-locales # Print list of locales supported by Chrome, as JSON build/locale_tool.py list-locales --as-json # Check all .grd and BUILD.gn for locale-related issues build/locale_tool.py check-all --scan-dir . # Does the same and tries to fix bad files. build/locale_tool.py check-all --scan-dir . --fix-inplace # Only check and fix Android .xml outputs in .grd files: build/locale_tool.py check-grd-android-outputs \ --scan-dir . --fix-inplace # Try to add android_webview .xtb outputs in .grd files # for new locales 'aa' and 'zz': build/locale_tool.py check-grd-translations \ --scan-dir android_webview/ \ --add-locales 'aa zz' \ --fix-inplace # Perform internal consistency check between this script # and the content of build/config/localges.gni build/locale_tools.py check-locales BUG=944606 R=agrieve@chromium.org, govind@chromium.org, jshin@chromium.org, estevenson@chromium.org Change-Id: I3753bb528f6a56bec94cce8ec7b5b802f438857e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553425 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649648}
-
Zhenyao Mo authored
Also, check in results for from build 3363 to 4131. Data might be deleted and lost forever at a future point. Such data is valuable to understand the issues with IPG and potential solutions for reliable power measuring. BUG=867155 TEST=manual R=sunnyps@chromium.org Change-Id: Iee41152a10993c72e13b3daff4c3d6e08ac5bee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558747 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649647}
-
ishell@chromium.org authored
With enabled pointer compression empty V8 instance reports memory usage values less than 1 MB which makes the test fail for Memory.Experimental.Renderer2.V8.* metrics. Bug: v8:7703, chromium:949157 Change-Id: I285731326732157b592efc197c1fda1a5016c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559141Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649646}
-
John Budorick authored
Follow-up to crrev.com/c/1560141 Bug: 861983 Change-Id: I8c8a51fc8b6c44b2e2e693e5746e2d370bacde53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562290 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#649645}
-
Jun Mukai authored
This adds to mark the tracing of overview enter/exit animation to ease the performance analysis. Bug: 949227 Test: manually in chrome://tracing Change-Id: Ia616dbbc8f825fd459e1253b2d60915a1f653250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560307 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649644}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051 InvalidateLayout() was changed to result in a Layout() at a later date. This means there may be an additional Layout() called. AppsGridView cancels any animations if Layout() is called. Currently, an async layout is being triggered as part of preparing for the animation. Which means the reorder animation is canceled. The fix is to explicitly force a layout (which makes the pending layout do nothing) and further ignore the layout call. BUG=949713 TEST=see steps in bug. Change-Id: I9aa887e4e49b182a2912a6c599fa26618429e1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562372Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649643}
-
Tibor Goldschwendt authored
Bug: 949154 Change-Id: Ifbaeb87a60580192780ad7f2e9c41495d50433c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550684 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649642}
-
Yining Wang authored
ManifestWebAppBrowserController is a derived class from WebAppBrowserController. It should be able to control the UI look for focus mode windows. Bug: 950182 Change-Id: I28ebe4e123a719d44a52fabe7b86bb1b92e4c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553083 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#649641}
-
Jesse Selover authored
Bug: 795089 Change-Id: I22a904cc0fb8dd1445424c6d526dbbc9bfbed788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475204 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#649640}
-
Alexander Alekseev authored
Automatic time zone detection metrics report external location provider health status and should be kept until we use this API. Bug: 933191 Change-Id: I635053e47bdb604f126c5d67ec06d4e9dedb62dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559339 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#649639}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0951cfd13e29..408a3c63d37b git log 0951cfd13e29..408a3c63d37b --date=short --no-merges --format='%ad %ae %s' 2019-04-10 noahric@chromium.org Add explicit stride options to I420BufferPool. 2019-04-10 eshr@google.com Reland "Add new field trial for controlling congestion window settings" 2019-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 23e69401..19364ba5 (649414:649524) Created with: gclient setdep -r src/third_party/webrtc@408a3c63d37b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia3c4eeaeeb9cb29fe7776347aa72bdbbc492363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649638}
-
Junbo Ke authored
Bug: b/120907590 Merge-With: eureka-internal/260345 Test: Manual test on device Change-Id: I5c2063815cbeae78761496871db1bf2e804c82a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554901Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#649637}
-
Marialicia Villarreal Garcia authored
1. This change hooks up UIA_AutomationFocusChangedEventId for views. 2. This change moves NotifyAccessibilityEvent to fire UIA events until after our internal state is up-to-date. We need to do this due to a bug where Narrator focus does not follow keyboard focus since NotifyAccessibilityEvent is called before updating the focused item in SetPopupFocusOverride. Bug: 928949 Change-Id: I0635b7f93c8a4e5ac223f4b379eb7082e99aad17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559161Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#649636}
-
Chris Lu authored
Bug: 919685 Change-Id: Idf3c2a5f3c4f2dc4658b684fea5b5e02104a9c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561831Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649635}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28fa257fa607..73904e05a2db git log 28fa257fa607..73904e05a2db --date=short --no-merges --format='%ad %ae %s' 2019-04-10 treehugger-gerrit@google.com Merge "Show buffer overruns in ProfileProto." Created with: gclient setdep -r src/third_party/perfetto@73904e05a2db The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I839e5a467af12f1f7a299760fc8509b84f524095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562047Reviewed-by:
-
Victor Costan authored
The method and its derivatives are supposed to be used in tests, so it's good to be exact. Change-Id: Ifc4d6c278a32a125e79c2f1bc6cb3defd01494ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558158Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649633}
-
Justin Cohen authored
iOS 12.2 has a bug where the WKWebView internal page doesn't display. Bug: 950488, 793317 Change-Id: Idf3e26125b121a7b753f65e176337f5fc67ce2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562218Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649632}
-
Justin Cohen authored
Original code was changed to use GetLastCommittedURL instead of GetVisibleURL to bandaid over the NTP pending item bug in crrev.com/c/1456639. That bandaid was disabled in crrev.com/c/1534359, but didn't change the NTP check back to GetVisibleURL. Bug: 931569 Change-Id: I1f8a8acc2ec151c67ca2103602a457b90e65dd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562224 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Changwan Ryu authored
Header's content length should be set in ResourceMultiBufferDataProvider::DidReceiveResponse() and copied to url_data_ such that MultibufferDataSource::StartCallback() later determines the success of the reading. Then why is this flaky? ResourceMultiBufferDataProvider::DidFinishLoading() also copies the url data, so depending on the timing, StartCallback() could pick up the correct url data length, and the test passes when this happens. The expected content length information seems missing in AndroidStreamReaderUrlLoader. Also, when the test fails, readyState doesn't seem to change from 0 to 4 in blink::WebMediaPlayerImpl. I'm not entirely sure if this is needed for all the tests that require media playback, but this seems to make it more obvious where it fails. Bug: 936757 Change-Id: I62245808876385a05c8e011882e2122622ff5c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548579Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649630}
-
David Tseng authored
Fixes AXAuraObjCache lifetime in test. TBR=seantopping@chromium.org,dmazzoni@chromium.org,sky@chromium.org Bug: 950972 Original change description: Change-Id: I60744f22b1b17b07545f6b5e4548d9cc67df4d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558059 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#649629}
-
Mikel Astiz authored
This avois potential jank on the UI thread and is achieved by leveraging ModelTypeStore's built-in support for preprocessing data on the backend sequence. Bug: 922971 Change-Id: If813c6626df1de40a8f6e74b2eccfbab2ee648a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562430 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649628}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/32a9ea1c5be2..3635a1295b12 git log 32a9ea1c5be2..3635a1295b12 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 srisser@google.com Generic Transform Feedback buffer as global state 2019-04-10 sugoi@google.com Use the ImageView's format in clear operations Created with: gclient setdep -r src/third_party/swiftshader@3635a1295b12 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I942146ac08f67016a24e247a1bcbdab2ab18492a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562042Reviewed-by:
-
Mehran Mahmoudi authored
This implements stylings for list items in TouchlessDialogPresenter per UX specs. It also forwards the key events from TouchlessDialogPresenter to TouchlessUiController. Bug: 944512 Change-Id: I159529b9ff39c8f01dde4cb90db4ef8a7dd4f7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553037Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649626}
-
Takashi Toyoshima authored
Updates in the 3rd patchset: - add a virtual method to the iOS BrowserState for obtainig cors_exempt_headers, that can be implemented outside ios/web, and missed users in ios/web can support X-Client-Data now. Updates between the 1st and the 2nd patchsets: - initial variation header support for iOS Chrome, this adds additional argument to one of ctor of NetworkContext, and set cors_exempt_headers in chrome/ uses. - additional variation header support for Chromecast - additional variation header support for StoragePartition Original descriptions: Now ResourceRequest has multiple special header entries that are aimed for escaping from CORS checks for internal uses. This patch introduces cors_exempt_headers to handle this kind of entries in an unified way. Also this patch removes {Get|Set}ClientDataHeader interfaces from WebURLRequest because these should not be used in Blink. Bug: 940331 Change-Id: Ie9a2b175e46f7dd567a9896d5e09c562f170a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547611 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649625}
-
Varun Khaneja authored
R=nparker Bug: 933065 Change-Id: Ie2e790cd9ce5fa2aa5f0e7ef9d200b1d0e608060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509012Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649624}
-
bsheedy authored
Enables the use of the sandboxed process for the XR browser tests. This is achieved by running the tests through a wrapper script that sets the correct ACLs on the output directory before running the tests. Bug: 949619 Change-Id: If583d50234f8d763da23cd70ab65b898a4164492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555499 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 30bfe0fd. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia35dade3eef0599dd3d5fc9d14b640f46de58365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562152Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649622}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d7730600369..7682feb30b68 Created with: gclient setdep -r src-internal@7682feb30b68 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: If8c9c134cfb9aac2680dcceb517fe6d688ba7711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562041Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649621}
-
Sébastien Séguin-Gagnon authored
Bug: 945572 Change-Id: Iddea284189237432651e030ca72193eec2a27c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560555 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
-
Henrique Grandinetti authored
Bug: 951242 Change-Id: I8a9a86683fd9143458fd62dbc53c41a91a85771d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561835Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#649619}
-
Ushesh Desai authored
Not included are the removals which require other changes (and are mostly being handled as part of those changes). Change-Id: If6164751335c90982e1094a464ef9dc3828916ad Bug: 886965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552109Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ushesh Desai <ushesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649618}
-
Jacques Newman authored
Added corresponding baselines for uia for each existing *-expected-win.txt. Modified optgroup.html to test the SelectionContainer property, updated corresponding *-expected files. Re-added pattern-specific properties, e.g. UIA_GridItemRowPropertyId It was required that we add the property to the cache request before they could be accessed from the pattern. The following properties are not working correctly: * ValuePattern.Value: - Should be fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1519319 * GridPattern: ColumnCount and RowCount are sometimes 0 when they should be greater than 0. Added and tested the following pattern properties: ExpandCollapse.ExpandCollapseState Grid.ColumnCount Grid.RowCount GridItem.Column GridItem.ColumnSpan GridItem.Row GridItem.RowSpan GridItem.ContainingGrid RangeValue.IsReadOnly RangeValue.LargeChange RangeValue.SmallChange RangeValue.Maximum RangeValue.Minimum RangeValue.Value Scroll.HorizontalScrollPercent Scroll.HorizontalViewSize Scroll.HorizontallyScrollable Scroll.VerticalScrollPercent Scroll.VerticalViewSize Scroll.VerticallyScrollable Selection.CanSelectMultiple Selection.IsSelectionRequired SelectionItem.IsSelected SelectionItem.SelectionContainer Table.RowOrColumnMajor Toggle.ToggleState Value.IsReadOnly Value.Value Window.IsModal Bug: 847971 Change-Id: I1fbfe2730e8281e8dbb1bc16bfecb68810a0fe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521468 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
-
Nicolas Ouellet-payeur authored
win32 Bug: 949382 Change-Id: I4a12c77bb506f07678d2bd3e824c2364b37b905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561630Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#649616}
-
Alexander Guettler authored
After fixing the bounds check in r623087 it could happen that the window below the mouse is still the render_widget_host after a tooltip was created and called SetCapture to not forward mouse events to us. This makes sure that we only do the bounds check if there is not a capture currently active. R=kenrb@chromium.org, lanwei@chromium.org Bug: 944772 Change-Id: Id6f5ab4ca1f643a8830ad22b36a6975b1da5bc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554356Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#649615}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3649ea708153e3d33688e5d5fb96268364932f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562043Reviewed-by:
-
Jérôme Lebel authored
Adding user actions for the advanced setting view: + Signin_Signin_ConfirmAdvancedSyncSettings The user taps on "Confirm". + Signin_Signin_CancelAdvancedSyncSettings The user cancels the settings (by tapping on the cancel button and then validate the alert dialog). Bug: 937110 Change-Id: I4d3653571febd373b0a642e56dc35f5d1f369532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554675 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#649613}
-
Mikel Astiz authored
This simplifies the dependencies and the interactions across datatypes, which are quite fragile and rely on special-casing for DeviceInfo in ProfileSyncService (very early initialization via InitLocalCacheGuid()). Instead, let's make SESSIONS read the individual fields it needs (i.e. device name and type) directly from common utility libraries. Bug: 951051 Change-Id: I99831ff5bc66003bc1142551f654b9fa387e4e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560151 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649612}
-
Austin Eng authored
This reverts commit 9d4aadda. Reason for revert: Breaking tests on waterfall and CQ Original change's description: > Remove sharding for dawn_end2end_tests > > These tests run very quickly and do not need to be sharded. > > Bug: 948902 > Change-Id: Ice7c19d1f603dc378af36eee86e396fcdebda88f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558709 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649570} TBR=kbr@chromium.org,enga@chromium.org Change-Id: I0cdc653be4306cef6c78708d2b7f684acdb5acc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562292Reviewed-by:
-
Matt Mueller authored
This ensures that during the trial when CertVerifyProcNSS and CertVerifyProcBuiltin are being used simultaneously, the builtin verifier does not get to "cheat" by using AIA fetched certs from CertVerifyProcNSS. Bug: 951166 Change-Id: Ib0b3241f6764360df74bd5ede693e92cf0381de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559206Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#649610}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/224e075bba5b..280474c2a985 git log 224e075bba5b..280474c2a985 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@280474c2a985 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia28cb9e19e31631a2db79818f905698d066989c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562039Reviewed-by:
-
