- 02 Jun, 2020 40 commits
-
-
Dominic Mazzoni authored
Bug: 1090378 Change-Id: Iccd269f281f228aef508c564dad91c7f38d96d2c Tbr: jinsukkim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224026 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774299}
-
Min Qin authored
This is not used anywhere BUG=1088729 Change-Id: I3831bce56c5817ef619c6b040f31f87e95622135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225498Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774298}
-
Tom Anderson authored
Fixes a regression introduced after [1] where Future would call OnResponseImpl() in destruction even if it was already called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220524 BUG=1066670 TBR=msisov Change-Id: I6c42809ec3f5973c141eb76e52650aa560fda6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227056Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#774297}
-
Brandon Wylie authored
Bug: 1088593, 1088541, 1088542, 1089641, 1089640, 1089637, 1089636 Change-Id: I6c42e7280a4f6075122123a196263713f64feb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224256Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b1ab5728344..a6c70741e76f 2020-06-02 peah@webrtc.org Change to using the new Ooura constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8f711b3c00df7630be82c0864fa0909c10c014f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa9d99ff6b53..2ad3dfb46bb6 2020-06-02 brianosman@google.com For custom vector/normal/position attrs, let marker ID 0 mean CTM 2020-06-02 senorblanco@chromium.org Dawn: fix MSC build. 2020-06-02 mtklein@google.com roll clang_win 2020-06-02 johnstiles@google.com Add headers to SkSL GN file. 2020-06-02 herb@google.com Remove ineffective lazy field fMetricsAndImages 2020-06-02 mtklein@google.com add Fuchsia condition results for G3 build 2020-06-02 bsalomon@google.com Remove submit from async read pixels. User must submit. 2020-06-02 geofflang@google.com Remove ES3 context requirement to use rectangle textures with ANGLE. 2020-06-02 adlai@google.com Make GrContextThreadSafeProxy not a GrContext_Base If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087118,chromium:1090019 Tbr: tdenniston@google.com Change-Id: If34b2b069ed1a84c91a2e1cecaac49b0734eb846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226960Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4391bc111097..6380ab5a1d67 2020-06-02 bmeurer@chromium.org [wasm] Display UI locations with hexadecimal pc offsets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e3c12677b6ade6201c11450997274303e2c3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226959Reviewed-by:
-
Chris Lu authored
When a WebState is detached from a WebStateList, the Overlay Presenter removes itself as the OverlayRequestQueue's delegate. If an overlay was being presented, the queue then removes the request. However, the OverlayWasDismissed() callback of the request is still executed, causing bad behavior given that the request is now null. Two new codepaths are introduced to managed this newly discovered scenario best reproduced with using the Crash Restore Infobar: 1) The presenter remains the delegate of a queue when its WebState is detached and an overlay is being presented. That way if the queue is destroyed and the requests are cancelled, | removed_request_awaiting_dismissal_| can be used to extend its lifetime until dismissal callbacks are finished. 2) If the presenter is replaced as the queue's delegate, there is no way to guarantee the validity of |presenting_request_| from then on. This can technically also occur separately from WebState detachment. Thus, upon replacement, the presenter will do early DidHideOverlay() calls, reset |presenting_request_| and mark |detached_queue_replaced_delegate_| as true so that it knows to early return in OverlayWasDismissed since the request is likely to be invalid at that point. Bug: 1071914 Change-Id: Ie7d7d7e67849323ac482b83680f7e35853b8c284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207509 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774292}
-
Lei Zhang authored
This reverts commit e4542cf9. Reason for revert: Broke Chrome OS. Original change's description: > Use use_x11 feature when preprocessing clipboard.mojom. > > The |kSelection| enum value is only available for systems running X11. > > Bug: 676224 > Change-Id: Icdd99c86712d6127a6ae81e74d17b189073e11ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163637 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762479} TBR=dcheng@chromium.org,thestig@chromium.org,huangdarwin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 676224,1088233 Change-Id: I7ddf3dd99e78d0e5128691d3ef310d09ed848ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225846Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774291}
-
Sergey Abbakumov authored
It's possible that a video frame mailbox is not registered in gpu::SharedImageInterface, but will be passed to ClientSharedImageInterface::DestroySharedImage which results in DCHECK() for Android MediaPlayerRenderer code path. Bug: 1075552 Change-Id: Id24245f349e61784a407b60729f82d44033843fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165738 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#774290}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/837f38b3e0ca..f16eda346663 $ git log 837f38b3e..f16eda346 --date=short --no-merges --format='%ad %ae %s' 2020-05-21 no-reply Correct uninitialized variable. Created with: roll-dep src/third_party/snappy/src Bug: 1090173 Change-Id: I227a3b5fb6c3aff698381c66a5f997d1138a6068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225828 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774289}
-
Robert Sesek authored
It was used in Site Isolation experiments with V8's low-memory mode, but the feature did not pan out in practice. Bug: 1089520 Change-Id: Ie28ef387d5cd0ca0a5f08a6142488355eddd958d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225272Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#774288}
-
François Doray authored
This reverts commit 30e4bc39. Reason for revert: Suspected culprit for crbug.com/1090427 Original change's description: > dpwa: Implement backward compatibility for Bookmark Apps. > > Implement backward compatibility of Web Apps via > shadow Bookmark Apps. > > On a web app install/update/uninstall we also install/update/uninstall > the shadow bookmark app. > > Any install/uninstall changes for the extensions registry get > propagated to the sync server (syncer::ModelType::APPS) and to all > devices where BMO is disabled. > > Design doc: go/chrome-bmo-migration. > > Bug: 1020037 > Fixed: 1086909 > Change-Id: I29c673f8eb83373f4abb1d984c91e8a436d00410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162507 > Commit-Queue: Owen Min <zmin@chromium.org> > Auto-Submit: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774134} TBR=alancutter@chromium.org,loyso@chromium.org,zmin@chromium.org Change-Id: I8e43156b19eccc9d4dd550d946e7551ade9cc54d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020037, 1090427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226060Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774287}
-
Regan Hsu authored
Fixed: 1070712 Change-Id: I7f3fc2c906112d615f22b8298f093cd6c02277f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225482 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774286}
-
Ian Kilpatrick authored
Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2222621 There should be no behaviour change. Bug: 993813 Change-Id: Ic59085a9ead856cddeec0619450bc532b6878b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225755 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774285}
-
Bill Budge authored
Bug: 1089248, 1088961, 1088962, 1088963, 1088964 Change-Id: I1aa9118cf6ce34e5cfd5a607c4ed661c80abfa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225354 Auto-Submit: Bill Budge <bbudge@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#774284}
-
Richard Townsend authored
Use of ambiguous !IsSynchronous() lead to state confusion where the parser incorrectly switched to the foreground, budgeted mode. This was caught by the relevant DCHECK assertions. Bug: 901056, 1087325, 1087032 Change-Id: Ic765babfd21cf084d024408740514046d9d772f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224800Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#774283}
-
Anatoliy Potapchuk authored
There is no single codepath that is running diagnostic mode for kiosk, and it has not been working for more around a year and a half. Let's remove this redundant code. Bug: 1015383,932323,1077499 Change-Id: I43050f07bc100db5ea1b3612fdd322182d1dd146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218176 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774282}
-
Brandon Wylie authored
Bug: 1090031,1083917 Change-Id: Ie4096f28387f3a9214806179de5a04af06063a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225268Reviewed-by:
-
Ana Salazar authored
Set expiration date of Ash.NavigationWidget.AnimationSmoothness metrics for one year. Bug: 1089730, 1089756, 1089757, 1089758 Change-Id: I662253a28ca968e8d3588b4065755bada917352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226918 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aab54fd01db6..957a2359f66b 2020-06-02 jmadill@chromium.org Skip VulkanBarriersPerfBenchmark on NV/Win. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1090139 Tbr: ynovikov@google.com Change-Id: I2c3847964a807cdd355edd72a8a8c917f70989e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226887Reviewed-by:
-
Benoit Lize authored
With some configurations, DiskDataAllocator triggers DCHECK()s: - Serializing an empty file is supported by Mojo, but discouraged - Background writes need to be explicitly annotated in blink This also adds a threading restriction exception for reads on the main thread. This wasn't hit because a write always happen before a read, but is required as well. This is expected, and is covered by metrics to ensure this is not an issue in practice. Bug: 1087862, 1029320 Change-Id: I41f5fca2b9b371a6ad7b9988ba3914543bd44d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222580 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774278}
-
David Bokan authored
The |is_composited| was added to ScrollNodes in https://crrev.com/6ce0a16d1e0 as a way to tell which ScrollNodes are able to scroll directly on the compositor by changing the transform tree. When the scroll unification flag is turned on, scroll nodes without this bit set avoid mutating the transform tree and instead rely on a commit from the main thread for a scroll to be realized. PropertyTreeBuilder creates property trees for the UI compositor and some tests based on the layer tree. The CL above did not update this method of tree generation to set this bit. Since the nodes are built from layers, all nodes should be considered composited in this case. This change fixes tests when the scroll unification flag is turned on. Bug: 1086625 Change-Id: I3a3552a5c17f1f69e038657c1f267b2a61f7a070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222892 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774277}
-
Jarryd authored
Change-Id: I2c7df80c038104c8c19e9d70e2b75ca0d8acedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225837 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Mark Yacoub authored
Encapsulate {id, mode and origin} into a single struct that is passed through Mojom. The intention is to use a vector of the structs of the multiple displays that will be configured together. BUG=1082882 TEST=no changes in modesetting any device Change-Id: I932b7bae16670a3eff55f2666ce1096c8a4b8a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202876Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#774275}
-
Mounir Lamouri authored
Don't keep a copy of the player id in the controller. Simplifies the logic. Bug: None Change-Id: Ia9f4be60f8affd4329f788a59597b06a2cb521ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196935Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#774274}
-
Ali Juma authored
This adds some integration tests for Safe Browsing, verifying that error pages are displayed when navigating to an unsafe URL, the "Back to safety" and "Details" buttons work as expected, the proceed link dismisses the error page and loads the unsafe site. Change-Id: Ife93280ae78562626d779d28c432c76c3c582bc0 Bug: 1087390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222694 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#774273}
-
Jian Li authored
This allows Feed v2 surface UI being rendered in NTP. All the interaction with Feed v2 surface is now wrapped under Stream API, as in FeedStream class. According to android-binary-size trybot, this increases the binary sizes by ~2.6kb. The increase comes from exposing Feed v2 UI and there isn't much we can do to reduce them. Bug: 1044139 Binary-Size: Size increase is unavoidable (see above) Change-Id: I0ec53959867b8842f9f546ad42c22f05d819fa1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224154Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774272}
-
Brandon Wylie authored
Bug: 1086345 Change-Id: Ia5ca55590795a9ecd4586787520458d98ac1876f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225823 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#774271}
-
Yao Xiao authored
Bug: 1062736 Change-Id: Ib6dae46fc0fffc06376f2f792daea6de7394ecfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219012 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#774270}
-
Tommy C. Li authored
This CL adds the accessibility messages for popup headers. It also moves the logic out of OmniboxResultView into OmniboxPopupModel. We had to do this, since we now have headers that are not encapsulated within OmniboxResultView. Moreover, we've had crashes with one View reaching into other Views. Our new design going forward is to have Views be relatively independent while coordinating shared business logic though the OmniboxPopupModel. One more thing: This CL will also make VoiceOver enunciate the accessibility labels for all focused-button SelectionStates, not just BUTTON_FOCUSED. We need this because we now have a sundry of focused button states. This CL is not a complete solution, we still have a few more things to do, that will have to be in separate CLs: - Don't update the temporary text when tabbing INTO a Header. - Update the temporary text when tabbing OUT of a Header. - Provide the proper 'Selected' accessibility event when focusing the header button. We don't do this yet. Bug: 1078183, 1052522 Change-Id: I94108ca5a527754c0087f9a06f1aeb5d53dc57e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220348Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774269}
-
Andrew Grieve authored
Similar to enable_proguard_obfuscation, provides a global toggle to disable path renaming and resource id coalescing. Useful for APK analysis tools that don't support mapping files. Bug: None Change-Id: I9d6b90a9f452e5c87852ecacdfa0def103ddacd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225362 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#774268}
-
Matthew Wang authored
Network.Shill.WiFi.{Ap80211rSupport, BSSTransitionManagementSupport, SessionLength, RoamComplete, RoamTime} Bug: 1089039,1089042,1089801,1089802,1089803 Change-Id: I12bd488d3fec7c195799287dd7c6db7167385616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225391Reviewed-by: -
Shengfa Lin authored
document.activeElement could return body when no element has focus. When user first navigate to url or switch frame, we don't want to treat this body as focus. Therefore, we will check document.hasFocus() first. Bug: chromedriver:3502,b/157759309 Change-Id: I87e649423a6fde55a7b8a273c3500787045edac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225521Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#774266}
-
Dominic Mazzoni authored
This reverts commit 62ff616d. Reason for revert: Both of these are failing on MSAN: SigninReauthViewControllerBrowserTest.CancelReauthDialog SigninReauthViewControllerBrowserTest.ConfirmReauthDialog Original change's description: > [signin] Add reauth browser tests with a fake Gaia page > > This CL adds a new set of tests for the reauth dialog. These tests > check interactions with a Gaia Reauth endpoint that is imitated through > an EmbeddedTestServer. > > The main "embedded/xreauth/chrome" endpoint operates in two modes: > - In the default mode, the endpoint redirects to the "challenge" URL > whose response can be controlled within the test by a > ControllableHttpResponse. > - If the "?done" query is present, the endpoint returns the > HTTP_NO_CONTENT response that signifies a successful reauth. > > The CL also extracts common test code into test suite functions to > reduce the code duplication and make the tests code more readable. > > Bug: 1045515 > Change-Id: I89d4aac57ef25168def1341fb63b1a7498dcfa0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225396 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774205} TBR=droger@chromium.org,alexilin@chromium.org Change-Id: I9e322b00bb98f9394b81fda2a0e62bf5db5cd9e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045515, 1090451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225852Reviewed-by:
-
Kevin Babbitt authored
At window close, we make an outbound call to UI Automation to signal it that objects associated with that window are no longer valid and can be cleaned up. If that cleanup call happens to be the first call into UIA during the lifetime of the browser process - because UIA has not otherwise been used - it can trigger UIA to initialize itself, which can result in an outbound COM call from the browser main thread, which can trigger pumping of messages back into our window. That can lead to bad behavior since objects are already partially torn down at that point. The fix is for each message handler to keep track of whether it has returned any UIA objects and only make the cleanup call if so. Bug: 1087553 Change-Id: Ibf55df4d2e531fb8c4e404ede80e17833ff61543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220473 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Alex Gough authored
Prelude to removal of WithSandboxType API. See linked bug for rationale. Does not change behavior. Tests: browser_tests PrintBrowserTest.* Bug: 1065087 Change-Id: Idaf185273813b4fc75cad3897f0507569135134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202423 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Junbo Ke authored
This change is generated by the automated script. Bug: internal b/152051045 Test: None Change-Id: I831e12e625e667424fc1869351297a864cc6ae7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225738 Commit-Queue: Junbo Ke <juke@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Junbo Ke <juke@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#774262}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0afcb72086f3d2deffedb3156b62ebcc2922c8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226915Reviewed-by:
-
Moe Ahmadi authored
Change-Id: Iba0d2ad906701e78b8dbd28730c7653178aef55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224025Reviewed-by:
-
