- 07 Jul, 2020 40 commits
-
-
David Grogan authored
The test includes some variants of the crash repro as evidence that the crash was harmless. Bug: 1018439 Fixed: 1091588 Change-Id: I879d4ce879d9fafb86b26a21609141b2fcfc5a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265100Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786031}
-
Brian Sheedy authored
Removes all the remaining uses of //third_party/pymock from the following directories in favor of the version provided by vpython: //chrome/installer/mac/signing/ //chrome/test/data/android/ //components/schema_org/ This is so that the third_party version can be removed. Bug: 1094489 Change-Id: I3441c03b4af871dc3a7c0071f02c367a8839991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284045Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786030}
-
David Black authored
Bug snuck in with: https://chromium-review.googlesource.com/c/chromium/src/+/2257401 Bug: b:160641054 Change-Id: Iaa2c2c7ea7a453e871610fa8b268d4492f7a1c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284364Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#786029}
-
Sven Zheng authored
Retry should get the CQ false reject rate down. The tests will retry once if they fail(standard browser test retry limit). Also to get out of experimental, I plan to do it incrementally by enable some tests first. Bug: 1102894 Change-Id: Ie1b0b3d6540770feff78f5578b678cd0d5648ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285246Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786028}
-
Curt Clemens authored
ToDictionary and FromDictionary methods convert to/from a Value dictionary to facilitate storing PrivateCertificates in Prefs. Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#786027}
-
Vasiliy Telezhnikov authored
CHROMIUM_stream_texture_matrix is now unused. This CL removes the extension. Bug: 1076564 Change-Id: I046d07674e98015d962fc8120f3ad1efc3641fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283648Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#786026}
-
Mustafa Emre Acer authored
This is a follow up to https://crrev.com/c/2274667 This attribute was recently introduced so that developers wouldn't get presubmit errors for accessibility labels that are not shown in the UI. However, screen readers do actually display most accessibility labels, so having screenshots for these strings are still useful. Still, there is a small subset of accessibility labels that are never displayed. This CL renames the existing attribute to make the intention of the carveout clear. Bug: 1094077 Change-Id: I4c171d29fea0aac611cb07759422bd5c25688017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285076 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786025}
-
Patrick To authored
When a session is created in OpenXR, it is not started until an OpenXR event indicates that the session is ready to begin. However, WebXR starts requesting frames as soon as the runtime is created. This calls xrWaitFrame before the session has begun, which generates an OpenXR error. This change keeps track of when the session is running, and only calls xrWaitFrame when the session has begun. Otherwise, an empty frame is returned to WebXR. Bug: 1050729 Change-Id: I990457a349ba90395404b2adb3f14b3c21883bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275370Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786024}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/db0d1b0d2459..e1ca4c7cd49a 2020-07-07 aninditaghosh@google.com Add compute_metric function to http.py 2020-07-07 treehugger-gerrit@google.com Merge "Fix incorrect max retry calculation." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f6fae5edb34a1c1a527fa3d2cf47039bd56643c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786023}
-
Josh Horwich authored
Add an experiment flag to enable 64-bit native bridge for ARC on systems that have 64-bit native bridge support available but not enabled. Note that due to the nature of the timing of starting ARC mini- container - which can be affected by the properties controlled by this experiment - and user login, the experiment is treated as a one way off->on transition for all users on a given device. The experiment flag will have no effect on systems that do not have 64-bit native support available, nor will it affect systems that have 64-bit native support enabled generally. Bug: b:62095998 Change-Id: If2a5dc96ba36f8aba31405122a6de20764af30b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252956 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#786022}
-
Kevin McNee authored
Tbr: fdoray@chromium.org Bug: 1080602 Change-Id: Ie8e315ed0b2285c8b23eb322f074059dcd77edd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285385Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786021}
-
Emily Stark authored
This reverts commit 65ac9625. Reason for revert: Something got messed up in a rebase somehow and this ended up accidentally reverting parts of https://chromium-review.googlesource.com/c/chromium/src/+/2283655/ Original change's description: > Clean up steady-state scheme/trivial subdomains elision flags > > These flags are enabled by default and expired since M76. > > I'm cleaning these up now because I'm starting to think about > uneliding scheme/trivial subdomains on hover (for the omnibox UI > simplified domain field trials), and it'll be simpler code if we don't > have to reason about these expired flags in both enabled and disabled > states. > > Bug: 797354 > Change-Id: I766a30c2f886ae1d651c2bf8eed0bc094664bde7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277880 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785962} TBR=msw@chromium.org,tommycli@chromium.org,tedchoc@chromium.org,estark@chromium.org Change-Id: I608b380c23af2211019b6fac2988a13da25f4d26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285514Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786020}
-
Moe Ahmadi authored
In order to support different ranking approaches for the local history zero-prefix suggestions, this CL modifies the current implementation to allow ranking the normalized search terms in C++. To accomplish this, LocalHistoryZeroSuggestProvider now requests an unordered list of rows grouped by |normalized_term| from the URL database in which |visit_count| is the sum of all visit counts and |last_visit_time| is the latest visit time for that normalized term. It also simplifies the LocalHistoryZeroSuggestProvider implementation by moving the freshness and validity checks for the normalized term into the SQL query. This change is not expected to alter the existing behavior as confirmed by the unit tests. Bug: 1096615 Change-Id: I01c29afff51f348e5c32766e4e53b3ff7687a3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278625Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786019}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ce1375c5f044..81a9074069be 2020-07-07 ayui@chromium.org CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097674 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iba142ae4697ae2244eb2d4bc1eed641579f2250f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285317Reviewed-by:
-
Chris Cunningham authored
This connects the IDL definitions to real code. We introduce DecoderTemplate to house the common request processing between audio/video decoders. A follow up cl will convert VideoDecoder to use this as well. For now AudioDecoder always uses FFmpeg and hard codes the codec to AAC. Change-Id: I891fbe095e57a240db2b528ced81ee1d6f14ef31 Bug: 1094090 Change-Id: I891fbe095e57a240db2b528ced81ee1d6f14ef31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274584 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#786017}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/A-udLmaNjd82md7204xsCfIJdXVm8X4DA0wugNTV8hQC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202007060800_RC00.html Bug: b/159891423, b/156706635, b/160193577, b/159893051, b/159083441, b/160033715, b/159947267, b/159083441 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I51157589f9fd3c008aaa4b9b53d89d06ce5d08d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283031 Auto-Submit: Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786016}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/233c2d8fa4c3..5e2efe33ef0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1044616,chromium:1090060,chromium:1102625,chromium:1102642 Tbr: huangdarwin@google.com,mcnee@google.com Change-Id: I0366f4fc2c0dbfac53e19eacb3c32baf853c9ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786015}
-
Haiyang Pan authored
Bug: 1102974 Change-Id: Ic61b2a997ab9c80aa5bf684713625a465a3257ec No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285259 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#786014}
-
Nick Diego Yamane authored
Now that SwayWM supports null drag icon surfaces to be passed when starting DND sessions [1], we can safely use it instead of allocating a surface with no buffer attached, which is currently not supported by Exosphere [2]. A non-null drag icon surface will be used in the future, once (at least) Exo supports the protocol extensions being proposed at the tab dragging design document [3]. This does not cause any functional change. The aforementioned Sway fix is available for now only in upstream development branch. It is expected to be included in releases >= 1.5. [1] https://github.com/swaywm/sway/issues/5509 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1102926 [3] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=tonikitoo@igalia.com Bug: 896640 Change-Id: Ic00b960c44c67a2311282b5b46a7cac752a773e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284981 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#786013}
-
Taylor Bergquist authored
This reverts commit e3a4fe74. Reason for revert: Breaks scrolling by shrinking the tabstrip to fit the available space instead of allowing it to grow and become scrollable. Original change's description: > Fix tabstrip on Windows with TabScrolling turned on > > While the widths of everything were working correctly with the tabstrip, it seems the height was not. This corrects that, and it seems to be a common pattern with other ScrollViews as well. > > Bug: 1093529 > Change-Id: I31250a62c06c0534c1ab21868df2419313515563 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252633 > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Commit-Queue: Connie Wan <connily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780989} TBR=tbergquist@chromium.org,connily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093529 Change-Id: Id7c38c06a9632df9cf062e35437047357bff0113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285254Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#786012}
-
Emily Stark authored
This CL fixes horizontal and vertical jumping when simplified domain omnibox field trials are enabled. For vertical jumping, we were using the height and vertical position returned from GetSubstringBounds(), but that doesn't always match the existing height and vertical position of the URL in the omnibox. To fix this, we now reuse the previous bounds' height and vertical position when eliding/uneliding to the simplified domain. Horizontal jumping was due to not taking the Textfield's border insets into account when eliding/uneliding. To fix this, when eliding or uneliding, we now set the display rect's x value to that of the previous bounds' x value, instead of 0, so that the leading edge of the display rect always stays in the same spot. When uneliding to the full URL, we reuse the logic from Textfield::OnBoundsChanged() (which has been factored out into its own method) to reset the Textfield's display rect to its local bounds. Bug: 1101674 Change-Id: Ia32420a2d4365910267acd05b86cd299204b7e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283655 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#786011}
-
Manuel Rego Casasnovas authored
BUG=1098231 Change-Id: If40b218d4595993e8b78a51d0a391a3ab10ce4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282584Reviewed-by:
-
Robert Liao authored
BUG=914910 Change-Id: I8e7dbaddd01ea2bcfa9d1c177dde6008cd26e7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285080 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786009}
-
Zentaro Kavanagh authored
- Use constructor where possible - Reserve space where known Bug: None Test: manual Change-Id: I5f7c00d1cd67300a54f25ea48e238571017e1b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283890 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#786008}
-
Matt Reynolds authored
This CL converts the OnXEvent callback to use base::BindRepeating. RepeatingCallback is correct for this callback since OnXEvent is called every time there is something to read from |x_record_display_|. BUG=1007799 Change-Id: I2eb4630512c7d27f7cc6d852f7e2903bdf12142c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283415 Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#786007}
-
Kevin McNee authored
Tbr: mlamouri@chromium.org Bug: 1083302 Change-Id: I738e4a7188e32b94261f12e457fed4f7c2bb5c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285346Reviewed-by:
-
Ben Pastene authored
This will help with the TODO at: https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 It will also remove the need for hard-coding the names of all these QEMU-compatible boards. Bug: 937821 Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Victor Costan authored
This CL removes expectations for non-existing tests. The first two tests were renamed a while ago. The last test no longer has .tentative. in its name. Change-Id: Ib89bfff349800d76a8ab4287beefc14d53e20b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285043Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786004}
-
Christoph Schwering authored
Removed FormFieldDataPredictions::field. Moved FormdDataPredictions::operator==(), FormdDataPredictions::operator!=(), FormFieldDataPredictions::operator==(), FormFieldDataPredictions::operator!=(), to autofill_test_util.{h,cc} since they are used (only) in two tests. Bug: 1007974 Change-Id: Ibfb1034e3659625194e445ede54f766cf04fdb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224866Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#786003}
-
Jun Mukai authored
When TrayContainer's child preferredsize/visibility changed, it wants to emit the PreferredSizeChanged() signal. However, sometimes TrayContainer may not set the layout manager yet, which does not update the preferred size and the signal will be ignored. I believe that ideally the current code structure/layout logic should be refactored; the layout manager should always exist for this view -- but this would be a good fix for the reported issue of incorrect layout. BUG=chromium:1100650 TEST=manually Change-Id: Ifd64e9a8b6823366d54735951e3e4836d65b51d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284014Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#786002}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Replace one base::DeleteFile() usage with base::GetDeleteFileCallback(), which is even simpler, and fix a lint error along the way. Bug: 1009837 Change-Id: Ibfbaf06c9757d63136174b32d106dca617da8002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284365Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786001}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: Ica2cc17aebd7bd98df425940f8518c78a2c8a3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284356Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786000}
-
Lei Zhang authored
The 2-parameter version is deprecated. Use either the simpler 1-parameter version, or base::DeletePathRecursively() when appropriate. Bug: 1009837 Change-Id: Ib38d48b9bdffaaa181b87745522c6781232058cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284443Reviewed-by:
-
Lei Zhang authored
Just use base::DeleteFile() and related functions directly. The issues that forced the creation of extensions::file_util::DeleteFile() no longer exist. Bug: 1009837 Change-Id: If9cc24a8ad20ef6a647ce38e57f90ad180afaef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284353Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785998}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: Iee024c6196b4f32fcbb82fbba568977931792660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284358Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785997}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: Ie55658befa4b60860664be1b0097bb3c5a37e2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284367Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785996}
-
Lei Zhang authored
The 2-parameter version is deprecated. Use either the simpler 1-parameter version, or base::DeletePathRecursively() when appropriate. Bug: 1009837 Change-Id: I9b5c1bf506da6928410ef97b44addf9ad47352e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284355Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785995}
-
Chris Hamilton authored
This creates a registry of all FrameNodes and WorkersNodes, and a wrapper that allows them to be accessed from a common ExecutionContext type. This will be used in various upcoming per-ExecutionContext tracking CLs. BUG=1085129 Change-Id: Ibe6467ee07c9e143c788f6a42dcdd955966a0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274543 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Bug: 1098535 Change-Id: Ibdc89687a9e2b9966bceadef09be35b8bd5eab3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261816Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#785993}
-
Christoph Schwering authored
CL [1] changes the handling of dynamic forms, which breaks some assertions in the captured-site tests: aeropostale, collage, expedia, tillys. This CL adjusts the assertions to fix aeropostale and collage and disables expedia and tillys. In aeropostale, after entering the shipping address and confirming the augmented address, the site dynamically changes the postal code from 98908 to 98908-3821, and after form submission, the profile's postal code is updated accordingly. When the shipping form is autofilled next, the updated postal code is now filled. In collage, the entered address is reformatted by a JavaScript, and there seems to be a race condition with the JS. Moreover, the XPaths for billing address were wrong. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2273068 Diff: aeropostale.test 291c291 < "expectedValue": "98908-3821", --- > "expectedValue": "98908", collage.test 60c60 < { "type":"coolOff", "pauseTimeSec":2 }, --- > { "type": "pressEscape" }, collage.test 65c65 < "expectedValue": "1020 S 41st Ave Apt 12", --- > "expectedValue": "1020 S 41ST AVE", collage.test 76c76 < "expectedValue": "", --- > "expectedValue": "APT 12", collage.test 87c87 < "expectedValue": "98908-3821", --- > "expectedValue": "98908", collage.test 143a144,153 > "selector": "//input[@type=\"radio\" and @value=\"false\"]", > "visibility": 3, > "context": { > "isIframe": false > }, > "type": "click", > "action_index": 8 > }, > { "type":"coolOff", "pauseTimeSec":2 }, > { collage.test 185,194d194 < { < "selector": "//input[@name=\"sameBilling\"]", < "visibility": 3, < "context": { < "isIframe": false < }, < "type": "click", < "action_index": 8 < }, < { "type":"coolOff", "pauseTimeSec":2 }, Bug: 1091401, 1096990, 1101864, 1101866 Change-Id: I714daca65b5621e8f5cebb219ef1b15d6359c6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279973Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#785992}
-
