- 31 Jan, 2019 40 commits
-
-
Dominik Röttsches authored
These tests were comparing offsetLeft, but there were pixel differences which made some of the tests fails. Using a less than 1 getClientBoundingRect().left difference instead, cleaning up the code and removing expectations file due to these robustly passing now. The pixel differences are not relevant to the intention of the test. Bug: 927287 Change-Id: I74fe8d64edb1a52de4fd0dbb3143843b305f8156 Reviewed-on: https://chromium-review.googlesource.com/c/1448215 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#627968}
-
Lowell Manners authored
Tests which call GetIdentityTestEnvironmentFactories() don't set any fake cookie responses, so they don't need to create a FakeGCMS. This CL is part of eliminating FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: Ic42dcd215ecf9ca162e96cfa37d3424ead703ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1445909 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#627967}
-
Henrique Ferreiro authored
Replace with IdentityManagerFactory. This matches what SigninManager is using. Bug: 927239 Change-Id: I8888e94e3032b323c78f65fbdeaf455a57cb27bc Reviewed-on: https://chromium-review.googlesource.com/c/1448155Reviewed-by:
-
Marek Haranczyk authored
Bug: 915659 Change-Id: Ib277ee462b14fbeba96b065149ea413461a51cda Reviewed-on: https://chromium-review.googlesource.com/c/1448154Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#627965}
-
Nikita Podguzov authored
Modify WallpaperController interface to support external data type policy. Remove WallpaperPolicyHandler as its functionality was replaced by DeviceCloudExternalDataPolicyObserver. Bug: 814364 Change-Id: I022989ae13464ef6f7e3653a216d052e37e7d37f Reviewed-on: https://chromium-review.googlesource.com/c/1406694 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#627964}
-
Henrique Ferreiro authored
This include is not used. Bug: 927240 Change-Id: Ie6035f1ed59db494cf875118e9dda114d9dbe65e Reviewed-on: https://chromium-review.googlesource.com/c/1448217Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#627963}
-
Daniel Bratell authored
A test() target with no deps (maybe only public_deps or no deps at all) would fail to compile on android because of a "deps += [...]" statement. Bug: 927257 Change-Id: I7fa3172a1f9cdca146800b8f81b965cfd46f81e9 Reviewed-on: https://chromium-review.googlesource.com/c/1443016Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#627962}
-
Vasilii Sukhanov authored
TBR=mmenke@chromium.org Bug: 922876 Change-Id: I82c925d0c3dc1279b3da8a2b7a0e9c772ca7da26 Reviewed-on: https://chromium-review.googlesource.com/c/1448232Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#627961}
-
Joshua Pawlicki authored
Bug: 922951 Change-Id: Ib089a473c1a99828726fa4c35e03646304aa752a Reviewed-on: https://chromium-review.googlesource.com/c/1447837 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Christian Dullweber authored
LocalStorage deletion due to Clear-On-Exit is flaky on all plattforms. Disable this part of the test. TBR: jsbell@chromium.org Bug: 927312 Change-Id: I3833461f283704bc5db2c52816e42013672c531c Reviewed-on: https://chromium-review.googlesource.com/c/1448186Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#627959}
-
Nico Weber authored
Per discussion on bug. Bug: 877080 Change-Id: I7d5c8c4a5ab6887c1cc9885b8035c3bb83a2e9b3 Reviewed-on: https://chromium-review.googlesource.com/c/1443513Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#627958}
-
edchin authored
The bug referenced below was caused by a bad side-effect of a recent CL. The CL moved a |-closeAllTabs| call from BVC to BrowserViewWrangler. Previously, the |-closeAllTabs| call was essentially a NO-OP since |-browserStateDestroyed| was called a few lines earlier. Moving the call made it actually perform an action. TabModel's |-closeAllTabs| should not be called at shutdown because the method is only intended to be called when the user has taken action. It sets the CLOSE_USER_ACTION flag. Futhermore, at shutdown, |-closeAllTabs| does not need to be called. BrowserViewWrangler calls |-setMainBrowser:| which calls |-browserStateDestroyed| which calls WebStateList's |closeAllWebStates()| with the flag CLOSE_NO_FLAGS. This fixes the issue in the bug. The bug was that snapshots were being removed during shutdown. This was happening because snapshots are removed whenever a WebState is closed by user's action. There is no reason to revert the offending CL as this CL fixes the issue and the other parts of that CL are useful. Offending CL: https://chromium-review.googlesource.com/c/chromium/src/+/1388933 Bug: 927171 Change-Id: Ib9ccf125d93d28424fbf7d67ea72f8a06d9a7f2b Reviewed-on: https://chromium-review.googlesource.com/c/1446663 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#627957}
-
Manu Cornet authored
The implementation of |GetAccessibleNodeData| in the base Button class is more than sufficient, and does all the things the ShelfButton does (and more). Change-Id: I3ee2d6f8ecff676fcad34e2216199128394cf731 Reviewed-on: https://chromium-review.googlesource.com/c/1446256 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#627956}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84b1fb2bc73d..35f199648fe8 git log 84b1fb2bc73d..35f199648fe8 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 taylori@google.com Merge "perfetto-ui: Show slice details on click" 2019-01-31 fmayer@google.com Allow to specify dump interval. Default to no continuous dump. 2019-01-31 lalitm@google.com Merge "trace_processor: reduce memory + ingestion time for utid map" Created with: gclient setdep -r src/third_party/perfetto@35f199648fe8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I96f8ded2136acaa3581134239d7ac471524f6e2a Reviewed-on: https://chromium-review.googlesource.com/c/1448019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627955}
-
Keishi Hattori authored
This reverts commit 4a8c777f. Reason for revert: Check did not catch anything. Original change's description: > Oilpan: Check for interiors in freed backings > > Backings that we are freeing should not contain any interiors that are registered in HeapCompact. > This adds a speculative check to diagnose a crash. > > Bug: 918064 > Change-Id: I8c70bb4c2f455f7881474e981a56cb6c7197b94b > Reviewed-on: https://chromium-review.googlesource.com/c/1437037 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627008} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918064 Change-Id: Ibe36de441dbdefdf8e5cfd59b50aa14f786fe2ff Reviewed-on: https://chromium-review.googlesource.com/c/1448074Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#627954}
-
Dominic Battre authored
If a user has blacklisted a site for saving credentials, the login database stores this as an entry with an empty password. This CL recognizes this and reports that the password was typed while the site was blacklisted instead of reporting that a password was typed even though a password exits (the empty password). There are still two special cases left: 1) If a PSL matching domain is blacklisted, it is still considered part of the current site even though the user will see a save prompt. 2) The use user has ignored a password save prompt 3 times, we don't ask again. In this case we will not report the site as blacklisted but report that no password was stored. Bug: 918846 Change-Id: I5cb0396940ec6be55b9e0715b3a0a74aa52815b9 Reviewed-on: https://chromium-review.googlesource.com/c/1448213Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#627953}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea2dc6a6bc11..1bd245b91801 git log ea2dc6a6bc11..1bd245b91801 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 787f953343b0..5ebd2c0fafca (1 commits) Created with: gclient setdep -r src/third_party/skia@1bd245b91801 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I7d9082aea1ce097fceb7392d6fd456b2c5975d62 Reviewed-on: https://chromium-review.googlesource.com/c/1448018Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90df681a48bc..0198e1a4756a Created with: gclient setdep -r src-internal@0198e1a4756a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:927262 TBR=mmoss@chromium.org Change-Id: I10602c1cf4279206bfa574ff43ed829c714861de Reviewed-on: https://chromium-review.googlesource.com/c/1448017Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627951}
-
David Roger authored
Screenshot for desktop: https://storage.googleapis.com/chromium-translation-screenshots/65f9fcb54fd03b79fcb9c349165115ba3ce192ea Screenshot for android: https://storage.googleapis.com/chromium-translation-screenshots/874727fdb430be8fa0f9565dcaa63bbbc6c796f6 Bug: 915394 Change-Id: I39fd2342c31e0d461fa58f041ee5d0d65bb4e8ad Reviewed-on: https://chromium-review.googlesource.com/c/1430090Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#627950}
-
Max Moroz authored
Bug: 926588 Change-Id: Id336e9fa0db4f01eacee252a5cd17e9d967159ed Reviewed-on: https://chromium-review.googlesource.com/c/1447016Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#627949}
-
Gyuyoung Kim authored
BuildFakeSigninManager() of fake_signin_manager_builder.h/cc has been only used by identity_test_environment_chrome_browser_state_adaptor.cc. It can be folded into that class. So, this CL moves the function into that file and remove fake_signin_manager_builder.cc/h. Bug: 926947 Change-Id: I78a134b58c001a926f129d9162be73e0b4ae046e Reviewed-on: https://chromium-review.googlesource.com/c/1447158Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#627948}
-
Antonio Gomes authored
... where PO2TS stands for ProfileOAuth2TokenService. This is is a follow up of [1], that left off this PO2TS call. [1] https://chromium-review.googlesource.com/c/1370279 BUG=927258 Change-Id: I0a81b3863fb9aa33aebf5c60d13e2ce3ff66abf3 Reviewed-on: https://chromium-review.googlesource.com/c/1448135 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chrome momentarily showed the URL of the payment handler page before showing its title when initially loading the page. This information is redundant because of the payment handler origin displayed underneath its title. This patch hides the title whenever the page title starts with "https://", which covers the use cases that we care about. After this patch, Chrome momentarily shows no title for the payment handler page before showing it when initially loading the page. The origin display underneath the title is not affected by this patch. Bug: 926297 Change-Id: I6fb26fed3d1968fd27493f4f39625b47b55baccb Reviewed-on: https://chromium-review.googlesource.com/c/1446870Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#627946}
-
Nico Weber authored
No behavior change. Bug: 926235 Change-Id: Ic49c15fb2a993c5ad73e7dc52f58daefdb8985f5 Reviewed-on: https://chromium-review.googlesource.com/c/1447371 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#627945}
-
Henrique Ferreiro authored
This include is not used. Bug: 927236 Change-Id: I1aec31b4c6eb68bdd40b3eacea5fb47f27b2638c Reviewed-on: https://chromium-review.googlesource.com/c/1448156 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#627944}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8048600b. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I3e326caf9d585b3692872a30d13b9c2f51d5d60a Reviewed-on: https://chromium-review.googlesource.com/c/1447832Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627943}
-
Gyuyoung Kim authored
s13n: Remove the dependencies of SigninManagerFactory and OAuth2TokenServiceFactory in WebViewProfileInvalidationProviderFactory SigninManagerFactory and OAuth2TokenServiceFactory is not used in WebViewProfileInvalidationProviderFactory anymore. So this CL removes the uses of them in the constructor of WebViewProfileInvalidationProviderFactory. Bug: 927255 Change-Id: I25b8ce316fb855c520313d65caea0e4815428ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1448075Reviewed-by:
-
Jeremy Roman authored
Macros are more subtle and this works fine as a template. Change-Id: I54758aa8bdb0087bac67e9009825d254c37f27f0 Reviewed-on: https://chromium-review.googlesource.com/c/1447018Reviewed-by:
-
Lowell Manners authored
FakeGaiaCookieManagerService is being eliminated in favor of setting expectations using TestURLLoaderFactory. This is part of step 5 of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I506dc749107c0ba56ef1a7ab355754c1937ee9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1434275 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86830d2b..d00f37db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie022c331d703f7383e71f6508f62dc9a8d170b70 Reviewed-on: https://chromium-review.googlesource.com/c/1447833Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627939}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94bebb39c6cb..84b1fb2bc73d git log 94bebb39c6cb..84b1fb2bc73d --date=short --no-merges --format='%ad %ae %s' 2019-01-31 lalitm@google.com Merge "Revert "trace_processor: invalidate mismatched pid sched slices"" Created with: gclient setdep -r src/third_party/perfetto@84b1fb2bc73d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idaf0e91f43d5f3a51d1c4ce46f7dafe9cc329afc Reviewed-on: https://chromium-review.googlesource.com/c/1448016Reviewed-by:
-
Sylvain Defresne authored
Bug: none Change-Id: I22b586ffa132851cab0f5ca690b0b2ff157653be Reviewed-on: https://chromium-review.googlesource.com/c/1448159Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#627937}
-
Henrique Ferreiro authored
Port to IdentityManager API replacing AccountTrackerService::FindAccountInfoByEmail with IdentityManager::FindAccountInfoForAccountWithRefreshTokenByEmailAddress. Bug: 922741 Change-Id: I791de90d4a3b8a49535fcca8e746e5875c8ee365 Reviewed-on: https://chromium-review.googlesource.com/c/1438995 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The test was added recently (https://crrev.com/c/1446559) and is blocking the v8 roll since this CL: https://crrev.com/c/1445977. R=ahaas@chromium.org Bug: chromium:927296 Change-Id: I675baca01066cd1c31baff05518dfde0d8528fe0 Reviewed-on: https://chromium-review.googlesource.com/c/1448179Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#627935}
-
Thiemo Nagel authored
Any changes to these strings need to be reviewed by privacy. Compared to other options it seems least overhead for everyone involved to do that in a code review. Bug: none Change-Id: Ie6f0eb509ab69555e015c9bc6b9430ec80ca4f8f Reviewed-on: https://chromium-review.googlesource.com/c/1438999Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#627934}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/787f953343b0..5ebd2c0fafca git log 787f953343b0..5ebd2c0fafca --date=short --no-merges --format='%ad %ae %s' 2019-01-31 sugoi@google.com Support for device groups Created with: gclient setdep -r src/third_party/swiftshader@5ebd2c0fafca The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I60a3c2f3aaa4a8d63ffa3208efdd48c1053d1f73 Reviewed-on: https://chromium-review.googlesource.com/c/1448015Reviewed-by:
-
Jeremy Roman authored
The simplest way to achieve this is to just make a portal and try to activate it straight away. This code was previously unreachable in our tests: https://analysis.chromium.org/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=f3878c07b1c5501e27ea0964d8a0ba0196cf7680&path=//third_party/blink/renderer/core/html/portal/html_portal_element.cc Bug: 916310 Change-Id: I20cc6cbfb242e5466df6ffbbe0e30c065d6806ee Reviewed-on: https://chromium-review.googlesource.com/c/1447030Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#627932}
-
chrome://invalidationsTanja Gornak authored
Refactors the diagnostic collection implementation for better output and code. After this CL the diagnostic output will have separate section, for every diagnostic provider. In addition this CL eliminates unnecessary use of unique_ptr and switches to RepeatingCallback instead of Callback, where necessary. Bug: 878446 Change-Id: If436709ebc3d47780237b1e9ab65ad073bef5a0b Reviewed-on: https://chromium-review.googlesource.com/c/1447683 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Antonio Gomes authored
In this case IdentityTestEnvironmentProfileAdaptor::GetIdentityTestEnvironmentFactories BUG=926939 Change-Id: Ief02bc5c6cfaa236e09001e80a880ba53f95fd65 Reviewed-on: https://chromium-review.googlesource.com/c/1446475 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Antonio Gomes authored
... instead GaiaCookieManagerService::Observer. The methods being overriden are equivalents (OnAccountsInCookieUpdated() and OnGaiaAccountsInCookieUpdated(), respectively). BUG=926890 Change-Id: I108954803f258080dc77bb8d37bae8614efffaae Reviewed-on: https://chromium-review.googlesource.com/c/1446474 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
-
