GitLab

The message does not indicate an error, but it causes confusion.
The message appears when GetChromePolicyDetailsCallback
returns null for the policy
(see ConfigurationPolicyHandlerList::FilterOutUnsupportedPolicies).

Use an empty callback instead.

Bug: 1098245
Change-Id: Ifcf43a40ebae5bfd300721bcd69310ba3ebc0914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292523Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787828}

This CL moves bitmap request logic from PlayerFrameMediator to
PlayerFrameBitmapState. This is mostly a mechanical change just moving
code.

Bug: 1099722
Change-Id: Iddedf83510bd715b18f3b5e393099721db33b69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292895
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787827}

Bug: 1099855
Change-Id: I57368cf7bec54e97964fecb8da0dfe009d8f2968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270444
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787826}

Several pieces of state (SecurityOrigin, ContentSecurityPolicy, and
WebSandboxFlags) are set or calculated on DocumentInit, then transferred
to SecurityContextInit, which is then passed to SecurityContext to
complete initialization.

All of this state comes from DocumentLoader (for main thread cases).
Have DocumentLoader calculate the final state directly, then either
pass it to SecurityContextInit (in the case of SecurityOrigin) or apply
it directly to the SecurityContext for (CSP and sandbox flags).

Change-Id: I40a0a6a7f68a043818eeb9eb2ccbab437e8448d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293175
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787825}

When a new session is started, the timestamp is recorded and the session
is saved as Sessions_[timestamp] or Tabs_[timestamp]. The existing
session with the latest timestamp is chosen as the "last" session to
restore from, and all older sessions are deleted.

These new files were moved under a separate directory, to facilitate
snapshotting. Snapshotting relies on static file names, so the entire
folder is preserved rather than the (now dynamic) session files.

The folder structure is as follows:

[ProfileDir]
| Sessions
-----| Session_13233899802170163
     | Session_13233899825256793
     | Tabs_13233899802319101
     | Tabs_13233899825404195

The code ensures than any new session created has a higher timestamp
than any existing, in case of clock changes. If there is no older
session in the new format, it falls back to the legacy files
(as "Current Tabs" or "Current Session"), so current users should
have no interruption in restore.

Bug: 1056279,1067405
Change-Id: Ide4bc4a155e0a6de025c976ff520bc13b5edaa49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238885
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787824}

No functional change. Preparing to add icon_bitmaps_maskable in
subsequent CL.
Context: App icons are currently only those that have purpose:any. We
will soon add purpose:maskable icons too, so this CL makes it explicit
that these are "any" icons (suitable for any purpose).

Bug: 1102701
Change-Id: Ie51004576828309ea532d791fed07d916baa2943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283030Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787823}

Disable the SecurityTokenLoginTest.Basic test due to flakiness.

Bug: 1105102,1033936
Tbr: antrim@chromium.org
Change-Id: If60715c24add6623b1f8bfc14270144f5b2e0c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295959Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787822}

This patch updates the mirroring service to use openscreen's Answer
message definition for mirror setting constraints.
This necessitates a migration from base::Value to
Json::Value as well, so this includes a refactor of the ReceiverResponse
class as well.

Other notes:
1. Previously, the ReceiverResponse struct didn't offer any type safety,
which is worrisome since it is essentially a std::variant without any
checking. This patch includes updates to the ReceiverResponse to ensure
it is used correctly by callers, instead of relying on them to check
everything.

2. Unit tests using the ReceiverResponse have been refactored to support
the above changes, including the attempts at implementing some
const-correctness.

3. Sender side letterboxing is now toggled from the ANSWER message.

4. The mirror settings have been updated to use the constraints from the
ANSWER message, using libcast's new capture recommendations.

Bug: 1002603, b/158030831, b/158032164,
Change-Id: I8f633e9c41d70fdcfcce9f8be697acc1838cc8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245897
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787821}

This CL Exposes UIA_AnnotationTypesAttributeId, specifically for :
  - AnnotationType_GrammarError
  - AnnotationType_SpellingError

This allows ATs such as Narrator to announce when a word is
misspelled or there are grammar errors when the user types or
navigates through editable content.

---

- In ax_platform_node_textrangeprovider_win_unittest.cc I collapsed
  these macros into EXPECT_UIA_SAFEARRAY_EQ
  - EXPECT_UIA_DOUBLE_SAFEARRAY_EQ
  - EXPECT_UIA_VT_UNKNOWN_SAFEARRAY_EQ

- In ax_platform_node_textrangeprovider_win_unittest.cc I added a
  helper method, CreateTextRangeProviderWin, which handles creating
  the start and end AXNodePositions.

- Internally passing a VariantVector* rather than a VARIANT* for
  getting attribute values for ITextRangeProvider::FindAttribute and
  ITextRangeProvider::GetAttributeValue.
  - This affects a few methods in ax_platform_node_win and
    ax_platform_node_textrangeprovider_win.cc

- Added test cases to
  AXPlatformNodeTextRangeProviderTest.TestITextRangeProviderGetAttributeValue

Bug: 928948

AX-Relnotes: Fixed an issue where Narrator was not announcing misspelled words.
Change-Id: I0b5b4342f3bd78a1e84a8ba9d820458936822bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246918
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#787820}

Previously a synchronization could be pending when we got a frame
callback, meaning that the animations would not be updated after the
frame callback had run, but still require the synchronization timer to
fire.

Instead flush any pending synchronizations if we get a frame callback
before the synchronization timer fires. This gives stronger guarantees
about when to expect animation values to be updated.

This could address the flakiness observed in the referenced bug.

Bug: 1099657
Change-Id: Ieb90a4cd2b5bb5a3b3d1f0a0d86383f08ce0d3fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292309Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#787819}

Bug: 1007635
Change-Id: Ied6e6be95e5f903ca67ac14bea9de30a234129a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294574
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787818}

Change-Id: If443a9d7e73ee47af13e13fc4732255cedd86362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295519Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787817}

Bug: 1104846
Change-Id: If40315351b29ba3b0ab9662932e261bf92d53fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294350
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787816}

This adds a simple putAll implementation that loops put. A basic web
platform test is added as well.

Change-Id: I8fcc25ffacb64d15855da921eb14f3770df28694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274217
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787815}

The GrContext used by SharedImageBackingFactory can be GL, Vulkan,
Metal, or Dawn. SharedImageBackingFactory had started storing this
as is_vulkan, is_metal, is_dawn, instead of a single switch. Update
this to be a single switch.

R=kylechar
TBR=geofflang

Bug: 894929
Change-Id: I44c6273ce0818244586b87c53f4f15da83e11239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292999
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787814}

Baselines were generated in the following build:
https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5

Bug: 1068400
Change-Id: Idbc37012f45394eac1189024b9480dba88b1fa92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293278Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#787813}

Baselines were generated in the following build:
https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5

Bug: 1068400
Change-Id: Ie741f01d887c262139c0f4f951bc4c683444f415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292706Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#787812}

There was a bug in this test, but the fixed test has now been imported,
so we can safely remove expectations.

Bug: 1093622
Change-Id: Ice3da9052d863b320aeb0cd81602a8186860e02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292217Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787811}

Moves the core ProfileReportGenerator class from chrome/browser to
components so it can be reused by iOS. The desktop implementation of the
delegate is staying in chrome/browser.

For easier reviewing, the core class still takes the concrete delegate as
constructor argument, but in the following CL, this will be changed to use
the reporting delegate factory.

Bug: 1091936
Change-Id: I8f8ece003f24ba7c660f597562ae4448e737cc0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288812Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#787810}

Context:
PaymentRequestDelegateImpl is an internal class of
PaymentRequestFactory. It was made non-static just to reuse
PaymentRequestFactory#getWebContents. Since static internal class is
generally a more preferable code practice than non-static internal
class, we should refactor to make it static.

Before:
PaymentRequestDelegateImpl is not static.

After:
PaymentRequestDelegateImpl is static.

Change-Id: Ic5a8b45cb66c0c729751b1b0222c5ba77133b1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295220Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787809}

Following changes in https://crrev.com/c/2290535 from isFile/isDirectory
to kind, and following changes in http://crrev.com/c/2285670 from
getFile/getDirectory to getFileHandle/getDirectoryHandle.

Bug: 1103841, 1103022
Fixed: b/160828615
Change-Id: I9ca756c54a072e2049d1b176805138ccde8c17b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293177
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787808}

Baselines were generated in the following build:
https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5

Bug: 1068400
Change-Id: Id440f7d672e39ab52511edd128f8cdc2662f4a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293004Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#787807}

Add connection failure metrics into histogram. This will
be published for interface specific network connection
failures.

BUG=chromium:1085300

Cq-Depend: chromium:2277056
Change-Id: Ied6b33cb7420ea2574422d4f958d4adc585ab52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288764
Commit-Queue: Abhishek Kumar <kuabhs@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787806}

Change-Id: Icd8f0a84e6ae6fa9c68c4d34b91ad44fc5fff6ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285749Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787805}

Supports range-based for loop to get |NGPhysicalBoxFragment|.

Bug: 829028
Change-Id: I8473172ea723c725f63637307e189ae8abc52f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291293
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787804}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85f14941793d..5f4c6e5b4c89

2020-07-13 patrick.brosset@microsoft.com Grid: Make line number labels consistently sized
2020-07-13 tvanderlippe@chromium.org Add @types/codemirror
2020-07-13 tvanderlippe@chromium.org Reset OWNERS of BUILD.gn to INFRA_OWNERS
2020-07-13 tvanderlippe@chromium.org Move devtools_module_entrypoints to separate gni file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1047356,chromium:1097043,chromium:1098730
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3afc6f3357254d273bc9e1b87969848162011c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#787803}

Dumps only when a new flag |DumpItems| is specified, not to
break existing unit tests.

For now, |NGFragmentItem|s are dumped in the same format as
layout tree dump for now. We can  make this more similar to
|AppendFragmentToString|.

Bug: 982194
Change-Id: I6d12de2d9784ffdffef7e7d6450d229f84ca5f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294740Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787802}

Baselines were generated in the following build:
https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5

Bug: 1068400
Change-Id: Idcc55d4edf716f685baa570a28f8fdc202f2e414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293003Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#787801}

The scheduled download currently will be started when we restart the
browser. The download schedule struct is not written to the db.

Bug: 1104673,1078454
Change-Id: I1f39f4517250e0aa2dcce4696feab90a94cb8851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294340Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787800}

Since cflags currently ends up empty except for the mllvm flag in
compiler_codegen on Windows, just don't copy cflags to asmflags
on Windows for now.

This should go away in a week or two anyways.

Bug: 1104915
Change-Id: I7538e1297df69f0a066f84756ededbae5fd615ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295323
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787799}

Rename only; no functional change.

Bug: none
Change-Id: I71b3c7fd651d716d0df3ccc90b9f065799cf9053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290872
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787798}

It was observed on Fievel device.
When ActivityStorage::LocalTimeToUtcDayStart is called with
parameter being base::Time::Max(), it returns timestamp
like 1939-01-12 08:00:00.000 UTC, and all activity intervals
referring to year 2020 are filtered out.

It looks like in certain SDK timestamp.LocalMidnight() does not
work correctly, when timestamp.is_max().

As a workaround, the code will no longer call it for Max timestamp.
This can never happen to actual intervals, only to a report
threshold.

Bug: 1104428
Change-Id: I1704e6fe43f7c42517653c007f293aa7c3b0eb56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293264Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787797}

Running SuperSize-archive on TrichromeGoogle.ssargs fails because the
largest .so file cames from Google3, but its data (.map and unstripped
.so file) are unavailable.

This CL implements a workaround: Change Trichrome's generated .ssargs
files to specify --no-native for Trichrome Chrome to disable native
code processing.

Bug: 1103271, 1040645
Change-Id: I1af591738ef6b1e8375c21b3272017a5da1fd6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293167Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787796}

This reverts commit f4332f96.

Reason for revert: broke dialogs during tab reparenting,
see crbug.com/1103617

Original change's description:
> Speculative fix for app modal dialog crash
> 
> Cancel JS dialogs when a WebContents's delegate is set to null, as the
> dialog can't show without a WebContentsDelegate.
> 
> Bug: 1060986
> Change-Id: I5272faa23d5461fc8251887d9bc02f03c54e37e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283388
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#785954}

TBR=avi@chromium.org,estade@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1060986
Change-Id: Icab13a52cde868b8a9339d1bb1e585a1ab9aa24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293477Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787795}

This also unbans gmock. gmock has been used with success in //base as
well as many other components. Additionally, there is investigation to
creating a set of mocks in Views for help testability.

BUG=134675

Change-Id: Ic54d0855b3a958eed02bf0aafe9a4613e8c6be13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293009
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787794}

Baselines were generated in the following build:
https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5

Bug: 1068400
Change-Id: I53c8756ba52e99123741859b457aca20e33ace6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293316Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#787793}

map returns an iterator in Python 3, causing the comparison to fail,
use list comprehension instead.

Bug: chromium:1068191
Change-Id: I95014b4568faeb6e0901f0ae695504f51258016a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293619
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#787792}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

Bug: 1097092
Change-Id: I086ceb10e88a657c91d8d4938e49ee85f7d66f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295082Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787791}

Bug: 1095208
Change-Id: Iaac0f618d574ba505b9dc9b048ca5e0749925edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283412Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787790}

As per the UI mocks of update required screen, the title of the admin
message container is to be shown in bold.
This is applicable only to ChromeOS.

Bug: 1048607
Change-Id: I9d25024ca12aee5b54232c31dc7a4d52f3488573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292521Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#787789}