- 10 May, 2019 40 commits
-
-
David Jean authored
Since history always has normal browser state, even in incognito, pass down a new load strategy forcing incognito from main_controller. Catch a load in current tab for the other mode and forward to other service. Fix crash with calling pre-render before checking if we have a web state. Bug: 960728, 960732, 947005 Change-Id: I591e60ea7bf1e08ac27d6b63b8ba60fffa03e938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599466 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#658544}
-
Ilya Nikolaevskiy authored
Bug: chromium:930186 Change-Id: I7921ae4ce5d787e45e350db6a1a83b59201c024f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594714Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#658543}
-
Egor Pasko authored
More than once folks did not realize that the benchmark requires building maps_go_webapk. Explain it in the error message. Also explain more verbosely the very unobvious flags that are required to make Telemetry happy. Bug: 961624 Change-Id: Ibc2e895424c902cd7180a2e830eea60f3952f90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605415 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#658542}
-
Christian Biesinger authored
Fixes several DumpAccessibilityTreeTest.* content_browsertests with NG enabled. Change-Id: I0555c4077d8db33c0c3a79901ead009f043e55ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600966 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#658541}
-
Mikel Astiz authored
The sync (store) birthday can only be empty during the very initial interactions with the server, when control datatypes are downloaded, after enabling sync (or the user signing in, for sync-the-transport mode). If, during startup, the birthday is empty, we should throw away all sync metadata and redownload everything. One way to do so is to regenerate the cache GUID, which datatypes detect as mismatch and leads to all sync metadata being cleared. As can seen in newly added tests, the scenario seems hard to reproduce, but we have server-side evidence that some users run into this issue (and would even DCHECK-fail for DCHECK-enabled builds). Bug: 923285 Change-Id: If9e4807a086001931fd65f3e12a1ab53c4a33c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599456Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658540}
-
Charlie Harrison authored
This CL removes PageTrackDecider and BrowserPageTrackDecider, in favor of just putting relevant logic in the MetricsWebContentsObserver. This logic is a holdover from when page_load_metrics logic in the renderer process also did filtration of page loads that should not be tracked. This logic has been gone for a while now, so it doesn't make sense to include any abstraction layers here. This is purely a refactoring CL and is intended to have no behavior changes. Bug: None Change-Id: I794d984e767eba0963cdd71075e24bcbcb0d2aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602554Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#658539}
-
Stephane Zermatten authored
Before this change, the Focus action usually scrolled smoothly elements into view at 1/4 of the screen size. This sometimes failed, as right after smooth scrolling started, scrollIntoViewIfNeeded is called which, if it scrolls something, interrupts the smooth scrolling. The result is that the element is sometimes left too low on the screen - though always visible. This change disables smooth scrolling, which avoids the race condition. The cost of that is that we lose the nice scrolling animation. Bug: b/132137331 Change-Id: I9f43e8a26cea6d6202262dd8b84a60efd45f9e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599451Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#658538}
-
Morten Stenshorne authored
Remove old expectation file that caused the test to fail. TBR=yosin@chromium.org Bug: 891427 Change-Id: I740b7c208e921edc45066ef4c8b6dc8eb09f6291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605699Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#658537}
-
Mohamed Abdelhalim authored
This reverts commit 240cded6. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=957212 Original change's description: > Navigation: Move NavigationHandleImpl::ReadyToCommitNavigation to NavigationRequest. > > This is the second part of splitting > https://chromium-review.googlesource.com/c/chromium/src/+/1554767 > > Next steps: > Move the remaining members from NavigationHandleImpl to > NavigationRequest, and merge NavigationRequest::NavigationHandleState > into NavigationRequest::NavigationState. > > Bug: 916537 > Change-Id: Iff2193f6167f12301b84ae35be5ba6cdb1c5356b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578543 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653236} Bug: 957212 Change-Id: I720848cecd3e12c2b5ad30bfd348bbee5684ea0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605693Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658536}
-
Julian Pastarmov authored
Requested in b/117660113. BUG=none Change-Id: I31b8b22a3d504c78c25f0cd895e29c9da6f8db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584329 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#658535}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/199295882d87..fb8c856afa8f git log 199295882d87..fb8c856afa8f --date=short --no-merges --format='%ad %ae %s' 2019-05-10 nisse@webrtc.org Revert "Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN" 2019-05-10 eladalon@webrtc.org Reland "Rename configurations_ to vpx_configs_ in LibvpxVp8Encoder" 2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5f38b3b2..def6b1e7 (658382:658489) 2019-05-10 nisse@webrtc.org Move kRtpCsrcSize from common_types.h to rtp_headers.h Created with: gclient setdep -r src/third_party/webrtc@fb8c856afa8f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:961253,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic23c890a324a3210b060109b9ae949b1bad9febe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658534}
-
Anders Hartvoll Ruud authored
BUG=641877 R=futhark@chromium.org Change-Id: I472d9e6a9fd0eb7009ed43ca5eefcad40e1b9b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605412Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#658533}
-
Polina Bondarenko authored
WilcoDtcSupportdBridge should be started regardless of the result of Wilco DTC upstart job, since if the wilco DTC was already running, the job returns an error. BUG=b:132311683 TEST=local device Change-Id: I2f697ee4ae600ffc7d2b33c6cd90ffd8d8ab9121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602723Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#658532}
-
Maksim Ivanov authored
This is a cleanup CL that removes code related to Gaia V1 API ("blue-style Gaia"). The V2 API has been the default since almost 2 years - see commit 264e791e. Before this CL, V1 API could still be enabled via the command-line switch, but it seems that as of today there's no one who uses this flag anymore. This CL removes the command-line flag, makes the V2 API being used unconditionally, and removes some C++/JS/CSS code that existed to support switching between V1 and V2 APIs. manual testing of the visual look of OOBE login and enrollment Bug: 961290 Test: existing tests, Change-Id: I2ca26c92b2e2ff7146e7f389825bea7704186efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602639Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#658531}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3794c6f3ef5..5c293b71dc3e git log f3794c6f3ef5..5c293b71dc3e --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Bump buildtools system/core to newest version." Created with: gclient setdep -r src/third_party/perfetto@5c293b71dc3e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I894ac3421931da45fa0032cf92862d0c252528fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605861Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995da00b992c..62d6b621decf Created with: gclient setdep -r src-internal@62d6b621decf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I717e07abd967c14b7795584b6a551725baddf7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658529}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/cd86d0d20a..aa468ad755 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/cd86d0d20a..aa468ad755 Bug: None Change-Id: I60b77aab9d6bf82fb8f914ff67b07ae3edbdf51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599604 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658528}
-
Dominic Battré authored
This reverts commit 72316111. Reason for revert: Speculative revert, see crbug.com/950159 Original change's description: > Use DocumentInterfaceBroker to register AppCacheHost > > This CL uses DocumentInterfaceBroker to stop passing frame ID > over mojo from WebApplicationCacheHostImpl for the render > frame path and moves AppCacheHost registration and |host_| > from AppCacheBackendImpl to AppCacheServiceImpl. > > Now AppCacheBackend is only used for workers and it registers > AppCacheHost through AppCacheServiceImpl. > > Bug: 950159 > Change-Id: Ic1ba441a6a4bb7f430cf8fce8267ba69a7a4c32c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589478 > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658481} TBR=dgozman@chromium.org,kinuko@chromium.org,mek@chromium.org,haraken@chromium.org,jkim@igalia.com Change-Id: Ife2c87e8f79912f15ed925c85458b5becfa8490b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605416Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658527}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit a1092aed ("Fix leak in FontService PPAPI fallback function"): ../../components/services/font/ppapi_fontconfig_matching.cc:130:8: error: no member named 'unique_ptr' in namespace 'std' std::unique_ptr<FcLangSet, decltype(&FcLangSetDestroy)> langset( ~~~~~^ Bug: 957519 Change-Id: Ia1425d5b7046ebeb8d7351a184a9cc119bf9d8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605689 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#658526}
-
Thomas Tangl authored
Replace the settings-privacy-page element with a settings-personalization-options element. (The code for the metrics reporting was moved to settings-personalization-options as part of UnifiedConsent.) Bug: 960259 Change-Id: I919248f4078bbca438611fc0e64da907fe86ef2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604269 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#658525}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: If34020a8d2e823e33b3a76f61af44530603a653a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605691Reviewed-by:
-
Daniel Cheng authored
This is a reland of 28eb992f Fixes: - Disable sanitizers in the test helper. The test is intended to test baseline behavior with max optimizations/undefined behavior, and the assumption is that sanitized builds will, in fact, be saner. - Relax the nonce check, as the compiler can reorder IMMEDIATE_CRASH() blocks in the function epilogue as it wants. Original change's description: > Add test to verify the opcodes generated by IMMEDIATE_CRASH(). > > Bug: 958675 > Change-Id: Ica6b5bab7849f227567d8016354a39383533799f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595585 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658344} Bug: 958675 Change-Id: Ic1af1994909d58427cc12f1f9aee2765aa5b449c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604487 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/952b571a4ac7..199295882d87 git log 952b571a4ac7..199295882d87 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 oprypin@webrtc.org Qualify cmath function calls 2019-05-10 eladalon@webrtc.org Reland "Refactor handling of configuration overrides from Vp8FrameBufferController" 2019-05-10 nisse@webrtc.org Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN Created with: gclient setdep -r src/third_party/webrtc@199295882d87 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1b6739fbc385fbde482a70cfc2897a0fe09a622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604097Reviewed-by:
-
Antonio Gomes authored
This is a reland of 2f2d5d96 This revised CL fixes the missing include of third_party/blink/renderer/platform/scheduler/public/thread.h , originally missing. TBR=haraken@chromium.org Original change's description: > Onion soup canvas_capture_handler.cc/h > > This is a first step to OnionSoup content/renderer/media_capture_from_element/. > > It summary, this CL > > - Moves content/renderer/media_capture_from_element/canvas_capture_handler* to > third_party/blink/renderer/modules/mediacapturefromelement/. > - Adapts the existing code for Blink restrictions, eg use WTF::Bind > instead of base::Bind. > - Removes the code that used to plumb the creation of > content::CanvasCaptureHandler instances through blink::Platform, and make > blink::HTMLCanvasElementCapture to create it (see the second TODO > below). > > To be done (follow up CLs): > > - migrate some remaining base::Bind{Once,Repeating} uses to the > respective Blink/WTF alternatives. This is now blocked on having > a CrossThreadBindOnce implementation available (see > crrev.com/c/1597228). > - eliminate blink::WebCanvasCaptureHandler > third_party/blink/public/platform/web_canvas_capture_handler.h. > Note that this is not done now because there is code in > third_party/blink/renderer/core/html/canvas/canvas_draw_listener.cc|h > that use blink::WebCanvasCaptureHandler, and can not use > blink::CanvasCaptureHandler directly, because core/ can not depend on > modules/. > > R=kentaro@chromium.org, guidou@chromium.org > > BUG=787261 > > Change-Id: Id2dc1f6441e2568c8420f0849a2cb5f87f9a6d75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600898 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#658376} Bug: 787261 Change-Id: I9b5829d82c1b5420a5fc8c4cbb33505284471912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605560 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#658521}
-
David 'Digit' Turner authored
This CL implements step 2 in the refactoring described by http://crbug.com/951391, which attemps to port the viz component and service to use our new shared memory API (base::SharedMemory is deprecated). It modifies SharedBitmapManager::ChildAddedSharedBitmap to accept WritableSharedMemoryMapping values directly. This simplifies the implementation and gets rid of Mojo handle usage to pass shared memory region, in favor of the new base::UnsafeSharedMemoryRegion and base::WritableSharedMemoryMapping types. BUG=951391,795291 R=alexilin@chromium.org, enne@chromium.org, danakj@chromium.org, piman@chromium.org, samans@chromium.org, liberato@chromium.org Change-Id: I0314f43f64fc4cd5591c65816b764adb97fe6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571648 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#658520}
-
David 'Digit' Turner authored
This CL extends the LoadParams struct to allow loading a library from an existing file descriptor and/or a reserved memory mapping as well. This will be used later to implement a wrapper for android_dlopen_ext() that support ANDROID_DLEXT_{USE_LIBRARY_FD, USE_LIBRARY_FD_OFFSET, RESERVED_ADDRESS, RESERVED_ADDRESS_HINT}. + Provide new tests to verify that the feature works properly. + Fix FileDescriptor move assignment operator for 64-bit unit tests. BUG=936001 R=pasko@chromium.org, agrieve@chromium.org, cjgrant@chromium.org Change-Id: I1ed174dfa268f780c5397f6e76c659f8fa57c935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564111 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#658519}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5dc689c12028..95e58587bed9 git log 5dc689c12028..95e58587bed9 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src e291f7a09f67..2dd4ab3a4acb (4 commits) Created with: gclient setdep -r src/third_party/angle@95e58587bed9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ieb4a364446439c723edde1b9c03c740a594c743b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604096Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e959bcf..fb60ce92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9796f1cb99bcd2a0f08d311b272ba1ea021422d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605301Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658517}
-
Martin Robinson authored
When grabbing focus or setting the sequential focus navigation starting point for AtkText nodes, we should use the character offset to set it on the proper child node. This ensures that tab navigation works as expected after calling AtkText APIs on a parent node. Bug: 955349 Change-Id: Idf8677f7d4fb205fee46905c80fb1bf5bc9baf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599616 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#658516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be6aa332df1b..995da00b992c Created with: gclient setdep -r src-internal@995da00b992c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I1a5f8243a13aa6051416b66befb6ca6e918bb66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604094Reviewed-by:
-
Rune Lillesveen authored
Introduced in: https://crrev.com/bf7739c4947015b9ddfd245f28ea35de58fe45f8 Caused various fuzzer crashes. R=andruud@chromium.org Bug: 961535, 961520 Change-Id: I84fc226afb690fab5cbf07d7ca6aa9b79b4e2f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605406Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658514}
-
alanlxl authored
Add an internal page (chrome://machine-learning-internals) to debug ML Service models and test connectivity/performance. Currently it supports a built-in TEST model which add two floats. What is planned for this page: * Each built-in model can add a tab here, if it's worthwhile to help debugging of on-device issues. * Plan to add performance metrics (i.e. latency) of different operations. * Plan to add control operations like Disconnect/Connect from ML Service. Bug: 924738 Change-Id: I23ff4ad93c532b7c1fc951a7ede1cb376b551f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1411959 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658513}
-
Javier Ernesto Flores Robles authored
When the return key in the keyboard is pressed, the following text field will become first responder. If there is none, the current text field resigns first responder to hide the keyboard. Bug: 960420, 951300 Change-Id: I6497bc9e1930b06054ab2946665e4836de94d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602497 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658512}
-
Finnur Thorarinsson authored
The new permission they added in earlier betas has been removed and a new RELATIVE_PATH column has been added, which replaces the DATA column (being deprecated). Bug: 905257, 656015 Change-Id: Ie30d234a031920fdb6487732c8d5a719267d9e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602719 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#658511}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72316111. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I650f0f468b4d2936a4d3809ef7ba086d26658761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605302Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658510}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c59e4b6dba6..f3794c6f3ef5 git log 8c59e4b6dba6..f3794c6f3ef5 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Turn --pid and --name into comma separated lists." Created with: gclient setdep -r src/third_party/perfetto@f3794c6f3ef5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia93909d03b7a5772a2ee91b8523301dcdf9e6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604092Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I162bdbdb5de4a5f094cf631f769878cc90c46b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602096 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#658508}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/09537e93fddd..4c03bf558364 git log 09537e93fddd..4c03bf558364 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 perezju@chromium.org [Telemetry] Remove old code for ClockSync as AsyncEvent Created with: gclient setdep -r src/third_party/catapult@4c03bf558364 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947675 TBR=skyostil@google.com Change-Id: I022f1c0e6a187b9fecdb1d532c2bc043d293e29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605209Reviewed-by:
-
Dominic Battre authored
TBR=alph@chromium.org Bug: 959129 Change-Id: I90a383f3ee617f58614b14f0d54675ffc612b703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604266Reviewed-by:
-
Oleg Davydov authored
For further investigation of issues with forceinstalled extensions we need to know what happens with extensions in downloading stage in a more detailed way. We already collect data for this (in InstallationReporter via ExtensionDownloaderDelegate), so this commit introduces an UMA histogram. Change-Id: Id4d13b9e9678d0f7ef5bd30fbfbfebd7e57291bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587032 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658505}
-
