- 07 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/727115e42480..83e394a59e78 Created with: gclient setdep -r src-internal@83e394a59e78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059158 Tbr: jbudorick@google.com Change-Id: I56b758926d24c7d7c3048075207eb5d34ebb6749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092714Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747985}
-
Daniel Clark authored
This change moves the logic for handling highlight-on-hover for cells in date controls out of the JS and into :hover CSS rules. I'd originally planned for this work to wait until the old form controls implementation was removed. However, the highlight-managing code is setting ARIA attributes in a way that doesn't make sense now that the highlight positions no longer drive selection and are merely decorative. So as part of improving the screen reader experience for these controls it seems best to go ahead and do this work now. The highlight-managing code is now all effectively dead code when FormControlsRefresh is enabled that can be straightforwardly chopped out when the time comes to remove the old implementation. A follow-up change will ensure that the correct ARIA attributes are set for selection changes. Bug: 1046054, 1053798 Change-Id: Ie5081ef23b308a82bfc03887f96c912a82f411b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083866 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747984}
-
Ian Wells authored
Add StreamModelUpdateRequest and functions for converting wire protos into store protos Bug: 1044139 Change-Id: I243ebabc331884500dec480c69d843d38546a34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#747983}
-
Henrique Nakashima authored
CachedFeatureFlags should not have feature-specific code. Move the code in it related to Start Surface to a new class StartSurfaceConfiguration. Since many other packages check whether the start surface is enabled, the class is public. Bug: 1012975, 1058104 Change-Id: I3ee516ca4cab32f1b0f727192f0a32dfdbf3f050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070967Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747982}
-
Xinghui Lu authored
Based on the comment in https://crrev.com/c/2067462, to make the implementation of remote database manager and v4 local database manager consistent, remove the NOTREACHED() in the CancelCheck method. Bug: 1050859 Change-Id: I1bf9bbc5ec76864274085c57e3e4e98a8622bebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083569Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747981}
-
Chris Davis authored
This change removes a number of static initializers throughout the codebase. In most cases, code was moved to a function that returned a reference to a local static which is created on demand. I also made upstream changes to unrar, openvr and openxr which had static inits in their code which were appearing in chrome.dll. I am including the changes for unrar since that code doesn't get updated locally and the codebase had diverged with local changes. Bug: 341941 Change-Id: I3de5b282b0243dda86fa913f2677794373ae5c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088955Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747980}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ib823528514afe8743c6af5a055a8c7923e90ef95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089697Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747979}
-
Xianzhu Wang authored
The '_ms' postfix was redundant with the 'ms' unit of the measurement, and was inconsistent with other record_time measurements. This is a safe rename because the measurement is neither used nor monitored anywhere. Change-Id: Ibe8d72c41b6116213e0cddbd61085bd9e438474b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092672Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747978}
-
sauski authored
As part of the Friendly Settings Privacy settings redesign the "Do not track" toggle is being moved to the cookies page. To make moving cleaner this CL first creates a new custom polymer element and tests encompassing the toggle and the associated dialog. The new element is then placed in both locations in sections whose visibility is already controlled by the privacySettingsRedesign flag. Bug: 1032584 Change-Id: Id3190592989174fa7a0c51f7263844a1326e7ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092136Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#747977}
-
Philip Rogers authored
This reverts commit 3088046f. Reason for revert: Suspected as causing a ProxyCommit regression. Original change's description: > Skip commits for painted scrollbar thumb movement > > Painted scrollbars are used for overlay scrollbars on MacOS. Thumb > movement would cause a commit on every scroll change because the update > rect (set via Layer::SetNeedsDisplay) would change. This patch ignores > the update rect in PaintedScrollbarLayer::Update and uses part > invalidation for causing commits. With this change, scroll offset > changes do not cause commits. > > Bug: 1048384f > Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745544} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048384f, 1059436 Change-Id: I7e6e36fca7afecae35d969ca655965984a90e891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092185Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747976}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I301486ab2d3e9c84decfca20333968c48a8ce50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090365 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747975}
-
Xianzhu Wang authored
It contained only one demo test. Remove the benchmark because https://chromium-review.googlesource.com/c/chromium/src/+/2090977 makes record_time_partial_invalidation work for all web pages. Most of the changes in this CL were automatically generated by tools/perf/generate_perf_sharding.py. Change-Id: Iff8d805d83b845b03890af3113c0024f1e2c879f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092178 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Mei Liang authored
Change-Id: I45a9c08d8846f5e9c4dca549a23cddb85b4bc3b1 Bug: 1059299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092120Reviewed-by:
-
Regan Hsu authored
There is currently a delay in disabling the 'Confirm' button when the user submits a new PIN. While the PIN is asynchronously updating, the user can also continue typing into the PIN field. This CL disables the (1) 'Confirm' button and (2) PIN keyboard when the user submits a new PIN. The 'Confirm' button and PIN keyboard are re-enabled after the asynchronous update completes. Fixed: 1054322 Change-Id: Ied13b3b57bde18e9279d2f3a7bc02e3ad4188bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085595Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747972}
-
Karan Bhatia authored
This should be helpful to diagnose if the per-rule memory limit should be changed. BUG=974391 Change-Id: I42d5630ba9d1dde40fb963f13d9513cdbe7ca893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084676 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747971}
-
Noel Gordon authored
Follow-up to CL:2090553. Caret icons should be a 20px x 20px box based on the spec, so give them 20px CSS height and width. Add display so we can CSS transform the caret box as a unit. The -webkit mask-image arrow_left.svg used as the caret box background has SVG viewport 20px x 20px and 20px width/height attributes. No need for a -webkit-mask-position: center [1]. For RTL, read that from the main page HTML element (:host-context) and CSS transform the caret box with rotate(-180deg) when in RTL. Manually tested that it rotates correctly for <html dir=rtl>. [1] Visually, the arrow-left.svg content does not seem to be perfectly centered of its SVG viewbox. The content appears shifted slightly left to my eyes. Possible bug in that SVG icon, just noting. Asset images/files/ui/arrow_left.svg added in CL:2090553 is now unused and will be removed in a follow-up CL. Tbr: alex No-Tree-Checks: true Bug: 1035691 Change-Id: Ida53f6885be1f991cc285af5b19e5cba2d8ee365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093072Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747970}
-
Luum Habtemariam authored
Print preview currently has a constant maximum copies allowed (of 1000). Since we're now reliably getting the max copies supported from each printer, this change plumbs that max to the print preview UI and errors the user appropriately. Main changes: - Added separate CopiesCapability and CopiesTicketItem representations, as per the spec (https://developers.google.com/cloud-print/docs/cdd#cdd) Bug: chromium:1027830 Test: manually confirmed behavior and tests pass Change-Id: Ibcf53b9a43328e1846fd485c2e300420832499a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055351 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747969}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a5c7a16ba71..03ed5f6c4698 git log 1a5c7a16ba71..03ed5f6c4698 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 ianelliott@google.com Revert "Instantiate rx::DisplayEGL when device type EGL is selected" Created with: gclient setdep -r src/third_party/angle@03ed5f6c4698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ie7d11850c370716d5186f2e72e3e3a6623bfef53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747968}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie80da210c1aacbf4bcb7424550165efdc2173996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092991Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747967}
-
Xianzhu Wang authored
Instead of invalidating an element with specific element id which workred for one test only, now skip cache of display item and subsequence at pre-defined intervals, which works for any web page. Remove benchmark rasterize_and_record_micro.partial_invalidation which contained only one demo test and was not monitored. I plan to replace record_time with record_time_partial_invalidation for rasterize_and_record_micro.* benchmarks in the perf sheriff monitor list. Change-Id: I6515d08ac56b21573b1ba6986fb1cb2a00221c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090977 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c46171246cf5..97c0ebd7cc1e git log c46171246cf5..97c0ebd7cc1e --date=short --first-parent --format='%ad %ae %s' 2020-03-06 mathias@chromium.org Reland "Support emulating vision deficiencies" Created with: gclient setdep -r src/third_party/devtools-frontend/src@97c0ebd7cc1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12ed8ed86c37e138cd5ce2d58e9a45e54e677c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092456Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic89a35f09601c47e069ba395f1b911fed30e64d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092082Reviewed-by:
-
Michael Spang authored
It's an error to enable VULKAN without exposing fuchsia.vulkan.loader.Loader in the sandbox. The rest of the flags are still ignored and left as a TODO. Bug: 1059497 Change-Id: I96a4c1f51b5ee76f5df075a53afd92e029169f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093052 Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747963}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b3bfbaa3217f..0c5c7ea9e66a git log b3bfbaa3217f..0c5c7ea9e66a --date=short --first-parent --format='%ad %ae %s' 2020-03-06 ericlaw@microsoft.com [NetLog Viewer] Show loaded filename in title Created with: gclient setdep -r src/third_party/catapult@0c5c7ea9e66a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058919 Tbr: nuskos@google.com Change-Id: I68761464e70c45ad6ebd880671f83183d63afc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092453Reviewed-by:
-
Evan Stade authored
This is like navigate(), but replaces the current navigation entry. Change-Id: I479464cf3f6c1f349139890c1c5e7819bbb8b5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086266Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747961}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85560e5c. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifc823ae6be36a2bdae15eafe45143865978aaff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092631Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747960}
-
Caleb Rouleau authored
Provide better overview. Provide link to go/chrome-benchmarking-sheet. R=wenbinzhang@google.com Bug: 949246, 1054000 Change-Id: I5a36bd5d362b1e8fa28cd90ef7a973f503d62d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092058 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#747959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24a8e9e170f7..1b0124fec65c git log 24a8e9e170f7..1b0124fec65c --date=short --first-parent --format='%ad %ae %s' 2020-03-06 brianosman@google.com Move interpreter disassemble to out-of-line member of ByteCode 2020-03-06 mtklein@google.com Revert "Split building encoding from decoding" 2020-03-06 brianosman@google.com Handle runtime effect shader errors better Created with: gclient setdep -r src/third_party/skia@1b0124fec65c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ib649767fae068f078644dc317402a829105a465a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092454Reviewed-by:
-
Karan Bhatia authored
Remove a stale TODO from declarativeNetRequest code. This was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2016201. BUG=974391 TBR=lazyboy@chromium.org Change-Id: I374b08f428491cdd678c334238de8d5d3d23aba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092873Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747957}
-
Collin Baker authored
TBR=arakeri@microsoft.com No-Try: true Bug: 1058244 Change-Id: Ib1e272813e477245a98901ce9d6fe611616a252e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092876Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#747956}
-
Aaron Leventhal authored
Bug: 1059187 Change-Id: I6d42d40d5d6971ddba41c2fe62cb39e7b1e1b9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092431Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747955}
-
Marijn Kruisselbrink authored
This changes NativeFileSystemPermissionView to not only support asking for write access, but to also support asking for read access (as well as asking for read and write access at the same time). Also changes the origin scoped permission model to go through this new code path when asking for read access. This does not hook anything up yet to ask for read and write access at the same time (that will still DCHECK in the content layer), dealing with that case will be handled in a follow-up CL. Bug: 984769 Change-Id: I5fc276b11802e105379ae42e0f6abf84f2c7d81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091920Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747954}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2824af525d..57d4742bbb10 git log 4d2824af525d..57d4742bbb10 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 ehmaldonado@google.com git-cl: Tell users to set SKIP_GCE_AUTH_FOR_GIT=1 when running on cloudtop. 2020-03-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@57d4742bbb10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1059141 Tbr: agable@chromium.org Change-Id: Icb14cfc48478070475b4215e3740ce6dc38c4c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092452Reviewed-by:
-
Anastasia Helfinstein authored
The specification for the Switch Access menu (see bug for full details) specifies that the menu should be translucent, with rounded corners. To accomplish this, we need to make the underlying view transparent. Previously, the menu showed with a white background filling the bounding box. Bug: 973719 Change-Id: I101bb6203fd8c972f7b235821e0f0a51cafa25e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085596Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#747952}
-
rbpotter authored
Support /* ignore */ annotations in Polymer modulizer, following the same approach as the JS modulizer. This will be used to temporarily migrate settings_idle_load and settings pages that depend on it, before adding lazy loading to the Polymer 3 page. Bug: 1026426 Change-Id: Iaf2b3d1e3ba69f97946039522d86ecf2739370cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092183Reviewed-by:
-
Yicheng Li authored
Extend the expiration date for most fingerprint authentication UMA metrics, except two: 1. Fingerprint.Unlock.MatchIgnoredDueToPowerButtonPress This was introduced to verify that the fix for the race condition between power button press and fingerprint match on Nocturne works. This metric shows that ratio of matches ignored due to power button press on Nocturne is stable and reasonable, so we can assume this worked and no need to further track it. 2. Fingerprint.Unlock.MigrationForPositiveMatchSecretResult This was introduced to verify the migration to positive match secret works. Since the migration worked and not many devices are expected to run old fingerprint firmware after M85, we can let it expire. BUG=b:148979792 TEST=none Change-Id: Idf78ebfb2a568414f989b2120b486a227b7d1ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090872Reviewed-by:Christopher Thompson <cthomp@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#747950}
-
Tina Wang authored
After inherit from TextBubble, the ProfileCardView is no longer a view, so it can't be the label of the layout file. Change-Id: I79f0785eac13b33c3ab572d8cac0e78b2a26e6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092216Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747949}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c13b2f02094..b44162fdbb25 git log 8c13b2f02094..b44162fdbb25 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 madesroches@google.com Support for the largePoints feature in Vulkan Created with: gclient setdep -r src/third_party/swiftshader@b44162fdbb25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1f52ff1aeafd5045b8b0b042944070723497e1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091672Reviewed-by:
-
Li Lin authored
Also change the text to string16 as it will mostly used for rendering UI. Bug: b/150783279 Test: Unit tests Change-Id: Ib940ebec905c22a75152a437d8e6c12f33ae4777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092057 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747947}
-
Haiyang Pan authored
This reverts commit 01102b89. Reason for revert: Caused 30 test failures in lollipop phone tester at https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24514 Original change's description: > [Android Refactor] Replace StatusBarColorProvider > > This CL: > - Makes StatusBarColorController use TopToolbarThemeColorProvider > instead of StatusBarColorController.StatusBarColorProvider > - Deletes CustomTabStatusBarColorProvider.java > - Renames TabThemeColorProvider to TopToolbarThemeColorProvider and > makes it return the correct value when there is no active tab. > - Moves StatusBarColorController owners to RootUiCoordinator > > BUG=1015627 > > Change-Id: I0aff744a8901c00c6198adfa1a086b7de6193a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063966 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747745} TBR=twellington@chromium.org,mdjones@chromium.org,peconn@chromium.org,pkotwicz@chromium.org Change-Id: I9a75cc5fd45133234f43988b495b2566836dbc50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092559Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#747946}
-
