Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 16 Jul, 2018 4 commits
    • Nektarios Paisios's avatar
      Introduces SelectionDeserializer that receives an HTML snippet and creates a... · 00d1887a
      Nektarios Paisios authored 
      Introduces SelectionDeserializer that receives an HTML snippet and creates a selection in the AX tree

Will help with automated testing using HTML files that include selection markers.
R=dmazzoni@chromium.org

Change-Id: I7dd23b980b6966c87e09c12bdb27b8ad27c9cc15
Reviewed-on: https://chromium-review.googlesource.com/1106901
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575194}
      00d1887a
    • Andrew Moylan's avatar
      ML service: Implement D-Bus->Mojo bootstrap & add a thin client library · 5ced600f
      Andrew Moylan authored 
      This CL adds logic for Chromium to bootstrap a Mojo connection to the
Chrome OS ML service daemon via D-Bus, and a very simple client library
for client code in Chromium to use to access the ML service.

1. Bootstrap
To connect to the daemon, Chromium prepares a Unix socket pair and sends
a Mojo invitation, including a primordial pipe handle, through the
socket. The file descriptor for the other end of the socket pair is
passed to the daemon as the argument of its BootstrapMojoConnection
D-Bus method. The daemon is expected to bind the primordial pipe to an
implementation of the MachineLearningService top-level Mojo interface.

The ML service daemon side of the above interaction is added in
crrev.com/c/1123663.

2. Thin client library
This CL adds chromeos::machine_learning::ServiceConnection which client
code in Chromium can use to access the ML service. This singleton class
automatically performs D-Bus->Mojo bootstrap as necessary, and exposes
a method clients can use to bind a ModelProviderPtr mojo interface and
thereby access the ML service.

This CL also brings the .mojom files specifying the ML service Mojo
interface under public/mojom. Previously we intended to access these via
third_party/cros_system_api, but Chromium will instead maintain its own
copy of these mojoms, which will be manually eventually-consistent with
the Chrome OS copies (under src/platform2/ml). We are switching to this
recommended approach for the reasons discussed in the following doc:
https://docs.google.com/document/d/1rX3xtR6ZioKZaO-4qBFJFqFypSX1p6gAvQ_MuYn64G8
A separate CL will remove the .mojoms under platform/system_api/mojo.

Testing:

How to automatically test that Chromium + the daemon successfully
perform the D-Bus -> Mojo bootstrap is not clear and is under discussion
(comments welcome). It may have to wait until there is a client in
Chromium calling the daemon, which could then have an end-to-end
autotest.

I manually tested this against a Chrome OS ML service built with
crrev.com/c/1123663 by adding some test calls to BootstrapMojoConnection
initiated from chrome_browser_main_chromeos.

Bug: 836091, 836092, 836107
Change-Id: I3dbcaeb7a0af0bc09a56a98e68d9420cc1626d91
Reviewed-on: https://chromium-review.googlesource.com/1123964Reviewed-by: default avatarBen Chan <benchan@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
Reviewed-by: default avatarDan Erat <derat@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575193}
      5ced600f
    • skia-chromium-autoroll's avatar
      Roll src/third_party/skia 612d5214a2ae..fea9e90e2cdb (1 commits) · d7bc5df0
      skia-chromium-autoroll authored 
      https://skia.googlesource.com/skia.git/+log/612d5214a2ae..fea9e90e2cdb


git log 612d5214a2ae..fea9e90e2cdb --date=short --no-merges --format='%ad %ae %s'
2018-07-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@fea9e90e2cdb

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I9c44a4245aa7a709643a920e787b0e84ef3518f1
Reviewed-on: https://chromium-review.googlesource.com/1137783Reviewed-by: default avatarskia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575192}
      d7bc5df0
    • Sandra Sun's avatar
      Snaps after scrollbar clicking. · e98df9c6
      Sandra Sun authored 
      After user clicking on the scrollbar's track or arrows, we should snap
to the closest snap position of the container. This is done by simply
moving SnapAfterScrollbarDragging() from
ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp().

This patch also rewrites the previous
snaps-after-scrollbar-dragging.html test using the gesture-util.js, and
adds the new clicking tests to it as well.

Bug: 860768
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824
Reviewed-on: https://chromium-review.googlesource.com/1127153
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Reviewed-by: default avatarMajid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575191}
      e98df9c6
  3. 15 Jul, 2018 24 commits
  5. 14 Jul, 2018 12 commits