- 20 Aug, 2019 40 commits
-
-
Chih-Yu Huang authored
Originally, we set a timeout for flush that starts at calling VEA::Flush() and ends at flush callback is called. However, we don't know how many pending frames in VEA when we call VEA::Flush(). The delay may vary a lot due to the number of pending frames. This CL changed to set timeout of each BitstreamBufferReady() call. We could verify the time usage of each encoded bitstream buffer, and the time period between the last bitstream buffer is returned and the flush callback is called. It makes the unittest more robust. BUG=chromium:979497 TEST=run video.EncodeAccelH2642160PI420 on celes Change-Id: Ie52c9378397598aba5855d75553f7aef269bb4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720122 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688468}
-
Juan Antonio Navarro Perez authored
It appears these tests aren't running anywhere. The main test runner script does not work (fails with exception). Last changes to these files were from three years ago. Bug: 921000 Change-Id: I84dfebb24584a687d157394a6ceca707652c13c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760301Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#688467}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0803a22a..5c013580 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4d3f9ea91358e8e39e3f8fcb30c7f10d355b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760424Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688466}
-
Scott Violet authored
GetRedirectDistanceForURL() is no longer used. BUG=none TEST=none Change-Id: Ia47669629a160dab79f6d872fd96c7d6e09baa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761493 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688465}
-
Christian Dullweber authored
To correctly apply content settings, we need to know the top_frame_origin any time cookies are used. Currently we only have site_for_cookies, which is empty in third_party frames. Bug: 988398 Change-Id: Icb724aaaf89c244aa7aebdbaceb1f9a8c3c3ec91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731900 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#688464}
-
Juan Antonio Navarro Perez authored
We want to be able to import from core module in tools/perf without bringing the whole of Telemetry as a dependency. As a first step, for scripts that really need it we add near the top: from core import path_util path_util.AddTelemetryToPath() Alternatively, top level benchmark runner scripts can just import: from chrome_telemetry_build import chromium_config which *will* implicitly add to sys.path Telemetry and all its required dependencies. The implicit dependency to Telemetry in "core" will be removed on a follow up CL. Bug: 981349 Change-Id: I900366d1849341d079b45ae4201a2c6e9d1c9044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760218Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#688463}
-
Stephen Nusko authored
This improves readability, and in a future CL when I add received_packets() to allow counting of all packets (not just test ones) makes the function names meaningful. Also follow the C++ style guide and declare structs before functions. Change-Id: Id2f9cc41e0cbe49fb8162c9b979ae1744b1a53a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760949 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#688462}
-
A Olsen authored
This is a reland of 3ea87442 Turns off the tests for Mac Asan, which seems to be the only build breaking according to the flakiness dashboard [1]. Apparently, the whole test is not picked up on that builder. Also fixes a typo in onCompleted_, which looks unrelated to the breakage. TBR=olsen@chromium.org,xiyuan@chromium.org [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PasswordChangeAuthenticatorUnitTest Original change's description: > Better success detection for pw change > > Only slightly improves success detection at this stage, > by adding Azure support - Ping and Okta are still pretty > lacking - but makes room in the code for better success > detection, and adds a unit test. > > Bug: 930109 > Change-Id: I59a173095301f7c641031f79cb3a6c946c5efc09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754013 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688173} Bug: 930109 Change-Id: Ie10ba06e86afa94f852dcac65bdc3b0519248d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761591 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#688461}
-
Joel Hockey authored
Contain all FilesApp foreground access to the background object to the FileManager class. This simplifies a lot of the externs dependencies and I think it provides a cleaner API. Change-Id: I96716d0c53d538a90adfb04f9f54ce6cd7d72568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761880Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#688460}
-
Yi Su authored
Bug: 991608 Change-Id: If185af4f57f6c065373f494387121895b0dbe461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760728 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688459}
-
Mohamed Amir Yosef authored
The feature hasn't launched yet, and hence I am extending the expiry of enable-sync-uss-bookmarks flag to be at M80 Change-Id: I6223298095f58cee0cbe0c0cf1c8638309258643 Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761268 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688458}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I089547a07eb26a1e7ffb509499348390f6d1f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688457}
-
Alex Ilin authored
User can hit ANR on NTP because Chrome wants to display a Signin promo. Signin promo requires a list of Android accounts on a device to display the user name and the profile picture. The promo view is built synchronously meaning that the UI thread may be blocked waiting for a list of accounts. The list of accounts is requested through the AccountManagerFacade that maintains the accounts cache. As soon as this cache is populated, it's safe to synchronously request the list of accounts. This CL adds an additional check to SignInPromo to not build the promo view until the cache is populated. The AccountsChangeObserver will notify the SignInPromo when the cache is built. Bug: 971618 Change-Id: I3e719bd16ceb077933de410e403d6f4692cf4578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710575Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688456}
-
Marc Treib authored
This flag should get removed soon (see bug), but let's keep it around until that actually happens. Bug: 990745 Change-Id: Ibaf96e78ebcb959ae6bcc44d71e3debced233405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760964 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/978eb0dc16f8..f66a25cd28ef Created with: gclient setdep -r src-internal@f66a25cd28ef The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:954450,chromium:956776 Change-Id: I6bdb036890005bb6b58eaad065892aaa5f049364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761699Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688454}
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: Id9eae41b435aca6ce97a2fa5317d63e5b0d52d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734210Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#688453}
-
Oleg Davydov authored
We see in statistics that for some reason force-installed extensions stuck in CREATED stage. Generally it should never happen, since these extensions should immediately be moved to PENDING stage (or reported as failed). Unfortunately, we weren't able to reproduce it locally. To have the problem more localized we need to split CREATED->PENDING transition into substages. Bug: 989526 Change-Id: I4a3f1601dea67c0a75cec1c1ebcf07536ef8704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729252Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#688452}
-
Thomas Tangl authored
Reasons: - The initially focused view was only specified for the signed-out state and only for regular profiles. - Other toolbar menus(e.g. 3-dot menu) don't have an initially focused view. The profile menu aims to have the same behavior. Bug: 966388 Change-Id: I401f950c7ce02d96ac49d5c3f3375ec755ddb930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760920Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688451}
-
Tanisha Mandre authored
- Directory will contain credit card scanner specific files. - Files will inherit from 'Scanner' abstract classes in the Scanner directory. Bug: 990744 Change-Id: I42db0408701642e45b06f8402e27bdf6d4bd62c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760966Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#688450}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.LevelDBDatabase interface, and adapt unit tests. Bug: 955171 Change-Id: I309afa09e166a75d6567f409fae46fc90a04b884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755905 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#688449}
-
Takashi Sakamoto authored
TabSpinnerTest.LoadTabsOneByOne is timeout on linux-chromeos-debug. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=TabSpinnerTest.LoadTabsOneByOne Bug: 974349 Change-Id: Iaa850ebf45f7d4c301d3d0cd581cc771c917cc5f Tbr: estade@chromium.org, anniesu@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761877Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#688448}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 79747b71. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I4f33304e2b45a094e2942268b4fed61c37b96636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760423Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688447}
-
Anne Lim authored
Add instrument_token to CloudTokenData proto in WalletMaskedCreditCard. This is a part of b/133228158 Change-Id: I4a54155bc3b4b56a35ebec27292159b30a308749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761389Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#688446}
-
Takashi Sakamoto authored
The following tests are failing on mac bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=vr%2F * vr/events_vrdisplayactivate.html * vr/events_vrdisplaypresentchange.html * vr/exitPresent_resolve.html * vr/getLayers_notpresenting.html * vr/getLayers_presenting.html * vr/getLayers_presenting_nondefaultbounds.html * vr/getLayers_update.html * vr/requestAnimationFrame_consistentTimestamps.html * vr/requestAnimationFrame_handoff.html * vr/requestAnimationFrame_submitFrame_combinations.html * vr/requestPresent_resolve.html * vr/requestPresent_resolve_repeatwithgesture.html * vr/requestPresent_resolve_repeatwithoutgesture.html * vr/requestPresent_resolve_then_reject.html Bug: 914134 Change-Id: I07abd2c60026135b52d7ea47878bad14c823046e Tbr: estade@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757409Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#688445}
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: I83d46be4821ce90cce7768c7bcb2b4a1d9e15a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761870 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#688444}
-
Kent Tamura authored
This is a preparation to remove Platform::GetDataResource(name). This CL has no behavior changes. Bug: 983396 Change-Id: Ia93d07a632a0ffbe4560694a413245fd385a3e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760585 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688443}
-
Rika Fujimaki authored
Finally, I delete all methods which are not used any longer. Now that ModuleRecord is STATIC_ONLY(). Bug: 991863 Change-Id: Ia9d32245a4cb13e96307d1563fca3a0b3db0a280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755663Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#688442}
-
Kent Tamura authored
This is a reland of c182b679 without any changes. The revert didn't fix test flakiness. Original change's description: > Use base::Time::LocalExplode() to implement Document::lastModified() > > Using ConvertToLocalTime() and DateComponents:: > SetMillisecondsSinceEpochForDateTimeLocal() is hard to understand. > > Bug: 988343 > Change-Id: I997dae5b110570f438f487615e8f20dbea55af7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755435 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687529} Bug: 988343 Tbr: yhirano@chromium.org Change-Id: I6740031ba78b4fb6edf68f40449ab7e9b58f6b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761875Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#688441}
-
Ioana Pandele authored
The leak detection dialog follows the same UI pattern, thus the onboarding dialog code can be reused. This is mostly a rename CL, the only difference being that the dialog now receives the drawable id from the bridge, which is meant to allow for drawable customization for different dialogs. Change-Id: I3178bb1040e9d2495464063f642a1357117ca479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751252Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#688440}
-
Alex Clarke authored
Split off from https://crrev.com/c/1751324 There is a race condition between loading all parts of the document and running the test. This patch fixes it. Bug: 971191 Change-Id: Ie1090416758553d8e5fa36a8ac4592cd3ce5ceb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760912 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688439}
-
Alexandre Courbot authored
The "new" H.264 decoder is designed to be used with a kernel that supports request API and the upstream H.264 definitions. However the V4L2SVD still does not support requests and only works on older kernels, so make sure to select the legacy decoder for now. Bug: 987856 Test: video_decode_accelerator_tests with --use_vd on Kevin. Change-Id: Iccad414633395574b9a74f8e77c96f9ccdf3a223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761947 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688438}
-
Matt Falkenhagen authored
This allows more tests to pass when ServiceWorkerOnUI is enabled, since ChromeBlobStorageContext can be used only on the IO thread. Bug: 824858 Change-Id: I7830861183d9d18db3c2ab9fbd6a6c12b3a8a18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760844Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688437}
-
Kenichi Ishibashi authored
Post a task to the IO thread to create EmbeddedWorkerInstanceClient when off-the-main-thread service worker startup is enabled. This is a tentative workaround to avoid some race conditions which happen when we make EmbeddedWorkerInstanceClient independent from RenderThreadImpl (see crbug.com/995134). Ideally we shouldn't need to post a task. Instead we should bind EmbeddedWorkerInstanceClient on the IO thread. Bug: 538751 Change-Id: I4bdb54232fb7abde7d6d1dccf1ac3cb58db16a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761888Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688436}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.LevelDBService interface, and adapt unit tests. Bug: 955171 Change-Id: I4f0dd4904bdeb9a4942da0ccce1d55b60504a677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752838Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#688435}
-
Sigurd Schneider authored
Devtools would allow starting timeline recording when another tracing session was currently running, and entered an unexpected state when the second tracing was requested to stop. This CL prevents a second tracing session from being started and displays an error message instead. Bug: chromium:919798 Change-Id: I006953a544a7293446656fff002e68b88de44eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715083 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#688434}
-
Raphael Kubo da Costa authored
The "Build From Tarball" and "publish_tarball" builders are in the "cron" bucket, not the "ci" one. Bug: 884710 Change-Id: Ia2813076eef27d70795a18e0b2068a13b67239a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760916 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688433}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92d81e78499b..978eb0dc16f8 Created with: gclient setdep -r src-internal@978eb0dc16f8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I127a2eafd8999026925ca252dd7623a6c2de89c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761501Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688432}
-
Tamer Tas authored
This CL specifies layout tests to run with the bot. R=yangguo@chromium.org TBR=machenbach@chromium.org,jbudorick@chromium.org,bmeurer@chromium.org Bug: chromium:995657 No-Try: True Change-Id: I7dbd30705728a0555703422fe7f1d6edabb6ce3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760960 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#688431}
-
Luciano Pacheco authored
FilePathWatcher is DCHECKing when touching a directory for a recursive directory, this is due to invariant being broken between members: |recursive_paths_by_watch_| and |recursive_watches_by_path_|. Function UpdateRecursiveWatches() was erasing from |recursive_watches_by_path_|, but wasn't erasing from |recursive_paths_by_watch_|. This CL fixes UpdateRecursiveWatches() to maintain the invariant, by erasing from |recursive_paths_by_watch_| too. Test: base_unittests --gtest_filter="*RecursiveWatch*" Bug: 995196 Change-Id: Ibcc8b015d7d9b68d2eff59f4ae9e87d84d76991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757960Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#688430}
-
Andrew Moylan authored
These are still being actively used to monitor the ongoing rollout of this service. Bug: 984247,984228,984210,984202,984198,984185 Change-Id: I2d8562204d08ce47315f4fa129846eb5595b18ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761890 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688429}
-