- 31 May, 2019 40 commits
-
-
Ian Kilpatrick authored
There should be no behaviour change as a result of this patch. Bug: 813068 Change-Id: I627eeea190435b5136f5382c2d28bab66f9eb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639117Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef80e835027e..c92b6ad29083 Created with: gclient setdep -r src-internal@c92b6ad29083 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:955936,chromium:b/133794084,chromium:b/134085742 TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I51c4ed1b7b1ef7e755fc75b388e8f9a08d786360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665234}
-
Christian Biesinger authored
It's not necessary and causes problems in LayoutNG when we reuse the cached fragment inside of ForceLayout (nothing will set the height to the correct value) In the specific testcase, we incorrectly think that the block has a percentage-sized child due to the abspos item. Bug: 967061 Change-Id: If6fabc93173f025966f359510e5b600914376e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638192 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665233}
-
Raymond Toy authored
Use a static local to hold the vector of all the FFTSetup objects that can be shared across all FFTFrame objects. Modeled after how PFFFT does this. Internal change with no user-visible effects. Bug: 962644 Change-Id: I9325f94f3ee18dd19014c00a4872c74d667bf497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629429Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665232}
-
Danyao Wang authored
Also add rouslan@ and danyao@ to ios/chrome/browser/payments/OWNERS. Change-Id: I695105d983eef56101fd7325e4ea3a5d2f4c448f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637449Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#665231}
-
Robert Liao authored
Currently, WebUI refers to Views Resources. It should use the web default checkboxes already used by components like devtools BUG=967845 Change-Id: I5a56633b8ddc8b513d7407cfc5278c797e0fdff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632427 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665230}
-
Michael Ludwig authored
Bug: 967778, 948128 Change-Id: Ibf1682788ee9f444e76674f8b0d93bc33954b67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637050Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#665229}
-
Lily Chen authored
Bug: 969144 Change-Id: I58d049cfb5cbcda95fc1fb06a8fe409bbc26ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638819Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#665228}
-
Darwin Huang authored
Enables the Async Clipboard API's read and write functions, with ClipboardItem, on stable, by updating runtime_enabled_features flags from experimental to stable. Spec: https://w3c.github.io/clipboard-apis/#async-clipboard-api Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TssvWe8TzBc Bug: 150835 Change-Id: I602defa5f300832c2322e3dccb444b4c807311ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567224Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665227}
-
Andrey Kosyakov authored
Use appropriate (pending) RenderFrameHost when choosing associated RenderFrameDevToolsAgentHost in WillCreateURLLoaderFactory(). Change-Id: If72a7e056cea3f8a35f98564d9d3aed3e46f6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636684 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665226}
-
Caleb Raitto authored
Metrics are already supplied in https://crrev.com/c/1496495 -- this CL fills out the additional, non-metrics info in the RequestFinishedInfo struct. Bug: 879208 Change-Id: Ie3c51275ca1003a16a2ad2817351e436d84a3264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575736 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665225}
-
Jian Li authored
Bug: 965999 Tbr: rouslan@chromium.org,caitkp@chromium.org Change-Id: Ie5a4015599e9657f992afdf4dce18b97734efb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634563 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#665224}
-
Ben Pastene authored
eg: https://chromium-swarm.appspot.com/task?id=4527b399d8f02d10 Something went wrong there, and cros_run_test return non-zero, but no failed Tast tests were found, so the test runner returned zero. This'll prevent that from happening. Bug: 947531 Change-Id: Ie43912771820f3920c30b82f82d6d54555868164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638777Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665223}
-
Kevin Babbitt authored
This is similar to the issue fixed in crrev.com/c/1532893 and follow-up crrev.com/c/1535165. When the PDF plugin sends its accessibility tree to the browser process, we would incorrectly detect that the PDF tree is the root tree and switch out the node tracked by the UIA fragment root as its lone child. The fix is to check for a parent tree ID when determining whether a given tree is the root tree. Bug: 968245 Change-Id: I91a193064a51f9694eb4338af7a12f2fbf22dd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636480Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665222}
-
Lukasz Anforowicz authored
This CL fixes a problem where a GuestView that stops loading (e.g. a MimeHandlerView for a PDF) would not trigger a re-checking whether a parent frame can also report that it stopped loading. The CL fixes this by adding a |parent->CheckCompleted()| call to WebRemoteFrameImpl::DidStopLoading. In a regular-OOPIF case, the check in the parent would be triggered by: 1. OOPIF process: FrameLoader::DidFinishNavigation -> parent->CheckCompleted() -> RemoteFrame::CheckCompleted() -> ... -> RenderFrameProxy::CheckCompleted() -> send FrameHostMsg_CheckCompleted 2. Parent process: receive FrameMsg_CheckCompleted -> LocalFrame::CheckCompleted() The flow above is not happening for GuestView, because the main frame inside the GuestView doesn't know it has a parent. FWIW, the DidStopLoading issue is (a bit remotely) similar to the old https://crbug.com/779433. This CL re-enables a portion of the SavePageOriginalVsSavedComparisonTest.ObjectElementsViaHttp test, because after this CL, the test no longer hangs when waiting for the test page to stop loading. The remainder of the test will be re-enabled after fixing find-in-page issues that are tracked in https://crbug.com/965254. Bug: 964364 Change-Id: Iee165a88cdfb94b3169919393c563b483c145cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621486 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665221}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a5f5504. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." be773908 "Portals: Use load event in tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib174828fd74fd50ba16721cea150a724beb91961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638191Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665220}
-
Bo Liu authored
The generated scripts launch apps using implicit intent, which requires CATEGORY_DEFAULT to work. Bug: 893766 Change-Id: I7a4da690fde2268b24f2ea13e4450b4ee20732dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638127Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665219}
-
Zhenyao Mo authored
The flags are queried through ID3D11Device::CheckFormatSupport(). Hopefully they can be used to bypass YUY2 related tests on AMD where creating a YUY2 swap chain fails. Also, they can be useful diagnosing swap chain related issues from user machines, i.e., whether we assumed certain capabilities without checking. BUG=967860 TEST=bots R=sunnyps@chromium.org,piman@chromium.org Change-Id: I5dff9069b2fc53851cbffc5263bd4a2e0e03582f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637195Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665218}
-
Abhijeet Kandalkar authored
ListHashSet is deprecated in favor of LinkedHashSet. HeapLinkedHashSet's invalidate iterators when the container is modified. This does not happen in this usage, so replacement is simple. Change-Id: Iea0b4d86c5991b87baf20cd37ebf154c99a8fa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637002Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#665217}
-
Dominic Battre authored
This CL removes base="true" for some histograms where it was incorrectly added due to a copy&paste error. Bug: 966041 Change-Id: Ie39b2879b5cbc76ef3c44373f374d92fec2cf9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637558 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#665216}
-
Eric Seckler authored
This is a reland of e507d09a. Adds missing mojo struct fields. Original change's description: > perfetto: Switch to clearing incremental state periodically > > The perfetto service now provides a signal for clearing of incremental > state. This patch plumbs the signal into our data sources down to the > event sink. > > Bug: 928738 > Change-Id: If4bfb5329eb50e8222cd670ed4a0ece0ad25081e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632213 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664154} Bug: 928738, 968176 TBR: oysteine@chromium.org Change-Id: I47ba78cd3105b058691427c9c2bf2475410fdd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638543Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Iecea2aa2fbabc7df10df4127d43defea5d9de0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610892Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665214}
-
Esmael El-Moslimany authored
As part of the MD refresh, the WebUI button style changed dramatically. We opted to reuse the paper-button and overriding the styling. The button logic is fairly straightforward. That said, paper-button use 5 Polymer behaviors. IronA11yKeysBehavior: a different way to handle keybindings. IronButtonState: supports toggling and whether focus was from a keyboard. IronControlState: handles disabling a control with the |disabled| property. PaperButtonBehaviorImpl: supports button elevation based on the button state (focused, pressed, disabled and normal). PaperRippleBehavior: lazily creates paper-ripple and forwards noink property to paper-ripple. cr-button applies the MD refresh style directly and implements only the functionality that is required. It makes use of the PaperRippleBehavior and cr.ui.FocusOutlineManager (used in place of IronButtonState which also supports toggling). Bug: 967793 Change-Id: I0417974fcc69467be249920410b5ae77bdc529db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632894Reviewed-by: -
Raymond Toy authored
Android uses the FFT library PFFFT. Use this on Linux too. Some simple tests show that PFFFT is up to maybe 5% faster than the current ffmpeg FFT library that was being used. This also means that for all intents and purposes the Linux build is the same as the Android build with respect to WebAudio. Hence the Linux bots should essentially produce the same coverage for Android. There may also be some memory savings because PFFFT allows sharing the FFT twiddle-factors and other state between FFTs of the same size. FFmpeg doesn't allow this. Bug: 968168 Change-Id: Ic453c857817bf49b664a6681ea4b194f4e66d5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637717 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Vladislav Kuzkokov authored
This removes circular dependency. Bug: 964948 Change-Id: I2a37319b7b92fe4b5a347baa69f5fde72c120cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617768 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
Modify WaylandKeyboard keymap handling method to use the brand new SharedMemory API rather than raw mmap/munmap calls. This does not implies in any behavioral change. Bug: 578890, 795291 Change-Id: I7e5a0495b96af84a114414ce34268410d2cee57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637627Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#665210}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc30e72cb429..cc9bc65588ee git log bc30e72cb429..cc9bc65588ee --date=short --no-merges --format='%ad %ae %s' 2019-05-31 spang@chromium.org Vulkan: Fix synchronization with current surface Created with: gclient setdep -r src/third_party/angle@cc9bc65588ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I22fe424daed16a040bef709af23cf921937f2f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665209}
-
Rune Lillesveen authored
Change-Id: Ib1c0c2f927864729c9249af863e43f37128d657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638457Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0817a0661743..ef80e835027e Created with: gclient setdep -r src-internal@ef80e835027e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ifbc56fe14b0846d81acdc6530d43ab2933bbdca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638348Reviewed-by:
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 766678 Change-Id: I58ca1e8bee1ff1e53d5daad628f83f6b310cc8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635824 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665206}
-
Ben Pastene authored
These tests fail when built with official & chrome branding. Bug: 947531, 968349, 932269 Change-Id: I9617356070613c58165b1618e529fc4b8794e018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636089Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665205}
-
Fred Mello authored
Bug: b/133669491 Change-Id: I61a9767a08a0024155a40ca4e88e5022209644a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638193Reviewed-by:
-
Mark Mentovai authored
This is a reland of 6a008993, which was reverted in 235d842a. (Thus, this is a revert of that revert.) Since the last attempt, the structure of the keystone_registration bundle_data rule in third_party/googlemac (via src-internal DEPS) has changed to avoid the dangling symbolic link problem previously encountered. The description from 6a008993: The copy_bundle_data tool is implemented in terms of pax for directories and ln hard links for files. The pax command does preserve symbolic links within the tree that is being copied. But with the way that pax is invoked by the tool, cd-ing into the source, if the source is itself a symbolic link to a directory, the tree will be logically copied rather than just as a symbolic link. A similar issue exists with the non-directory symbolic link source case, where a hard link will be produced instead of a symbolic link. Fix both of these cases by specifically testing if the source is a symbolic link and then re-creating it if so. Bug: 955936 Change-Id: Ia13ddf743603e98337c3523e9101e7627e1c31d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637673Reviewed-by:
-
Ian Kilpatrick authored
This allows callsites to pass in a lambda that does a capture by reference. There should be no behaviour change. Bug: 967830 Change-Id: I0253a9bb7dd8f95b9129d17eeabae1dc6c58c527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637588Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665202}
-
Caleb Raitto authored
This CL finishes the chain of changes needed to call metrics listeners with RequestFinishedInfo, and it includes some sanity check tests verifying that the returned metrics are valid. RequestFinishedInfo includes more than request metrics, and those fields will be copied in later CLs. Bug: 879208 Change-Id: I0349d611943044bb16053fb0ab3262d5f36a4829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496495 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
-
Mason Freed authored
This is a reland of 5418a092 - this needed a rebaselined layout test for Mac. Original change's description: > Clean up backdrop-filter layout tests and expectations > > This CL cleans up the layout tests for backdrop-filter: > - The backdrop-filter-bleeding.html test was never really complete, and > the effect it was testing for is completely covered by the existing > external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html > test. > - The backdrop-filter-boundary.html test never had a valid expectation > file. It now does, and the test has been made a bit more obvious. It > already passed. > - Another CL (http://crrev.com/663338) made the > backdrop-filter-clipped.html test pass. > > Bug: 497522 > Change-Id: Ib95edda9dfb15fc451eaeb225310d422d70787df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637490 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664954} Bug: 497522 Change-Id: I51f9f0bee8b5b3dd601adf27db4a25c3bdfacc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638657 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Lindsay Pasricha authored
We renamed the EG2 test targets in https://chromium-review.googlesource.com/c/chromium/src/+/1628171 but these files weren't updated. Bug: 866147 Change-Id: I59891bba8a0516fc9b5eca4867acb5e0fcde859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637839Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#665199}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: I2353843752a270db375471e9faa62336fe50158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635629 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
-
Pâris MEULEMAN authored
This CL aims to remove OAuth2TokenService.Oauth2TokenServiceObserver, which is unused except for tests. The tests depending on this API were modified to test the behavior using a different way in parent CLs: - Test that saveStoredAccounts was successfully executed; - Test the C++ Oauth2TokenServiceDelegateAndroid instead, which gives access to the C++ OAuth2TokenService::Observer. Bug: 960281 Change-Id: I152f5c582d7795c05162e0ab3fca219c0db10a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602715 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/887362fca7a7..8b079d6881fc git log 887362fca7a7..8b079d6881fc --date=short --no-merges --format='%ad %ae %s' 2019-05-31 mnissler@chromium.org Revert "Mark guado as experimental" Created with: gclient setdep -r src/third_party/chromite@8b079d6881fc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iba1e13e9eb126f79bd3a10b957cbf7531e6eab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638564Reviewed-by:
-
