- 19 Jan, 2021 25 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13466d016b58..84e43fa2c447 2021-01-19 tikuta@chromium.org ninjalog uploader: migrate to python3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I472e79748ba8fd8beeb74b26830ba66e25e3c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844658}
-
tby authored
We've changed the proto field used to record structured metrics, this CL changes the metrics provider from using deprecated_structured_event to using structured_data.events. Bug: 1148168 Change-Id: I9b987c2e24886ee72b2f404dcd713981674cc194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636079Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#844657}
-
Kyle Williams authored
Move the various GetCurrentFormFactor functions to the VariationsServiceClient class. BUG=b:177442621 TEST=autoninja -C out/Default/ components:components_unittests && xvfb-run ./out/Default/components_unittests --gtest_filter=FieldTrialUtilTest.* Change-Id: Ib677ed6cfbba91a287cb5c9ef06cf96332e4be3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633426 Auto-Submit: Kyle Williams <kdgwill@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844656}
-
Song Fangzhen authored
Reject hostnames that resolve to non-public exception unless a raw IP address or a *.local hostname is entered by the user. TODO: Show connection dialog and use the hostname provided by the user. Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 1119661 Change-Id: I9a1300adf8b4acef2fbc2f18c465f86bc11b3859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631664 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#844655}
-
Minggang Wang authored
The functions declared in ip_address_space_util.h are needed when moving WebURLLoaderImpl into blink. So, as part of the OnionSoup project, this patch moves the functions to third_party/blink/public/common/net/ and its unit test accordingly. Bug: 1110176 Change-Id: I9a9b7056d6e822eaf39a1f21a8c5fb35379d5ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635217Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#844654}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4922c164ada4ac7b75873c1919098eabd48e2ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636500Reviewed-by:
-
Rakina Zata Amni authored
Currently we have a per-request buffer limit, but we're seeing some OOM regressions, presumably because we have a lot of small requests that when summed up takes a lot of memory. This CL adds a per-process buffer limit to ensure we can control how much memory buffered network requests in a renderer process can take while in bfcache and hopefully reduce the OOM rate. Bug: 1137682 Change-Id: I7685dab83e3502d7169949acf4b123a2c66a47b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631388 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610992290-682e9bbbdeeb2e8d01a84d67f327a574b1495751.profdata to chrome-win32-master-1611003391-e5257fde85260089be74668a059af9daef590c17.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3e41fd58164d0060b263ea0c32fc11bbba5d72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632782Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610992290-93f2acc9d0a77f7b507d260e7f325f3b3b6e6de9.profdata to chrome-mac-master-1611013939-848f93cc4650c420e66bbec68de10e40d4656b36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3f606bb364a3d8d100396540df5c6081c85ccd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636502Reviewed-by:
-
Luciano Pacheco authored
- Add the JS module for icons.html. - Add the required resources to preprocess_if_exp) Bug: 1133186 Change-Id: Iac0c6f0c84e14bd1511157677452bc643bf9829a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636095 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844649}
-
Michael Crouse authored
This removes tflite_deps from flatbuffers as it is not needed for the initial operations supported. This also removes those operations from being compiled when TFLite is included in the build. Bug: 1165517 Change-Id: I0e430b689a39e5a6664d789b7c15ce4618391800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632387Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844648}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I477ea0e93269cf6a156b0f74b1017d0893e96661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636497Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I5ea65641e2c9606a2f078d6946d3aac9ae8c9fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636498Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/679d118787e7..5635dbb91641 2021-01-18 penghuang@chromium.org Only call context::unMakeCurrent() if context is changed. 2021-01-18 geofflang@google.com Generate internal gl entry point functions as C functions. 2021-01-18 geofflang@google.com GL: Add detection of IMG and Vivante GPUs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:983167 Tbr: cnorthrop@google.com Change-Id: I59b6953733a027688b1a408769a41f83a8c04498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632780Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610992290-a2bb9ab0a72f07714d6834315a5f80b743087bf7.profdata to chrome-win64-master-1611003391-f38d26b13046eb21865bd4aef763cfd6c815875c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1d66aca2f7ee615cdfa968a021a5996c1221ef82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632781Reviewed-by:
-
Maggie Cai authored
This reverts commit ddd08c52. Reason for revert: This CL is likly the cause for test failure DemoSetupArcSupportedTest.OnlineSetupFlowErrorDefault in builder Linux Chromium OS ASan LSan Tests (1) starting from https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39313/blamelist Original change's description: > OOBE: Arc-ToS Improvements > > Migrate ArcToSScreen to multistep behavior. > Get rid of display: none; and display: block; > > Bug: 1156667 > Change-Id: I4c2fc425edd4883c5edfceb0a5a9f67a6227de7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603744 > Commit-Queue: Ossama Mahmoud <osamafathy@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844554} TBR=antrim@chromium.org,rsorokin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,osamafathy@google.com Change-Id: I62973f98fccb5086b852879395d04f4a3050c244 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636099Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844643}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dabd9655278a..13466d016b58 2021-01-19 tikuta@chromium.org autoninja: use pure python3 to get build id and for post_build_ninja_summary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib94499c48d057bfffe9f1041dafa59528d7c3042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636496Reviewed-by:
-
https://chromium-review.googlesource.com/c/chromium/src/+/2633748Nico Weber authored
Change-Id: I027a493f129021059ef8a7b51ca1d5bee01e65ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635076 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844641}
-
Maggie Cai authored
This reverts commit ce17e926. Reason for revert: This CL is likely the cause of crash for test MessagePortProviderBrowserTest.PostMessage in builder Linux MSan Test starting from https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/27063/blamelist Original change's description: > PostMessage hookup to allow payment request delegation. > > This CL adds fields to postMessage data structures that convey > the sender Window's intention to delegate a capability to the > receiver Window. The change is behind two runtime flags: one flag > ("CapabilityDelegation") enables the parsing of a new postMessage > option for delegation, while the other flag > ("CapabilityDelegationPaymentRequest") enables transmission of > payment request delegation information to the receiver Window. > > Bug: 1130558 > Change-Id: Ifad482bc9629ea69b9bd802d5f0f7df7c24645f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568627 > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844548} TBR=dcheng@chromium.org,flackr@chromium.org,mustaq@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9a6ac999124984ca5ddff2a64f6c4f4eebd56e97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636098Reviewed-by:
-
Xianzhu Wang authored
Previously the maximum animation scale functions returned kInvalidScale if any keyframe in any animation of the element couldn't calculate a scale. Now return kInvalidScale only if none of the keyframes can calculate a scale. Change-Id: Id982445e68fe862c3f2ac1c93d11cb2a49aadcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631347 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844639}
-
Maggie Cai authored
This reverts commit c065ff54. Reason for revert: This CL is likely to cause the test failure in multiple builders. compositing/squashing/remove-from-grouped-mapping-on-reassignment.html Some builders: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7566/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/113061/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/52902/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/79230/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/79230/blamelist Original change's description: > Not clamp up setTimeout(..., 0) to 1ms for single_shot > > setTimeout(..., 0) is clamping up to 1ms for historical reasons: > crbug.com/402694, and the issue has been open for years which was > blocked by the challenge of updating all test expectations accordingly. > > Chrome doesn't need the clamp for anything in particular and no 1ms > clamp in the spec, moreover, we found Speedometer2 performance can boost > ~1% on Windows without it based on Pinpoint perf. > > Most failure tests failed with this change had been fixed in separated > CLs. > > Bug: 402694 > Change-Id: I46196584b887513ca520221be68099116931d4f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578703 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#844459} TBR=skyostil@chromium.org,wanming.lin@intel.com,foolip@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0148f4b5cd39d4e1bea66f753c91aaf7da537fb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 402694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636078Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cf0ef0022c7..29bd8638adb0 2021-01-18 asapersson@webrtc.org Add field trial for allowing cropped resolution when limiting max layers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f5671490cd3e3d71004b256fb3445e990045eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636495Reviewed-by:
-
Bartek Nowierski authored
Names like |ptr| or |address| don't convey the intention for the pointer to point to the beginning of a slot, and |slot_start| does it. Improve comments while at it. The renaming made it obvious that in one case SlotSpan::FromPointer could be used instead of FromPointerNoAlignmentCheck. Change-Id: I17cc44bcbbfad57e17477bf64d54d140ad279c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631719Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844636}
-
Philip Rogers authored
For the transition to garbage collected LayoutObjects, non-stack-allocated objects need to opt in to tracing [1]. PaintInfo should be stack allocated and this patch marks it as such. To do this, DirectionFlippingScope needed to be marked as stack allocated as well. With this patch, PaintInfo should work as-is during the transition to garbage collected LayoutObjects. [1] https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/platform/heap/BlinkGCAPIReference.md#stack_allocated Bug: 1030176 Change-Id: Ifddaaf53eedb9f36bfb050cbb1c3edd84daa3780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633642Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844635}
-
Luciano Pacheco authored
Remove incorrect .bind(this) because rollup fails because `this` is null in that context. These callbacks don't use `this` so it's safe to remove the binding. Import webui_command_extender.m.js to add the method setHidden() in cr.ui.Command when running as JS modules. Bug: 1133186 Change-Id: Iac70f1364a2bf77bfbdf6eb4d3d453786519c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636006 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
- 18 Jan, 2021 15 commits
-
-
Luciano Pacheco authored
When running as JS modules the `cr.ui` namespace is removed causing the name conflict. Bug: 1133186 Change-Id: Id52659090df89e67f9b0a3cf44d01b4a0747584b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636076Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ce36a5a3764..f2a99e868d8f 2021-01-18 andoli@chromium.org [module.json extensions] help views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ee585380074376569a2b9bd2e4be6696e688da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636261Reviewed-by:
-
Xianzhu Wang authored
Previously the maximum scale of a translation animation was unknown in cc, making it indistinguishable from animations whose scale was not computable. We used the native scale (page_scale * device_scale) for such animating layers, which may be too small or too big if the element has very big or small accumulated scale from ancestors. See crbug.com/1153428. Now let MutatorHost::MaximumScale() return 1 (instead of kNotScaled which is renamed to kInvalidScale) for translation animations. Accordingly modify PropertyTrees::MaximumAnimationToScreenScale() which depended on kNotScaled for non-scale animations to avoid combination of maximum scales of multiple scale animations. Now check if the maximum scale is 1 (which may be for translation animation, or a scale animation with with maximum scale == 1, but we don't need to distinguish them) for the purpose. Also optimize PropertyTrees::MaximumAnimationToScreenScale() by caching the current to-screen scale of non-animating parent to avoid multiple calculation of when the parent has multiple animating children. Bug: 1161586 Change-Id: If269fd003f77daf1239184e62aa75291c400bfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605415 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jarryd authored
Bug: 1165232 Change-Id: I6849113b9988536a2742f17d9f0da13b68d58ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632778Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844630}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I9a26f72fc24f4fe49c160120ebca3f4cf22f0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636005 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
My intention was to do that already in [1] but I somehow missed adding my own email address. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2590037 Bug: 1158389 Change-Id: I6c2ddb4a9e8e62ae3a83487d27a19c1ab8c2f439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636353Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844628}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e02dfe6c..ee927aaa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3d8bfbd97b45b9f48d691f8f35561e5cbfc0ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636374Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844627}
-
Sara Kato authored
Bug: 1159562 Test: build Change-Id: I48f18f8d345e34c219c58f5e5599f8e8fa7f1420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616052Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844626}
-
Mike Reed authored
One repercussion of this is that SkPaint no longer controls how images are sampled -- that is done explicitly with a SkSamplingOptions parameter to drawImage calls, and the same parameter passed to image-shader factories. To address this (ignoring paint's filter-quality), OpacityCanvas now has to override more draw calls. This is fragile, and not the best direction, but is necessary (it seems) at the moment. See skbug.com/11126 Bug: skia:11126 Bug: skia:7650 Change-Id: I6562ca834ddde34c533e68fe4a5abb8c2fae22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605650 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#844625}
-
Joshua Berenhaus authored
To manually test metrics in Chromium, this needs to return true to ensure UMA client id logic behaves correctly. Bug: 1160364 Change-Id: Icc413159e5f5f4674d6beb40804c10dc249b841e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610957 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/12971a22d265..5cf0ef0022c7 2021-01-18 nisse@webrtc.org Stricter compile-time thread annotations in JsepTransportController 2021-01-18 philipel@webrtc.org Remove unused function VideoDecoder::PrefersLateDecoding. 2021-01-18 alessiob@webrtc.org Remove unused code in APM 2021-01-18 danilchap@webrtc.org Delete unused.h include from api as unused 2021-01-18 nisse@webrtc.org Move deprecated code to their own build targets. 2021-01-18 philipp.hancke@googlemail.com fix variable naming in ReportSdpFormatReceived 2021-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision da248227..18311e27 (844357:844473) 2021-01-18 philipp.hancke@googlemail.com payload type mapper: use media constants 2021-01-18 nisse@webrtc.org Update pc/ to use C++ lambdas instead of rtc::Bind 2021-01-18 danilchap@webrtc.org Delete RTC_WARN_UNUSED_RESULT as no longer used 2021-01-18 hta@webrtc.org Reland "Improve structuring of test for audio glitches." 2021-01-18 nisse@webrtc.org Update SCTP test to use C++ lambdas instead of rtc::Bind 2021-01-18 mbonadei@webrtc.org Remove deprecated //rtc_base:async_resolver. 2021-01-18 tommi@webrtc.org Remove lock from RtpStreamReceiverController. 2021-01-18 tommi@webrtc.org Reduce redundant flags for audio stream playout state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:857004 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id422e48c8889fa1dc4dca523d1e8446269e6c6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636477Reviewed-by:
-
Kevin Ellis authored
Prior to the patch, the validity of the execution context was only checked on entry to the method; however, the execution context can be invalidated during the course of parsing keyframes or options. The parsing of options is upstream of Animatable::animate and caught by the existing check, but invalidation during keyframe parsing could fall through triggering a crash. Bug: 1161739 Change-Id: Ic0fc927d1d6ce902592bf92261fd4c506e96afac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636213 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
The class DictationChromeos already lives in a ChromeOS-only directory: chrome/browser/ash/. Remove its suffix. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I28ff84b527e3eebc7584b22a7f99a9acdbe4cf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627371 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844621}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610981979-8f34756a4da6cb018f171d5c6603852477d6e4b4.profdata to chrome-win32-master-1610992290-682e9bbbdeeb2e8d01a84d67f327a574b1495751.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic72ee725b81807e3d184e601258cb7f4f9f944cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633440Reviewed-by:
-
Jonathan Backer authored
This CL copies https://skia-review.googlesource.com/c/skia/+/312056 and uses coherent memory on mobile GPUs, which demonstrated a significant CPU saving on Android. Change-Id: I3ca13695a168e7b998b9ebffddab06d21f10983b Bug: 1167904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636380Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844619}
-
