GitLab

The pref data_reduction_proxy::prefs::kDataReductionProxy should have
been part of data_reduction_proxy::RegisterPrefs() to avoid having
all embedder register it manually just before call said function.

BUG=557814

Review URL: https://codereview.chromium.org/1463973003

Cr-Commit-Position: refs/heads/master@{#361358}

It's one very trivial function that only has a single call-site. It
doesn't need its own file.

BUG=

Review URL: https://codereview.chromium.org/1474533004

Cr-Commit-Position: refs/heads/master@{#361357}

That way, we don't have to mess with the hidden values in the dtor.

BUG=558975
R=haraken@chromium.org,sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1472823002

Cr-Commit-Position: refs/heads/master@{#361356}

BUG=

Review URL: https://codereview.chromium.org/1468043003

Cr-Commit-Position: refs/heads/master@{#361355}

BUG=528489

Review URL: https://codereview.chromium.org/1468163003

Cr-Commit-Position: refs/heads/master@{#361354}

BUG=

Review URL: https://codereview.chromium.org/1473553002

Cr-Commit-Position: refs/heads/master@{#361353}

Also changed the API for the prefixed version to maintain compatibility between the two.

This is an interop issue, Firefox bubbles the event while Safari does not, but I think we should match Firefox.

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821

Review URL: https://codereview.chromium.org/1435893003

Cr-Commit-Position: refs/heads/master@{#361352}

Rename SVGPathTraversalStateBuilder.{cpp,h} to SVGPathQuery.{cpp,h}, and
similarly rename the class itself. Move the query methods in
SVGPathUtilities (getSVGPathSegAtLengthFromSVGPathByteStream,
getTotalLengthOfSVGPathByteStream, getPointAtLengthOfSVGPathByteStream)
to that class, shortening their names in the process.
Open-code the SVGPathParser driver to allow the general SVGPathConsumer
interface to be simplified - incrementPathSegmentCount and
continueConsuming are only used for path queries.

BUG=467592

Review URL: https://codereview.chromium.org/1471943003

Cr-Commit-Position: refs/heads/master@{#361351}

JUnit/Robolectric tests run on the host without native code and so can't
set the application context the usual way. Provide a test-only method to
set only the Java-side context for this purpose.

Move the assertion about not changing the set context to
initApplicationContext because the JUnit tests will use a different
mock context for each test case.

BUG=552419
R=dgn@chromium.org

Review URL: https://codereview.chromium.org/1474723002

Cr-Commit-Position: refs/heads/master@{#361350}

The early return after PostTaskAndReply() in
GLSurfaceOzoneSurfaceless::SwapBuffersAsync was erroneously removed in
f960a950 ("Split up synchronous & asynchronous swap buffers APIs").  This
adds it back.

It also removes the else after return; that's against the style guide.

BUG=560553
TEST=boot chrome on veyron_jerry

Review URL: https://codereview.chromium.org/1475683002

Cr-Commit-Position: refs/heads/master@{#361349}

Add repeat_delay_ms and repeat_count as configurable parameters to the infinit scrolling benchmarks.

Twitter gets stuck most of the time when we scroll continuously. Non-continuous scrolling fixes the issue.

BUG=

Review URL: https://codereview.chromium.org/1471233002

Cr-Commit-Position: refs/heads/master@{#361348}

This reverts commit 587e7058
(crrev.com/1447213002)

Reason for the revert:
broke all Android perf bots. More context in crbug.com/560813.
This CL is causing a null pointer deref in the browser whenever
a renderer kill is detected:

Thread 0 (crashed)
 0  libchrome_public.so!breakpad::CrashDumpManager::Observe [crash_dump_manager_android.cc : 194 + 0x0]

    Found by: given as instruction pointer in context
 1  libchrome_public.so!content::NotificationServiceImpl::Notify [notification_service_impl.cc : 123 + 0xd]

    Found by: call frame info
 2  libchrome_public.so!content::RenderProcessHostImpl::Cleanup [render_process_host_impl.cc : 1790 + 0x1]

    Found by: call frame info
 3  libchrome_public.so!content::RenderWidgetHostImpl::~RenderWidgetHostImpl [render_widget_host_impl.cc : 257 + 0x9]

    Found by: call frame info
 4  libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 266 + 0x5]

    Found by: call frame info
 5  libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 277 + 0x3]

    Found by: call frame info
 6  libchrome_public.so!content::RenderWidgetHostImpl::Destroy [render_widget_host_impl.cc : 1465 + 0x7]

    Found by: call frame info

BUG=560813,510327
NOTRY=TRUE
TBR=skyostil@chromium.org,yfriedman@chromium.org,wnwen@chromium.org

Review URL: https://codereview.chromium.org/1474543003

Cr-Commit-Position: refs/heads/master@{#361347}

BUG=

Review URL: https://codereview.chromium.org/1471253002

Cr-Commit-Position: refs/heads/master@{#361346}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b787e6bc..0164a63f

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1469803005

Cr-Commit-Position: refs/heads/master@{#361345}

Also remove a few Windows newlines :-/

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1470093004 .

Cr-Commit-Position: refs/heads/master@{#361344}

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=

Review URL: https://codereview.chromium.org/1469143002

Cr-Commit-Position: refs/heads/master@{#361343}

https://url.spec.whatwg.org/#api

This changes the generated code, but ought not be observable, as any
call to `new URL(x, urlObject)` will now instead behaves as
`new URL(x, urlObject.toString())`.

BUG=460722

Review URL: https://codereview.chromium.org/1464133002

Cr-Commit-Position: refs/heads/master@{#361342}

BUG=557430

Review URL: https://codereview.chromium.org/1438863002

Cr-Commit-Position: refs/heads/master@{#361341}

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1466423006 .

Cr-Commit-Position: refs/heads/master@{#361340}

The current minor GC collects all unmodified wrappers that are not active. It does not take care about references. Hence, it is not safe to mark any object that might contain a reference as not active. Several object wrappers could have references, so disabled collecting them during minor GC.

BUG=553054

Review URL: https://codereview.chromium.org/1464783002

Cr-Commit-Position: refs/heads/master@{#361339}

Rename buildSVGPathByteStreamFromString to buildByteStreamFromString to
be more consistent with other functions (buildStringFromByteStream and
buildPathFromByteStream). Also drop the PathParsingMode argument, since
it's always UnalteredParsing (and it's unlikely we'll need to build
normalized byte streams ATM.)

Make buildStringFromByteStream return the resulting String instead of
using an out-parameter. Tidies up call-sites and makes for slightly
smaller code.

BUG=467592

Review URL: https://codereview.chromium.org/1469323002

Cr-Commit-Position: refs/heads/master@{#361338}

BUG=442514

Review URL: https://codereview.chromium.org/1467003002

Cr-Commit-Position: refs/heads/master@{#361337}

This is an attempt to get 90% cycle time under 2 hours.

Currently cycle time is considered higher priority than false rejections,
although we try to keep both low.

BUG=none
R=sergiyb@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/1474703002 .

Cr-Commit-Position: refs/heads/master@{#361336}

Use immutable texture for the default FBO like chromium compositor.

In theory, it speeds up drawing speed, because immutable texture skips texture
validation on drawing call.

In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization.

BUG=557848
TEST=
WebglConformance.conformance_renderbuffers_framebuffer_state_restoration
WebglConformance.conformance_textures_misc_texture_size_cube_maps
WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1

Review URL: https://codereview.chromium.org/1449043005

Cr-Commit-Position: refs/heads/master@{#361335}

Revert of Remove fallback tick software draw. (patchset #3 id:100001 of https://codereview.chromium.org/1428263003/ )

Reason for revert:
Causes scheduler to stop activating after clearView is called. PrepareTiles is required to advance the scheduler, so draws are currently needed.

crbug.com/558743

Original issue's description:
> Remove fallback tick software draw.
>
> The fallback software draw was needed to allow the scheduler to advance
> in cases where the WebView is detached or offscreen. Because it is now
> possible for the pending tree to activate without a draw, the fallback
> tick is no longer needed in order for VisualStateListener callbacks
> to fire.
>
> BUG=431166
>
> Committed: https://crrev.com/9addff46d3bc49f8d04e43eeb3f55e01a4982a00
> Cr-Commit-Position: refs/heads/master@{#358156}

TBR=boliu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=431166

Review URL: https://codereview.chromium.org/1474653002

Cr-Commit-Position: refs/heads/master@{#361334}

One layout text requires rebaselining after the last roll:
canvas-imageSmoothingQuality-pixel.html.

BUG=559240
NOTRY=true
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1468403002

Cr-Commit-Position: refs/heads/master@{#361333}

New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px height.

BUG=558287
TEST=automated

Review URL: https://codereview.chromium.org/1468353002

Cr-Commit-Position: refs/heads/master@{#361332}

BUG=540702

Review URL: https://codereview.chromium.org/1471213002

Cr-Commit-Position: refs/heads/master@{#361331}

BUG=557197

Committed: https://crrev.com/0eb771aa98ba2bd4db0e2b82241afe8f5760c32e
Cr-Commit-Position: refs/heads/master@{#361053}

Review URL: https://codereview.chromium.org/1453903002

Cr-Commit-Position: refs/heads/master@{#361330}

It's a rare flake (3/200), but still.
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61716
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61770
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61897

I don't see anything interesting in the logs, just a timeout.

BUG=523255
TBR=sky

Review URL: https://codereview.chromium.org/1476463002

Cr-Commit-Position: refs/heads/master@{#361329}

- Notifications.PersistentNotificationActionCount tracks number of
  action buttons per notification

- Notifications.Persistent.ClickedActionButton counts clicks on action
  buttons

- Notifications.Persistent.Clicked no longer includes clicks on action
  buttons

BUG=513671

Review URL: https://codereview.chromium.org/1422193003

Cr-Commit-Position: refs/heads/master@{#361328}

This test is flaky on the Win XP bot. See bug for more info.

BUG=560716
TBR=rockot

Review URL: https://codereview.chromium.org/1472043002

Cr-Commit-Position: refs/heads/master@{#361327}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6ed50d99..b787e6bc

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1467413003

Cr-Commit-Position: refs/heads/master@{#361326}

BUG=

Review URL: https://codereview.chromium.org/1466423005

Cr-Commit-Position: refs/heads/master@{#361325}

Review URL: https://codereview.chromium.org/1468163002

Cr-Commit-Position: refs/heads/master@{#361324}

Revert of Remove SkFontConfigInterface race suppression. (patchset #1 id:1 of https://codereview.chromium.org/1467313002/ )

Reason for revert:
The data race is still reproducible (see the bug)

BUG=chromium:369257

Original issue's description:
> Remove SkFontConfigInterface race suppression.
>
> The race was fixed with https://codereview.chromium.org/355573006 ,
> committed as
> https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2
>
> This is effectively a revert of https://codereview.chromium.org/273523002 .
>
> BUG=chromium:369257
>
> Committed: https://crrev.com/a8c01b568251a5dc191e4fb67ab5c1dc6b8af86e
> Cr-Commit-Position: refs/heads/master@{#361125}

TBR=mtklein@chromium.org,bungeman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:369257

Review URL: https://codereview.chromium.org/1468173005

Cr-Commit-Position: refs/heads/master@{#361323}

Initial implementation of CSS font-display, a new @font-face descriptor
behind the experimental web platform feature flag.

Spec: https://tabatkins.github.io/specs/css-font-display/
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/7s4-eQTAxqs/SoahsGpMAQAJ

BUG=530015

Review URL: https://codereview.chromium.org/1429713004

Cr-Commit-Position: refs/heads/master@{#361322}

BUG=455638
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1468383002

Cr-Commit-Position: refs/heads/master@{#361321}

[1] and [2] placed release assertions to investigate a crash bug and provide a
workaround solution. Now the right fix has been landed and we can remove them.

1: https://crrev.com/4b823461db8e2bc8faf5438be4cc30f6a9401aef
2: https://crrev.com/a6af78bd57595484765d2a3ca18f38fa135be796

BUG=550632

Review URL: https://codereview.chromium.org/1456463002

Cr-Commit-Position: refs/heads/master@{#361320}

This commit grays out unmanaged WiFis and button to joining other WiFis
when AllowOnlyPolicyNetworksToConnect is true after user logged in, as
well as adds the tooltip to tell users why.

BUG=208378

Review URL: https://codereview.chromium.org/1469733003

Cr-Commit-Position: refs/heads/master@{#361319}