GitLab

WebsiteSettingsPopupLegacy was replaced with WebsiteSettingsPopup.
This change removes the old dialog and it's dependencies.

BUG=456167

Review URL: https://codereview.chromium.org/878413008

Cr-Commit-Position: refs/heads/master@{#315377}

An IRT layer is being added to Mojo NaCl support. The change to the Mojo
repository for this will temporarily break ppapi mojo support until a
corresponding chrome change is landed to make the Mojo IRT interface available
in Chrome.

BUG=454466
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/907913002

Cr-Commit-Position: refs/heads/master@{#315376}

Rolls in two CLs on Android tools:

1) Add aarch64 gold linker:
  https://chromium-review.googlesource.com/247060
2) Remove proguarding from GMS core
  https://chromium-review.googlesource.com/247611

BUG=None

Review URL: https://codereview.chromium.org/906363002

Cr-Commit-Position: refs/heads/master@{#315375}

The test attempts to monitor speech immediately after startup. Disabling for now until we can figure out why it flakes on bots.

NOTRY=true
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/908913002

Cr-Commit-Position: refs/heads/master@{#315374}

Revert of Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change  Original (patchset #7 id:120001 of https://codereview.chromium.org/890013006/)

Reason for revert:
Suspected to cause chromeos vox test failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/56046

Original issue's description:
> Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Original issue: https://codereview.chromium.org/880063002
> Previous reland attempt: https://codereview.chromium.org/895623003/
>
> This cl changes the way in which ChromeVox initially verbalizes a page which led to flakeyness in
>   chromevox_tests --gtest_filter=BackgroundTest.*
>
> To attempt and address the flakeyness,
> - chromevox_e2e_test_base.js and chromevox_next_e2e_test_base.js now explicitly separates listening to page load events from the chrome.automation tree and the chrome.tabs APIs.
> They are named: runWithLoadedTree, runWithLoadedTab, and runWithTab. The last method allows a caller to create a tab, but not wait for it to load (based on the tab status being 'complete').
> - each test in background_test now no longer waits for ChromeVox to speak 'start' (which formerly could have been triggered by a loadComplete automation event).
> - tab creation is still done via the tabs API, but listening for load is done via chrome.automation. (i.e. add a listener for an automation tree to load completely, then create a tab).
>
> It is not known at this time if this cl will continue to cause flakes in the above tests. Try bots and local runs yielded no flakeyness. The next step may be to introduce logging to identify the source of the flakeyness.
>
> TBR=tfarina
>
> Committed: https://crrev.com/9b006b56ca402da3774708f08e062c89018d57a6
> Cr-Commit-Position: refs/heads/master@{#315362}

TBR=dmazzoni@chromium.org,tfarina@chromium.org,dtseng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/910013002

Cr-Commit-Position: refs/heads/master@{#315373}

ObserverListThreadSafe::Notify is the 4th most called function in a
profile generated on my host. This is because all tasks posted from it
are stamped with this callsite, providing very little information.

This patch forces callers to pass in their own tracking data so that
the profile will differentiate between each observer list holder.

TBR=garykac@chromium.org,rdsmith@chromium.org,stuartmorgan@chromium.org,gbillock@chromium.org

Review URL: https://codereview.chromium.org/877993003

Cr-Commit-Position: refs/heads/master@{#315372}

BUG=413783

Review URL: https://codereview.chromium.org/887843003

Cr-Commit-Position: refs/heads/master@{#315371}

This is required to re-land CL 26009004 in webrtc (was reverted
due to compiler errors while rolling webrtc into chromium):
https://webrtc-codereview.appspot.com/26009004/

BUG=https://code.google.com/p/webrtc/issues/detail?id=3976

Review URL: https://codereview.chromium.org/896393005

Cr-Commit-Position: refs/heads/master@{#315370}

1. This allows other constraints about prefetched resources to be applied.
2. Together with another CL https://codereview.chromium.org/793823002/, the prefetched resources can temporarily bypass revalidation.

BUG=405690, 406209

Review URL: https://codereview.chromium.org/891343007

Cr-Commit-Position: refs/heads/master@{#315369}

This patch rolls trace-viewer to:
https://github.com/google/trace-viewer/commit/a9802a1384185f9c7ee250ce67d3d24d07b11141

Review URL: https://codereview.chromium.org/910773003

Cr-Commit-Position: refs/heads/master@{#315368}

Original: http://crrev.com/889723002
Reverted: http://crrev.com/895373002

This version restores a missing @VisibleForTests annotation
to GoogleServicesNotificationController.getInstance(). Its
removal caused the method to be pruned on build, breaking
downstream tests that depended on it.

GoogleServicesNotificationController is modified to work
the way most other singleton classes work, so that it is
not necessary to pass into the SyncNotificationController
constructor (and thus, into SyncController in the future).

SyncController gets a temporary setter method so that SNC
can be constructed downstream and passed in until all its
dependencies are upstream.

BUG=428882

Review URL: https://codereview.chromium.org/895283003

Cr-Commit-Position: refs/heads/master@{#315367}

BUG=none
TEST=compiles

Review URL: https://codereview.chromium.org/907523003

Cr-Commit-Position: refs/heads/master@{#315366}

TBR=thestig@chromium.org
NOTRY=true
BUG=442785

Review URL: https://codereview.chromium.org/904443004

Cr-Commit-Position: refs/heads/master@{#315365}

This regressed in https://codereview.chromium.org/897563002/.

I also fixed the ChromeContentUtilityClient::PreSandboxStartup() code as well since it was incorrect.

BUG=456623

Review URL: https://codereview.chromium.org/906923003

Cr-Commit-Position: refs/heads/master@{#315364}

BUG=453880

Review URL: https://codereview.chromium.org/905723004

Cr-Commit-Position: refs/heads/master@{#315363}

Original issue: https://codereview.chromium.org/880063002
Previous reland attempt: https://codereview.chromium.org/895623003/

This cl changes the way in which ChromeVox initially verbalizes a page which led to flakeyness in
  chromevox_tests --gtest_filter=BackgroundTest.*

To attempt and address the flakeyness,
- chromevox_e2e_test_base.js and chromevox_next_e2e_test_base.js now explicitly separates listening to page load events from the chrome.automation tree and the chrome.tabs APIs.
They are named: runWithLoadedTree, runWithLoadedTab, and runWithTab. The last method allows a caller to create a tab, but not wait for it to load (based on the tab status being 'complete').
- each test in background_test now no longer waits for ChromeVox to speak 'start' (which formerly could have been triggered by a loadComplete automation event).
- tab creation is still done via the tabs API, but listening for load is done via chrome.automation. (i.e. add a listener for an automation tree to load completely, then create a tab).

It is not known at this time if this cl will continue to cause flakes in the above tests. Try bots and local runs yielded no flakeyness. The next step may be to introduce logging to identify the source of the flakeyness.

TBR=tfarina

Review URL: https://codereview.chromium.org/890013006

Cr-Commit-Position: refs/heads/master@{#315362}

Chrome doesn't use overlay scrollbars. The only thing that we do with this
library is attempt to initialize it (as part of gtk2+ init) which occasionally
tries to read a missing settings schema and crashes.

BUG=456205
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/905703003

Cr-Commit-Position: refs/heads/master@{#315361}

Unless we reconstruct an already sanitized referrer from the referrer
url and the referrer policy, we should always sanitize it before
constructing a request from it.

BUG=454621,422871
R=mkwst@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/898613004

Cr-Commit-Position: refs/heads/master@{#315360}

Per crbug/444930 discussion, BrowserCdm should generally remain on UI
thread. Interactions between the CMA pipeline and BrowserCdm should
remain thread-safe.

R=erickung@chromium.org,lcwu@chromium.org

Review URL: https://codereview.chromium.org/903083003

Cr-Commit-Position: refs/heads/master@{#315359}

This was just a hacky workaround whilst GCM didn't send us subtypes for
incoming messages. Now that it does, we don't need it any more (and it
might cause false positives during testing).

BUG=350383

Review URL: https://codereview.chromium.org/907003003

Cr-Commit-Position: refs/heads/master@{#315358}

This CL:
 - Pulls in the dependencies required to build breakpad and the
   crash component.
 - Introduces a crash reporter for WebView which unconditionally
   enables microdumps (but not minidump uploads).
 - Introduces a fallback no-op implementation which avoids the burden
   of importing and supporting breakpad in the internal Android builds
   (which are going to be deprecated soon).

Impact of this change on the WebView APK size:
  Before the change: 25700337 bytes
  After the change:  25720974 bytes
  Delta:                20637 bytes

Impact of this change on the uncompressed libwebviewchromium.so lib:
  Before the change: 28547980 bytes
  After the change:  28576844 bytes
  Delta:                28864 bytes

BUG=410294, 456494
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/902093003

Cr-Commit-Position: refs/heads/master@{#315357}

Cast shell needs to exist when the parent process dies.

BUG=internal b/19182288

Review URL: https://codereview.chromium.org/872073005

Cr-Commit-Position: refs/heads/master@{#315356}

BUG=

Review URL: https://codereview.chromium.org/909903002

Cr-Commit-Position: refs/heads/master@{#315355}

R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/910793002

Cr-Commit-Position: refs/heads/master@{#315354}

This is a regression from [1] which added a dup() call on
the renderer launching process. This CL removes these calls
by reveiling the subtle ownership of the file descriptors.

The original intention here was to completely hide and simplify
the notion of the ownership, at the cost of a few dup() calls.
However, the crash report on the reported bug indicates that
the dup() can fail and it lets the renderer initialization fail,
probably due to some per-process limit of the number of opened files.

[1] https://codereview.chromium.org/585203002

R=mdempsky@chromium.org, jam@chromium.org
BUG=455364

Review URL: https://codereview.chromium.org/909553003

Cr-Commit-Position: refs/heads/master@{#315353}

Revert of Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread (patchset #1 id:1 of https://codereview.chromium.org/899473002/)

Reason for revert:
this CL doesn't fix the original issue

Original issue's description:
> Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread
>
> For MediaPlayerListener, the callbacks can happen on a non-UI thread.
> Weak_ptr is not thread safe, so we shouldn't bind the weak_ptr in those callbacks.
> This change creates a threadsafe proxy class to bridge all the callbacks.
>
> BUG=453581, 447368, 447367
>
> Committed: https://crrev.com/2e9885788692f69203a98fb42347428ef553d640
> Cr-Commit-Position: refs/heads/master@{#314241}

TBR=xhwang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453581, 447368, 447367

Review URL: https://codereview.chromium.org/879273006

Cr-Commit-Position: refs/heads/master@{#315352}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4e534d0..31223e0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/903733003

Cr-Commit-Position: refs/heads/master@{#315351}

This was blocked on a WebRTC issue for a long time. However,
latest trybot runs appear green.

BUG=360622, 324216, 307043
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/227533008

Cr-Commit-Position: refs/heads/master@{#315350}

BUG=

Review URL: https://codereview.chromium.org/891773003

Cr-Commit-Position: refs/heads/master@{#315349}

This should allow https://codereview.chromium.org/878163004/ to land safely.

BUG=400499

Review URL: https://codereview.chromium.org/902053006

Cr-Commit-Position: refs/heads/master@{#315348}

Similar to the existing Logcat, allows to iterate over the lines of
output from long running commands.

BUG=

Review URL: https://codereview.chromium.org/909833002

Cr-Commit-Position: refs/heads/master@{#315347}

Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates (patchset #2 id:20001 of https://codereview.chromium.org/905853002/)

Reason for revert:
Looks like this broke the build

Undefined symbols for architecture armv7:
  "syncer::sessions::test_util::SimulateDownloadUpdatesFailed(syncer::EnumSet<syncer::ModelType, (syncer::ModelType)2, (syncer::ModelType)33>, syncer::sessions::NudgeTracker const&, syncer::sessions::SyncSession*)", referenced from:
      syncer::BackoffTriggersSyncSchedulerTest_FailDownloadOnceThenSucceed_Test::TestBody() in sync_scheduler_unittest.o
      syncer::BackoffTriggersSyncSchedulerTest_FailDownloadTwice_Test::TestBody() in sync_scheduler_unittest.o
      syncer::SyncSchedulerTest_FailedRetry_Test::TestBody() in sync_scheduler_unittest.o

Original issue's description:
> Sync commit errors should temporarily re-enable
> trigger pre-commit getupdates
>
> Add a boolean variable in class DataTypeTracker, so every
> time when a data type got conflict response from server
> during commit, will set that boolean variable to true, then
> next time sync, GetUpdate will check the boolean to see if
> need to GetUpdate to resolve conflict locally.
>
> BUG=324893
>
> Committed: https://crrev.com/21f43c5af27e24c34565df26bb51fcc704c97597
> Cr-Commit-Position: refs/heads/master@{#315339}

TBR=zea@chromium.org,stanisc@chromium.org,maniscalco@chromium.org,pvalenzuela@chromium.org,gangwu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=324893

Review URL: https://codereview.chromium.org/891123003

Cr-Commit-Position: refs/heads/master@{#315346}

A few updates to the documentation, a developer pointed out some of the docs weren't quite clear.

TBR= sbc@chromium.org, jmedley@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/886163005

Cr-Commit-Position: refs/heads/master@{#315345}

In order to be able to use it in places other than content (e.g. handles
for unified touch selection controller), ImageWindowDelegate is moved to
a new ui module called aura_extra.

Also, to make it more useful, ImageWindowDelegate can now be customized
by setting background color and image offset.

COLLABORATOR=mfomitchev
BUG=399721

Review URL: https://codereview.chromium.org/880703002

Cr-Commit-Position: refs/heads/master@{#315344}

BUG=455900

Review URL: https://codereview.chromium.org/900363003

Cr-Commit-Position: refs/heads/master@{#315343}

Reason for revert:
Looks like this broke the linux 32 bots:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/9539
lots of failures like:
ASSERTION FAILED: !((reinterpret_cast<uintptr_t>(address) + sizeof(HeapObjectHeader)) & allocationMask)
../../third_party/WebKit/Source/platform/heap/Heap.cpp(875) : void blink::FreeList::addToFreeList(Address, size_t)

TBR=dpranke@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/907953002

Cr-Commit-Position: refs/heads/master@{#315342}

This is a clean-up, it follows up on https://codereview.chromium.org/825773003/.

BUG=451018

Review URL: https://codereview.chromium.org/866983003

Cr-Commit-Position: refs/heads/master@{#315341}

Revert of Mac: Enable two finger double-tap smart zoom (patchset #1 id:1 of https://codereview.chromium.org/909633002/)

Reason for revert:
This is a suspect in the dramatic increase in crash rates noted
in crbug.com/456860.

The crashes are on 10.10, so there are no stack traces, so this
is just a guess.

Original issue's description:
> Mac: Enable two finger double-tap smart zoom
>
> BUG=452592
>
> Committed: https://crrev.com/e69b4fd53dbf2d4c1fdc82de623186d7b21c29fb
> Cr-Commit-Position: refs/heads/master@{#315214}

TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=452592

Review URL: https://codereview.chromium.org/859393005

Cr-Commit-Position: refs/heads/master@{#315340}

trigger pre-commit getupdates

Add a boolean variable in class DataTypeTracker, so every
time when a data type got conflict response from server
during commit, will set that boolean variable to true, then
next time sync, GetUpdate will check the boolean to see if
need to GetUpdate to resolve conflict locally.

BUG=324893

Review URL: https://codereview.chromium.org/905853002

Cr-Commit-Position: refs/heads/master@{#315339}

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35192/steps/cc_unittests/logs/stdio#failure1
TBR=aelias@chromium.org

BUG=456617

Review URL: https://codereview.chromium.org/913543002

Cr-Commit-Position: refs/heads/master@{#315338}