- 24 Aug, 2018 40 commits
-
-
Alan Cutter authored
This CL ensures the TabHelper of a PWA WebContents is updated to indicate whether it has it's own "extension" window or not to ensure it gets cleaned up appropriately on uninstall. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354491&signed_aid=mELqu3AB-QBQpk1qojP7qg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354490&signed_aid=4RqFYkoMkmsndSMnrq5inA==&inline=1 Bug: 877009 Change-Id: I81e7888260a40df68f5e9a5443ea2a815b8a686f Reviewed-on: https://chromium-review.googlesource.com/1186388 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#585732}
-
Max Moroz authored
This reverts commit 1501aabf. Reason for revert: broke a build that was used for fuzzing: crbug.com/877063. Original change's description: > Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686. > > This change removes 6+ MB of binaries from the build tools bundle: > 3.7M lib/linux/libclang_rt.asan-i686-android.so > 2.5M lib/linux/libclang_rt.ubsan_standalone-i686-android.so > 80K lib/linux/libclang_rt.profile-i686-android.a > > It also can break some workflows, but as discussed in person, there is a good > chance that no one is using those libraries on i686 arch. > > > Bug: 866225 > Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3 > Reviewed-on: https://chromium-review.googlesource.com/1158708 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Max Moroz <mmoroz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579854} R=hans@chromium.org, inferno@chromium.org, thakis@chromium.org Bug: 877063 Change-Id: Ic5754458e6516dc25cf4cedaeb7eb9195faafbec Reviewed-on: https://chromium-review.googlesource.com/1187629 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585731}
-
Istiaque Ahmed authored
In case of an error where service worker script loading fails (e.g. when there is an attempt to load an extension service worker script after the extension has been uninstalled), the current code fails DCHECK if network stack calls OnComplete with error param right from mojom::URLLoaderFactory::CreateLoaderAndStart. This CL changes the DCHECK to apply only for non-error case. This should fix the flakiness of the test: ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload. Bug: 877218, 868183 Test: Repeated aforementioned test x 500 locally, no DCHECK observed. Change-Id: I1691771e466365477051f5ca1136f01f921a1ec8 Reviewed-on: https://chromium-review.googlesource.com/1187762 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585730}
-
Yoshisato Yanagisawa authored
Since Goma Canary builders are scattered to cr-buildbucket.cfg and is difficult to see, let me gather all the builders to one place. Bug: 874754 Change-Id: Ie8ca261cc28f734c4175d6fc07082429e0c026da Reviewed-on: https://chromium-review.googlesource.com/1188045Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#585729}
-
Sammie Quon authored
This is a reland of c40ba7f2. Added a missing ASH_EXPORT which was causing ash_unittests to fail. TBR=xiyuan@chromium.org Original change's description: > applist: Introduce HomeLauncherGestureHandler. > > Introduce swipe down gesture to homecher. This cl implements the design > at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# > > The design doc states to use a new ScopedClass but after a bit more > thought I think that would be more difficult especially once animations > are added. > > This should be behind a enabled by default flag, but I do not want to > merge too much during code review, so I will add the flag shortly > after this lands. > > Test: added tests > Bug: 872319 > Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 > Reviewed-on: https://chromium-review.googlesource.com/1184326 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585524} Bug: 872319 Change-Id: Ic3b2320e96cb1fd770ce60a5d48818e7ee78d21c Reviewed-on: https://chromium-review.googlesource.com/1187042Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#585728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa6aaad8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23216 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ibc8838d43dcf7a2f26468879347785e0bfe35b64 Reviewed-on: https://chromium-review.googlesource.com/1187896 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585727}
-
Han Leon authored
The legacy IPC struct traits of ServiceWorkerFetchRequest is no longer used anywhere, so we can just remove it then remove the whole file service_worker_messages.h. BUG=789854 Change-Id: I4d4e8ab30d1fca562d6b738aad394d1eb73935e4 Reviewed-on: https://chromium-review.googlesource.com/1187901Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#585726}
-
Stefan Zager authored
Since determining occlusion is much more expensive than computing clipping, throttle the frequency of IntersectionObserver notifications to no more than one every 100ms. BUG=827639 R=chrishtr@chromium.org Change-Id: I6675482041418c628dbddfd648319d18d871d38b Reviewed-on: https://chromium-review.googlesource.com/1175210Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#585725}
-
Alex Lau authored
Currently this is shown for all roots. Bug: 875380 Test: Tested on kevin. Change-Id: Ied92804c5a3936d458b38e84daf973c5928b3534 Reviewed-on: https://chromium-review.googlesource.com/1186206Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#585724}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce6a1cc587a7..367ed462b517 git log ce6a1cc587a7..367ed462b517 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tsepez@chromium.org Use pdfium::span<> in CPDF_Stream::SetData(). 2018-08-23 tsepez@chromium.org Pass unique_ptr<> to CFX_MemoryStream constructor 2018-08-23 thestig@chromium.org Fix GCC build with V8 disabled. 2018-08-23 rharrison@chromium.org Enable warnings for shadowed variables 2018-08-23 rharrison@chromium.org Fix shadowed variables 2018-08-23 hnakashima@chromium.org Remove CBC_BarcodeMatrix::m_matrixOut and just return the bit array. 2018-08-23 thestig@chromium.org Remove deprecated FPDFDest_GetPageIndex() API. 2018-08-23 tsepez@chromium.org Remove bool arg from CFWL_Widget::GetBorderSize(). 2018-08-23 hnakashima@chromium.org Swap width and height params in CBC_BarcodeMatrix constructor. 2018-08-23 npm@chromium.org Cleanup CPDF_TextPage::GetRectArray Created with: gclient setdep -r src/third_party/pdfium@367ed462b517 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ife89a1b2ceec8f4489fff9b0304d4f742460bde9 Reviewed-on: https://chromium-review.googlesource.com/1187096Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585723}
-
Nicolas Ouellet-Payeur authored
It lets us migrate policies from an extension domain to the Chrome domain. ExtensionPolicyMigrator is a callback that can be attached to a ConfigurationPolicyProvider. It is run after the policies are refreshed, but before OnUpdatePolicy() is triggered, and it can modify the PolicyBundle to migrate the policies to their new domain. See: https://docs.google.com/document/d/1_ZxQ4Rc7RIGT4NOfjhdaJJ2gSJCZIHgcwCOumjYD0Cs/edit Bug: 869958 Change-Id: I2da6cf08720e73ca3589cfeaac5094d9df2d8b5c Reviewed-on: https://chromium-review.googlesource.com/1158968 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585722}
-
Han Leon authored
BUG= Change-Id: I4ef96d8055825be72ac40bff03932a376bb018f4 Reviewed-on: https://chromium-review.googlesource.com/1187830Reviewed-by:
-
Dale Curtis authored
This adds everything necessary to support MP4+Opus. Specifically: - The necessary box support such that the Opus and dOps boxes can be parsed from an MP4 when using MSE. - Updates to the mime type parsing for canPlayType/isTypeSupported - Clones all the Opus in WebM tests for Opus in Mp4. Things that need fixing: - End-trimming is not correctly specified for opus-in-mp4 test data yet and no tooling (nor Xiph folks) have correct test clips, this is tracked by http://crbug.com/876544 Other things fixed: - Some duplicate tests and media have been removed for Opus Webm. - Moved opus_constants from media/filters to media/formats/common - Removed unused constants/functions from opus_constants. - MockMediaSource now allows SetAppendWindow so we can reuse the (voluminous) opus audio hashes instead of generating new ones while the test media is broken. BUG=649438 TEST=new unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8dd11f7d08616b551dae1bca14c3e44d5447c92c Reviewed-on: https://chromium-review.googlesource.com/1178929 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585720}
-
Tommy Steimel authored
This CL re-adds the null checks for internal_button_ and GetComputedStyle on the overlay play button. These were added to prevent a crash, then removed when the crash was not fixed and replaced with a different null check. However, it looks like we actually need these too, so we're adding them back. Bug: 870490 Change-Id: I1c6ad4b3f1dc36c7a2149a06c4f42f8ca00fb589 Reviewed-on: https://chromium-review.googlesource.com/1187710Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585719}
-
Sergei Datsenko authored
BUG=chromium:856874 Change-Id: I9e7e9645d120b27868618053cffd5953908b99b1 Reviewed-on: https://chromium-review.googlesource.com/1184801Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#585718}
-
wutao authored
This patchs implements the assistant audio decoder service. Bug: b/80315134 Test: manual. Change-Id: I3643614339c4623fb26e1aaeed968c0bdea99796 Reviewed-on: https://chromium-review.googlesource.com/1184385 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#585717}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/790b2751b515..195b9510dbe5 git log 790b2751b515..195b9510dbe5 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 achuith@chromium.org cros_run_vm_test: Support for test_that args. 2018-08-23 vapier@chromium.org cbuildbot: sdk: stop trying to uprev android Created with: gclient setdep -r src/third_party/chromite@195b9510dbe5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2980a1fde59e78ca3237889984e24d02f261450 Reviewed-on: https://chromium-review.googlesource.com/1187862Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585716}
-
Hayato Ito authored
BUG=877299 TBR=yosin@chromium.org Change-Id: I98846bfc3dd89d07e2703cda8b8c32e3e6767cfd Reviewed-on: https://chromium-review.googlesource.com/1187849Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585715}
-
Sam McNally authored
One of the two implementations now supports moving directories so update the documentation to mention that moving directories may be supported, depending on the implementation. Bug: 172187 Change-Id: Ie5fde919681fef8a80528d25fd7b9e5a48225013 Reviewed-on: https://chromium-review.googlesource.com/1186931Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585714}
-
Tetsui Ohkubo authored
This CL replaces WiFi off icon to new one. The icon is specific to ash so it's placed in ash/resources/vector_icons. TEST=manual BUG=876218 Change-Id: I47d40641f2e8d4c7bc0d68322d84b6cd15d0bb69 Reviewed-on: https://chromium-review.googlesource.com/1184654Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#585713}
-
Stuart Langley authored
During normal processing, the file system starts a number of periodic requests to drive to refresh state. Many of these are not in response to user input and can complete gradually. However the underlying drive service has no way to differentiate between user initiate requests and background requests and uses the same processing queue for both, resulting in user initiated requests being delayed. This CL introduces a rate limited queue that the file system can use for requesting background requests, so that we always have capacity to quickly service user initiated requests. Bug: 874456 Change-Id: I5c041d7406f99d7f70af89aacc84bec39134f9a4 Reviewed-on: https://chromium-review.googlesource.com/1179119 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Alexei Filippov authored
On MacOS the implementation of libmalloc sometimes calls malloc recursively, delegating allocations between zones. That causes our hooks being called twice. The scoped guard allows us to detect that, and avoid double counting. BUG=803276 Change-Id: I96bfa2c7cf29b0f21777033f259c2e2d8286b2e2 Reviewed-on: https://chromium-review.googlesource.com/1187831 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585711}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I30aabba8626d648fa80ca3353a37dd9d97668b23 Reviewed-on: https://chromium-review.googlesource.com/1188062Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#585710}
-
Wez authored
Previously if QEMU ran but neither exited prematurely, nor did the guest ever become connectible via SSH, then the QEMU sub-process would be left running after the runner script exited. Bug: 877194 Change-Id: Id50fa44e11987f69afc469d73adc445b5066b7a5 Reviewed-on: https://chromium-review.googlesource.com/1187543 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585709}
-
Lei Zhang authored
Fix some lint errors as well. TBR=emircan@chromium.org,kbr@chromium.org,reillyg@chromium.org,sandersd@chromium.org,thakis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6753c2e20302ce2296950d9a033bf0d0ac3cf509 Reviewed-on: https://chromium-review.googlesource.com/1183847Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585708}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d5c73cf..b44922e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52f10ea76f26b0ed65f565fabb6d9f500b27ced5 Reviewed-on: https://chromium-review.googlesource.com/1187378Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585707}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b16da6a2a9e5..7b7eb8800be0 git log b16da6a2a9e5..7b7eb8800be0 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 tandrii@chromium.org git cl: restart using project~number on Gerrit. 2018-08-23 tandrii@chromium.org git cl: temporary stop using project~number on Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@7b7eb8800be0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876964,chromium:876910,chromium:876964,chromium:876910 TBR=agable@chromium.org Change-Id: Ifa9855cab76e938fb4be4584ebb2e61708bcb3e8 Reviewed-on: https://chromium-review.googlesource.com/1187095Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585706}
-
rajendrant authored
This CL defers the loading of CSS background images. StyleResolver registers the element to LazyLoadImageObserver so that when the element is scrolled near the viewport, full image will be triggered. The image load is deferred using ResourceFetcher::ResourceNeedsLoad() and the full image load is triggered via ResourceFetcher::StartLoad(). Bug: 846170 Change-Id: If90bf69e4583e4d8ff8006485c10229c3dca22f2 Reviewed-on: https://chromium-review.googlesource.com/1161208 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585705}
-
Robert Ogden authored
Including: * domains without a dot as in ".com" * private IPs * localhost, except in testing Whether or not to trigger on localhost is determined by a variation param to allow it to be changed in browser or unit tests, and during local development. Bug: 864644 Change-Id: I8798c202342ababa95c90e5918b8d836a4ec15e3 Reviewed-on: https://chromium-review.googlesource.com/1187502 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585704}
-
Ramin Halavati authored
Invalidation, search engines, and omnibox preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I8c2fbfac8ff8e9002ab828c908e826419bff2abc Reviewed-on: https://chromium-review.googlesource.com/1185599Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585703}
-
Will Harris authored
Running Chrome normally and watching it for a few minutes, I don't see this being delay loaded by anything, so this is probably a load time improvement. BUG=871847 Change-Id: I7c6647325f63d7d7dfa0e6b0807c15757cf8fda0 Reviewed-on: https://chromium-review.googlesource.com/1187711Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585702}
-
Xiaocheng Hu authored
This patch refactors the function by extracing DirectionAt() out of it, so that the logic of getting direction from VisiblePosition is abstracted. It also reduces one client of InlineBox, making it easier to transition to LayoutNG. Bug: 877263 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifba556e3fb03b7bfa6e4ed27df5e39d07a45eb7c Reviewed-on: https://chromium-review.googlesource.com/1187630Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Noel Gordon authored
More variables in this file are said to be const but are declared var. Make the directory tree selectors const. ENTRY_SET is too generic (not really helpful for code searching): make it FOLDER_ENTRY_SET, also make it const. Ahhh DIRECTORY: be const till I think of a better name. Bug: 876267 Change-Id: Ic0c1a25c4d019088cf73e45119081b4582c640c0 Reviewed-on: https://chromium-review.googlesource.com/1186521 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add new test file for tests related to Launcher. Add test util to call the Files app event listener that listens to chrome.launcherSearchProvider.OnOpenResult event, which emulates a call from the Launcher app. Bug: 869481 Change-Id: I178b20a8860348d613dd655291747a98e94cce95 Reviewed-on: https://chromium-review.googlesource.com/1186295Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#585699}
-
Luciano Pacheco authored
The IF condition is inverted, it should return when it isn't a native FileEntry/DirectoryEntry, only FilesAppEntry's types have "type_name" attribute defined. Test: New browser test being added on crrev.com/c/1186295 Bug: 869481 Change-Id: Icfdbdedc8289c65447f02c0604e6a36ac8176e6b Reviewed-on: https://chromium-review.googlesource.com/1186006 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Lei Zhang authored
- Make sure the base::SharedMemory passed in is valid. - Add a helper function in PdfCompositorImplTest to create test data. - Remove some unused headers. Change-Id: I2e6efeec7ec6efb75bd973edc9d1a532e1919ff0 Reviewed-on: https://chromium-review.googlesource.com/1186271Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585697}
-
Noel Gordon authored
TREEITEM_DRIVE and TREEITEM_DOWNLOADS are shared between various tests but are var-defined in multiple places. Multiple definitions are error-prone: choose one place and define them as const therein (CreateNewFolder for now). Update folder_shortcuts.js test to use this new TREEITEM_DRIVE definition, keyboard_operations.js already uses the TREEITEM_DRIVE/DOWNLOADS definitions. Test: browser_tests --gtest_filter="*/FilesApp*" No-presubmit: true Bug: 876267 Change-Id: I7b86719a29a25e9d649c33edbe8af6cddae529bc Reviewed-on: https://chromium-review.googlesource.com/1186390 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
agrieve authored
-keepname -> -keepnames Change-Id: Ie8febb9c4239e5344b0e3e6b333b4576cccb84b3 Reviewed-on: https://chromium-review.googlesource.com/1185692Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#585695}
-
JunHo Seo authored
Convert list: snav-display-contents-crash snav-div-in-anchor snav-fully-aligned-horizontally snav-fully-aligned-vertically snav-hidden-focusable-element snav-imagemap-area-not-focusable snav-imagemap-area-without-image snav-imagemap-overlapped-areas snav-imagemap-simple snav-media-elements Bug: 803086 Change-Id: Iebe20bba5868fec1e1c38f2a188346432c42d568 Reviewed-on: https://chromium-review.googlesource.com/1184945Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#585694}
-
Nigel Tao authored
A follow-up commit will use the IDs as a map key, to de-duplicate installation tasks and avoid re-installing a web app that's already installed. That requires that different web apps have different IDs. Change-Id: I8a86e6cd20ed59a2f5df0683353935004a2c39a5 Reviewed-on: https://chromium-review.googlesource.com/1186927Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585693}
-
