GitLab

Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/515303003/)

Reason for revert:
Reverting to see if it fixes the following issue. Crash rate has gone up by 10 times.

BUG=409191

Original issue's description:
> Landing Recent QUIC Changes.
>
> Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
>
> Merge internal change: 74239145
> https://codereview.chromium.org/509203003/
>
>
> Remove PacketType from QUIC because the QUEUED type is not used and the
> other types can be reduced to a bool.
>
> Merge internal change: 74148481
> https://codereview.chromium.org/515003003/
>
>
> Don't send a QUIC SCUP message until after handshake confirmed.
>
> A server config update was occasionally being sent before the crypto
> handshake was complete, causing the client to close the connection.
>
> Merge internal change: 74132773
> https://codereview.chromium.org/516713002/
>
>
> Change TransmissionInfo's all_transmissions SequenceNumberSet* to
> default to NULL, and only be present if there are multiple transmissions.
>
> Estimated to save ~2% of CPU.
>
> Merge internal change: 74076012
> https://codereview.chromium.org/509073004/
>
>
> Log the quic version for internal server tracing.
> Not used in production.
>
> Merge internal change: 74069715
> https://codereview.chromium.org/514043002/
>
>
> Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
> deque.
>
> Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
> on tools/quic/end_to_end_test.cc.
>
> Merge internal change: 74054196
> https://codereview.chromium.org/514033002/
>
>
> Unit test for empty packet closes QUIC connection bug.
>
> Merge internal change: 74041239
> https://codereview.chromium.org/495423011/
>
>
> Log the QUIC transmission type in QUIC internal server trace visitor.
> Not used in production.
>
> Merge internal change: 73895739
> https://codereview.chromium.org/514023002/
>
>
> Not used in production. Log whether a QUIC packet sent was a crypto
> packet or not for internal server side tracing.
>
> Merge internal change: 73894063
> https://codereview.chromium.org/515003002/
>
>
> Fix a QUIC bug in which PING frames were not being ACK'd.
>
> Merge internal change: 73837644
> https://codereview.chromium.org/512933005/
>
> R=rch@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949

TBR=rch@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/523813003

Cr-Commit-Position: refs/heads/master@{#292722}

scale_factor was not used at all.
scroll_offset was not being used correctly. This CL now grabs the scroll offset from the CompositorFrameMetadata in RenderWidgetHostView.

BUG=none
TBR=kenrb@chromium.org for code deletion in view_messages.h + browser_plugin_messages.h

Review URL: https://codereview.chromium.org/525523003

Cr-Commit-Position: refs/heads/master@{#292721}

Refactors the migration tests to no longer reuse the same
StatusChangeChecker.

Splits the previous MigrationChecker into two separate classes:
MigrationWaiter and MigrationWatcher.  The waiter is long-lived
and observes migrations.  The waiter exists only while we're
waiting for a migration to complete.

BUG=97780, 95742

Review URL: https://codereview.chromium.org/490643004

Cr-Commit-Position: refs/heads/master@{#292720}

BUG=395240
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/420663003

Cr-Commit-Position: refs/heads/master@{#292719}

This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).

NOTRY=True

Review URL: https://codereview.chromium.org/414503004

Cr-Commit-Position: refs/heads/master@{#292718}

The coded size should always be rounded up to multiples of 16 pixels to accomodate
alignment requirements of HW encoders, while the visible size reflects the actual
content size.

Update video capture messages to pass visible rect from browser to renderer process.

BUG=402501
TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown
R=dalecurtis@chromium.org, hclam@chromium.org, palmer@chromium.org

Review URL: https://codereview.chromium.org/500653003

Cr-Commit-Position: refs/heads/master@{#292717}

- Rename to tools/resources/list_unused_grit_header.py.
- Handle structures of type "FOO_{LEFT,RIGHT,TOP}".
- Add ability to scan files and folders.

NOTRY=true

Review URL: https://codereview.chromium.org/524743002

Cr-Commit-Position: refs/heads/master@{#292716}

The problem is that some locales (Hindi) or platforms (Linux) have a
bigger base font size for the default font (crbug.com/405994). If this
is the case, we should decrease the font size to the one we expect,
so that the font fits in the button correctly.

Just adjusting the baseline is not always enough, as the new avatar
button has a fixed size, and the text might not fit correctly
regardless of the baseline adjustments.

Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing

BUG=403466
TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button.

Review URL: https://codereview.chromium.org/470053004

Cr-Commit-Position: refs/heads/master@{#292715}

Everything seems to run fine locally.

BUG=270920

Review URL: https://codereview.chromium.org/513543007

Cr-Commit-Position: refs/heads/master@{#292714}

Allow special characters such as spaces in filenames.

Also includes some general cleanup, and documentation.

Review URL: https://codereview.chromium.org/15854004

Cr-Commit-Position: refs/heads/master@{#292713}

BUG=none
TEST=compile
TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/518303002

Cr-Commit-Position: refs/heads/master@{#292712}

https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/519933002

Cr-Commit-Position: refs/heads/master@{#292711}

Override the main() function from libppapi_stub, and rather than
simply failing when PPAPI is missing, assume that we are running
in sel_ldr and jump directly to the user's main function.

As a nice side effect this removes the needs to SEL_LDR=1 builds.

Review URL: https://codereview.chromium.org/412083002

Cr-Commit-Position: refs/heads/master@{#292710}

BUG=NONE
TEST=manually
NOTRY=true

Review URL: https://codereview.chromium.org/519903002

Cr-Commit-Position: refs/heads/master@{#292709}

NOTRY=True

Review URL: https://codereview.chromium.org/521453003

Cr-Commit-Position: refs/heads/master@{#292708}

Revert of Disable BrowserTest.InterstitialCloseTab which is flaky. (patchset #1 id:1 of https://codereview.chromium.org/424143003/)

Reason for revert:
This should be fixed by r288895

Original issue's description:
> Disable BrowserTest.InterstitialCloseTab which is flaky.
>
> BUG=393218
> TBR=mattm@chromium.org
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286225

TBR=mattm@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393218

Review URL: https://codereview.chromium.org/523733003

Cr-Commit-Position: refs/heads/master@{#292707}

This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.

BUG=404066

Review URL: https://codereview.chromium.org/480453002

Cr-Commit-Position: refs/heads/master@{#292706}

pa_stream_flush() returns a pa_operation object on success, so we must unref it by calling pa_operation_unref() to avoid memory leaks.

BUG=238493

Review URL: https://codereview.chromium.org/520613003

Cr-Commit-Position: refs/heads/master@{#292705}

This component handles the protocol between Chrome and an associated phone for
the Easy Unlock and Easy Sign-in features.

The system is currently implemented as a Chrome packaged app, and this is the
first step in migrating this functionality to native code. We will gradually
reimplement the system and switch from the app to this component once the
refactoring is complete.

BUG=385719

Review URL: https://codereview.chromium.org/505373004

Cr-Commit-Position: refs/heads/master@{#292704}

BUG=
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2f985cb

Committed: https://chromium.googlesource.com/chromium/src/+/26bbbb9

Review URL: https://codereview.chromium.org/516683002

Cr-Commit-Position: refs/heads/master@{#292703}

This CL also makes ApplicationRunnerChromium use MessagePumpMojo by default

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/506353002

Cr-Commit-Position: refs/heads/master@{#292702}

Also fix up tools/unused-grit-header.py to deal with some more grit formatting and corner cases.

Review URL: https://codereview.chromium.org/514493002

Cr-Commit-Position: refs/heads/master@{#292701}

BUG=370071

Review URL: https://codereview.chromium.org/343053002

Cr-Commit-Position: refs/heads/master@{#292700}

Also don't use "default" as a variable name, as it's a keyword.
Also fix a bug where a wstring was passed to %ls.

No real behavior change.

BUG=82385
R=hans@chromium.org
TBR=cpu, vitalybuka

Review URL: https://codereview.chromium.org/526513002

Cr-Commit-Position: refs/heads/master@{#292699}

Based on readability review by Dean Berris at Google.

R=jln@chromium.org

Review URL: https://codereview.chromium.org/511993005

Cr-Commit-Position: refs/heads/master@{#292698}

BUG=None

Review URL: https://codereview.chromium.org/518133002

Cr-Commit-Position: refs/heads/master@{#292697}

BUG=223859
BUG=394757

Review URL: https://codereview.chromium.org/514373003

Cr-Commit-Position: refs/heads/master@{#292696}

loading signal to ResourceScheduler

BUG=128035

Review URL: https://codereview.chromium.org/501703002

Cr-Commit-Position: refs/heads/master@{#292695}

BUG=408600
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/511053003

Cr-Commit-Position: refs/heads/master@{#292694}

BUG=

Review URL: https://codereview.chromium.org/337473004

Cr-Commit-Position: refs/heads/master@{#292693}

Also, adds some logic to FakeEasyUnlockClient.

BUG=407996

(note that these would have caught the crashes in bugs 404798 and 405976 :/)

Review URL: https://codereview.chromium.org/513013003

Cr-Commit-Position: refs/heads/master@{#292692}

R=lcwu@chromium.org,asvitkine@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/522853002

Cr-Commit-Position: refs/heads/master@{#292691}

Current HeadUpDisplayLayerImpl allocates one resource
and reuse it continuously. This patch is trying to
allocate two resources and swap one of them
which is available.
so HeadUpDisplayLayerImpl does not need free the resource
while the layer is alive.

Bug=None

Review URL: https://codereview.chromium.org/491783003

Cr-Commit-Position: refs/heads/master@{#292690}

Remove unused input_channels parameter from fuzzed media::AudioParameters generation.
Link against new components/pdf files.

Review URL: https://codereview.chromium.org/518923003

Cr-Commit-Position: refs/heads/master@{#292689}

Include the following CLs:

Avoids MSVC warnings about possible value truncation.
https://codereview.chromium.org/515383002/

TBR=agl@chromium.org,pkasting@chromium.org
BUG=

Review URL: https://codereview.chromium.org/521463002

Cr-Commit-Position: refs/heads/master@{#292688}

https://chromium.googlesource.com/chromium/blink/+log/3c4c83c54cc17327ea22f7c628e790a8895dde0d..a70eaece73b718e58ad26a2271e8b99dd1727043
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/519853002

Cr-Commit-Position: refs/heads/master@{#292687}

Sort the list of input java files for the aidl build step so that
the contents of generated makefiles in WebView have a stable ordering.

BUG=

Review URL: https://codereview.chromium.org/323803003

Cr-Commit-Position: refs/heads/master@{#292686}

Currently, the touch event queue will flush itself when it's notified
that all touch handlers have been removed. However, this effectively
overrides the ack of any outstanding touch that is being handled. In
particular, the touch may have been the cause of handler removal *and*
been preventDefault'ed, in which case we should respect the
preventDeafult.

Defer flushing the queue when all handlers have been removed, instead
waiting for any outstanding touch ack. Any additional pending events
will be automatically flushed when the ack is received.

BUG=406916

Review URL: https://codereview.chromium.org/521453002

Cr-Commit-Position: refs/heads/master@{#292685}

Advertise support for PDF plugins, and use the implementations from the
pdf component (in //components/pdf) for adding the necessary support for
showing PDF files in athena.

BUG=401242
R=jamescook@chromium.org, oshima@chromium.org, raymes@chromium.org

Review URL: https://codereview.chromium.org/484873004

Cr-Commit-Position: refs/heads/master@{#292684}

This code was used for Win8 non-aura builds. Now it's dead.
metro_driver should be cleared separately as it has a lot of stuff excluded from build.

BUG=142330
NOTRY=true
R=mad@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/524543002

Cr-Commit-Position: refs/heads/master@{#292683}