GitLab

https://pdfium.googlesource.com/pdfium.git/+log/024cbe1befe1..391d4f3130da

git log 024cbe1befe1..391d4f3130da --date=short --first-parent --format='%ad %ae %s'
2019-12-04 tsepez@chromium.org Remove #ifdef around right-button methods in fpdf_view_c_api_test.c
2019-12-04 tsepez@chromium.org Expose FORM_OnRButton{Down,Up} to non-XFA builds

Created with:
  gclient setdep -r src/third_party/pdfium@391d4f3130da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ia43b81e53d114f53b60cd6bff59b29a24c99fbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951656Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721717}

Bug: 973095
Change-Id: Ic0f0dffdaf16a4a024e08a08ea3daa811d8e192c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935156Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721716}

Some builds take more than 3 hours leading to timeout of almost complete
builds. Extend timeout until the builds are faster.

R=bpastene@google.com

Bug: 1030593
Change-Id: I4c85e14abfe1613e1f6908f175cbfaf1b8e91214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951091Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Anushruth  <anushruth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721715}

It's unlikely that CoreAnimation remains a power win when we get to
many layers, because of how we reconstruct the CALayer tree.

Further, when we get to ~20k layers, we start seeing corruption.

Bug: 1022116, 1024110, 835395
Change-Id: If74cd2b0d80c11dabf050be160d7eee3fb81e274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951659Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721714}

https://dawn.googlesource.com/dawn.git/+log/53782d60dc73..42b3b9c4131a

git log 53782d60dc73..42b3b9c4131a --date=short --first-parent --format='%ad %ae %s'
2019-12-04 rharrison@chromium.org Plumb UseSpvc toggle for tests

Created with:
  gclient setdep -r src/third_party/dawn@42b3b9c4131a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I35a4c44e8f6a5896e08b84d6f59d755f39b1e42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951341Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721713}

This CL removes the 'ignore' button on Safety Tips. UX folks felt that
this would be clearer and more consistent with existing patterns. Both
the infobar (mobile) and bubble (desktop) variants have dedicated close
(X) buttons that do the same thing.

This leaves them looking like this:
Desktop: https://drive.google.com/open?id=1e3UlzRa0g4kzr5p1-8dCO7Hfec3rWho7
Android: https://drive.google.com/open?id=19OGdgjZsQ4khNErmG_W160vlhQrvDiz6

Bug: 1030171
Change-Id: I906751b7ceb7b5023ae9ebaf5eea957ce220f51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948248Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721712}

It avoids triggering callbacks that end up being no-ops and limit it to
situations where the observer would actually do something about it.

Bug: 1028822
Change-Id: I7982f74d5791277e181e63e91c0f9f076586717a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949561Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721711}

Most of them are not necessary at all. One spot has parameters shadowing
member variables. Fix this by renaming the parameters.

Change-Id: I16c13588d40269d5c18bfe8877af31abc3ac5516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947828Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721710}

This change hooks up the selection of languages in this ViewController
to trigger InfobarTranslateLanguageSelectionDelegate calls in the
TranslateMediator. This will result in the Translate InfobarModal to be
updated with the new language selected. The new language will be temporarily stored
in the mediator. Only when the user taps on the Translate button will
the InfobarDelegate be updated with the new language.

To show the current source/target language in the ViewController, TableViewTextItem
is given a new checked property for the mediator to set before sending up the items
to the ViewController.

A isMovingFromParentViewController check is also made in viewDidDisappear in
InfobarTranslateTableViewController so that it doesn't call modalInfobarWasDismissed:
when the user is trying to change languages.

Bug: 1014959
Change-Id: If4374caac153673ac04618663994811a00dc76b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942672
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721709}

WebLayer uses the same implementation as WebView. What it lacks compared
to Clank is just metrics. That is, the parts of
//chrome/browser/spellchecker that Clank actually uses are purely
metrics as the spelling service is not enabled for Clank.

Implementing spellcheck for desktop would require refactoring a lot of
//chrome/browser/spellchecker.

Bug: 1025621
Change-Id: I186f78c08d97267cb8d55e55adff952018293840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929494
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721708}

After more investigation of which devices logged URLs will be coming
from, it's unlikely we'll be getting useful signal from the chromebook
itself. So let's disable URL logging altogether.

This CL:
 1. Disables URL navigation logging.
 2. Redacts any existing URLs in saved protos.

Bug: 1012936
Change-Id: Ie96191ea6b0be47f7a2adbb29b80cc3b693f7844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947614Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721707}

Change-Id: Iec9b00fb28f5d94900da086cefdb556bd1c31a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949848
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721706}

See attached bug for screencast. Confirmed with UX that the highlight should only appear on drag, not hover.

Bug: 1017822
Change-Id: I0921f5cf425d82c25344adb4801de6de8746f771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929490Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721705}

This regression was caused by refactoring the delegate in
https://chromium-review.googlesource.com/c/chromium/src/+/1938253

Change-Id: I2fe052bbe240b9fb19ef0c6c5bd633f8d67f2336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940870Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721704}

Currently, when the device scale changes, we accept the Window Manager's
instructions on how to re-position the omnibox popup.

That doesn't work anymore in the WebUI tab-strip world, and actually if
it ever worked in the past, it seems like it must have by chance only.

This CL makes it so that on widget resize (which should only happen
during device scale change or rotation), we explicitly update the popup
appearance, which should re-align it to wherever the omnibox currently
is.

I tested this by changing the device scale (Ctrl+Shift+Plus) on
ChromeOS on Linux with the omnibox popup open.

Bug: 1027387
Change-Id: If80e20ef276704363c01ec98a685eb791f29ae56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951335
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721703}

Tests basic functionality of the JS Self-Profiling API via a helper JS
module.

Bug: 956688
Change-Id: Ib16e7f86c05fb35df930639f41dc1a25b9dd9242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790586
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721702}

https://swiftshader.googlesource.com/SwiftShader.git/+log/80d21bbafd2d..a727d8080716

git log 80d21bbafd2d..a727d8080716 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 sugoi@google.com Enable the fullDrawIndexUint32 feature

Created with:
  gclient setdep -r src/third_party/swiftshader@a727d8080716

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I01c09606e6f6d9a8e334219b425cc4cc0ccbe7db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721701}

Update some of the share sheet styling to match the spec. Also add
in the icons for STTS and QRCodes.

screenshot: http://screen/4okyHGgCLAn.png

Bug: 1009124
Change-Id: If1aa78812644602643ff5d76d068ad1151bd159e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949077Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721700}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=reveman@chromium.org

Bug: 1023677
Change-Id: Ia795dd9eeb5400b51249bb3cc48120e262f22f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927014
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721699}

Bug: 1020740
Change-Id: I15dbc8d06a72e54c4c7c0a16b2afa8331113185b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951337Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721698}

R=pkasting@chromium.org

Bug: 1028831
Change-Id: Icba29140de51382053d11766573e602677fb609e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950687
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Stephen Lin <stephenlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721697}

Bug: 1030446
Change-Id: Id022b1d43b7359df768671fbb5562f53a8b21f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947549
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721696}

- Modified ensureAppLaunchedWithFeaturesEnabled API in AppLaunchManager
  - Added flag |relaunchPolicy| to control manners during relaunching
    app.
- Added backgroundAndForegroundApp method to AppLaunchManager, which
  backgrounds the app and moves it back to foreground.
- Added tests in smoke_egtests.mm to test the newly added methods.
- Changed disabled tests in restore_egtest.mm to using the new API and
  enabled them.
- Changed other affected tests.

Bug: 1018482

Change-Id: Ia20026ca0999b2be3a31ab01f19e47196b4bd07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935713
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721695}

When dragging a window from shelf, if the window should be taken to home
screen after the drag ends, use scale-in animation to show home screen.
If overview is active, then fade out overview windows.

Bug: 997885, 1026944
Change-Id: I11b92e152679fe32efc2fae0b30b71dcba4ccc74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949276
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721694}

Also reshard the nexus5x perf bot.
Note that this may cause false positive regressions because it
will move some benchmarks to run on different devices.
DO NOT REVERT THIS CL if it appears to cause a perf regression.

Rendering team tells me that nexus5x has a high degree of noise for them,
so they don't mind running fewer benchmarks on it and relying instead on
nexus5 and pixel2 bots.

R=johnchen@chromium.org, sadrul@chromium.org

Bug: 1030788, 1030840
Change-Id: If7a7f2cd847989b4fddd24bc6fa56b5379795d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951333
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721693}

This makes finding the inverse operation easier since the Join and
Split operations are defined in two different header files.

BUG=

Change-Id: I86ed3fb360737d3c2fed14edcff59afa0bbac05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948241
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721692}

If kDragFromShelfToHomeOrOverview feature is enabled, gesture to drag
most recent app window in from top of the home screen is disabled.
Given that on home screen the drag handle presence indicates that an app
window can be dragged in, remove the handle when the feature is enabled.

BUG=1024629,1026964, 1030817

Change-Id: Iefc229bcb447618502b554b8848a800f829c3969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951643Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721691}

Rename PermissionRequestAutoBlocker to NotificationPermissionUiSelector
to better reflect its current responsibility, and to disambiguate from
PermissionDecisionAutoBlocker.

Factor out all logic from ShouldCurrentRequestUseQuietUI() into an
NotificationPermissionUiSelector implementation, in preparation for the
drop-in replacement ContextualNotifictionPermissionUiSelector from a
follow-up CL.

Also update calls sites on Android to call the PermissionRequestManager
instead of the QuietNotificationPermissionUiState, so that these call
sites will be able to tolerate showing only a fraction of requests
using the quiet UI once Safe Browsing based triggering is enabled.

Bug: 1030633
Change-Id: I355072e0f40cae665536c66b0631d8e609be9b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951105Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721690}

When aggregator.GetNode() is nullptr, ShouldWalkObject returns false.

Bug: 999264

Change-Id: I4d25322dfdff3741c7a3f02bf6971db233716c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946450
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721689}

Once we have a Q bot these can go on the CQ.

Bug: 1012819
Change-Id: Ia8dd3eff4aaf239db80676e832cb2b936ad6bfc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943096
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721688}

Adding a nullptr check to OnSimpleLoaderCompleteInternal() to avoid crashes
that have been appearing since M69.

Change-Id: Iaa1ddc1cefb741917029bbfb581995c7836d373a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949549Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#721687}

This (somewhat) refactors the AddOutOfFlowChildCandidate into two variants:
 1) For the inline-level OOF case.
 2) For the block-level OOF, added additional "edge" paramaeters.

There should be no behaviour change.

Bug: 845235
Change-Id: If3957078afca7cc0f9175198837a06f0f2badadb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931676
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721686}

ChromeDriver is not correctly detecting when a context id is no longer
valid. This cl updates the error string used to detect this case, and
returns a Selenium standard error instead of a Chrome specific-error.

Bug: chromedriver:3230
Change-Id: Iaa33ae5d64cc634dddc53776e0d03bc385cf6bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951571Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721685}

Splitting these changes off of
https://chromium-review.googlesource.com/c/chromium/src/+/1949773

Bug: 1022212
Change-Id: Ibf62966995ff4c16eb8cd1edf65110e469ad28e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951156
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721684}

This reverts commit 9d32d07a.

Reason for revert: Causing webkit_layout_tests failures:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7801

Original change's description:
> Make ScriptedAnimationController a ContextLifecycleStateObserver
> 
> This removes the need for special-case pausing/unpausing in Document, as well
> as custom Document::Shutdown() logic.
> 
> Bug: 1029822
> Change-Id: I2c9cda5bb3720626cdc1f3fcadb7876422ca375e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949275
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Auto-Submit: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721599}

TBR=haraken@chromium.org,japhet@chromium.org

Change-Id: Ib0dae947c5d4f5dd375b4d14130cf33146648036
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1029822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951772Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721683}

This adds an optional message below the form in the show action form.
At the message's right there is a tappable icon that prompts a message.
In the prompt it's possible to add a button that opens an URL.


Bug: b/144083252
Change-Id: Iaa02a0660cc1f9cc7246e620f0579346a4d2d494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940174
Commit-Queue: Luca Hunkeler <hluca@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#721682}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1e65162c..6d162b51

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I00a230070338ec44e0be84dfdacebd9aca156535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950887Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721681}

https://chromium.googlesource.com/catapult.git/+log/1d23e728fb93..c4a669a1bfc2

git log 1d23e728fb93..c4a669a1bfc2 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 crouleau@chromium.org [Telemetry] Add weblayer as a tag for disabling.

Created with:
  gclient setdep -r src/third_party/catapult@c4a669a1bfc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1030735
Tbr: sadrul@google.com
Change-Id: If733f658298c78b14a15f8bf26bc901e8843a182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951339Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721680}

TBR=rsorokin@chromium.org,xiyuan@chromium.org

Bug: 1030810
Change-Id: Ibca3245a6109f1f6dc56c5389309cfe088a58c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951545
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721679}

This revert https://chromium-review.googlesource.com/c/chromium/src/+/1951146

Bug: 967716
Change-Id: Iee524f60bc3ee38d0a8118523429d5905ad33914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951136Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721678}