- 10 Dec, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606733211-benchmark-89.0.4343.0-r1 to 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I668fb1438a7a245c04f1e70f39a5555d21a29882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835861}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606737320-benchmark-89.0.4343.0-r1 to 89-4324.22-1607342008-benchmark-89.0.4351.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If3aa4bc39ef1f592a8a2ed94a08a2474fdf81812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585738Reviewed-by:
-
Gordon Seto authored
This reverts commit c641fdaa. Reason for revert: Fix tests that were failing due to nearby_contact_visibility.html being loaded directly in the test at nearby_share_browsertest.js:171. This caused V1 tests to fail because loading the source directly skips loading the strings that are required. In this CL we remove the browsePreload() override so that the nearby_contact_visibility.html source is not loaded directly. This is the same logic NearbyOnboardingPageTest does, which also needs to use string-loading during its tests. Original change's description: > Revert "[Nearby] Update subpage visibility text and fix dialog a11y." > > This reverts commit dc4eea24. > > Reason for revert: It looks like this is causing test failures --> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/21664/ Change-Id: I0e503980ce97d8b8fe3740bba81697c7ed453801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583115Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#835859}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/505943a6a4cb..bd6d8e4204b5 2020-12-10 wl@gnu.org .mailmap: Add Priyesh. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: I5a4fe829beb2c74be504834ecb34dd9822311169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585704Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835858}
-
Ben Joyce authored
Bug: 1157340 Change-Id: I8d261a7811e0c785080e2b80419ea8af98bf53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585387Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#835857}
-
Alex Leung authored
Modules in //chromecast/media/common are shared with internal repos and cannot have any //media dependencies. I left in targets/headers that redirect to the new targets and will be removed once internal dependencies have been removed. Bug: b/174777644 Change-Id: I8456f8c1315f711a10d98b4c0b9d2490e3462596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578386Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#835856}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0379a1cd635..cfb713273ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,bartekg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156885 Tbr: aaronhk@google.com,bartekg@google.com Change-Id: I110a1fbd0d14add251ea246fb556708570f080d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835855}
-
Xiaocheng Hu authored
This patch implements: - The core of the "generate a counter representation" algorithm [1] for all counter algorithms - The fallback algorithm when a @counter-style fails to represent a given counter value This patch does not implement 'prefix', 'suffix', 'negative', 'pad' descriptors, and also the first symbol value for 'fixed' system. These will be left for future patches. [1] https://drafts.csswg.org/css-counter-styles-3/#generate-a-counter Bug: 687225 Change-Id: I93c8914ab72cbf22f768f0a3e3cada42909975cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581201Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835854}
-
Jeroen Dhollander authored
This unfortunately ended up being a rather big change. It includes: - Adding unittests for chromeos/services/libassistant - Introducing a |StateObserver| to inform the assistant service when the |AssistantManager| has been created. - Rename |ServiceController| to |ServiceControllerProxy|, to prevent confusion with the |ServiceController| in the libassistant service. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*:ServiceController*.*" Change-Id: I1dc675aeb1ded0cb2c9a3a35bea57fc03fce4f06 TBR: sky@ Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522332 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835853}
-
Harry Cutts authored
This CL adds a new setting for the pointing stick's primary button, with a corresponding dropdown on the pointers subpage. The setting carries over to the login screen, too. If the flag is disabled, changes to the equivalent mouse setting are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. login screen) Bug: 1114828 Test: Check the dropdown changes the primary button (including on the Change-Id: I3f078767bfe703a2f451eac807969e68e5273902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573389 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835852}
-
Jiaqi Han authored
The classpaths written by build/android/gyp/create_java_binary_script.py are relative paths to the current working directory, this CL removes the duplication part for the concatenation of source root and the relative paths. Merge-With: eureka-internal/494461 Bug: None Test: CQ Change-Id: I434e2807c86909c86dad9c5ebd528b8fbe56b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582411 Commit-Queue: Jiaqi Han <jiaqih@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#835851}
-
Amr Aboelkher authored
Hash dance timer usually starts off whenever the AutoEnrollmentCientImpl is going to start i.e. AutoEnrollmentCientImpl::Start(). However, as PSM is being executed in the beginning, before Hash dance sequentially, that will make the resulting Hash timer record Hash dance duration + PSM duration. This CL is starting the timer of Hash dance only when preparing and sending off the Hash dance request. Also, it adds its required regression tests. BUG=chromium:1157317 Change-Id: Ie4aa0b8a3bd6cf296e3804995cacc45c23833c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582121 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#835850}
-
Yue Li authored
This is a reland of 8144dae3 Original change's description: > Quick Answers: Add page size options for Search request > > Since we only use the first result from search request, set the page > size to 1 to reduce the delay. > > Bug: b/173239982 > Test: None > Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833940} Bug: b/173239982 Change-Id: I357edef540563fdbc8b5ba93bbb78ac127d827b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578262Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/35f077086ef3..0a64a9747555 2020-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d94a77b3 2020-12-10 nicolascapens@google.com Update dEQP/Cherry setup documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b3163a44bdbfe146dcfdcd142059394452f6a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584694Reviewed-by:
-
Peter Qiu authored
Bug: internal b/174649142 Test: manual on device Change-Id: I737054f7aa7fbfed193dc7cd5dba29cd4ba3902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582824 Commit-Queue: Peter Qiu <zqiu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#835847}
-
Joel Riley authored
Also update floating panel UI to match visual spec: go/enhanced-sts-spec AX-Relnotes: N/A Bug: 1143825 Change-Id: I0d5cf4b5c026e7eb7b5ccc6944a77d9247cab41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577882 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835846}
-
Kramer Ge authored
This reverts commit 500376ce. Reason for revert: crbug.com/1144179 has been fixed, we no longer make consecutive subsurface commits with fences. Original change's description: > [LaCrOS]Disable usage of linux_explicit_synchronization for now > > linux_explicit_synchronization can cause crash due to a bug in earlier > exo version. Underlying issue can be fixed from lacros side. Re-enable > once fix is landed. > > Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 > Bug: 1151012 > > TBR=rjkroege@chromium.org > > Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552854 > Reviewed-by: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829874} TBR=rjkroege@chromium.org,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151012 Change-Id: I932daf018ac1e48898221f849652b50d65f1b0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580280Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#835845}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/108b759ef91b..f6df8692023c 2020-12-10 jmadill@chromium.org Vulkan: Support XFB in non-Vertex stages. 2020-12-10 kaiyili@google.com Add an option to copy the artifact to vendor partition 2020-12-10 jmadill@chromium.org Increase internal max uniform blocks limit to 60. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: run roll_aosp.sh --copy-to-vendor-partion, build the Android image Change-Id: I5e8d8661db84048c39452fedc8181aff7885a9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585724Reviewed-by:
-
Fritz Koenig authored
This is a short clip. If the hardware can decode the clip in it's entirety before sending a reset then there will be 2 flushes, not 1. BUG=b:174428494 TEST=tast.video.DecodeAccelVD.vp9_show_existing_frame Change-Id: Ia22aed2397d25567f019edb5f43740c8efeb0898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578381 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#835843}
-
Thomas Guilbert authored
This CL fixes a race condition in which a MediaLog could be created in a context that is already destroyed. See the attached bug for more details. Bug: 1154468 Change-Id: I26ae0c621d9a4557d224ca77f696ad3ce53b41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580478Reviewed-by:
-
Michael Bai authored
Make server and computed field types available for Java when the autofill starts, this patch doesn't work for prediction that arrives after the autofill start. Add the integration test. Change-Id: I2eb23f0244ce4b745eaa15bcaee57e10f41acd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581146 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#835841}
-
bttk authored
SitePerProcessAutoplayBrowserTest.PropagateUserGestureFlag is flaky. TBR=alexmos@chromium.org Bug: 1014175 Change-Id: I4547aaefd7337900f20883e0768a0bda418a923c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586207Reviewed-by:
-
Hans Wennborg authored
Otherwise the script doesn't run on Windows; relying on the shebang doesn't work there. Bug: 877722 Change-Id: Id7665fb1d03bece0d015eb6a9f2f7fbf96325d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582078Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bob Haarman <inglorion@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#835839}
-
Leonid Baraz authored
Bug: b:170054326 Change-Id: Id1948ddad64e6bec3ed960a83b910073b18bb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582863 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835838}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9f89587dc4fc..6def748c92e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3d1a42b4aa0d2a14445637453b81ce2a30499c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585548Reviewed-by:
-
Boris Sazonov authored
Adds chrome/browser/lacros/account_manager_facade_lacros_unittest.cc and a couple of basic tests for AccountManagerFacadeLacros. To make that class testable, the mojo::Remote is now passed explicitly to the ctor. Bug: 1117472 Change-Id: I59826ff3c7c0d6561b8fd4cb94a164884eb91a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545923Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835836}
-
Yue Zhang authored
SimplePlayPause and MultiplePlayersPlayPause are flaky on multiple Android bots. TBR: mlamouri@google.com Bug: 1157319 Change-Id: Ic1944c2281f10ba3dca8298e22d0a784d533919e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585668Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835835}
-
Austin Sullivan authored
- Allows for file picker prompt to start in a well-known directory (Desktop, Documents, Downloads, etc.) - If specified, this field takes precedence over LastPickedDirectory https://crrev.com/c/2478901 - Adds RuntimeEnabled feature flag for all in-development FSA APIs Bug: 1019287 Change-Id: I1f6278d2407e756e4a0e24ed043a93dc088e7905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555998 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Frank Liberato authored
Previously, we would elide any config change that arrived before the first frame was decoded, since the accelerated decoder sends one even if it matches the container config. Unfortunately, some streams actually do change config before the first frame (e.g., some RTC streams). Eliding it leaves the D3D11 decoder configured for the container config. This CL causes D3D11VideoDecoder to elide the config change, and prevent re-allocating the D3D11 decoder, only if the config matches what the container told us. Bug: 1109397 Change-Id: Ib9c5ec77897b24666118077935f91c541cbdabe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585666 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835833}
-
Garrett Beaty authored
This adds support for providing multiple console_view_entry values in ci.builder. Change-Id: Ia936e903a139e855fbdb14ca452a176225c56317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585446 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#835832}
-
Rachel Carpenter authored
Targeted for M89, launch bug crbug/1104668 Bug: b/174514210 Change-Id: Ica81eef4d720142a1725b105da5159ce46873e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583586Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835831}
-
edchin authored
This CL creates a base class that will hold cross-platform code. The derived class PasswordProtectionService (in /content) will have content-specific code. This CL keeps the base class in the same file to make the review easier. A followup CL will move the base class (and unittest) into separate files. * moves navigation throttle code to derived class. * moves some content-specific functions to derived class. Bug: 1147967 Change-Id: I1fa606f241225680bd33b7828fdfc6b588ad415d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576079Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835830}
-
Andrew Xu authored
This CL shows the delete button's inkdrop highlight when the button is under pseudo focus and protects the feature by a browser test case. Bug: 1151493 Change-Id: I3b42cb001e63002b658b84c662338e773efe5c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583208Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835829}
-
Robbie Gibson authored
Bug: 1056781 Change-Id: Ie7c1421b4e6767d6f9714f75f2317555045ff951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581920 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835828}
-
Trevor Perrier authored
Change-Id: Ib664751e624c8211035d6b00ff8e9ebc669f05a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585550Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Josh Simmons <jds@google.com> Auto-Submit: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#835827}
-
Jimmy Gong authored
Previously, the connected Phone Hub UI would display before the phone model is initialized. This resulted in the UI flashing the uninitialized status model before the actual phone model status. This fix delays the connected view from displaying until the model is initialized. Fixed: 1155636 Change-Id: Iadbbefbc3e5cee70316cfe02ef9d466888a2e6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581221 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Proposal: go/phishguard-referring-app-android. Add SafeBrowsingReferringAppBridge to obtain referring app information from java side. This class is not added under safe_browsing/ module, because it depends on IntentHandler, which is not modularized yet. Bug: 1154860 Change-Id: I75307e232a63d4f09016db7bb712186f266896d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568643 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835825}
-
Hiroshige Hayashizaki authored
As the non-bare keys and resolution results of specifier maps are normalized (i.e. serialized URLs), raw and percent-encoded non-ASCII strings are considered equal (as both of them are percent-encoded after serialization). This CL tests that raw and percent-encoded versions of non-ASCII characters are: - Considered equal in non-bare specifier keys, - Considered equal in checking backtracking, and - Not considered equal in bare specifier keys. For consistency, this CL also adds some backtracking tests that don't involve non-ASCII characters but use the same patterns of added non-ASCII tests. Bug: 848607, https://github.com/WICG/import-maps/issues/207 Change-Id: I6c8ae478da2fcbe0f6df03a608dabdad60644ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573422 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835824}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4a4586c0442385d383e3722d95d83053856e1ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585266Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607590477-d35f449faec99b40815e9d2dc99b7b8e79c372c4.profdata to chrome-win64-master-1607612331-9abd6632cfb32a4e513da1b46025c0e77c15ae02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5a64d3d36c6532f12069f84961f02f981b749936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585104Reviewed-by:
-
