- 10 Sep, 2019 40 commits
-
-
Jit Yao Yap authored
Change-Id: Ib0710ad86a9266d5b60a4cceca6abff00b0c20d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795248Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#695218}
-
Sigurdur Asgeirsson authored
This allows users of the public performance manager API, outside the performance_manager directory to use the test fixtures and access the graph implementation for testing only. Bug: 910288 Change-Id: I529f3b54d190f2cae1e3a23bd5d5758f5e973b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790402Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695217}
-
Peter Kasting authored
Bug: 23697 Change-Id: Id372671eda6800a995fb31ff30213a8276e7b4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792006Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695216}
-
Aaron Krajeski authored
For deferred offscreen canvases, it's possible that there are un-drawn, recorded commands at these points. Bug: 1002523 Change-Id: I0b47319ff38aaa4030e9b74f897abd54eeeb4bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779107 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695215}
-
Corentin Wallez authored
Also implements GPUTextureViewDescriptor.aspect and GPUBindGroupLayoutBinding.textureDimension that were added to Dawn in this roll. https://dawn.googlesource.com/dawn.git/+log/a900ccebcf42..f60522f5a467 $ git log a900ccebc..f60522f5a --date=short --no-merges --format='%ad %ae %s' 2019-09-10 digit [fuchsia] Fix Chromium build. 2019-09-10 digit [fuchsia] Implement external semaphore and memory support. 2019-09-10 cwallez Implement BGLBinding::textureDimension 2019-09-10 cwallez Add TextureViewDescriptor.aspect. 2019-09-10 cwallez Implement debug markers and groups for CommandEncoder 2019-09-09 enga Metal: Support setting bind groups before pipeline to match WebGPU semantics 2019-09-09 enga D3D12: Add IndexBufferTracker 2019-09-09 enga D3D12: Factor SetVertexBuffer tracking to match other tracking classes 2019-09-09 digit [fuchsia] Add headers containing extra vulkan definitions. 2019-09-09 digit Enable Vulkan for Chromium Fuchsia build. 2019-09-09 enga dawn_wire: Fix leak in Server::DoDevicePopErrorScope 2019-09-07 hao.x.li Align the size of Uniform and Storage buffer to 16 bytes in Metal 2019-09-05 bryan.bernhart Resource Management 6: VK support for resource allocation. Created with: roll-dep src/third_party/dawn Change-Id: I631197c99bb2847175731627a1d808fa5b85a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795762Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695214}
-
Sam Maier authored
Bug: 992461 Change-Id: I89026c422872e499f8038814a2a98c68e9fa422d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796103 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#695213}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c650bce8. With Chromium commits locally applied on WPT: d8d7248d "Move forced colors tests to wpt" 999a3129 "[LayoutNG] Fix line breaking behavior after out-of-flow objects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mcasas@chromium.org: external/wpt/geolocation-API mstensho@chromium.org: external/wpt/css/css-multicol timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic9dcdc7fe26ebe599ebe30ae1472d2377bb1c54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795663Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695212}
-
Mandy Chen authored
As per the plan [1] to localize the Audits Panel, this CL adds locale files in the lighthouse repo [2] to audits_worker/lighthouse/locales/. The files are copied to the output folder that's uploaded to the remote server (out/Release/resources/inspector/audits_worker/lighthouse/locales) and they are not bundled into audits_worker_module.js. They are also not bundled with the default (non-remote) devtools (out/Release/gen/devtools). Screenshots: https://imgur.com/a/hZiufh4 [1]: https://docs.google.com/document/d/1jnt3BqKB-4q3AE94UWFA0Gqspx8Sd_jivlB7gQMlmfk/edit?pli=1 [2]: https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n/locales Bug: 941561 Change-Id: I6c6572ceef6f94ebd5ff46cc17a83c21f8708221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784959Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695211}
-
Tatiana Buldina authored
Bug: chromedriver:2198 Change-Id: I8e13ec3b88dd7018cb4650fc0ce52d4feb4aed07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793944Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695210}
-
Roger Tawa authored
The production version of DeviceManagementService::CreateJob() is now always async, so tests should not assume that it works synchronosuly. This CL removes the mock functions that allowed tests to be written in a sync manner and updates the tests to work async. Change-Id: I6b52fb56ef60b2e0e642f9f85d0a1afb2a6662d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642228 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695209}
-
Aga Wronska authored
Test: ParentAccessViewTest Bug: 999384, 999391 Change-Id: I22f5a4bf109401822bc4492efd55f0e4d77630d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793636Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695208}
-
Yun Liu authored
FlushingReTrace caused ClassNotFoundException error on bots: e.g. https://chromium-swarm.appspot.com/task?id=472348a61c76df10 Bug: 985581, 968605 Change-Id: I1d1415f68a8426b81a7c549d0419d32d8a2bd7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790070Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Bug: 950039 Change-Id: I96c208a9e3f9d75cd56ff04a7c7d97427635cc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790147 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695206}
-
Lan Wei authored
These tests are flaky when we send the events asynchronously, now we change to send the last action in one tick synchronously by default. Now the test should not be flaky any more. Bug: 999814, 1000530 Change-Id: I3fbc438b74c1912983c6767e77fc94c386aea256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795745Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b01c7962da..507f43465b33 git log 45b01c7962da..507f43465b33 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jakobi@webrtc.org Reland "Make relative arrival delay mode default in NetEq delay manager." 2019-09-10 henrika@webrtc.org Add support for 192kHz input audio sample rate. Created with: gclient setdep -r src/third_party/webrtc@507f43465b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I1fbb8bcacdf0c2c8a9e13c693396795bed547106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695204}
-
Jérôme Lebel authored
Adding -[SigninEarlGreyUI signOutWithManagedAccount:] and removing some calls for TapButtonWithLabelId(). Bug: 684817 Change-Id: Ie99d6c64eb5566e9f423f19e0b856b32c6d8d525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795584Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695203}
-
Darin Fisher authored
Change-Id: I307a15e13b577db6ab3b728f09fbce65e3e528d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793408 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695202}
-
Himanshu Jaju authored
Adds illustration to educate user on how to use devices with shared clipboard. Button to open chrome settings page to turn on sync would be a follow up CL. Dark mode - https://drive.google.com/open?id=1bgNYKQIAppVpqDfknpntFderdEzcLkYL Light mode - https://drive.google.com/open?id=106EBilI5KGzpdpPzLgrQUccmgwpFAT5s Bug: 1001102 Change-Id: I48815dc1822657125ca7538b6ab69c3fa8b38886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790202Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#695201}
-
Matt Menke authored
This CL makes HttpServerProperties methods that deal with broken alt services take NetworkIsolationKeys, and wires through through to the BrokenAlternativeServices object it owns. This CL also updates HttpServerPropertiesManager to save/load the NetworkIsolationKey associated with each broken alt service. Bug: 969890 Change-Id: I81909c8a3965d510fe775e7ccadebd4d88e5a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775260 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695200}
-
Saman Sami authored
vulkan_content_browsertests does not need an exception to not run on Linux FYI GPU TSAN Release. It's already excluded. Bug: 940723 Change-Id: I58ff26b57f5d5fa60ca54627b320149fe4de3d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795983Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#695199}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a47836e01af9..b2d5d40a3393 git log a47836e01af9..b2d5d40a3393 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 bsalomon@google.com Adapt GrRectBlur for cases with rect W/H less than six sigma. 2019-09-10 jvanverth@google.com Hook up pinch-zoom and swipe gestures. 2019-09-10 bsalomon@google.com Remove per-format glCheckframebufferStatus checks. Created with: gclient setdep -r src/third_party/skia@b2d5d40a3393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I7a6344c8dc37b12e5fc9b962cacba850c9ddbb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796105Reviewed-by:
-
Shivani Sharma authored
top-frame-origin was added to RedirectInfo for splitting the http cache using the top-frame-origin and that had to be updated when navigation requests were redirected. Now split cache uses network isolation key (computed in the browser process) and it is updated on redirect in the URLLoader->FollowRedirect. After these changes the top-frame-origin in RedirectInfo is no longer needed. Navigation resources with split cache are already being tested in existing browser tests and this removal does not break any of those tests. Bug: 978968 Change-Id: I58a69b4799fe3ba567cfe09989890e9af86924be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732794Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#695197}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/devtools. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 891670 Change-Id: I42f549fef6bf7c3e1da3c6b08fdd64353f741a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786901 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#695196}
-
John Chen authored
Perf test system_health.common_mobile/background:news:nytimes is failing on all Android devices. Disabling it. TBR=crouleau@chromium.org NOTRY=true Bug: 1002546 Change-Id: If54c8c34edace7711c12fbe809044158ea6708b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795753Reviewed-by:
-
Koji Ishii authored
This patch fixes `vertical-align: top` and `bottom` when they are applied to a box that has children with `text-top` or `text-bottom`. In LayoutNG, `vertical-align` is handled in 3 different timings. 1. `top` and `bottom` are added to the pending list of the line box, or to the nearest ancestor box that has `top` or `bottom`. 2. `text-bop` and `text-bottom` are added to the pending list of the parent box. 3. Other values are computed when the box is closed. When a box has both 1 and 2, this patch changes to compute 1 (`top` and `bottom`) after 2. Before this patch, both 1 and 2 are computed at the same time for each box. 3 test cases out of 20 in this test fails without this patch. Bug: 1001664 Change-Id: I0e7746447f5e401837c2c28e308171f0987eba35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792396Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695194}
-
Abigail Klein authored
This flag will be used for improvements to the chrome:accessibility page. The page queries for the accessibility tree, which is sensitive code that powers accessibility. Making changes to that code needs to be done carefully and will require its own QA pass, which is what motivates adding this flag. Bug: 785493 Change-Id: I37d57761447ca1ab17a91e410b09547bf7ac4a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790067Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#695193}
-
Matt Menke authored
This CL deletes FileProtocolHandler from net/, makes URLRequestFileJob a test-only class (HTTP request mocks subclass it), and deletes URLRequestFileDirJob and NetworkDelegate::CanAccessFile. File URLs are now handled outside of the network service, so this code is no longer being used. This CL leaves in place net/directory_* files, which are used by the new code (And should probably be moved somewhere more appropriate for their new use, in another CL), and the network build option disable_file_support, which should also be cleaned up when moving those files. TBR=seantopping@chromium.org Bug: 934009 Change-Id: I2ef493849847adbb340a364de12ea41e91870b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787187 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695192}
-
Matt Menke authored
Currently, they're always empty, because HttpServerPropertiesManager neither saves nor loads them, nor does HttpServerProperties take them as input. Bug: 969890 Change-Id: Ifd59c763be96ef2ded39501f5af2cbcc3dea3906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769527 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Kamila authored
This CL implements two experimental UI flavors for surfacing notification permission requests to users on Desktop that are quieter than the currently implemented permission bubbles hanging off the left-hand side of the Omnibox. The new UX consists of showing a "Notifications blocked" icon in the Omnibox, clicking on which will display a bubble where users have the ability to add a per-site allow exception by clicking "Allow for this site", as well as a "Manage" button for managing notification preferences. The first UX flavor shows a static icon, while the second flavor shows a sliding icon that appears with animation and is initially accompanied by an explanatory text label before it is minimized. Detailed changes: - Show the notification prompt as an indicator icon in the location bar. - Change the logic to show an indicator when a permission is requested (instead of when a permission is accepted or denied). - Let permission request manager know when the user allows notifications for a site. - Implement the new notifications permission request image and bubble model. - Implement the icon variations in UI in content_setting_image_model. - Add experimental variations, complementary to Android. Screenshots: Static icon http://screen/XVLQ1sAWHQD Sliding icon http://screen/mDdFC3utKaP Bug: 986737 Change-Id: Id40db28465d36f502d09f09c0ad0cb4c2cf904e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726092 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#695190}
-
Mandy Chen authored
The city names in settings are not localized because the localization parser doesn't know about them. Modify the parser to recognize these strings. Bug: 941561 Change-Id: If1974dd471b3d646c900dea6932f427a273c19f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769300Reviewed-by:
-
Peter Kasting authored
Bug: 1000055 Change-Id: I18e9dda2079ac4634abcb4cadd35fbcb11b82c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793257 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695188}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/video_capture. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=chfremer@chromium.org Bug: 891670 Change-Id: Icccc112e5c7be94fd38e2901c013657910579288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787110 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695187}
-
Gyuyoung Kim authored
This CL applies pending_remote to AssistantService::Init and Assistant::AddAssistantInteractionSubscriber. - Convert mojo::Binding to mojo::Receiver - Rename AddBinding to AddReceiver - Apply pending_remote to AssistantInteractionSubscriberPtr Bug: 955171 Change-Id: I6f6653c10c56d60dfc259eb25b5e27936a2cfd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778896Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695186}
-
John Chen authored
rendering.mobile/balls_svg_animations has already been disabled on android-webview, but consistent failures are also observed on non-webview devices. Disabling on all Android devices. TBR=crouleau@chromium.org NOTRY=true Bug: 1000473 Change-Id: I8fa8008e97bd768ffd70758376dc73ade025d662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795750Reviewed-by:
-
Anastasiia Nikolaienko authored
To allow reauthentication of secondary accounts from ARC, remove check for account value. Secondary accounts which have been added directly from ARC may not be in the list of Chrome accounts. If invalidated account is in ARC, but not in Chrome OS Account Manager, return an error. Bug: b/137921583 Change-Id: I4a0a904481e1afc39a17e2a755987b7aaad72da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746173 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#695184}
-
Aga Wronska authored
Change-Id: Ia92d28d7287bd14c5da2d706b266556b4b3c0de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793768Reviewed-by:
-
Nick Burris authored
Add a 'selector' member to window.location which is currently just an empty object but can be used for feature detection for scroll to text, and can be extended later to include properties for the fragment directive. Also add a test for the member to the web platform test. Tested updated WPT locally with run_web_tests.py --additional-driver-flag= '--enable-blink-features=TextFragmentIdentifiers' Bug: 1000308 Change-Id: I99b5ea14008e0b84f1e67129b7af27107b1fdec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791793Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#695182}
-
Donn Denman authored
Fixes a bug with the Contextual Search panel on tablets: when not full width it is no longer centered. Now it is. Details in the bug. BUG=1000952 Change-Id: I39d7f4c11f42b7e78a6c8373b1ca8e09600ac012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790327 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695181}
-
Anton Bikineev authored
After this commit the GarbageCollectedFinalized class becomes a dumb class. It will be removed as soon as the blink-gc-plugin is updated and clang is rolled. Change-Id: I6c6454bf434f1daac0ee3b741995113c3e68c15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738378 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695180}
-
Sinan Sahin authored
testDismissContextMenuOnClick instrumentation test fails because we click on a notification instead of a view in the app which causes a java.lang.SecurityException: "Injecting to another application requires INJECT_EVENTS permission." To work around this issue, this CL changes the test to click roughly the bottom right corner of the screen. Bug: 1001966 Change-Id: I3f0d3c06ad72450217b936ea17d896db4162deb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792685Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#695179}
-
