GitLab

TEST=unit tests
BUG=85046

Review URL: http://codereview.chromium.org/7046057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88452 0039d316-1c4b-4281-b951-d872f2087c98

Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS.

BUG=chromium-os:15789
TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug

Review URL: http://codereview.chromium.org/7108019

TBR=rkc@chromium.org
Review URL: http://codereview.chromium.org/7104076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84783
TEST=existing tests since no new feature
Review URL: http://codereview.chromium.org/7003070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88446 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88445 0039d316-1c4b-4281-b951-d872f2087c98

```---------------------------------------------------------------------
r686 | nduca@chromium.org | 2011-06-08 16:50:48 -0700 (Wed, 08 Jun 2011) | 2 lin
es

Fix crlf newlines in surface.cpp
TBR=apatrick@chromium.org
```

---------------------------------------------------------------------
r684 | daniel@transgaming.com | 2011-06-08 13:38:09 -0700 (Wed, 08 Jun 2011) | 1
 line

Revert copyImage changes from r682 as they cause regressions on some webpages
------------------------------------------------------------------------
r683 | nduca@chromium.org | 2011-06-08 11:43:16 -0700 (Wed, 08 Jun 2011) | 3 lin
es

Recommit r668, which got undone accidentally by r673.

Review URL: http://codereview.appspot.com/4589043
------------------------------------------------------------------------

r682 | daniel@transgaming.com | 2011-06-08 05:42:28 -0700 (Wed, 08 Jun 2011) | 6 lines

No need to update texture before overwriting it with CopyImage.

Issue=163
TRAC #17019
Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------
r681 | daniel@transgaming.com | 2011-06-08 05:41:32 -0700 (Wed, 08 Jun 2011) | 6 lines

Fix multi-sample state management.

Issue=160
TRAC #16817
Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------
r680 | daniel@transgaming.com | 2011-06-08 05:40:23 -0700 (Wed, 08 Jun 2011) | 4 lines

Add missing DWM libraries to Release project.

Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------

BUG=84071

Review URL: http://codereview.chromium.org/7046054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88444 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a port of the ntp3 notification area, except it allows multiple links.

I think there are currently some minor bugs around most visited deletion and undo; think of this changeset as just a new piece of UI, and I will improve the functionality later.

BUG=none
TEST=[x] a most visited thumbnail and then undo

Review URL: http://codereview.chromium.org/7124002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing tests due to no new functionaility
Review URL: http://codereview.chromium.org/7104067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88441 0039d316-1c4b-4281-b951-d872f2087c98

Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS.

BUG=chromium-os:15789
TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug

Review URL: http://codereview.chromium.org/7108019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88440 0039d316-1c4b-4281-b951-d872f2087c98

Add PyAuto automation call GetPanelInfo(). Includes basic information: title, url, renderer pid, and whether it is incognito.

BUG=chromium-os:14135
TEST=Manual.

Review URL: http://codereview.chromium.org/7108025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88439 0039d316-1c4b-4281-b951-d872f2087c98

I've run the test over 20k times without any issues. (The test passed
nearly instantly in all cases.) I've also run it under valigrind (over
100 times). I've run it with other tests and on its own numerous times
with no problems. All of this was done on Linux because that it where the
test failed.

Also, noteworthy is that this same functionality is run by other tests which
the Linux bots have been passing without incident.

BUG=53607
TEST=TemplateURLModel.Load

Review URL: http://codereview.chromium.org/3341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88438 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88437 0039d316-1c4b-4281-b951-d872f2087c98

TBR=koz

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88436 0039d316-1c4b-4281-b951-d872f2087c98

result in some weird resizing in the tab strip.

BUG=85380
TEST=see bug
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7044061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85475
TEST=browser_tests
TBR=tsepez

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Invoking SetSelectedIndex(-1) results in stack overflow.
TEST=NONE


Review URL: http://codereview.chromium.org/7140001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

This test is to verify that popup process launched through incognito shares a process id with it's parent process

Review URL: http://codereview.chromium.org/7068032
Patch from Jasneet <jasneet@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88429 0039d316-1c4b-4281-b951-d872f2087c98

Loading 2x bitmaps on 10.5 caused a regression in our startup time.

Since we don't need 2x bitmaps on 10.5 and 10.6 simple fix is to simply disable loading the bitmaps on those platforms.

BUG=80501
TEST=Ran on 10.6 and used logs to verify that the resource pak was not being loaded. Did the same on 10.7 and verified that the resource pak was being loaded.


Review URL: http://codereview.chromium.org/6995090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88426 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully
no longer crash clang.

BUG=84815
TEST=none

Review URL: http://codereview.chromium.org/7104062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88425 0039d316-1c4b-4281-b951-d872f2087c98

This change disables scaling of infobar icons. With this change it should be easier to catch clipping issues due to incorrectly sized infobar icons.

BUG=80432
TEST=Try jobs pending.


Review URL: http://codereview.chromium.org/7134024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88424 0039d316-1c4b-4281-b951-d872f2087c98

Adjust layout of settings pages to use a display table in order to adjust appropriately for internationalization.  Fix vertical alignment of headings with options.

BUG=74487, 56535
TEST=Launch in a variety of locales.  Go to 'chrome://settigns/browser'.  Check for layout problems due to overlap of an option heading and the corresponding controls.


Review URL: http://codereview.chromium.org/7088010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88419 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88418 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus
Review URL: http://codereview.chromium.org/7046058

TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/7003071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88415 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus
Review URL: http://codereview.chromium.org/7046058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88414 0039d316-1c4b-4281-b951-d872f2087c98

This increments the promo version in PromoResourceService so that users will fetch the new promo immediately after upgrading to M13, rather than having to wait up to 48 hours.

BUG=84561
TEST=none


Review URL: http://codereview.chromium.org/7104063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88413 0039d316-1c4b-4281-b951-d872f2087c98

(Also moves the image forcing to after the image is set so it doesn't get
reset.)

BUG=85443
TEST=compiles

Review URL: http://codereview.chromium.org/7003066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88412 0039d316-1c4b-4281-b951-d872f2087c98

The test previously failed to wait for the 'pkill chrome' command to finish
killing the relevant chrome processes.

BUG=chromium-os:16297
TEST=None

Review URL: http://codereview.chromium.org/7108023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7108007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88408 0039d316-1c4b-4281-b951-d872f2087c98

Icons in the download DOM UI were very fuzzy.

This was a regression due to r76743.

The problem was that IconLoad was returning a multi-resolution image but callers weren't multi-resolution aware.

For example, the download DOM UI would encode the image to PNG but it would just pick the first bitmap which happened to be 16x16. This caused icons in the DOM UI to look fuzzy.

I think there are two fixes for this:
1. Change IconLoader so that callers no longer specify the icon size. Instead, callers must pick the right resolution when they get the icon loaded callback.
2. Have callers specify that they want all resolutions.

I went with 2 because always loading all icon sizes can be expensive.

BUG=84741
TEST=Ran and verified that the downloads UI looks good.


Review URL: http://codereview.chromium.org/6995068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88406 0039d316-1c4b-4281-b951-d872f2087c98

This logging is inspired by Xiyuan's change in http://codereview.chromium.org/7038026/

BUG=81451
TEST=none

Review URL: http://codereview.chromium.org/7104049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88405 0039d316-1c4b-4281-b951-d872f2087c98

Every time the dialog is loaded, the read-only email address would be appended
to the span.

BUG=84665
TEST=manual


Review URL: http://codereview.chromium.org/7054062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Preview a webpage. Enter a page range text. If the text is invalid, an error message is displayed.


Review URL: http://codereview.chromium.org/7003060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88402 0039d316-1c4b-4281-b951-d872f2087c98

Adding padding at the bottom of internet details page, so we make room for button strip (and avoid its overlapping with page contents)

BUG=chromium-os:12995
TEST=Made sure buttons on the internet details dialog don't overlapp with contents in any of its tabs.
Review URL: http://codereview.chromium.org/7054056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88401 0039d316-1c4b-4281-b951-d872f2087c98

Use the System URL Request Context in the web resource service instead of the default profile's context.

This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs.

BUG=64339
TEST=all current web resource tests continue to work.
Review URL: http://codereview.chromium.org/7099004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85081
TEST=Open print preview tab, print a doc. Reopen, the last used printer should be pre-selected.


Review URL: http://codereview.chromium.org/7042034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/7058055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16264
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7046050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run remoting_simple_host --me2mom without cached credentials.


Review URL: http://codereview.chromium.org/7041006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88394 0039d316-1c4b-4281-b951-d872f2087c98