- 14 Feb, 2020 40 commits
-
-
Roland McGrath authored
The <zircon/syscalls/definitions.h> header is an implementation detail of the OS that was never meant to be used by application code. <zircon/syscalls.h> alone gives access to the Zircon syscall API. Bug: fuchsia:45844 Change-Id: I0a1594e36c5eb6a05ff2266461970e49958c34bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055591 Auto-Submit: Roland McGrath <mcgrathr@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741543}
-
Kelvin Jiang authored
If an extension uses all hosts (e.g. by specifying <all_urls> in host permissions), an API permission kHostsAll is created somewhere down the line. This permission is used to provide a permission message, but kHostsAll is not added as an API permission when checking if there is a privilege increase between a set of granted vs requested API permissions. As a result, an extension can be reported for a privilege increase even when it shouldn't. This CL fixes this issue by adding kHostsAll for privilege increase checks to make sure the right messages are compared. Bug: 1014505, 512344 Change-Id: Ie20045c6760b50dae5949b9cceaf10467fcf1534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042387Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741542}
-
Mike Reed authored
Also updated test color values to be "valid". The previous set were intended to be premul-rgba, but they were not legal premul. The new values are SkColor values, which are defined to be unpremul. Bug: 896969 Change-Id: Iebaf94ab767d2622798a239a4714ac4b64613225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053257Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#741541}
-
Matt Jones authored
TBR: mthiesse@chromium.org Bug: 1052429 Change-Id: I6aab582df7d71ba3433e23d302b334fd081641b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057099Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741540}
-
Andrew Grieve authored
Didn't meaningfully change runtime nor file size, but seems like a flag we should be using. Bug: None Change-Id: I7e42cb4bac8036d97f6db61c4906c1ff6ae88e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040910 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741539}
-
Mason Freed authored
This CL adds the DeclarativeShadowDOM runtime enabled feature, and implements a basic approach. There are no tests yet, as this is an evolving spec/approach. But this allows basic testing of attaching the shadow root upon the closing <template> tag. See the explainer [1], the issue discussion [2], the intent to prototype [3], and the chromestatus entry [4]. To test this feature: --enable-blink-features=DeclarativeShadowDOM and then: <div> <template shadowroot=open> <div></div> <slot></slot> </template> <span> </div> [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md [2] https://github.com/whatwg/dom/issues/831 [3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nJDc-1s3R9U [4] https://chromestatus.com/feature/5191745052606464 Bug: 1042130 Change-Id: I5057c932a89fc401735d024348799d30c97e959e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018336 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#741538}
-
Robert Sesek authored
Bug: 710376 Change-Id: I78027a4bb288f9136de105c76df364cf24c70087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053254Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741537}
-
Min Qin authored
BUG=1021151 Change-Id: Ie1b15017136f98b9573b3621cbf816c4e0d0e5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055893 Auto-Submit: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741536}
-
Pavol Marko authored
Before this CL, it was posted on the ThreadPool, however the task assumes that it runs on the same sequence it was posted from. This gave me DHCECK failures in browsertests, but could have worse implications. Bug: none Test: browser_tests don't fail with with DCHECK failures for me anymore Change-Id: I583bbd5e483568fa39595e6e7c4c854570998758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055085 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741535}
-
Tim Volodine authored
Rebaseline some interfaces and properties that are exposed in Chrome and are also expected/OK to be exposed in Android WebView. In particular: interface Animation : EventTarget interface AnimationEffect interface Blob - some methods interface ByteLengthQueuingStrategy interface CSS - static method registerProperty interface CanvasRenderingContext2D - getter/setter interface Clipboard : EventTarget - method read/write interface ClipboardItem interface CountQueuingStrategy interface DeviceMotionEventAcceleration interface DeviceMotionEventRotationRate interface Document : Node - getters/setters (animation related) interface FormDataEvent : Event interface Geolocation interface GeolocationCoordinates interface GeolocationPosition interface GeolocationPositionError interface HTMLElement : Element - animation related interface KeyframeEffect : AnimationEffect interface OffscreenCanvasRenderingContext2D - methods interface OverconstrainedError interface RTCDtlsTransport : EventTarget interface SVGElement : Element - animation related interface ServiceWorkerContainer : EventTarget - message related BUG=867450 Change-Id: If4d6b8ecbe28d49789647e736bb436c7d674782f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044193 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741534}
-
Andrew Luo authored
Bug: 1021665 Change-Id: I4d0b51afd0134fc4b2413a6e9463745352d2b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038032 Auto-Submit: Andrew Luo <aluo@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#741533}
-
Sigurdur Asgeirsson authored
Change-Id: I9f02fe6f5de33ef136d1bf9336a0e066128204fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047375 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#741532}
-
Will Harris authored
This allows MITIGATION_DYNAMIC_CODE_DISABLE to be enabled for the process on Windows, and moves PAC resolver from the Renderer helper variant to the Default helper variant on macOS. BUG=961831,961592 Change-Id: I90f9dc69fa5ebf43f71b0395d7d2217fc24181b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051153 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741531}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06265e017f9e..3a36511f21d1 git log 06265e017f9e..3a36511f21d1 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 egdaniel@google.com Remove origin from GrSurfaceProxy. 2020-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ac4e1d236088..f9f999f5a2eb (6 commits) 2020-02-14 bsalomon@google.com Remove unique_ptr_address_as_pointer_address Created with: gclient setdep -r src/third_party/skia@3a36511f21d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I6e964f9e4eb89f7bf49165d11a2bfd83af89695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741530}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0bdce0f5115d..9478dbffef45 git log 0bdce0f5115d..9478dbffef45 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 fmayer@google.com Merge "Deobfuscate names in flamegraph." Created with: gclient setdep -r src/third_party/perfetto@9478dbffef45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8368c9d6cfb210958377ce642783f55a73425964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057376Reviewed-by:
-
Chris Mumford authored
This reverts commit 3893c26b. Reason for revert: Dangling reference to ios-simulator-xcode-clang.json. https://sheriff-o-matic.appspot.com/chromium/examine/chromium.read%20build%20config Original change's description: > [iOS] Remove xcode clang bots > > Bug: 1049646 > Change-Id: If024c2185409167031bcdaf3a801e73cb1c61b0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042679 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741519} TBR=justincohen@chromium.org,martiniss@chromium.org,michaeldo@chromium.org Change-Id: I2e0e630a1c4f5ed5706a40a34a5c479e1dff31f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057583Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#741528}
-
Kurt Horimoto authored
Rather than being owned by the OverlayContainerCoordinator, this CL moves this functionality to a separate object owned by the OverlayPresentationContext. This will allow it to be used in a follow-up CL when the overlay container functionality is split between multiple coordinators. Bug: 1030357 Change-Id: I38a6e7d179e119b180059df1e1a78b10029548b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056110 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741527}
-
Yue Zhang authored
Currently, we use AnchoredPopupWindow#onRectChanged to force update popup strip layout when new tabs are added. This could lead to a race condition where RecyclerView tries to recycle a view that has been temporarily detached due to the re-layouting process. This is only reproducible when there is recycling happening, and when tab is added from background. This CL bypasses this crash by disabling the force update for adding tabs from background. Note that it is already a known issue that strip is not properly updated when tab is added from background, so this CL doesn't introduce any UI difference before/after. Bug: 1045944, 1050401 Change-Id: I4d7ba97f53d41042867bea9562ce2e76aade118b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048988 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741526}
-
Sujie Zhu authored
card for Android On Android, we will return RequestOption in GetRealPan response if user check the Opt-in checkbox on unmask dialog. When requestOption is returned, we will call FIDOAuthenticator Authorize. We also store the cvc and card info to delay the form filling until verification finishes. For registering new card, we did not add this flow for Clank yet. We do it similarly as Desktop. Note that this CL is not specific for settings page, this is shared between checkout flow and settings page. For settings page, we will have a follow up CL to hide the checkbox when intent to opt-in. Updated corresponding unittest, but could not manual test locally because of no enrolled key yet. Bug: 949269 Change-Id: I44f9585a77c19bf33f5d791f616b9756944ddc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044649 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#741525}
-
Ben Goldberger authored
Bug: 1049291 Change-Id: If7c6b04a2a3ac4db08db7b20558225daf77c55dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055803Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#741524}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfbb2ba942c1..a710b74a3690 Created with: gclient setdep -r src-internal@a710b74a3690 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1051809 Tbr: jbudorick@google.com Change-Id: I0872e6f2c449a01a462a18baba6fed2714dca3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057377Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741523}
-
Ryan Daum authored
* Allows the aura widget hierarchy to be be viewed in the Elements tab in the chrome inspector. * Requires that --enable-ui-devtools be passed. * Process for use described at https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ui/ui_devtools/index.md Bug: internal b/148931987 Test: manual Change-Id: If1caceb2df6bf189f185163ed225826220530af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052553Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#741522}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b27cda94. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I39bb7554e40d35ee00ca2a96deb149b32d8dcb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056646Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741521}
-
Wez authored
Fuchsia's GN SDK provides GN rules for Fuchsia-specific targets (e.g. FIDL libraries, Fuchsia components & packages, etc). This change switches update-sdk.py to download the GN SDK; follow-up CLs will migrate the Chromium build to use the SDK-provided rules. Bug: 1050703 Change-Id: I1023eb3d8239c2905aa7945883bfb3d016974192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056907 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741520}
-
Mike Dougherty authored
Bug: 1049646 Change-Id: If024c2185409167031bcdaf3a801e73cb1c61b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042679Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741519}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a3e7d4dd2bc..9f4ab98d1264 git log 3a3e7d4dd2bc..9f4ab98d1264 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jmadill@chromium.org Return angle::Result from more label functions. Created with: gclient setdep -r src/third_party/angle@9f4ab98d1264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I9d6e721bd793f0b9157baa8aca3da44e4f7401a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057369Reviewed-by:
-
Aaron Krajeski authored
With deferral enabled we can get a lot of resource thrash when intermediate canvases and contexts are created, updated and drawn to a target canvas multiple times in a tight loop. Add a perf test for this. Bug: 1049491 Change-Id: I360ed39a36027bd6efafddee5582a64b90eb3ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053727Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#741517}
-
Monica Basta authored
Adding a mechanism to compare images by an identifier which is the GAIA picture url with size. This avoids overriding the image and sending uncessary |OnProfileAvatarChanged| while the image is the same. Bug: 1050375 Change-Id: Ie5cdc58d1f18e256c8560cf2b87552d47c3c8bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055083 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741516}
-
Manu Cornet authored
Bug: 1050788 Change-Id: I462618ca7f4f4486502ecbd3d89be557f6a71c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057088Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741515}
-
Wez authored
Remove logic from update-sdk.py for cleaning up the Fuchsia SDK from the old download path, since it has been ~years since we migrated. Replace all use of print() with logging.info() and set default logging level to logging.INFO. Bug: 1050703 Change-Id: I816d68988506fd6d5c7b98514048b41c34ab550f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056809Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741514}
-
Matt Jones authored
TBR: dullweber@chromium.org Bug: 1052395 Change-Id: Ieecc844418eb9b3ff976306d6af97768351719e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057152 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Hongchan Choi authored
This is a preparation work to implement the synchronous stopping in AudioDestination::Stop(). Bug: 1048351 Change-Id: Ib15da752f41e07ccdb810609140371dd9ee7a2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042368 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#741512}
-
Dave Tapuska authored
Add a use counter to track usage of feature. BUG=961448 Change-Id: Ic8166b6b1e23df166024f6db5c51b894fbbd03ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056490Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#741511}
-
Adrienne Walker authored
This can't happen right now, but will be needed when the storage service restarts. Bug: 1015214 Change-Id: I51de219204847310f2b3238c104dea97dc72909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055384Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86fbe04c6633..c4243361bbb6 git log 86fbe04c6633..c4243361bbb6 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 maruel@google.com [lucicfg] Update in depot_tools to 1.12.2 Created with: gclient setdep -r src/third_party/depot_tools@c4243361bbb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051164 Tbr: agable@chromium.org Change-Id: I849f65990e9018b292be045c8fb3e9253ffc066a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057370Reviewed-by:
-
Becca Hughes authored
Stores artwork URLs associated with the media session and loads them too. BUG=1024379 Change-Id: Ie3f4951da24a57c6e1ba9658ee8e35941e08f845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055686 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741508}
-
shrekshao authored
Bug: 1052344 Change-Id: I411fb5250ade492857a5c57e39324ca98300a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057110 Commit-Queue: Shrek Shao <shrekshao@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#741507}
-
Carlos IL authored
Sets the feature to enabled by default and removes the config from fieldtrial_testing_config.json in preparation for launch. Bug: 1025276 Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741506}
-
Ben Joyce authored
To update to androidx, we run the "jetify" script on all targets passed to process_java_prebuilt. This converts all references in the jar to androidx without having to modify the source code. This also allows us to not have to check in third_party jars that reference androidx, such as the gms libraries. To compile with the androidx dependencies with the android_support_library references still in the code, we modified the java groups in android_deps/BUILD.gn to have the dependency target depended on androidx, but use the old support library as an input_jar. All the resources (such as layout.xml files) need to be converted to androidx too, which was done in another CL, this CL just activates that feature in compile_resources.py Bug: 896775 Change-Id: Ib53c670b53145999ca57eebd4905e8f22684de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830506 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#741505}
-
Stephen Chenney authored
This method is empty for all cases. Bug: 1042141 Change-Id: I449c83c533fa0f1593279a29f71bb019d49d8fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056925 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
