- 17 Nov, 2017 40 commits
-
-
Michael Thiessen authored
The GVR bugs have been fixed, we can remove our workaround. Workaround was added in https://chromium-review.googlesource.com/c/chromium/src/+/682107 Bug: 769005 Change-Id: I2ff8edc388de04fa2c4f662406ab7687c13eb88e Reviewed-on: https://chromium-review.googlesource.com/775864 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517461}
-
Ran Ji authored
Add an extra to the intent that sent to CCT to indicate where it comes from. Currently the extra is only set by Webapp/WebApk Bug: 769728 Change-Id: I38ddbf9a5e797e602513de098a890645419d90c3 Reviewed-on: https://chromium-review.googlesource.com/751302Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517460}
-
Francois Doray authored
The "MinimumProtectionTime" field trial has expired. Not having to read the "AllowMultipleDiscards" param of this field trial will simplify the TabManager refactor. Bug: 775644 Change-Id: Ide53247821bc9753fe8d6ba27614d3591384cbed Reviewed-on: https://chromium-review.googlesource.com/771545 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517459}
-
Sammie Quon authored
Add a minimum distance for windows that get tapped and already in a snap region (windows tapped close too the left or right side of the screen). This is so users do not accidently snap too easily when trying to activate the window. Also fix a bug where you can drag very straight across or down without the overview window moving. Test: ash_unittests SplitViewWindowSelectorTest.Dragging Bug: 778933, 781324 Change-Id: I1b4e993951260f079f85851890854dc217ea95f3 Reviewed-on: https://chromium-review.googlesource.com/757985 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517458}
-
rnephew authored
This reverts commit d0c9cacb. Reason for revert: 5X AOSP bug is fixed and rolled. https://chromium-review.googlesource.com/c/chromium/src/+/776353 Original change's description: > Disable failing blink_perf.canvas stories on Webview too > > Even though they're failing on 5X webview and they're disabled on 5X, > there's a bug where 5X webview isn't matching the 5X test condition > (https://github.com/catapult-project/catapult/issues/4045). > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 784540 > Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84 > Reviewed-on: https://chromium-review.googlesource.com/775433 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517137} TBR=charliea@chromium.org,ashleymarie@chromium.org Change-Id: Ib48acc82b6fb1b2a1e3aa3c4f3966456cf88103f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 784540 Reviewed-on: https://chromium-review.googlesource.com/777060Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#517457}
-
Scott Chen authored
This CL changes the look of the welcome page for profiles that have DICE fully enabled. Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ife6f0d2cc661b15d2cf9be9a8577b090707ff57d Reviewed-on: https://chromium-review.googlesource.com/753386 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#517456}
-
Marc Treib authored
The test has some flakes on Win dbg, which is likely just a bit too slow. This CL increases the sleep time from 100 to 200 ms to hopefully resolve the flakes. TBRing this single-character test-only change, so it can accumulate some runs over the weekend. TBR=mastiz Bug: 778248 Change-Id: I9c9d0a39023d76ad4bea05aa8f700bd310d4f284 Reviewed-on: https://chromium-review.googlesource.com/776660Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517455}
-
Tom Sepez authored
No functional change intended, just duplicate code reduction. Adds the common signal handler to broker_process.cc, since all it does is call back into BrokerProcess methods. Change-Id: Ie8f1604888465fb9996c34a7f0f42811b8cddb30 Reviewed-on: https://chromium-review.googlesource.com/773109 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517454}
-
Koji Ishii authored
TBR=eae@chromium.org Bug: 714962 Change-Id: I573cac0271e631a79b6c8c9f6f9b2b9477458bf2 Reviewed-on: https://chromium-review.googlesource.com/776515Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#517453}
-
Gauthier Ambard authored
This code is no longer used as ContentSuggestions is enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1cf12abd965840c1f02c137fa4f542057842648d Reviewed-on: https://chromium-review.googlesource.com/776653 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517452}
-
Jamie Madill authored
Bug: 786044 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8f7cb86b0bdff0b60ffe3d3a1553ff34c262ef1d Reviewed-on: https://chromium-review.googlesource.com/774986Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517451}
-
Shivani Sharma authored
When a writer transaction gets converted to the reader and it was the transaction that created the network transaction, then it should save the network transaction's info like network received bytes at that point. This was not happening because the condition for saving the network transaction info checked if the transaction was still in Writers but it was not. Removed that condition since its not needed. Bug: 782992 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie31e803144628612053d232fa4a7df42a984d14e Reviewed-on: https://chromium-review.googlesource.com/771779Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517450}
-
Philip Jägenstedt authored
This isn't needed because: * Fullscreen::FullscreenElementChanged sets the flag when an element becomes the fullscreen element. * Moving a fullscreen element always means first removing it, and removing a fullscreen element should exit fullscreen. The test would hit an assert without this change. Bug: 781527 Change-Id: If57a93efefdd60073e949f823aa58d3f0e148deb Reviewed-on: https://chromium-review.googlesource.com/776599Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517449}
-
Henrique Nakashima authored
This change is gated by the kIsEditModeTracked flag in pdfium_engine.cc. There should be no functional change yet as the flag is off. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb6c266a0dbef1b168ef7f52d85ad4b5214ac639 Reviewed-on: https://chromium-review.googlesource.com/769491 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#517448}
-
Gauthier Ambard authored
ContentSuggestions is enabled to 100%, the GoogleLandingMediator won't be used anymore. Saving the favicons for the Content widget should be done from the ContentSuggestionsMediator. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31667a896cfdbe378d0efa6b67df5c8e9189d4d7 Reviewed-on: https://chromium-review.googlesource.com/776798Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517447}
-
Owen Min authored
Using build-in util URL function to add path and query to the url instead of using StringAppendF. Bug: Change-Id: Ie62bff86da96e62bf41ed6097adbe43956efe99f Reviewed-on: https://chromium-review.googlesource.com/775934Reviewed-by:
-
Louis Romero authored
Simple enough fix, we just have to tell MDC we agree to let footer cells handle interactions when editing, as footers are not editable. Bug: 665425 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7ada7dd0fd845046753991e548399b2ff29ef543 R: marq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/776834Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#517445}
-
Gauthier Ambard authored
This CL adds the methods to the ToolbarCoordinator to support taking snapshot for Side Swipe. The support for the UI update will be added later. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I45170fa89244f5645d3da8dc5e059dcb34ab1f42 Reviewed-on: https://chromium-review.googlesource.com/774280 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517444}
-
Christopher Grant authored
Death tests are prone to flakiness in test environments that fork. This test started failing when a seemingly totally unrelated change affected dynamic library loading. That other change was reverted for more investigation, but on our side, lets just avoid such tests. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia2bce3f7d610949b9f96b62c0df9a6def010ac54 Reviewed-on: https://chromium-review.googlesource.com/775865Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#517443}
-
Christos Froussios authored
DestinationFileSystem is the desktop implemenation of Destination, which sends the data to the file system. Bug: 785237 Change-Id: I034fab562eafde2240dc75743cb2ebbc6f7ec9ac Reviewed-on: https://chromium-review.googlesource.com/776596 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517442}
-
Allen Bauer authored
Added check for existance of the FindBarController before causing it to be created on demand. This should prevent a startup performance regression. Bug: 783350 Change-Id: Idbf4243e22db833fba8123c6b9e828c8c953ff12 Reviewed-on: https://chromium-review.googlesource.com/764030Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517441}
-
Gauthier Ambard authored
The updates to the back/forward buttons, related to the tab history presentations are now moved to a new object. The goal of this object is to contain most of the updates of the buttons of the toolbar. Bug: 784846 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idc95d91cfca5a265e661d89550a8b1dc5e40d3ef Reviewed-on: https://chromium-review.googlesource.com/768869 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#517440}
-
Leszek Swirski authored
For V8 logs and UMA, we want to detect whether scripts passed to V8 are from an external file, inline scripts, generated strings or other sources. Previously we were doing this by checking source offsets and the presence of a resource cache handler, but this was inaccurate, not to mention a layer violation. This introduces a ScriptSourceOrigin enum which is made a member of ScriptSourceCode. The ScriptLoader tells the ClassicPendingScript whether its source is coming from an inline script, is generated during a document.write, or more esoteric variants like is from a non-parser generated element. Then, the V8ScriptRunner can use this enum to decide what sort of "no cache handler" reason it should pass to V8, which is logged in UMA. I have also opportunistically updated other users of ScriptSourceCode that don't necessarily use script tags. We may want to track these individually in the future. Bug: chromium:769203 Change-Id: I24f1e7a5b235246e7d4e2b4753b8aec112239832 Reviewed-on: https://chromium-review.googlesource.com/771793Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#517439}
-
Alexei Svitkine authored
Note: Since the last time you were in OWNERS for histograms.xml, we've refactored our OWNERS files and have a central file in base/metrics. So this gives you OWNERS over a lot more files than just histograms.xml - please defer to other OWNERS if reviews come in for code you're not familiar with. And please review the docs we have at: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md For best practices for histograms that you should hold up during review. Thanks! BUG=none Change-Id: I05441f908958b3312b54c4b1420834f57c8209ef Reviewed-on: https://chromium-review.googlesource.com/776281Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#517438}
-
tanvir.rizvi authored
ReplaceSelectionCommand crashes if InsertHTML content have trailing non visible content. This happens as the nextAncesstorSibling comes as null This CL does the safety check to prevent the crash observed in this scenario. Bug: 781282 Change-Id: Ibb886956dafcdfaadac4dd2ee6b6c1ef70ad8340 Reviewed-on: https://chromium-review.googlesource.com/768550 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517437}
-
danakj authored
This eliminates one set of TextureMailbox uses, toward getting rid of the class, which overlaps with TransferableResource and forces extra plumbing and knowledge of types. We can remove the Android-specific fields from TextureMailbox with this, as they were only used for video, and can now go directly to TransferableResource instead of requiring extra plumbing through TextureMailbox. R=piman@chromium.org Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I227b16a2073a0b7d27f082d1d650dbb6016246d5 Reviewed-on: https://chromium-review.googlesource.com/773062 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517436}
-
Ria Jiang authored
Bug: none Change-Id: I726fa1f76e21b6c1a75cb19100eaa3ad19c26c91 Reviewed-on: https://chromium-review.googlesource.com/775817Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Louis Romero authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifc43afb495541b7ed62e9d001d331469d3156caa Reviewed-on: https://chromium-review.googlesource.com/776694Reviewed-by:
-
Michael Thiessen authored
lolk Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8341d0c701f46a50f92bf5c6fb1682ab136c0b72 TBR=ymalik@chromium.org Change-Id: I8341d0c701f46a50f92bf5c6fb1682ab136c0b72 Reviewed-on: https://chromium-review.googlesource.com/776156Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#517433}
-
Dirk Pranke authored
This reverts commit 85f6ac62. Reason for revert: It looks like this breaks a clean checkout; see crbug.com/786356 and https://ci.chromium.org/buildbot/chromium.chromiumos/chromeos-amd64-generic-rel/1519 (and the next build, which is I think a clobber build). Original change's description: > Roll src/third_party/chromite/ ef632e4a4..aed007c17 (60 commits) > > https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef632e4a473b..aed007c17605 > > $ git log ef632e4a4..aed007c17 --date=short --no-merges --format='%ad %ae %s' > 2017-11-13 cywang auto_updater: Apply cold reboot for AU > 2017-11-15 dgarrett cros tryjob: Fix submission of unknown build configs. > 2017-11-15 dgarrett cros_tryjob: Add go link to -tryjob error messages. > 2017-11-16 phobbs Revert "gob_util: Support Appengine Gerrit credentials." > 2017-11-14 dgarrett branch-util: Fix branch-util-tryjob for testing. > 2017-11-15 shapiroc Fix issue with model specific au fanout > 2017-11-07 aelder deploy_chrome: Add --private_key option > 2017-11-09 phobbs locking: Fix errno.EDEADLK reference. > 2017-11-15 cmtice Revert "generic_stages: temporarily ignore all target prebuilts." > 2017-11-15 chrome-bot Update config settings by config-updater. > 2017-11-15 hiroh TestSimpleChromeWorkflowStage: Pass --nogn-gen to cros chrome-sdk > 2017-11-09 phobbs gob_util: Support Appengine Gerrit credentials. > 2017-11-08 achuith [cros_vm]: Use virtio instead of cirrus. > 2017-11-14 cmtice generic_stages: temporarily ignore all target prebuilts. > 2017-11-13 shapiroc Configure coral for chrome/android pfq and paladin > 2017-09-13 vapier cros tryjob: restore metavar > 2017-11-14 stevenjb TestSimpleChromeWorkflowStage: Pass --nogngen to cros chrome-sdk > 2017-11-14 chrome-bot Update config settings by config-updater. > 2017-11-13 xixuan cros-update: use curl instead of wget to check devserver health. > 2017-11-13 chrome-bot Update config settings by config-updater. > 2017-09-29 stevenjb cros_chrome_sdk: Automatically generate args.gn files > 2017-11-11 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." > 2016-07-20 sjg commands: Use cros_config_host instead of fdtget > 2017-11-08 dgarrett cbuildbot: Enforce tryjob safe configs. > 2017-11-01 dgarrett cros tryjob: Enforce tryjob safe configs. > 2017-11-07 manojgupta generic_stages: temporarily ignore all target prebuilts. > 2017-11-09 akeshet summarize_build_stats: link to new cq-weekly dashboard > 2017-11-09 akeshet summarize_build_stats: drop the "Top reasons" table > 2017-11-09 akeshet summarize_build_stats: add a category picker to the top X lists > 2017-11-10 chrome-bot Update config settings by config-updater. > 2017-11-09 dgarrett chromeos_config: Remove tryjob config overrides. > 2017-11-01 dgarrett cros tryjob: Update --list for production vs tryjob. > 2017-11-07 vapier image_test: move security_CroshModules autotest here > 2017-11-08 derat chromite: Make TastVMTestStage unforgiving. > 2017-11-06 nxia Get current builders_array from metadata. > 2017-11-09 stevenjb chrome_chromeos_lkgm: Add --email to 'git cl upload' > 2017-11-08 derat chromite: Run ARC Tast VM tests on betty-release. > 2017-11-08 ayatane Fix typo > 2017-11-06 ayatane Exclude provision suite from subsystems > 2017-08-21 smbarber chromeos_config: Add tatl-full builder on external waterfall > 2017-11-08 lhchavez Remove support for aosp_bertha* Android targets > 2017-11-08 stevenjb chrome_chromeos_lkgm: Remove any existing chrome checkout > 2017-11-08 chrome-bot Update config settings by config-updater. > 2017-09-28 nxia chromite changes for Cros_CL_Status_Viewer > 2017-11-06 phobbs cidb: Changes for cl_exonerator > 2017-11-07 dgarrett chromeos_config: Update generated files together. > 2017-11-07 achuith [cros_vm]: Better error messages for qemu. > 2017-11-03 pprabhu cidb_integration_test: Wait longer for mysqld to initialize. > 2017-11-08 chrome-bot Update config settings by config-updater. > 2017-10-20 dgarrett chromeos_config: Create mirrored tryjob build configs. > 2017-11-07 stevenjb cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) > 2017-11-06 akeshet pre-cq: mark failed-to-apply changes as pre-cq-failed so they don't loop > 2017-10-27 davidriley Reland "cbuildbot: Emit partition files for provisioning purposes." > 2017-11-06 derat chromite: Ensure TastVMTest runs after VMTest failure. > 2017-11-06 pprabhu cq_stats: deploy the correct cidb credentials. > 2017-11-06 pprabhu Update cidb settings for gen2 SQL instances. > 2017-11-06 pprabhu Hack fake_modules some more to allow chromite import. > 2017-10-31 dgarrett cros_uprevchrome: Tweak tempdir creation. > 2017-11-06 dgarrett cros_tryjob: Add --chrome_version passthrough option. > 2017-11-03 llozano chromite: cleanup board lists for llvm-toolchain configs. > > Created with: > roll-dep src/third_party/chromite > > Bug: 762650 > Change-Id: Ib17a3570e32c98bae423d88c6320a5be95a26fef > Reviewed-on: https://chromium-review.googlesource.com/775023 > Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517193} TBR=stevenjb@chromium.org,alemate@chromium.org,xiaoyinh@chromium.org Change-Id: I2c2079179b5aa59820bc2c58bc2ab21b96f63342 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762650 Reviewed-on: https://chromium-review.googlesource.com/777059Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517432}
-
Gauthier Ambard authored
The OmniboxFocuser protocol is used through the app (e.g. in NTP). The ToolbarCoordinator needs to implement it to be passed as a protocol to those objects. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29e531dfee92596ec6e1f3b926a142306c64a037 Reviewed-on: https://chromium-review.googlesource.com/771891 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Change-Id: Ie5be4c9508d63fb0a58180942bdee3a8cbb3ef2b Reviewed-on: https://chromium-review.googlesource.com/776878Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#517430}
-
Kristian H. Kristensen authored
Allow primary planes to not have to be the size of the mode. This lets us configure a primary plane that's smaller than the current mode, which will be useful for the underlay strategy. This commit also adds a new option to ozone_demo to test the partial primary plane functionality. BUG=772239 TEST=ozone_demo --enable-drm-atomic --partial-primary-plane works on KBL or RK3399 boards showing red/blue pulsing square; ozone_demo --disable-drm-atomic --partial-primary-plane shows black screen but doesn't exit or crash. Bug: Change-Id: Ie77b02848efca717dee465783c692333d2e6c988 Reviewed-on: https://chromium-review.googlesource.com/666000Reviewed-by:Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517429}
-
Gauthier Ambard authored
Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia01f0d2e9e4a32607c0bd0c18228564110585909 Reviewed-on: https://chromium-review.googlesource.com/776881Reviewed-by:
-
Martin Sramek authored
After https://chromium-review.googlesource.com/771890, the functionality tested by this fuzzer depends on base::CommandLine. This was not initialized in the fuzzer, making it crash. Bug: 786023 Change-Id: I1c599e3231d5236b6ffb59e20373c2243ee0d026 Reviewed-on: https://chromium-review.googlesource.com/776874Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517427}
-
Guido Urdaneta authored
This reverts commit 0326c088. Reason for revert: Suspect of causing virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-request-fallback.https.html to fail on several Mac and Linux bots. See for example https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/7923 Original change's description: > Plumb extra errors from ResourceRequestCompletionStatus to Blink > > This patch plumbs CORSError and HTTP response headers > from ResourceRequestCompletinoStatus to Blink's ResourceError. > > Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors > Bug: 736308 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345 > Reviewed-on: https://chromium-review.googlesource.com/749024 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517388} TBR=kinuko@chromium.org,toyoshim@chromium.org,tyoshino@chromium.org,yhirano@chromium.org,mkwst@chromium.org Change-Id: Ib973ef76eaab93e4c4dbf9b08712bbd560eac368 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/776913Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#517426}
-
Julia Tuttle authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7038de9351cd34c22a23a0e60694e7330e1ab66 Reviewed-on: https://chromium-review.googlesource.com/766730Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#517425}
-
Eugene But authored
This CL implements DownloadTask public interface. DownloadControllerImpl CL: crrev.com/c/758525 Design doc: http://go/ios-web-download-api Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iffea44bfb64cc945f7d899dd7181556a730394f1 Reviewed-on: https://chromium-review.googlesource.com/775889Reviewed-by:
-
Will Harris authored
These are obtained from the reverse of WTERMSIG macro - e.g. WTERMSIG(132) is 4 which is SIGILL defined in sys/signal.h BUG=None Change-Id: Ifbfb9895354ca511f2787d21feb4b33e415fd8ec Reviewed-on: https://chromium-review.googlesource.com/773778Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517423}
-
Colin Blundell authored
Several DEPS entries were allowing dependencies on the internals of a service. This CL tightens those DEPS down. Note that a couple are left: this is intentional, as in those cases the services in question are actually being embedded in the dependent. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e91f08559399997059c4c81dd7857e19c776175 Reviewed-on: https://chromium-review.googlesource.com/776695Reviewed-by:
-
