GitLab

Set up an experiment to see the impact of always using the fast exit
path. For context, see https://groups.google.com/a/chromium.org/d/topic/chromium-dev/AMB2Y7Sqj48/discussion

Testing: launch with --enable-features=DesktopFastShutdown

BUG=653647

Review-Url: https://codereview.chromium.org/2528173003
Cr-Commit-Position: refs/heads/master@{#436328}

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090

Review-Url: https://codereview.chromium.org/2532953002
Cr-Commit-Position: refs/heads/master@{#436327}

- This makes the tests more integration-test-like.
- This is a step towards merging ManifestUpgradeDetectorTest and
  WebApkUpdateManagerTest (See https://codereview.chromium.org/2460253002/)

BUG=639536

Review-Url: https://codereview.chromium.org/2543073005
Cr-Commit-Position: refs/heads/master@{#436326}

https://skia.googlesource.com/skia.git/+log/b048e81c5c27..55360b11c7da

$ git log b048e81c5..55360b11c --date=short --no-merges --format='%ad %ae %s'
2016-12-05 robertphillips Revert "Remove use of makeDeferredRenderTargetContextWithFallback"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2546403002
Cr-Commit-Position: refs/heads/master@{#436325}

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096

Review-Url: https://codereview.chromium.org/2547563002
Cr-Commit-Position: refs/heads/master@{#436324}

Noticed this function was hot on blink_perf.paint's color-changes.html
microbenchmark. With this patch, color-changes.html runs 2.7% faster
(average -0.8ms) but that number should be taken with a grain of salt
since it's near the standard deviation of the test.

Manual profiling with and without the patch confirmed this function is
no longer hot.

Review-Url: https://codereview.chromium.org/2550083002
Cr-Commit-Position: refs/heads/master@{#436323}

BUG=659601

TBR=msw@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2548383002
Cr-Commit-Position: refs/heads/master@{#436322}

This is using addtrack, removetrack and change events on the TextTrackList exposed
on the media element to be notified and update the closed captions button. Because
the events are asynchronous, some tests have to be modified to be asynchronous.
They have been moved to media/controls/ too.

There is one hook that was added in order to notify the controls that an
HTMLTrackElement failed to load. There is no clear way to figure that out otherwise.
An HTML issue has been opened: https://github.com/whatwg/html/issues/2121

BUG=662761

Review-Url: https://codereview.chromium.org/2539023002
Cr-Commit-Position: refs/heads/master@{#436321}

Also remove test-specific code path and other minor cleanups.

This CL is preparatory for the new spec-compliant MediaStream constraint processing.

BUG=657733

Review-Url: https://codereview.chromium.org/2550493003
Cr-Commit-Position: refs/heads/master@{#436320}

The DownloadImage method in WebState was implemented in Tab.
This CL moves the implementation to WebStateImpl.

BUG=664988

Review-Url: https://codereview.chromium.org/2528043002
Cr-Commit-Position: refs/heads/master@{#436319}

https://pdfium.googlesource.com/pdfium.git/+log/4bed2af0c049..f6ee820732b8

$ git log 4bed2af0c..f6ee82073 --date=short --no-merges --format='%ad %ae %s'
2016-12-05 jbudorick [android] Make pdfium_unittests work on Android.
2016-12-05 caryclark enable skia gradients, fix bugs

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2549143002
Cr-Commit-Position: refs/heads/master@{#436318}

AutoscrollForSelection is to help users select content outside the current
viewport. However, the current implementation starts the autoscroll whenever
the mouse-drag event reaches the edge of the viewport, regardless of whether
the user is selecting or not. It makes no sense to start the autoscroll when
the element was not selectable at all. This patch allows the
AutoscrollForSelection fire only when the mouse is dragged across a selectable
element.

BUG=588448

Review-Url: https://codereview.chromium.org/2536083002
Cr-Commit-Position: refs/heads/master@{#436317}

BUG=668223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2529713002
Cr-Commit-Position: refs/heads/master@{#436316}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e01db2c9..e9c2d951

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2548353002
Cr-Commit-Position: refs/heads/master@{#436315}

BUG=none

Review-Url: https://codereview.chromium.org/2554453002
Cr-Commit-Position: refs/heads/master@{#436314}

Updates ios DEPS files to mirror the desktop DEPS files.  For example, the rules
in ios/DEPS roughly resemble the rules in DEPS, and the rules in ios/chrome/DEPS
roughly resemble the rules in chrome/DEPS.

Also adds some new rules to accomodate iOS code that will be landing in the near
future.

BUG=665969

Review-Url: https://codereview.chromium.org/2541083002
Cr-Commit-Position: refs/heads/master@{#436313}

The CSS @import scanner attaches a passive resource client to a css
preload request. This passive client should not affect the policy
decisions of the preload and should just observe notifications passively.

This patch fixes a bug where removing a passive client from an otherwise
unused preload ends up cancelling it, which removes the preload from
memory cache. This is very wrong behavior, and causes the optimization
to be less effective, and report bad metrics.

Simply not removing the client will not cause the resource to live
longer than necessary, because the client holds only weak references
to the resource.

BUG=670295,662999

Review-Url: https://codereview.chromium.org/2542183002
Cr-Commit-Position: refs/heads/master@{#436312}

If using shared memory, stores base::Features in the field trial
allocator (under a different type defined in FeatureList) when
spawning the first new process. When a child process is created,
it will first try to get initialized from shared memory. If that
doesn't work, it'll fallback to the command line.

BUG=661224

Review-Url: https://codereview.chromium.org/2546653002
Cr-Commit-Position: refs/heads/master@{#436311}

Revert of [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrate commi… (patchset #2 id:20001 of https://codereview.chromium.org/2533453002/ )

Reason for revert:
The .cc is nowhere to be found.

Original issue's description:
> [ObjC ARC] Converts ios/public/consumer/base:base to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799
> Cr-Commit-Position: refs/heads/master@{#436281}

TBR=sdefresne@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2548313003
Cr-Commit-Position: refs/heads/master@{#436310}

BUG=514752

Review-Url: https://codereview.chromium.org/2544883006
Cr-Commit-Position: refs/heads/master@{#436309}

BUG=662903

Review-Url: https://codereview.chromium.org/2546413002
Cr-Commit-Position: refs/heads/master@{#436308}

BUG=667837

Review-Url: https://codereview.chromium.org/2547063002
Cr-Commit-Position: refs/heads/master@{#436307}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2514843002
Cr-Commit-Position: refs/heads/master@{#436306}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516643002
Cr-Commit-Position: refs/heads/master@{#436305}

While we're here, also sort the file alphabetically.

Review-Url: https://codereview.chromium.org/2550153002
Cr-Commit-Position: refs/heads/master@{#436304}

ScopedBlockSwizzler is a helper class that swizzles methods for use in unittests
only.  It is most commonly used to inject test objects to replace shared
singletons.

BUG=662903

Review-Url: https://codereview.chromium.org/2551083002
Cr-Commit-Position: refs/heads/master@{#436303}

This lets us see what request sizes look like over time and the percentage of bytes that come from the cache as opposed to the network.

BUG=669080

Review-Url: https://codereview.chromium.org/2548613003
Cr-Commit-Position: refs/heads/master@{#436302}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2512553006
Cr-Commit-Position: refs/heads/master@{#436301}

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980

Review-Url: https://codereview.chromium.org/2551913002
Cr-Commit-Position: refs/heads/master@{#436300}

The directory no longer exists.

BUG=none

Review-Url: https://codereview.chromium.org/2541893002
Cr-Commit-Position: refs/heads/master@{#436299}

The DOMTimer's ScheduledAction hold on to the script source and
state needed to execute the timer action. Let go of ShceduledAction's
resource early.

Apart from reducing the lifetime of script source, this is a speculative
fix for crashes reported in v8::PersistentValueVector::Clear() during
lazy sweeping of ScheduledAction objects.

R=
BUG=

Review-Url: https://codereview.chromium.org/2552673002
Cr-Commit-Position: refs/heads/master@{#436298}

This CL cleans up the API in bookmark_last_visit_utils.h to use const&
instead of const* where appropriate.

BUG=652740

Review-Url: https://codereview.chromium.org/2518033002
Cr-Commit-Position: refs/heads/master@{#436297}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2505933009
Cr-Commit-Position: refs/heads/master@{#436296}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2516663002
Cr-Commit-Position: refs/heads/master@{#436295}

BUG=628942,631151
R=dominicc@chromium.org

Review-Url: https://codereview.chromium.org/2190523002
Cr-Commit-Position: refs/heads/master@{#436294}

BUG=669589

Review-Url: https://codereview.chromium.org/2546063003
Cr-Commit-Position: refs/heads/master@{#436293}

BUG=none
TEST=none
R=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2546253002
Cr-Commit-Position: refs/heads/master@{#436292}

Display content settings and zoomlevel for extensions with extension name instead of showing a cryptic id.
If an extension has a favicon, it is shown as well.

https://screenshot.googleplex.com/7rMF5f26CmW
https://screenshot.googleplex.com/9TbvP1zDYWJ

BUG=412740
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2525943002
Cr-Commit-Position: refs/heads/master@{#436291}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f295aa2a..e01db2c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2549123002
Cr-Commit-Position: refs/heads/master@{#436290}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2514813002
Cr-Commit-Position: refs/heads/master@{#436289}