GitLab

This is in preparation for using {{patterns}} in toolchain definitions. It makes them
more generic and usable for this, without actually implementing any new features or
changing behavior. The only external change should be that the $in variable is used for
actions instead of making a redundant new variable (used to be called $source).

It removes the FileTemplate class and explodes it into several files: the type list and
helpers (substitution_type), a single pattern (substitution_pattern), a list of patterns
(substitution_list), and a class of helper functions for processing templates in various
ways (substitution_writer).

Previously, the things needing substitutions (args, outputs, depfile) were stored as
strings and parsed in to FileTemplates as needed. This new method stores the
SubstitutionList/Pattern directly on the target. This allows it to issue parse errors
(previously such errors were ignored since errors weren't reportable when writing Ninja
files) and cleans up a lot of the code that uses it.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/429423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287847 0039d316-1c4b-4281-b951-d872f2087c98

This patch ensures that we heapify pointers instead of objects in
priority queue eviction.

Performance data:
Before:
tile_manager_eviction_tile_queue_construct:
2= 411875.46875 runs/s
10= 8762.1435546875 runs/s
50= 48.008880615234375 runs/s

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3337.1767578125 runs/s
2_32= 3041.9306640625 runs/s
2_64= 2513.700439453125 runs/s
2_128= 1940.756591796875 runs/s

After:
tile_manager_eviction_tile_queue_construct:
2= 391767.84375 runs/s (-5%)
10= 8705.869140625 runs/s (-2%)
50= 49.93892288208008 runs/s (+4%)

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3691.25146484375 runs/s (+10%)
2_32= 3666.619384765625 runs/s (+20%)
2_64= 3544.351318359375 runs/s (+41%)
2_128= 3341.751708984375 runs/s (+72%)

R=reveman

Review URL: https://codereview.chromium.org/430053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287846 0039d316-1c4b-4281-b951-d872f2087c98

An unhandled context menu may result in the showing of the paste popup. However,
this paste popup notification is not well-ordered with respect to other
notifications that determine insertion handle state, namely, position and
region editability updates. Consequently, the paste popup may be shown without
a corresponding insertion handle. Resolve this by forcing an editability and
position update when the paste popup notification is received.

BUG=400304,400330,396997

Review URL: https://codereview.chromium.org/447493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287845 0039d316-1c4b-4281-b951-d872f2087c98

The tests are part of https://codereview.chromium.org/406713002/

BUG=None
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/444743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287844 0039d316-1c4b-4281-b951-d872f2087c98

Mock at https://docs.google.com/a/google.com/presentation/d/1GUagduYmawbUHiWwhQdtyxCUFugv2BPPCH0eHhIWGO8/edit#slide=id.g354ad708b_00

BUG=401147

Review URL: https://codereview.chromium.org/435423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287843 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the binary assets for https://codereview.chromium.org/438513002/
This will allow trybots to run and the commit queue to actually pass :)

R=xiyuan@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/444773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287842 0039d316-1c4b-4281-b951-d872f2087c98

- LLVM now uses C++11, so need to use LLVM_OVERRIDE anymore.
- Small changes in Clang interfaces for flags and FrontendFactory
  instantiation.
- clang-format-diff.py works slightly differently now, so update the
  run_tool.py wrapper to invoke it correctly.
- Delete tools that are no longer needed.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/448693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401092

Review URL: https://codereview.chromium.org/449523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287840 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400484
R=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/442423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287838 0039d316-1c4b-4281-b951-d872f2087c98

This behavior is similar to not having a native event on the non-Ozone path.

Synthesized events were processed after the ScreenPositionClient was removed
from the window. Trying to convert the cursor point to screen coordinates would
trigger a CHECK in ash::wm::ConvertPointToScreen since these synthesized events
would be processed as the WindowTreeHost was shutdown.

BUG=398888
NOTRY=true

Review URL: https://codereview.chromium.org/442033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287837 0039d316-1c4b-4281-b951-d872f2087c98

R=dbeam@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/442133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400474

Review URL: https://codereview.chromium.org/441613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399735

Review URL: https://codereview.chromium.org/443973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287833 0039d316-1c4b-4281-b951-d872f2087c98

Adding the OnSendAcknowledgement event to enable Chrome components to
get updates on GCM server receiving the messages.

BUG=374969
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/442123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287831 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287830 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/41ebbddd76b747d5fb32c02dda0de3d03a3edda5..be21e3432e4cf925fe494efe23edcb457bd05fcb

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/445073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287829 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an oversight from https://codereview.chromium.org/307483002.

"Before" screenshot: https://drive.google.com/a/google.com/file/d/0BxTU2YPRG-lRNl9FRy1KQ2c2dEU/view?usp=sharing
Mock: https://folio.googleplex.com/chrome-ux/mocks/064-chrome-away-from-chrome/supervised-users/mirror#%2FPlaypen_210514_mirror-11.png

BUG=310640

Review URL: https://codereview.chromium.org/443033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287828 0039d316-1c4b-4281-b951-d872f2087c98

build/android/pylib: telemetry
build/get_landmines.py: needs to force build

BUG=399774,399710
TEST=none
R=tonyg@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/444073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287827 0039d316-1c4b-4281-b951-d872f2087c98

Added a histogram "Network.Shill.DeviceConnectionStatus" for tracking the
connection status of the device. A sample is emitted once every 3
minutes.

Added a histogram "Network.Shill.Wifi.NetworkProblemDetected" for tracking
the connection problem encountered by TrafficMonitor after the wifi
connection is established. This event is reported whenever a network
problem is encountered while connected to a  wifi network.

Added a histogram "NetworkShill.WiFi.UserInitiatedConnectionFailureReason"
for tracking the reasons for failed wifi connection attempts that are
manually initiated by the user. This event is reported everytime
user-initiated wifi connection attempts failed.

BUG=chromium:374274, chromium:392965, chromium:392990
TEST=Start chrome, and browse to chrome://histograms to verify the
histograms mentioned above exist.
NOTRY=true

Review URL: https://codereview.chromium.org/429353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287826 0039d316-1c4b-4281-b951-d872f2087c98

This only affects OSX. Recently, Chrome stopped prompting users for access to
the keychain to autofill passwords (to pull in passwords from other browsers).
Opera wants to use a different policy, so pull the logic into
password_manager_client.

BUG=178358

Review URL: https://codereview.chromium.org/444753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287825 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Disabled test incorrectly.

Original issue's description:
> Disable failing test
> 
> BUG=401169
> TBR=dfalcantara
> NOTRY=TRUE
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287818

TBR=dfalcantara@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401169

Review URL: https://codereview.chromium.org/447873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393235

Review URL: https://codereview.chromium.org/447793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287732

Review URL: https://codereview.chromium.org/427883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401169
TBR=dfalcantara
NOTRY=TRUE

Review URL: https://codereview.chromium.org/445093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/443183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366825

Review URL: https://codereview.chromium.org/449483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400930

Review URL: https://codereview.chromium.org/442863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287814 0039d316-1c4b-4281-b951-d872f2087c98

AudioManagerAndroid will NPE on hardware platforms that don't
have bluetooth.

BUG=401039

Review URL: https://codereview.chromium.org/449463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399964
NOTRY=true

Review URL: https://codereview.chromium.org/435313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287812 0039d316-1c4b-4281-b951-d872f2087c98

No point in keeping memory around for a frame we don't care about.

BUG=399071,399420

Review URL: https://codereview.chromium.org/433903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399370

Review URL: https://codereview.chromium.org/433603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287809 0039d316-1c4b-4281-b951-d872f2087c98

Includes new shader translator inspection API.

BUG=351396

Review URL: https://codereview.chromium.org/445673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287808 0039d316-1c4b-4281-b951-d872f2087c98

Tested interactively and adds unit test.  Seems to behave as expected.

BUG=47572

Review URL: https://codereview.chromium.org/440753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287807 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the PrefHashBrowserTestBase fixture which these tests are based on.

This fixture (in conjunction with the new PREF_HASH_BROWSER_TEST macro) provides an easy way to override 3 methods in order to:
 1) Setup Chrome as desired in a PRE_ test.
 2) Attack Preferences while Chrome isn't running.
 3) Relaunch Chrome and verify reaction to attacks.

The fixture+macro also parametrizes every test such that they are ran in every SettingsEnforcement trial group.

A few pieces were resurrected from the old PrefHashBrowserTest used to test unloaded profile seeding prior to http://crrev.com/277209

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287689

Review URL: https://codereview.chromium.org/431973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287805 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the right-side table-of-contents on the documentation page, so it is
collapsible and only shows h2 headings by default.

NOTRY because it is a documentation-only change.

BUG=374811
R=sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/438403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287804 0039d316-1c4b-4281-b951-d872f2087c98

It's decided that it's unnecessary to ask user to confirm profile deletion if he chooses to remove other
data while disconnecting sync because the confirmation dialog can get lost sometimes and user's data is left behind.

BUG=395441
NOTRY=true

Review URL: https://codereview.chromium.org/426123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287802 0039d316-1c4b-4281-b951-d872f2087c98

A11y options list and remove supervised user menu are moved up in case of shelf-overlapping. Network list gets scrollbar in that case.

Also remove supervised user button aligned.

BUG=382851

Review URL: https://codereview.chromium.org/399613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287801 0039d316-1c4b-4281-b951-d872f2087c98

This is to prepare for on-demand backup where backup manger needs to persist
backup data if the shutdown is due to switching to syncing. No behavior changes are introduced by this cl.

BUG=362679
NOTRY=true

Review URL: https://codereview.chromium.org/437683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287799 0039d316-1c4b-4281-b951-d872f2087c98