- 04 Oct, 2019 40 commits
-
-
Tim van der Lippe authored
- InspectorBackendCommands is now loaded via ES Modules Bug: 1006759 Change-Id: I2826518a55e1f4fd7704cfb04120885f9aa9b604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837772Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#702821}
-
Rohit Agarwal authored
This reverts commit 3fcc018a. Reason for revert: The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1839793 is getting reverted, so we need to remove these tests. The tests will be added again, once after the revert is made and the necessary changes are done to address the issue mentioned in the revert reason. Original change's description: > Add regression tests. > > Bug: 1004101 > Change-Id: I8c8d12cc4faa60b6ead3abf2ed7ca8572fbca6f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803921 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Florian Uunk <feuunk@chromium.org> > Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699901} TBR=vasilii@chromium.org,feuunk@chromium.org,roagarwal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004101 Change-Id: I5391451791b9455652154f7eb7cfea5232f14747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839794Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#702820}
-
David Jean authored
Added disabling of animation when battery level is below 20%. This is behind a flag that is false by default. It will be enabled to 1% in next release to gather information. Some animations not controlled by [UIView setAnimationsEnabled:] are not handled for now. Also some components imported from google3 do not respect or restore the current animationsEnabled status: MaterialOverlay, MaterialSnackbar: force animations enabled but restore previous value. NISnapshotRotation: is worse because it will leave it back to enabled after doing an animation (not sure where we use it?) Bug: 1006431 Change-Id: Ib2f32598575c0e63b579a2388dad914945714add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821917Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#702819}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: Ie177cdbcc6b2d7a1ee94e7d2ed51986adcfeb0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837731Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#702818}
-
Maksim Moskvitin authored
The new test checks that client successfully processes remote updates with keystore Nigori node, that contains only keystore key in keybag, and decrypts the password, that was encrypted with this keystore key. In order to support such kind of integration tests, this CL adds helper function for injecting passwords to fake server. Bug: 922900 Change-Id: If0cb06ae980ec995498a6154acf7db3f48e67303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658388 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702817}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b5c3cdb7611..c4c5d7998d6e git log 6b5c3cdb7611..c4c5d7998d6e --date=short --no-merges --format='%ad %ae %s' 2019-10-04 hidehiko@chromium.org chromite: sync_chrome on Android PFQ. 2019-10-04 hidehiko@chromium.org chromite: Split TastVMTest canary suite into two. 2019-10-04 vapier@chromium.org patch: rework PatchException message handling Created with: gclient setdep -r src/third_party/chromite@c4c5d7998d6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I562fc8b038f63826619e3338fb670adc18e620a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702816}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/813c3d43c4bd..56b86259997a git log 813c3d43c4bd..56b86259997a --date=short --no-merges --format='%ad %ae %s' 2019-10-04 crouleau@chromium.org [Telemetry] Fix usage string for run_benchmark list. Created with: gclient setdep -r src/third_party/catapult@56b86259997a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:985103 Change-Id: I432ca22119c62bb62c439fdfd8590bef5d2edc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840111Reviewed-by:
-
Mikel Astiz authored
Follow-up patch to update name occurrences in tests after https://chromium-review.googlesource.com/c/chromium/src/+/1835351 renamed IsPassphraseRequiredForDecryption(). Bug: 1010189 Change-Id: Id8ae87579c935724deacda0d4d4faff6a9769452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840234Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702814}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d897a1016473..97565d8a9687 git log d897a1016473..97565d8a9687 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 matthew.clarkson@arm.com build: fix cross-compilation Created with: gclient setdep -r src/third_party/perfetto@97565d8a9687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ieb3d30bc591b36b1590529156b6687a4dc8d480e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840251Reviewed-by:
-
Ioana Pandele authored
TBR=thakis@chromium.org Bug: 1010930 Change-Id: I1ab24ddf5c4c68db4d0d7b390a3268507687bfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838195Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Maya Lekova authored
This adds more histograms for TurboFan optimization, on top of https://chromium-review.googlesource.com/c/chromium/src/+/1549060/ (split by concurrent vs non-concurrent optimizations). UMA metrics CL in v8: https://chromium.googlesource.com/v8/v8/+/848e1b9a1979ab7d319363fe28f5773009511705 Bug: v8:7790, v8:9074 Change-Id: Ifa1988d9b02e7f621481991aca08258769baceeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605984 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702811}
-
Rayan Kanso authored
- Expose the `address` property and place it behind a flag. - Add & implement the getProperties method. Change-Id: If9bbebde6b8d076fd48b0b8a3584181e40adc1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835621Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#702810}
-
Alex Chau authored
Bug: 1010968 Change-Id: I700ac292ef3ceb5ed5849edb943a3a9459adf275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836417 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702809}
-
Koji Ishii authored
r701601 (crrev.com/c/1826063) removed the last use of the field, but it did not remove the code to set it up. This patch removes the never-used field. Change-Id: I291bafccbb0c827213e3b4c890d7589ec5dd3fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838806Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702808}
-
Elly Fong-Jones authored
This announcement tells the user to use Shift-F6 to navigate to the downloads bar, which doesn't work on Mac. It also contained a typo (a stray '>') and a typo in its descriptive text, both of which are fixed here. Bug: 940697 Change-Id: I297d92f1fbb34760e895865cfad5162b8e4aaa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830062 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#702807}
-
Christoph Schwering authored
Bug: 1009364 Change-Id: Icbd6f625d668362475728f7facc66c7f5d132f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836191 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#702806}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6cbe67cb75a..84f61e2273d6 Created with: gclient setdep -r src-internal@84f61e2273d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1006216 Change-Id: I8ee5c284a8ab5e3b60198b5ee2f2d02351c0d741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840112Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702805}
-
Juan Antonio Navarro Perez authored
These are no longer in use after the completed migrations for jetstream, octane, and jetstream2. See attached bug for details. Bug: 1003530 Change-Id: I84ff73186b299aa7b6be3bb57abca392656a4c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835504Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#702804}
-
Erik Chen authored
The const version of this method is never used. This CL removes it. Bug: 912193 Change-Id: I973025692c7598824f0e3b0375191fc534cd42bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832766 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702803}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ec261d9d..31be647e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I95e55c6c1694d060cc57987cce4feff5a0ece4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839872Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702802}
-
Arthur Hemery authored
Filtering current failures on the android-bfcache-debug fyi bot. Bug: 1007276 Change-Id: I291f5aba1b1520661a6b59e87e86a812d3df64b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840094Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#702801}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/44b32176ee48..8fa0f1a6567c git log 44b32176ee48..8fa0f1a6567c --date=short --no-merges --format='%ad %ae %s' 2019-10-03 afdx@google.com spirv-fuzz: option to convert shader into a form that renders red (#2934) 2019-10-03 32110296+AaronHaganAMD@users.noreply.github.com Add SPV_KHR_shader_clock validation (#2879) 2019-10-03 paulthomson@users.noreply.github.com reduce/fuzz: improve command line args (#2932) 2019-10-03 alanbaker@google.com Validate physical storage buffer restrictions (#2930) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@8fa0f1a6567c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Bug: None Change-Id: Ib979631a70f7faf4cd75888b5bbfa99b70560f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838985Reviewed-by:
-
Mikhail Khokhlov authored
Bug: 1010041 Change-Id: I8aaee5a7ed7aafee3ef72a5fbdf56e63cfdd3d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835508 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbdf48ecb204..95edac1c9a4a git log fbdf48ecb204..95edac1c9a4a --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@95edac1c9a4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ia1061a3f576993edf80164a22d2ebffb54e6d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839517Reviewed-by:
-
Dominic Battré authored
Revert "Disable flaky ActivationStateComputingThrottleSubFrameTest.Whitelisted_DisablesGenericRules/*" This reverts commit 1f02a2f6. Reason for revert: Test is not the root cause, see crbug.com/1011275 Original change's description: > Disable flaky ActivationStateComputingThrottleSubFrameTest.Whitelisted_DisablesGenericRules/* > > TBR=battre@chromium.org > > Bug: 1010186 > Change-Id: I9d56d9225fbfe6069476878c4d531d1d43371515 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837316 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702310} TBR=battre@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010186 Change-Id: Ia3e479f104b34bdbdb657e3450b68f69c771fd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840172Reviewed-by:
-
Maksim Sisov authored
To avoid translating locations of mouse events back to px from dip, start using the WindowEventFilterLinux as a post handler outside the event dispatching mechanism. That is, Linux X11/Wayland sends events in px coordinates, but the event dispatching translates them to dip. This results in unnecessary translation of pointer locations back to px. Bug: 990756, 1004674 Change-Id: If14a542375b8bdb9f134e2857d3c793b15600593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835352 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702796}
-
Mathias Bynens authored
We've gathered sufficient data, so the use counter can now be removed again. The use counter was originally added here: - V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/1718145 - Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1718367 BUG=v8:9551 Change-Id: I7f8ab0cd19000e9259686d4166eb2bb484270fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839851Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#702795}
-
Bret Sepulveda authored
This reverts commit 1eeaf38b. Reason for revert: Test is still flaky Original change's description: > Revert "sheriff: Disable BrowserNonClientFrameViewPopupTest.HitTestPopupTopChrome." > > This reverts commit e9e520a3. > > Reason for revert: Flakiness unlikely to be caused by the test itself. > > Original change's description: > > sheriff: Disable BrowserNonClientFrameViewPopupTest.HitTestPopupTopChrome. > > > > Flaky on Linux ASAN and TSAN. > > > > TBR=bsep > > > > Bug: 998946 > > Change-Id: Iead970e3ca6738c495a9b922c19f24294b9093e4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774006 > > Reviewed-by: Darren Shen <shend@chromium.org> > > Commit-Queue: Darren Shen <shend@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691478} > > TBR=shend@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 998946 > Change-Id: Id164a193c1182b71d002b66b4e8b328fddde7402 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835619 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702017} TBR=bsep@chromium.org,shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998946 Change-Id: Ib22b71a4d4fc6ddf74c0be5cd16eb8bd5896599a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840096Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#702794}
-
arthursonzogni authored
A small oversight with patch: https://chromium-review.googlesource.com/c/chromium/src/+/1786447 Only the main RenderFrameHost was checked it can enter the BackForwardCache. Instead, it should be applied to any document, including the nested ones. Change-Id: I5c23a8f321f0a8f27d2291d7e2ec0b99d4d76419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839951 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702793}
-
Maksim Sisov authored
Some platforms might not support that, but still would like to provide a default value. In case of Wayland, it depends on xdg decoration extension protocol, support for which will be added later. Bug: 990756 Change-Id: I550104522a729ae154711e4fb61b80b8878007ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834347Reviewed-by:
-
Edward Jung authored
intersitital dark mode Bug: 978002 Change-Id: Ib4ca7073536c241525636decec3227817795ee64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833604Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#702791}
-
Dominic Battré authored
This reverts commit dde9b262. Reason for revert: The test is not the root cause, see crbug.com/1011275 Original change's description: > Disable flaky SubframeNavigationFilteringThrottleTest.FilterOnRedirect > > TBR=battre@chromium.org > > Bug: 1010781 > Change-Id: Iba7c19d5c4cf12160128ac15e91d9042d0cd7bd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837439 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702325} TBR=battre@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010781 Change-Id: I40f87c3c316a07944c6fae169a1113465bd26fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840232Reviewed-by:
-
arthursonzogni authored
This makes the following statement to be true: - about:srcdoc should inherit |cookie_url| from its owner. - about:blank should inherit |cookie_url| from its owner (if any) Bug: 1003167, 1009963 Change-Id: Ie0d5d1310cf3a76f0466191528316a55a900332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829350Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#702789}
-
Yuta Kasai authored
- In the previous code, the expiration time was set to null so that remaining_timeout() was negative during initial script evaluation so that calling self.serviceWorker.postMessage() would fail. This CL sets max_request_expiration_time properly in ServiceWorkerVersion::StartWorkerInternal(). - Add and fix unittests about expiration time. - Fix the expected.txt properly. - In spec, service worker's initial state should be parsed. https://w3c.github.io/ServiceWorker/#service-worker-concept Link to the Chrome Platform Status: https://chromestatus.com/feature/6678900060979200 Bug: 977496 Change-Id: I4f8368e165fb84304b49519ed43d7b21d5ec756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819091Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yuta Kasai <yutakasai@google.com> Cr-Commit-Position: refs/heads/master@{#702788}
-
Mikhail Khokhlov authored
This CL speeds up uploading test artifacts to the cloud by doing it in a thread pool. It also fixes a bug where run_indentifier would change during the script run. Bug: 981349 Change-Id: I65fea156d73fb568f8ecb3e05d330971ab55be29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837630 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
Omer Katz authored
We called Heap().FlushV8References in IncrementalMarkingStep after returning from MarkPhaseAdvanceMarking. This means that FlushV8References is not called during the atomic pause (which doesn't use IncrementalMarkingStep). This could lead to errors. Moving the call to FlushV8References into MarkPhaseAdvanceMarking means it will be called regardless of whether we're in incremental marking or atomic pause. Bug: 986235 Change-Id: I70f85908f0ed8d750456f19d83f779734a5fac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813328 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Boris Sazonov authored
Moves onCredentialSelected from a callback parameter to TouchToFillComponent.Delegate. This is a preparation to expading the delegate with a method to fetch favicons. Bug: 1009331 Change-Id: I671ff3eaf4ab2b2f643759fbe96ae744d396b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836412 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702785}
-
Yasmin authored
The fix is to move the Shared Clipboard from Copy group to become visible after/replacing Click to Call position. All sharing features should be place together in one block. Bug: 1002120 Change-Id: I579a9f2d7578bc5e93b6e90f3f2f110aba8b9336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833480Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702784}
-
Rayan Kanso authored
TWAs used to have a page transition value of `LINK`, which makes sense for CCTs, but not so much for a TWA, which should match WebAPK behaviour. Change-Id: I3f387f5bfaa8eba73aa26133993d156ce9f53092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829200 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#702783}
-
Gauthier Ambard authored
This CL removes the default VoiceOver action which is reading the title of the item then the content of the badge. Now the accessibility label is the title and a new property, |additionalAccessibilityLabel|, if it is set. This is a reland of crrev.com/c/1789397, fixing the failing tests. Bug: 985764 Change-Id: I6abef0554fd30463d3381de7baf000752cafeb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833475Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#702782}
-
