- 23 Feb, 2018 40 commits
-
-
Nico Weber authored
https://webrtc.googlesource.com/deps/third_party/openmax.git/+log/b611996df3b8..63d8cf4708c9 $ git log b611996df..63d8cf470 --date=short --no-merges --format='%ad %ae %s' 63d8cf42 Remove gyp files from openmax_dl. a661346 Make `git cl upload` work again in third_party/openmax_dl. Created with: roll-dep src/third_party/openmax_dl Bug: none Change-Id: I73d42f9a2e50e60c259fffd7825f185ede924aa6 Reviewed-on: https://chromium-review.googlesource.com/934428 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#538906}
-
Scott Violet authored
This renames targets in chrome, chromecast and chromeos. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=thakis@chromium.org,dcheng@chromium.org Change-Id: I35f82bb244d2f8bd745d3157f266bae99f21f888 Reviewed-on: https://chromium-review.googlesource.com/935296Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#538905}
-
Luna Lu authored
This is a reland of 6252427a. Original change's description: > Add WPT tests for feature policy > > 1. Added tests for header policy. > a. document.policy shows correctly parsed policy > b. local / remote iframes without allow attribute correctly inherit > document.policy > c. dynamically update allow attribute updates the policy correctly. > > 2. Added tests for nested policies. > > Bug: 732003 > Change-Id: I869449f6bba89fc58997355df27249f403d76808 > Reviewed-on: https://chromium-review.googlesource.com/796952 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531698} Bug: 732003 Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05 Reviewed-on: https://chromium-review.googlesource.com/887324Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#538904}
-
Rob Buis authored
Fix errorprone JavaLangClash warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/JavaLangClash Bug: 801253 Change-Id: I5958e0e1c3d15e637b04c12e2810dee0cfb16cfc Reviewed-on: https://chromium-review.googlesource.com/929755Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#538903}
-
Troy Hildebrandt authored
This CL provides a functional version of the query in omnibox functionality, hidden behind a flag. Tests for the new functionality are also included in LocationBarLayoutTest. Further input from UX/security is required at this point. Bug: 776988 Change-Id: I2f45df924ebf0caeacdccd1384bbf18d9facf791 Reviewed-on: https://chromium-review.googlesource.com/902929 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#538902}
-
Adrienne Walker authored
This content size parameter is incorrectly small, which causes additional clearing in some cases in the benchmark. Bug: 810497 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7a6bb361c29de6e5550f9f4b96becab08463bff5 Reviewed-on: https://chromium-review.googlesource.com/935147Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#538901}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5154855..c90024f5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia9ba4482481e0de2482f723fb8357ba3651b3712 Reviewed-on: https://chromium-review.googlesource.com/934426Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#538900}
-
Danyao Wang authored
Using wpt-import in Chromium b1ae03c5. With Chromium commits locally applied on WPT: 73f5acd5 "[css-typed-om] Rejig CSSResourceValue hierarchy." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12684 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen garykac@chromium.org: external/wpt/clipboard-apis igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/resources tyoshino@chromium.org: external/wpt/navigation-timing worker-dev@chromium.org: external/wpt/workers TBR=danyao No-Export: true Change-Id: I1a3f32c7a9cefd2099c7e733dd6289a6a0e54f19 Reviewed-on: https://chromium-review.googlesource.com/934841 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538899}
-
Nasko Oskov authored
This test uses URL without the proper port number for the embedded test server, which can cause it to fail. Change-Id: I29e2966446b07adeacdfbe2daf061611b1307b17 Reviewed-on: https://chromium-review.googlesource.com/934964Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#538898}
-
wutao authored
This cl adds the shelf icon to Keyboard Shortcut Viewer (KSV). Bug: 768932 Test: Tested on device. Change-Id: I61f6684df80ae213bc294e87e909063833af629d Reviewed-on: https://chromium-review.googlesource.com/934850 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#538897}
-
Daniel Erat authored
Make ShutdownController pass the actual cause of a shutdown request (power button, system tray, or login screen) to powerd rather just a generic "UI request from ash" string. Also get rid of an "unknown" ShutdownReason enum value that looks like it was just used as an initial placeholder within LockStateController. Bug: none Change-Id: I0760e68a6bf462c508d1f2d8740b8e6a1cf31191 Reviewed-on: https://chromium-review.googlesource.com/933546Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#538896}
-
Ian Clelland authored
Change-Id: I1e6e6225611f468cf710b8d4c9cfa5f28fccb6dd Reviewed-on: https://chromium-review.googlesource.com/935150Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#538895}
-
Xianzhu Wang authored
Previously we always output 2 saveLayers for each effect node, one for non-filter effect another for filter effect. Now don't output no-op saveLayer operations. Bug: 814227 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4462c387dfaf3fa246dcf6df6ebca84f30a5d2a2 Reviewed-on: https://chromium-review.googlesource.com/929878 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538894}
-
Majid Valipour authored
Previously we send an update to AnimationWorklet every time there was a ticking animation present. This was particularly bad for scroll-linked animations which may not need to be ticked every frame but only when their input scroller offset has changed. This CL introduces a simple optimization where we only animate if there is at least one ticking animation whose input has changed. Also we no longer take mutator_ into account in NeedsTickAnimations() because mutator's need for ticking is already captured by existence of ticking worklet animation players. Bug: 776952 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iab0b81a10a925b70fa676c22cd6d0888bf0a7614 Reviewed-on: https://chromium-review.googlesource.com/927405 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#538893}
-
Finnur Thorarinsson authored
... a class that handles the encoding and decoding of the data passing back and forth to the Windows Action Center. This also changes the syntax of the encoded string to use only the pipe sign (no more $) and introduce a type at the beginning of the string, which indicates what syntax the rest of the string follows. Bug: 734095 Change-Id: I8d9181ee784ea7d8aae0907af4f3fd1dda68314c Reviewed-on: https://chromium-review.googlesource.com/932661 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#538892}
-
Kyle Horimoto authored
Previously, such hotspots could only be displayed once per use login to ensure that we do not spam the user. However, user feedback indicates that users expect to see the notification each time they unlock their devices again. This change makes it possible for the notification to be displayed multiple times per user login, as long as the user has locked their device in between each time. Bug: 813838, 672263 Change-Id: Ib1c400b0b9c335e7c42193edfad5a324a2f05be7 Reviewed-on: https://chromium-review.googlesource.com/929867 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#538891}
-
Christopher Grant authored
This ensures that it interacts properly with other renderers. If we render the keyboard directly, it won't flush previously-queued work, and elements may draw out of order. BUG=815078 R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id691fea5a5a0bbbbe5f8e6d56b0ed2c33b0a8b59 Reviewed-on: https://chromium-review.googlesource.com/934981 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#538890}
-
bsheedy authored
Fixes two unrelated bugs that were causing VrShellNavigationTest#test2dTo2d to fail in different ways. The first is that, at least with the DON flow skipped, it's possible to get into the VR browser before we switch orientation to landscape, which results in incorrect screen dimensions and thus reported screen size. This is fixed by manually swapping width and height in this case. The second is that we could hit a DCHECK in native code for running on the UI thread when calling requestToExitVr. This is fixed by running the onClick that triggers this on the UI thread. Bug: 814934 Change-Id: Id3ec37f11beca833588b8bec4bfab4e84aaae1ab Reviewed-on: https://chromium-review.googlesource.com/935185 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#538889}
-
Yi Gu authored
Elements with worklet animations should be composited to run on cc. Currently the workaround is asking developers to force promoting the elements by adding will-change property. This patch is to composite the affected elements automatically based on their properties. Bug: 776533 Change-Id: I8265e27b5aa3c136a622f8f35b83f770c87b58c6 Reviewed-on: https://chromium-review.googlesource.com/930128 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538888}
-
Nico Weber authored
I need some more time to figure out what to do here, but there's a bot now and it also needs to be able to build. So remove the target from the build in cross builds for now. TBR=grt Bug: 799827 Change-Id: I3a07ae1298025651e873342b3e1220e546d3e24c Reviewed-on: https://chromium-review.googlesource.com/935262Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538887}
-
Michael Spang authored
The touch device manager is currently using the public display::Display interface to get the id and geometry of the display. This almost works, except that when we associate touchscreens with displays the display id is always set to "1" instead of the real native display id. It's always "1" because the public display interface uses logical ids that have a different meaning than the internal ids. However, touchscreen association requires the internal ids to work. To fix this, do the touchscreen work inside CastDisplayConfigurator where it has access to native display internals. Because this has to also work with stub display configuration (null NativeDisplayDelegate), this also moves the stub display configuration path into CastDisplayConfigurator as ConfigureDisplayFromCommandLine(). Bug: b/65594145 Test: rbyers.github.io/paint.html Change-Id: Ic27529ec681e91a22e2395acb9bcf4ac04eab8ff Reviewed-on: https://chromium-review.googlesource.com/933062 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#538886}
-
https://chromium.googlesource.com/angle/angle.git/+log/e41df6556f93..a4ef843fe0de $ git log e41df6556..a4ef843fe --date=short --no-merges --format='%ad %ae %s' 2018-02-22 jiajia.qin ES31: Fix incorrect error code in DispatchComputeIndirect 2018-02-22 jiajia.qin Fix that readonly buffer variable can be assigned Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I4cab542f00d4606a6b251e7377f8367f2941af13 Reviewed-on: https://chromium-review.googlesource.com/935121 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538885}
-
Ria Jiang authored
This CL adds RenderWidgetHostViewBase::GetOffsetFromRootSurface() and implements it on different platforms. This is necessary to use the correct coordinate-space for Viz hit-test. Bug: 810128 Test: https://chromium-review.googlesource.com/c/chromium/src/+/919260 Change-Id: I01903dc92bc00bcfa19a3870e26e4f73ea7bff37 Reviewed-on: https://chromium-review.googlesource.com/930701Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#538884}
-
sczs authored
- Creates RecentTabsTableViewController, and adds the plumbing required from BVC to Coordinator to VC. Bug: 805135 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I40a2c02f2bd7e93e93bdf75cd365c7853c27ea6f Reviewed-on: https://chromium-review.googlesource.com/933261 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538883}
-
Tim Brown authored
Bug: 815232 Change-Id: I7fad2ccc0c63b16839fb4f43b095bbfb41e844fd Reviewed-on: https://chromium-review.googlesource.com/935156Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#538882}
-
John Chen authored
Add a missing dependency that was causing chromedriver_py_tests to fail on Mac when is_component_build=true. Bug: 814818 Change-Id: I923d6e96910255380669d5f02f3bc828feaa3396 Reviewed-on: https://chromium-review.googlesource.com/935287 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538881}
-
Matt Mueller authored
This allows path building to continue and try to build a valid path (either to a different root, or to the same cert if it happens to be self-signed.) Update comments & todos that trusted leaf certs are intentionally not supported. Bug: 814994 Change-Id: Id8e6a5f3d00c94c96271e4c6e21860206bb71c2a Reviewed-on: https://chromium-review.googlesource.com/933108Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#538880}
-
https://skia.googlesource.com/skia.git/+log/09f818d2c9c0..1022f743758b $ git log 09f818d2c..1022f7437 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 fmalita [skottie] Nested animation support Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I7a6f03eef6ec89e55e27e94a9d432289f01e26bd Reviewed-on: https://chromium-review.googlesource.com/935201 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538879}
-
James Cook authored
"!ash" is the same as "+ash" but will cause checkdeps.py to emit a presubmit warning if you add additional deps on that path. Since we're trying to eliminate deps on //ash, that's desirable. TBR=atwilson@chromium.org Bug: 678705 Change-Id: I911479be6d308f2ba21370761ab9d5575827e7df Reviewed-on: https://chromium-review.googlesource.com/935282 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#538878}
-
Peter Collingbourne authored
This bot has the same configuration as ToTAndroidCFI except that it uses clang releases instead of clang ToT. While here, drop an unnecessary test suite exception from the configuration for ToTAndroidCFI. Bug: 810907 Change-Id: I9040dd8ba64b9117fd6c1425ca60b88a6161bc2b Reviewed-on: https://chromium-review.googlesource.com/924607 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538877}
-
Peter Kasting authored
BUG=none TEST=none TBR=yusukes Change-Id: I49bc09082dc5d9cb3200a50cca74280b94a9455f Reviewed-on: https://chromium-review.googlesource.com/935291Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#538876}
-
Julia Tuttle authored
Bug: 810142 Change-Id: If62d38c058de404f3fd02508b9d63828d37d8d7c Reviewed-on: https://chromium-review.googlesource.com/919422 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#538875}
-
Xiaoqian Dai authored
Cros splitscreen: Defer resetting identity transform of the overview window until window is snapped. Before this change, in overview mode, when dragging a window item to snap to one side of the screen, the window will reset its identity transform first and then change to its desired snapped window bounds. It may work fine for Chrome browser/app windows since the bounds change is very quick, however, for Arc app windows, it takes much longer time to change to its desired bounds, thus the animation will look like the Arc app window enlarges itself to maximized window bounds (restore its original transform animation) and then shrinks to its snapped window bounds (bounds change animation). To fix this problem, we defer resetting to identity transform of the drag-to-snap window until its bounds has changed to its desired bounds. With this change, the animation will look like the Arc app window directly enlarges to its desired snapped window bounds. Bug: 725683 Change-Id: Id734b77593fbda8dce647c7c43d64671317c208e Reviewed-on: https://chromium-review.googlesource.com/910076Reviewed-by:
Mitsuru Oshima (OOO 2/23) <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#538874}
-
Eugene But authored
This reverts commit 9f7168d5. Reason for revert: iOS 11.3 Beta 3 does not have this bug Original change's description: > Always add WKWebView to the view hierarchy on iOS 11.3. > > On iOS 11.3 WKWebView loads much slower if it is not a part of the view > hierarchy. This is more-likely a system issue, however it is important > to have a workaround until Apple fixes the bug. > > BUG=739390 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I8a066a97699a56980689b1d37dde560e69d91ff1 > Reviewed-on: https://chromium-review.googlesource.com/910712 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536517} TBR=justincohen@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739390 Change-Id: I1d5332e35361e19020e34d4c12bbb2e87e8d036a Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/935222Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#538873}
-
Fady Samuel authored
Input throttling is not currently well supported on non-Chrome OS platforms and that's causing some crashes in the wild. Input throttling still makes sense on any synchronization event on any platform because things aren't getting updated while we are synchronizing but for the time being to avoid crashes in the wild, this CL disables input throttling outside of Chrome OS. Bug: 672962, 791447 Change-Id: I0ac419a683f8a0f735e746fa629a037370fbd169 Reviewed-on: https://chromium-review.googlesource.com/932542Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#538872}
-
Morten Stenshorne authored
We forgot to subtract space taken up by scrollbars. Now that we do, we also need NGBlockNode::GetScrollbarSizes() to add the horizontal scrollbar on the correct side. Need to check with the layout object, not directly with computed style. This matters e.g. if the object in question is the LayoutView, which always places it on the right hand side, even if document direction is RTL. Also fix static block offset in flipped blocks writing mode. We got it wrong, because we flipped an offset relative to the border edge around the padding box. That's a regression from https://chromium-review.googlesource.com/926004 Since I managed to break stuff without any tests regressing, I added a few to wpt/css/css-flexbox/ (it doesn't really matter which layout model to test with, as long as the containing block is in legacy layout, so I just picked flexbox). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf Reviewed-on: https://chromium-review.googlesource.com/931502Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#538871}
-
jonross authored
With RenderFrameSubmissionObserver browser_tests and content_browsertests can wait for the submission of compositor frames, or changes in RenderFrameMetadata. In a way that works for both classic and Viz DisplayCompositor. FrameWatcher did not work with Viz. This change ports all usage of FrameWatcher to RenderFrameSubmissionObserver. It also updates the new API to specifiy the two forms of waiting. FrameWatcher is also being deleted. TEST=content_browsertests, browser_tests Bug: 785013 Change-Id: I4e34ab49e8a7739a105686483ff9cd6aee3e3fa7 Reviewed-on: https://chromium-review.googlesource.com/924479Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#538870}
-
Robert Flack authored
WindowSelectorController::ToggleOverview used to do 3 removal loops over the active window list, one of which did a search through another window list for each window. This reduces the runtime complexity (a single removal loop) and makes the code easier to read (having fewer conditions). Bug: None Change-Id: I06ddf20b5ef3be57da4660de849bffeb4935683b Reviewed-on: https://chromium-review.googlesource.com/934974Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538869}
-
Mina Almasry authored
Will be used in to be implemented CMA backend. BUG=internal b/73746352 TEST=Build Change-Id: I08d520edf54cbd8658c6112eeb930e7e68fd3d6a Reviewed-on: https://chromium-review.googlesource.com/933584Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#538868}
-
Eugene But authored
This removes code from BVC and allows reusing Store Kit code in DownloadManagerCoordinator. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5d33de9666a0bdc35fb3d451158b33a8636bf4d Reviewed-on: https://chromium-review.googlesource.com/934315 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#538867}
-